95996 2012-09-06 10:42:07 -0700 [chromium] Don't use WebGestureEvent.boundingBox for touch adjustment 2012-09-10 07:03:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 95496 1 rbyers rbyers abarth aelias jamesr rjkroege trchen webkit.review.bot oldest_to_newest 713446 0 rbyers 2012-09-06 10:42:07 -0700 [chromium] Don't use WebGestureEvent.boundingBox for touch adjustment 713447 1 162538 rbyers 2012-09-06 10:42:58 -0700 Created attachment 162538 Patch 713452 2 rbyers 2012-09-06 10:44:50 -0700 trchen@ It looks like you recently added another use of GestureEvent boundingBox, so I missed this one in transitioning all the usages to the new fields in bug 95573. Does this simple change look OK to you? 713500 3 trchen 2012-09-06 11:21:26 -0700 You may also want to comment out WebFrameTest.DisambiguationPopupTest for now. I have one question regarding to the definition of width and height. So (event.x, event.y) is always the top left corner of the fat tap area, and the area extends to (event.x + event.width, event.y + event.height)? From the chromium side change I thought (event.x, event.y) is the center and the area extends for (+-event.width, +-event.height). Thanks for the help! 713728 4 162590 rbyers 2012-09-06 14:43:32 -0700 Created attachment 162590 Patch 713903 5 rbyers 2012-09-06 17:31:50 -0700 (In reply to comment #3) > You may also want to comment out WebFrameTest.DisambiguationPopupTest for now. The fix looks simple enough, OK if I just make it? I'm not sure how to run the test though - in my build webkit_unit_tests doesn't include WebFrameTests, but from the .gypi it doesn't appear to be Android specific or anything so not sure why. > I have one question regarding to the definition of width and height. So (event.x, event.y) is always the top left corner of the fat tap area, and the area extends to (event.x + event.width, event.y + event.height)? > > From the chromium side change I thought (event.x, event.y) is the center and the area extends for (+-event.width, +-event.height). Yes, sorry - you're right. (event.x, event.y) is the center, and width/height represent the total width, so bounding box extends from event.x-width/2 to event.x+width/2 etc. 715340 6 rbyers 2012-09-08 07:32:50 -0700 Ping - does this look OK to you know trchen@? 715341 7 162590 abarth 2012-09-08 07:34:42 -0700 Comment on attachment 162590 Patch Looks reasonable to me. Please check with trchen before landing. 715873 8 trchen 2012-09-10 02:52:46 -0700 (In reply to comment #6) > Ping - does this look OK to you know trchen@? LGTM. Great thanks for the explaination! 715976 9 rbyers 2012-09-10 05:48:04 -0700 Great, thanks. Can someone put this in the CQ for me please? I want to get this gardened into chromium ASAP so I can start the process of removing these old fields before someone starts using them somewhere else ;-) 716043 10 162590 webkit.review.bot 2012-09-10 07:03:01 -0700 Comment on attachment 162590 Patch Clearing flags on attachment: 162590 Committed r128058: <http://trac.webkit.org/changeset/128058> 716044 11 webkit.review.bot 2012-09-10 07:03:05 -0700 All reviewed patches have been landed. Closing bug. 162538 2012-09-06 10:42:58 -0700 2012-09-06 14:43:29 -0700 Patch bug-95996-20120906134238.patch text/plain 1997 rbyers U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3Njk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGVjMGUzMzQyNjk1NzUwNDk2YTcwYzEwNmU2NDNlYTljYzA3YzM1N2IuLmZjZWUzZDQzNGQ5ZmJj MmZlNGFhYjk4NmJkYzM0ZWU0N2JkMjNhNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDktMDYgIFJpY2sgQnllcnMgIDxyYnllcnNAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRG9uJ3QgdXNlIFdlYkdlc3R1cmVFdmVudC5ib3Vu ZGluZ0JveCBmb3IgdG91Y2ggYWRqdXN0bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU5OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTd2l0Y2ggZnJvbSBXZWJHZXN0dXJlRXZlbnQuYm91bmRpbmdC b3ggdG8gbmV3IGdlc3R1cmUtdHlwZSBzcGVjaWZpYworICAgICAgICBkYXRhIGZpZWxkcy4KKyAg ICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1w bDo6aGFuZGxlR2VzdHVyZUV2ZW50KToKKwogMjAxMi0wOS0wNSAgS2VuaWNoaSBJc2hpYmFzaGkg IDxiYXNoaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBVbnJldmlld2VkIGdh cmRlbmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4 IDRmYjQ1MWFmYmRiOGJkYWMxMDJhMTliOTRjZGM3YmE1NDk0YjQyY2MuLjI3YTI5ZWRlMzExNTI4 MmZmZDdmNTEzNzI2NzdmMDFiOGQ5MjE5NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5jcHAKQEAgLTcxMyw5ICs3MTMsMTAgQEAgYm9vbCBXZWJWaWV3SW1wbDo6 aGFuZGxlR2VzdHVyZUV2ZW50KGNvbnN0IFdlYkdlc3R1cmVFdmVudCYgZXZlbnQpCiAgICAgICAg IGhpZGVTZWxlY3RQb3B1cCgpOwogICAgICAgICBBU1NFUlQoIW1fc2VsZWN0UG9wdXApOwogCi0g ICAgICAgIGlmICghZXZlbnQuYm91bmRpbmdCb3guaXNFbXB0eSgpKSB7CisgICAgICAgIGlmIChl dmVudC5kYXRhLnRhcC53aWR0aCA+IDApIHsKKyAgICAgICAgICAgIEludFJlY3QgYm91bmRpbmdC b3goZXZlbnQueCwgZXZlbnQueSwgZXZlbnQuZGF0YS50YXAud2lkdGgsIGV2ZW50LmRhdGEudGFw LmhlaWdodCk7CiAgICAgICAgICAgICBWZWN0b3I8SW50UmVjdD4gZ29vZFRhcmdldHM7Ci0gICAg ICAgICAgICBmaW5kR29vZFRvdWNoVGFyZ2V0cyhldmVudC5ib3VuZGluZ0JveCwgbWFpbkZyYW1l SW1wbCgpLT5mcmFtZSgpLCBwYWdlU2NhbGVGYWN0b3IoKSwgZ29vZFRhcmdldHMpOworICAgICAg ICAgICAgZmluZEdvb2RUb3VjaFRhcmdldHMoYm91bmRpbmdCb3gsIG1haW5GcmFtZUltcGwoKS0+ ZnJhbWUoKSwgcGFnZVNjYWxlRmFjdG9yKCksIGdvb2RUYXJnZXRzKTsKICAgICAgICAgICAgIC8v IEZJWE1FOiByZXBsYWNlIHRvdWNoIGFkanVzdG1lbnQgY29kZSB3aGVuIG51bWJlck9mR29vZFRh cmdldHMgPT0gMT8KICAgICAgICAgICAgIC8vIFNpbmdsZSBjYW5kaWRhdGUgY2FzZSBpcyBjdXJy ZW50bHkgaGFuZGxlZCBieTogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg1MTAxCiAgICAgICAgICAgICBpZiAoZ29vZFRhcmdldHMuc2l6ZSgpID49IDIgJiYgbV9jbGll bnQgJiYgbV9jbGllbnQtPmRpZFRhcE11bHRpcGxlVGFyZ2V0cyhldmVudCwgZ29vZFRhcmdldHMp KQo= 162590 2012-09-06 14:43:32 -0700 2012-09-10 07:03:01 -0700 Patch bug-95996-20120906174312.patch text/plain 2662 rbyers U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3Njk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGVjMGUzMzQyNjk1NzUwNDk2YTcwYzEwNmU2NDNlYTljYzA3YzM1N2IuLmZjZWUzZDQzNGQ5ZmJj MmZlNGFhYjk4NmJkYzM0ZWU0N2JkMjNhNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDktMDYgIFJpY2sgQnllcnMgIDxyYnllcnNAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRG9uJ3QgdXNlIFdlYkdlc3R1cmVFdmVudC5ib3Vu ZGluZ0JveCBmb3IgdG91Y2ggYWRqdXN0bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU5OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTd2l0Y2ggZnJvbSBXZWJHZXN0dXJlRXZlbnQuYm91bmRpbmdC b3ggdG8gbmV3IGdlc3R1cmUtdHlwZSBzcGVjaWZpYworICAgICAgICBkYXRhIGZpZWxkcy4KKyAg ICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1w bDo6aGFuZGxlR2VzdHVyZUV2ZW50KToKKwogMjAxMi0wOS0wNSAgS2VuaWNoaSBJc2hpYmFzaGkg IDxiYXNoaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBVbnJldmlld2VkIGdh cmRlbmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4 IDRmYjQ1MWFmYmRiOGJkYWMxMDJhMTliOTRjZGM3YmE1NDk0YjQyY2MuLjA2NmY2Njk4ODY5MDQ0 Yjg1Yzk3M2Q0MzllYWE2OTNmMjI2ZjA2NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5jcHAKQEAgLTcxMyw5ICs3MTMsMTAgQEAgYm9vbCBXZWJWaWV3SW1wbDo6 aGFuZGxlR2VzdHVyZUV2ZW50KGNvbnN0IFdlYkdlc3R1cmVFdmVudCYgZXZlbnQpCiAgICAgICAg IGhpZGVTZWxlY3RQb3B1cCgpOwogICAgICAgICBBU1NFUlQoIW1fc2VsZWN0UG9wdXApOwogCi0g ICAgICAgIGlmICghZXZlbnQuYm91bmRpbmdCb3guaXNFbXB0eSgpKSB7CisgICAgICAgIGlmIChl dmVudC5kYXRhLnRhcC53aWR0aCA+IDApIHsKKyAgICAgICAgICAgIEludFJlY3QgYm91bmRpbmdC b3goZXZlbnQueCAtIGV2ZW50LmRhdGEudGFwLndpZHRoIC8gMiwgZXZlbnQueSAtIGV2ZW50LmRh dGEudGFwLmhlaWdodCAvIDIsIGV2ZW50LmRhdGEudGFwLndpZHRoLCBldmVudC5kYXRhLnRhcC5o ZWlnaHQpOwogICAgICAgICAgICAgVmVjdG9yPEludFJlY3Q+IGdvb2RUYXJnZXRzOwotICAgICAg ICAgICAgZmluZEdvb2RUb3VjaFRhcmdldHMoZXZlbnQuYm91bmRpbmdCb3gsIG1haW5GcmFtZUlt cGwoKS0+ZnJhbWUoKSwgcGFnZVNjYWxlRmFjdG9yKCksIGdvb2RUYXJnZXRzKTsKKyAgICAgICAg ICAgIGZpbmRHb29kVG91Y2hUYXJnZXRzKGJvdW5kaW5nQm94LCBtYWluRnJhbWVJbXBsKCktPmZy YW1lKCksIHBhZ2VTY2FsZUZhY3RvcigpLCBnb29kVGFyZ2V0cyk7CiAgICAgICAgICAgICAvLyBG SVhNRTogcmVwbGFjZSB0b3VjaCBhZGp1c3RtZW50IGNvZGUgd2hlbiBudW1iZXJPZkdvb2RUYXJn ZXRzID09IDE/CiAgICAgICAgICAgICAvLyBTaW5nbGUgY2FuZGlkYXRlIGNhc2UgaXMgY3VycmVu dGx5IGhhbmRsZWQgYnk6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 NTEwMQogICAgICAgICAgICAgaWYgKGdvb2RUYXJnZXRzLnNpemUoKSA+PSAyICYmIG1fY2xpZW50 ICYmIG1fY2xpZW50LT5kaWRUYXBNdWx0aXBsZVRhcmdldHMoZXZlbnQsIGdvb2RUYXJnZXRzKSkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNw cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcAppbmRleCAx OGFmNjg1YmI4YzUxZjg5MWZiYjBlMzQxNTgzODUxNTg5NjY0N2ZkLi4zNTdlYjA0MjIxZmU3YzUw MTUxNTZmNTY0NGNmODg1MWVhYTc4Y2JlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90 ZXN0cy9XZWJGcmFtZVRlc3QuY3BwCkBAIC0xMTAwLDcgKzExMDAsOCBAQCBzdGF0aWMgV2ViR2Vz dHVyZUV2ZW50IGZhdFRhcChpbnQgeCwgaW50IHkpCiAgICAgZXZlbnQudHlwZSA9IFdlYklucHV0 RXZlbnQ6Okdlc3R1cmVUYXA7CiAgICAgZXZlbnQueCA9IHg7CiAgICAgZXZlbnQueSA9IHk7Ci0g ICAgZXZlbnQuYm91bmRpbmdCb3ggPSBXZWJDb3JlOjpJbnRSZWN0KHggLSAyNSwgeSAtIDI1LCA1 MCwgNTApOworICAgIGV2ZW50LmRhdGEudGFwLndpZHRoID0gNTA7CisgICAgZXZlbnQuZGF0YS50 YXAuaGVpZ2h0ID0gNTA7CiAgICAgcmV0dXJuIGV2ZW50OwogfQogCg==