95994 2012-09-06 10:25:59 -0700 [chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest 2012-09-06 14:23:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne enne jamesr webkit.review.bot oldest_to_newest 713429 0 enne 2012-09-06 10:25:59 -0700 [chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest 713431 1 162536 enne 2012-09-06 10:28:38 -0700 Created attachment 162536 Patch 713453 2 162536 jamesr 2012-09-06 10:50:09 -0700 Comment on attachment 162536 Patch Thanks 713697 3 162536 webkit.review.bot 2012-09-06 14:23:26 -0700 Comment on attachment 162536 Patch Clearing flags on attachment: 162536 Committed r127784: <http://trac.webkit.org/changeset/127784> 713698 4 webkit.review.bot 2012-09-06 14:23:29 -0700 All reviewed patches have been landed. Closing bug. 162536 2012-09-06 10:28:38 -0700 2012-09-06 14:23:26 -0700 Patch bug-95994-20120906102819.patch text/plain 7450 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDAzNjcyYTFmNzAwN2ZlYWNkNDY0ZjU0N2JiOTU4YzQ5YzE1MmZiOTcuLjZmY2Q3YzI2MmExODA0 ZThjMjk2MTRiNTg1MzJkYWU3YmNkZmUzZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDktMDYgIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xl LmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIFJlbW92ZSBTY3JvbGxiYXIvU2V0dGluZ3MgZGVw ZW5kZW5jaWVzIGZyb20gU2Nyb2xsYmFyTGF5ZXJDaHJvbWl1bVRlc3QKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1OTk0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBjb21wb3NpdG9yIHRlc3Qgc2hv dWxkbid0IGRlcGVuZCBvbiBjb2RlIG91dHNpZGUgdGhlIGNvbXBvc2l0b3IuCisKKyAgICAgICAg KiB0ZXN0cy9TY3JvbGxiYXJMYXllckNocm9taXVtVGVzdC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpGYWtlV2ViU2Nyb2xsYmFyOjpjcmVhdGUpOgorICAgICAgICAoRmFrZVdlYlNjcm9sbGJhcik6 CisgICAgICAgIChXZWJDb3JlOjpURVNUKToKKwogMjAxMi0wOS0wNSAgTWFyayBQaWxncmltICA8 cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBSZW1vdmUgZ2V0UmVu ZGVyU3R5bGVGb3JTdHJpa2UgZnJvbSBQbGF0Zm9ybVN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvU2Nyb2xsYmFyTGF5ZXJDaHJvbWl1bVRlc3QuY3BwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9TY3JvbGxiYXJMYXllckNocm9taXVtVGVzdC5j cHAKaW5kZXggNjU5NjAzYTE5MDNlMjliNGY2ZmViZWVlZTc1MzQ1YmY5NDJjNDMxYi4uNmExOTNk N2UxMDY1ZDZiNGRjMmQ2NWVjOGQzM2I0ZmU1ZmM3MzViZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9TY3JvbGxiYXJMYXllckNocm9taXVtVGVzdC5jcHAKKysrIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9TY3JvbGxiYXJMYXllckNocm9taXVtVGVzdC5j cHAKQEAgLTMwLDggKzMwLDYgQEAKICNpbmNsdWRlICJDQ1Njcm9sbGJhckxheWVySW1wbC5oIgog I2luY2x1ZGUgIkNDU2luZ2xlVGhyZWFkUHJveHkuaCIKICNpbmNsdWRlICJGYWtlV2ViU2Nyb2xs YmFyVGhlbWVHZW9tZXRyeS5oIgotI2luY2x1ZGUgIlNjcm9sbGJhci5oIgotI2luY2x1ZGUgIlNl dHRpbmdzLmgiCiAjaW5jbHVkZSAiVHJlZVN5bmNocm9uaXplci5oIgogI2luY2x1ZGUgIldlYlNj cm9sbGJhckltcGwuaCIKICNpbmNsdWRlIDxndGVzdC9ndGVzdC5oPgpAQCAtNDMsNjggKzQxLDM3 IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgewogCi1jbGFzcyBNb2Nr U2Nyb2xsYmFyIDogcHVibGljIFNjcm9sbGJhciB7CitjbGFzcyBGYWtlV2ViU2Nyb2xsYmFyIDog cHVibGljIFdlYktpdDo6V2ViU2Nyb2xsYmFyIHsKIHB1YmxpYzoKLSAgICB2aXJ0dWFsIGludCB4 KCkgY29uc3QgeyByZXR1cm4gMDsgfQotICAgIHZpcnR1YWwgaW50IHkoKSBjb25zdCB7IHJldHVy biAwOyB9Ci0gICAgdmlydHVhbCBpbnQgd2lkdGgoKSBjb25zdCB7IHJldHVybiAwOyB9Ci0gICAg dmlydHVhbCBpbnQgaGVpZ2h0KCkgY29uc3QgeyByZXR1cm4gMDsgfQotICAgIHZpcnR1YWwgSW50 U2l6ZSBzaXplKCkgY29uc3QgeyByZXR1cm4gSW50U2l6ZSgpOyB9Ci0gICAgdmlydHVhbCBJbnRQ b2ludCBsb2NhdGlvbigpIGNvbnN0IHsgcmV0dXJuIEludFBvaW50KCk7IH0KLQotICAgIHZpcnR1 YWwgU2Nyb2xsVmlldyogcGFyZW50KCkgY29uc3QgeyByZXR1cm4gMDsgfQotICAgIHZpcnR1YWwg U2Nyb2xsVmlldyogcm9vdCgpIGNvbnN0IHsgcmV0dXJuIDA7IH0KLQotICAgIHZpcnR1YWwgdm9p ZCBzZXRGcmFtZVJlY3QoY29uc3QgSW50UmVjdCYpIHsgfQotICAgIHZpcnR1YWwgSW50UmVjdCBm cmFtZVJlY3QoKSBjb25zdCB7IHJldHVybiBJbnRSZWN0KCk7IH0KLQotICAgIHZpcnR1YWwgdm9p ZCBpbnZhbGlkYXRlKCkgeyB9Ci0gICAgdmlydHVhbCB2b2lkIGludmFsaWRhdGVSZWN0KGNvbnN0 IEludFJlY3QmKSB7IH0KLQotICAgIHZpcnR1YWwgU2Nyb2xsYmFyT3ZlcmxheVN0eWxlIHNjcm9s bGJhck92ZXJsYXlTdHlsZSgpIGNvbnN0IHsgcmV0dXJuIFNjcm9sbGJhck92ZXJsYXlTdHlsZURl ZmF1bHQ7IH0KLSAgICB2aXJ0dWFsIHZvaWQgZ2V0VGlja21hcmtzKFZlY3RvcjxJbnRSZWN0PiYp IGNvbnN0IHsgfQotICAgIHZpcnR1YWwgYm9vbCBpc1Njcm9sbGFibGVBcmVhQWN0aXZlKCkgY29u c3QgeyByZXR1cm4gZmFsc2U7IH0KLSAgICB2aXJ0dWFsIGJvb2wgaXNTY3JvbGxWaWV3U2Nyb2xs YmFyKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KLQotICAgIHZpcnR1YWwgSW50UG9pbnQgY29u dmVydEZyb21Db250YWluaW5nV2luZG93KGNvbnN0IEludFBvaW50JiB3aW5kb3dQb2ludCkgeyBy ZXR1cm4gd2luZG93UG9pbnQ7IH0KLQotICAgIHZpcnR1YWwgYm9vbCBpc0N1c3RvbVNjcm9sbGJh cigpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0gICAgdmlydHVhbCBTY3JvbGxiYXJPcmllbnRh dGlvbiBvcmllbnRhdGlvbigpIGNvbnN0IHsgcmV0dXJuIEhvcml6b250YWxTY3JvbGxiYXI7IH0K LQotICAgIHZpcnR1YWwgaW50IHZhbHVlKCkgY29uc3QgeyByZXR1cm4gMDsgfQotICAgIHZpcnR1 YWwgZmxvYXQgY3VycmVudFBvcygpIGNvbnN0IHsgcmV0dXJuIDA7IH0KLSAgICB2aXJ0dWFsIGlu dCB2aXNpYmxlU2l6ZSgpIGNvbnN0IHsgcmV0dXJuIDE7IH0KLSAgICB2aXJ0dWFsIGludCB0b3Rh bFNpemUoKSBjb25zdCB7IHJldHVybiAxOyB9Ci0gICAgdmlydHVhbCBpbnQgbWF4aW11bSgpIGNv bnN0IHsgcmV0dXJuIDA7IH0KLSAgICB2aXJ0dWFsIFNjcm9sbGJhckNvbnRyb2xTaXplIGNvbnRy b2xTaXplKCkgY29uc3QgeyByZXR1cm4gUmVndWxhclNjcm9sbGJhcjsgfQotCi0gICAgdmlydHVh bCBpbnQgbGluZVN0ZXAoKSBjb25zdCB7IHJldHVybiAwOyB9Ci0gICAgdmlydHVhbCBpbnQgcGFn ZVN0ZXAoKSBjb25zdCB7IHJldHVybiAwOyB9Ci0KLSAgICB2aXJ0dWFsIFNjcm9sbGJhclBhcnQg cHJlc3NlZFBhcnQoKSBjb25zdCB7IHJldHVybiBOb1BhcnQ7IH0KLSAgICB2aXJ0dWFsIFNjcm9s bGJhclBhcnQgaG92ZXJlZFBhcnQoKSBjb25zdCB7IHJldHVybiBOb1BhcnQ7IH0KLQotICAgIHZp cnR1YWwgdm9pZCBzdHlsZUNoYW5nZWQoKSB7IH0KLQotICAgIHZpcnR1YWwgYm9vbCBlbmFibGVk KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KLSAgICB2aXJ0dWFsIHZvaWQgc2V0RW5hYmxlZChi b29sKSB7IH0KLQotICAgIHZpcnR1YWwgYm9vbCBpc092ZXJsYXlTY3JvbGxiYXIoKSBjb25zdCB7 IHJldHVybiBmYWxzZTsgfQotCi0gICAgTW9ja1Njcm9sbGJhcigpIDogU2Nyb2xsYmFyKDAsIEhv cml6b250YWxTY3JvbGxiYXIsIFJlZ3VsYXJTY3JvbGxiYXIpIHsgfQotICAgIHZpcnR1YWwgfk1v Y2tTY3JvbGxiYXIoKSB7IH0KKyAgICBzdGF0aWMgUGFzc093blB0cjxGYWtlV2ViU2Nyb2xsYmFy PiBjcmVhdGUoKSB7IHJldHVybiBhZG9wdFB0cihuZXcgRmFrZVdlYlNjcm9sbGJhcigpKTsgfQor CisgICAgLy8gV2ViU2Nyb2xsYmFyIGltcGxlbWVudGF0aW9uCisgICAgdmlydHVhbCBib29sIGlz T3ZlcmxheSgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIGZhbHNlOyB9CisgICAgdmlydHVhbCBp bnQgdmFsdWUoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiAwOyB9CisgICAgdmlydHVhbCBXZWJL aXQ6OldlYlBvaW50IGxvY2F0aW9uKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gV2ViS2l0OjpX ZWJQb2ludCgpOyB9CisgICAgdmlydHVhbCBXZWJLaXQ6OldlYlNpemUgc2l6ZSgpIGNvbnN0IE9W RVJSSURFIHsgcmV0dXJuIFdlYktpdDo6V2ViU2l6ZSgpOyB9CisgICAgdmlydHVhbCBib29sIGVu YWJsZWQoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiB0cnVlOyB9CisgICAgdmlydHVhbCBpbnQg bWF4aW11bSgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIDA7IH0KKyAgICB2aXJ0dWFsIGludCB0 b3RhbFNpemUoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiAwOyB9CisgICAgdmlydHVhbCBib29s IGlzU2Nyb2xsVmlld1Njcm9sbGJhcigpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIGZhbHNlOyB9 CisgICAgdmlydHVhbCBib29sIGlzU2Nyb2xsYWJsZUFyZWFBY3RpdmUoKSBjb25zdCBPVkVSUklE RSB7IHJldHVybiB0cnVlOyB9CisgICAgdmlydHVhbCB2b2lkIGdldFRpY2ttYXJrcyhXZWJLaXQ6 OldlYlZlY3RvcjxXZWJLaXQ6OldlYlJlY3Q+JikgY29uc3QgT1ZFUlJJREUgeyB9CisgICAgdmly dHVhbCBTY3JvbGxiYXJDb250cm9sU2l6ZSBjb250cm9sU2l6ZSgpIGNvbnN0IE9WRVJSSURFIHsg cmV0dXJuIFdlYlNjcm9sbGJhcjo6UmVndWxhclNjcm9sbGJhcjsgfQorICAgIHZpcnR1YWwgU2Ny b2xsYmFyUGFydCBwcmVzc2VkUGFydCgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIFdlYlNjcm9s bGJhcjo6Tm9QYXJ0OyB9CisgICAgdmlydHVhbCBTY3JvbGxiYXJQYXJ0IGhvdmVyZWRQYXJ0KCkg Y29uc3QgT1ZFUlJJREUgeyByZXR1cm4gV2ViU2Nyb2xsYmFyOjpOb1BhcnQ7IH0KKyAgICB2aXJ0 dWFsIFNjcm9sbGJhck92ZXJsYXlTdHlsZSBzY3JvbGxiYXJPdmVybGF5U3R5bGUoKSBjb25zdCBP VkVSUklERSB7IHJldHVybiBXZWJTY3JvbGxiYXI6OlNjcm9sbGJhck92ZXJsYXlTdHlsZURlZmF1 bHQ7IH0KKyAgICB2aXJ0dWFsIGJvb2wgaXNDdXN0b21TY3JvbGxiYXIoKSBjb25zdCBPVkVSUklE RSB7IHJldHVybiBmYWxzZTsgfQorICAgIHZpcnR1YWwgT3JpZW50YXRpb24gb3JpZW50YXRpb24o KSBjb25zdCBPVkVSUklERSB7IHJldHVybiBXZWJTY3JvbGxiYXI6Okhvcml6b250YWw7IH0KIH07 CiAKIFRFU1QoU2Nyb2xsYmFyTGF5ZXJDaHJvbWl1bVRlc3QsIHJlc29sdmVTY3JvbGxMYXllclBv aW50ZXIpCiB7CiAgICAgRGVidWdTY29wZWRTZXRJbXBsVGhyZWFkIGltcGw7CiAKLSAgICBSZWZQ dHI8TW9ja1Njcm9sbGJhcj4gbW9ja1Njcm9sbGJhciA9IGFkb3B0UmVmKG5ldyBNb2NrU2Nyb2xs YmFyKTsKLSAgICBXZWJLaXQ6OldlYlNjcm9sbGJhclRoZW1lUGFpbnRlciBwYWludGVyKDAsIG1v Y2tTY3JvbGxiYXIuZ2V0KCkpOworICAgIFdlYktpdDo6V2ViU2Nyb2xsYmFyVGhlbWVQYWludGVy IHBhaW50ZXIoMCwgMCk7CiAKLSAgICBTZXR0aW5nczo6c2V0TW9ja1Njcm9sbGJhcnNFbmFibGVk KHRydWUpOwogICAgIHsKLSAgICAgICAgT3duUHRyPFdlYktpdDo6V2ViU2Nyb2xsYmFyPiBzY3Jv bGxiYXIgPSBhZG9wdFB0cihuZXcgV2ViS2l0OjpXZWJTY3JvbGxiYXJJbXBsKG1vY2tTY3JvbGxi YXIuZ2V0KCkpKTsKKyAgICAgICAgT3duUHRyPFdlYktpdDo6V2ViU2Nyb2xsYmFyPiBzY3JvbGxi YXIoRmFrZVdlYlNjcm9sbGJhcjo6Y3JlYXRlKCkpOwogICAgICAgICBSZWZQdHI8TGF5ZXJDaHJv bWl1bT4gbGF5ZXJUcmVlUm9vdCA9IExheWVyQ2hyb21pdW06OmNyZWF0ZSgpOwogICAgICAgICBS ZWZQdHI8TGF5ZXJDaHJvbWl1bT4gY2hpbGQxID0gTGF5ZXJDaHJvbWl1bTo6Y3JlYXRlKCk7CiAg ICAgICAgIFJlZlB0cjxMYXllckNocm9taXVtPiBjaGlsZDIgPSBTY3JvbGxiYXJMYXllckNocm9t aXVtOjpjcmVhdGUoc2Nyb2xsYmFyLnJlbGVhc2UoKSwgcGFpbnRlciwgV2ViS2l0OjpGYWtlV2Vi U2Nyb2xsYmFyVGhlbWVHZW9tZXRyeTo6Y3JlYXRlKCksIGNoaWxkMS0+aWQoKSk7CkBAIC0xMjEs NyArODgsNyBAQCBURVNUKFNjcm9sbGJhckxheWVyQ2hyb21pdW1UZXN0LCByZXNvbHZlU2Nyb2xs TGF5ZXJQb2ludGVyKQogICAgIH0KIAogICAgIHsgLy8gYW5vdGhlciB0cmF2ZXJzZSBvcmRlcgot ICAgICAgICBPd25QdHI8V2ViS2l0OjpXZWJTY3JvbGxiYXI+IHNjcm9sbGJhciA9IGFkb3B0UHRy KG5ldyBXZWJLaXQ6OldlYlNjcm9sbGJhckltcGwobW9ja1Njcm9sbGJhci5nZXQoKSkpOworICAg ICAgICBPd25QdHI8V2ViS2l0OjpXZWJTY3JvbGxiYXI+IHNjcm9sbGJhcihGYWtlV2ViU2Nyb2xs YmFyOjpjcmVhdGUoKSk7CiAgICAgICAgIFJlZlB0cjxMYXllckNocm9taXVtPiBsYXllclRyZWVS b290ID0gTGF5ZXJDaHJvbWl1bTo6Y3JlYXRlKCk7CiAgICAgICAgIFJlZlB0cjxMYXllckNocm9t aXVtPiBjaGlsZDIgPSBMYXllckNocm9taXVtOjpjcmVhdGUoKTsKICAgICAgICAgUmVmUHRyPExh eWVyQ2hyb21pdW0+IGNoaWxkMSA9IFNjcm9sbGJhckxheWVyQ2hyb21pdW06OmNyZWF0ZShzY3Jv bGxiYXIucmVsZWFzZSgpLCBwYWludGVyLCBXZWJLaXQ6OkZha2VXZWJTY3JvbGxiYXJUaGVtZUdl b21ldHJ5OjpjcmVhdGUoKSwgY2hpbGQyLT5pZCgpKTsKQEAgLTE0MiwxMiArMTA5LDkgQEAgVEVT VChTY3JvbGxiYXJMYXllckNocm9taXVtVGVzdCwgc2Nyb2xsT2Zmc2V0U3luY2hyb25pemF0aW9u KQogewogICAgIERlYnVnU2NvcGVkU2V0SW1wbFRocmVhZCBpbXBsOwogCi0gICAgUmVmUHRyPE1v Y2tTY3JvbGxiYXI+IG1vY2tTY3JvbGxiYXIgPSBhZG9wdFJlZihuZXcgTW9ja1Njcm9sbGJhcik7 Ci0gICAgV2ViS2l0OjpXZWJTY3JvbGxiYXJUaGVtZVBhaW50ZXIgcGFpbnRlcigwLCBtb2NrU2Ny b2xsYmFyLmdldCgpKTsKLQotICAgIFNldHRpbmdzOjpzZXRNb2NrU2Nyb2xsYmFyc0VuYWJsZWQo dHJ1ZSk7CisgICAgV2ViS2l0OjpXZWJTY3JvbGxiYXJUaGVtZVBhaW50ZXIgcGFpbnRlcigwLCAw KTsKIAotICAgIE93blB0cjxXZWJLaXQ6OldlYlNjcm9sbGJhcj4gc2Nyb2xsYmFyID0gYWRvcHRQ dHIobmV3IFdlYktpdDo6V2ViU2Nyb2xsYmFySW1wbChtb2NrU2Nyb2xsYmFyLmdldCgpKSk7Cisg ICAgT3duUHRyPFdlYktpdDo6V2ViU2Nyb2xsYmFyPiBzY3JvbGxiYXIoRmFrZVdlYlNjcm9sbGJh cjo6Y3JlYXRlKCkpOwogICAgIFJlZlB0cjxMYXllckNocm9taXVtPiBsYXllclRyZWVSb290ID0g TGF5ZXJDaHJvbWl1bTo6Y3JlYXRlKCk7CiAgICAgUmVmUHRyPExheWVyQ2hyb21pdW0+IGNvbnRl bnRMYXllciA9IExheWVyQ2hyb21pdW06OmNyZWF0ZSgpOwogICAgIFJlZlB0cjxMYXllckNocm9t aXVtPiBzY3JvbGxiYXJMYXllciA9IFNjcm9sbGJhckxheWVyQ2hyb21pdW06OmNyZWF0ZShzY3Jv bGxiYXIucmVsZWFzZSgpLCBwYWludGVyLCBXZWJLaXQ6OkZha2VXZWJTY3JvbGxiYXJUaGVtZUdl b21ldHJ5OjpjcmVhdGUoKSwgbGF5ZXJUcmVlUm9vdC0+aWQoKSk7Cg==