95993 2012-09-06 10:15:05 -0700 [BlackBerry] Add custom data-blackberry-webworks-context attribute. 2012-09-06 14:00:24 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 gmak webkit-unassigned mifenton tonikitoo webkit.review.bot oldest_to_newest 713408 0 gmak 2012-09-06 10:15:05 -0700 Check for data-blackberry-webworks-context when getting context and add the value to the context object 713426 1 162535 gmak 2012-09-06 10:24:03 -0700 Created attachment 162535 patch with commit log 713435 2 162535 rwlbuis 2012-09-06 10:30:30 -0700 Comment on attachment 162535 patch with commit log View in context: https://bugs.webkit.org/attachment.cgi?id=162535&action=review Looks good. > Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:119 > +WTF::String webWorksContext(const WebCore::Element* element) You should not need WTF:: nor WebCore:: here. But we can fix that later wince we already have WTF usage in this file. 713664 3 162535 webkit.review.bot 2012-09-06 14:00:21 -0700 Comment on attachment 162535 patch with commit log Clearing flags on attachment: 162535 Committed r127782: <http://trac.webkit.org/changeset/127782> 713665 4 webkit.review.bot 2012-09-06 14:00:24 -0700 All reviewed patches have been landed. Closing bug. 162535 2012-09-06 10:24:03 -0700 2012-09-06 14:00:21 -0700 patch with commit log 0001-2012-09-06-Genevieve-Mak-gmak-rim.com.patch text/plain 4767 gmak RnJvbSBjNWQ4NDBhM2NjNmQ4MWFhYmMwNjNlNjJkODg2ZTNlM2E3ZTJhNWEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZW5ldmlldmUgTWFrIDxnbWFrQHJpbS5jb20+CkRhdGU6IFRo dSwgNiBTZXAgMjAxMiAxMTo1NTozNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDktMDYg IEdlbmV2aWV2ZSBNYWsgIDxnbWFrQHJpbS5jb20+CgogICAgICAgIEFkZCBkYXRhLWJsYWNrYmVy cnktd2Vid29ya3MtY29udGV4dCBhdHRyaWJ1dGUgYW5kIHNldCB0aGUgY3VzdG9tIGNvbnRleHQg d2hlbgogICAgICAgIGdldHRpbmcgY29udGV4dC4KICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU5OTMKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgogICAgICAgIFBSICMxOTM3MjYKICAgICAgICBSZXZpZXdlZCBJbnRlcm5hbGx5IGJ5 IE1pa2UgRmVudG9uLgoKICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKICAgICAgICAoQmxhY2tC ZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6d2ViQ29udGV4dCk6CiAgICAgICAgLSBDaGVj ayBmb3IgY3VzdG9tIFdlYldvcmtzIGNvbnRleHQgYW5kIGFkZCBpdCBpZiB0aGVyZS4KICAgICAg ICAqIFdlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6Oldl YktpdDo6RE9NU3VwcG9ydDo6d2ViV29ya3NDb250ZXh0KToKICAgICAgICAoRE9NU3VwcG9ydCk6 CiAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuaDoKICAgICAgICAtIEFkZCBhIG1l dGhvZCB0aGF0IGNoZWNrcyBhIGdpdmVuIGVsZW1lbnQgZm9yIHRoZSBkYXRhLXdlYndvcmtzLWNv bnRleHQKICAgICAgICAgIGF0dHJpYnV0ZSBhbmQgcmV0dXJucyBpdHMgdmFsdWUgaWYgcHJlc2Vu dC4KLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwICAgICAgICAg ICB8ICAgIDcgKysrKysrCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAg ICAgICAgICAgICB8ICAgMjEgKysrKysrKysrKysrKysrKysrKysKIC4uLi9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwIHwgICAxMiArKysrKysrKysrKwogLi4u L1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5oICAgfCAgICAxICsK IDQgZmlsZXMgY2hhbmdlZCwgNDEgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRleCA5MzdiYjM1Li5iNTNlYTdk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKQEAgLTI0NDQsNiAr MjQ0NCwxMyBAQCBQbGF0Zm9ybTo6V2ViQ29udGV4dCBXZWJQYWdlUHJpdmF0ZTo6d2ViQ29udGV4 dChUYXJnZXREZXRlY3Rpb25TdHJhdGVneSBzdHJhdGVneQogCiAgICAgaWYgKG5vZGUtPmlzRWxl bWVudE5vZGUoKSkgewogICAgICAgICBFbGVtZW50KiBlbGVtZW50ID0gc3RhdGljX2Nhc3Q8RWxl bWVudCo+KG5vZGUtPnNoYWRvd0FuY2VzdG9yTm9kZSgpKTsKKworICAgICAgICBTdHJpbmcgd2Vi V29ya3NDb250ZXh0KERPTVN1cHBvcnQ6OndlYldvcmtzQ29udGV4dChlbGVtZW50KSk7CisgICAg ICAgIGlmICghd2ViV29ya3NDb250ZXh0LnN0cmlwV2hpdGVTcGFjZSgpLmlzRW1wdHkoKSkgewor ICAgICAgICAgICAgY29udGV4dC5zZXRGbGFnKFBsYXRmb3JtOjpXZWJDb250ZXh0OjpJc1dlYldv cmtzQ29udGV4dCk7CisgICAgICAgICAgICBjb250ZXh0LnNldFdlYldvcmtzQ29udGV4dCh3ZWJX b3Jrc0NvbnRleHQudXRmOCgpLmRhdGEoKSk7CisgICAgICAgIH0KKwogICAgICAgICBpZiAoRE9N U3VwcG9ydDo6aXNUZXh0QmFzZWRDb250ZW50RWRpdGFibGVFbGVtZW50KGVsZW1lbnQpKSB7CiAg ICAgICAgICAgICBpZiAoIWNhblN0YXJ0U2VsZWN0aW9uKSB7CiAgICAgICAgICAgICAgICAgLy8g SW5wdXQgZmllbGRzIGhvc3Qgbm9kZSBpcyBieSBzcGVjIG5vbi1lZGl0YWJsZSB1bmxlc3MgdGhl IGZpZWxkIGl0c2VsZiBoYXMgY29udGVudCBlZGl0YWJsZSBlbmFibGVkLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9DaGFuZ2VMb2cKaW5kZXggOTBmOTAzMS4uYmMyNTk0MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTItMDktMDYgIEdlbmV2aWV2ZSBNYWsg IDxnbWFrQHJpbS5jb20+CisKKyAgICAgICAgQWRkIGRhdGEtYmxhY2tiZXJyeS13ZWJ3b3Jrcy1j b250ZXh0IGF0dHJpYnV0ZSBhbmQgc2V0IHRoZSBjdXN0b20gY29udGV4dCB3aGVuCisgICAgICAg IGdldHRpbmcgY29udGV4dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk1OTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUFIgIzE5MzcyNgorICAgICAgICBSZXZpZXdlZCBJbnRlcm5hbGx5IGJ5IE1pa2Ug RmVudG9uLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJy eTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6d2ViQ29udGV4dCk6CisgICAgICAgICAgICAtIENo ZWNrIGZvciBjdXN0b20gV2ViV29ya3MgY29udGV4dCBhbmQgYWRkIGl0IGlmIHRoZXJlLgorICAg ICAgICAqIFdlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5 OjpXZWJLaXQ6OkRPTVN1cHBvcnQ6OndlYldvcmtzQ29udGV4dCk6CisgICAgICAgIChET01TdXBw b3J0KToKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuaDoKKyAgICAgICAgICAg IC0gQWRkIGEgbWV0aG9kIHRoYXQgY2hlY2tzIGEgZ2l2ZW4gZWxlbWVudCBmb3IgdGhlIGRhdGEt d2Vid29ya3MtY29udGV4dAorICAgICAgICAgICAgICBhdHRyaWJ1dGUgYW5kIHJldHVybnMgaXRz IHZhbHVlIGlmIHByZXNlbnQuCisKIDIwMTItMDgtMTYgIFJvYiBCdWlzICA8cmJ1aXNAcmltLmNv bT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gU3VwcHJlc3Mgbm9uIERSVCBKUyBDb25zb2xlIG91 dHB1dC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0 L0RPTVN1cHBvcnQuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQv RE9NU3VwcG9ydC5jcHAKaW5kZXggYTljMWY2Ny4uODdiZGU3YiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5jcHAKQEAgLTEx Niw2ICsxMTYsMTggQEAgV1RGOjpTdHJpbmcgaW5wdXRFbGVtZW50VGV4dChFbGVtZW50KiBlbGVt ZW50KQogICAgIHJldHVybiBlbGVtZW50VGV4dDsKIH0KIAorV1RGOjpTdHJpbmcgd2ViV29ya3ND b250ZXh0KGNvbnN0IFdlYkNvcmU6OkVsZW1lbnQqIGVsZW1lbnQpCit7CisgICAgaWYgKCFlbGVt ZW50KQorICAgICAgICByZXR1cm4gV1RGOjpTdHJpbmcoKTsKKworICAgIERFRklORV9TVEFUSUNf TE9DQUwoUXVhbGlmaWVkTmFtZSwgd2Vid29ya3NDb250ZXh0QXR0ciwgKG51bGxBdG9tLCAiZGF0 YS1ibGFja2JlcnJ5LXdlYndvcmtzLWNvbnRleHQiLCBudWxsQXRvbSkpOworICAgIGlmIChlbGVt ZW50LT5mYXN0SGFzQXR0cmlidXRlKHdlYndvcmtzQ29udGV4dEF0dHIpKQorICAgICAgICByZXR1 cm4gZWxlbWVudC0+ZmFzdEdldEF0dHJpYnV0ZSh3ZWJ3b3Jrc0NvbnRleHRBdHRyKTsKKworICAg IHJldHVybiBXVEY6OlN0cmluZygpOworfQorCiBib29sIGlzRWxlbWVudFR5cGVQbHVnaW4oY29u c3QgRWxlbWVudCogZWxlbWVudCkKIHsKICAgICBpZiAoIWVsZW1lbnQpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmggYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmgKaW5kZXggNWRl N2Y3My4uY2RmZTBmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktp dFN1cHBvcnQvRE9NU3VwcG9ydC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJL aXRTdXBwb3J0L0RPTVN1cHBvcnQuaApAQCAtNjMsNiArNjMsNyBAQCBBdHRyaWJ1dGVTdGF0ZSBl bGVtZW50U3VwcG9ydHNBdXRvY29tcGxldGUoY29uc3QgV2ViQ29yZTo6RWxlbWVudCopOwogQXR0 cmlidXRlU3RhdGUgZWxlbWVudFN1cHBvcnRzU3BlbGxDaGVjayhjb25zdCBXZWJDb3JlOjpFbGVt ZW50Kik7CiAKIFdURjo6U3RyaW5nIGlucHV0RWxlbWVudFRleHQoV2ViQ29yZTo6RWxlbWVudCop OworV1RGOjpTdHJpbmcgd2ViV29ya3NDb250ZXh0KGNvbnN0IFdlYkNvcmU6OkVsZW1lbnQqKTsK IAogV2ViQ29yZTo6SFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQqIHRvVGV4dENvbnRyb2xFbGVt ZW50KFdlYkNvcmU6Ok5vZGUqKTsKIAotLSAKMS43LjcuNAoK