95990 2012-09-06 09:14:06 -0700 [EFL][WK2] Build warning : fix warning about extended initializer on EWK2UnitTestBase.cpp. 2012-09-10 22:03:38 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 bw80.lee webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 713352 0 bw80.lee 2012-09-06 09:14:06 -0700 There is a warning on EWK2UnitTestBase.cpp. 713357 1 bw80.lee 2012-09-06 09:17:57 -0700 Warning message : warning: extended initializer lists only available with -std=c++0x or -std=gnu++0x [enabled by default] 713359 2 162522 bw80.lee 2012-09-06 09:20:57 -0700 Created attachment 162522 Patch 714133 3 162522 gyuyoung.kim 2012-09-06 22:47:17 -0700 Comment on attachment 162522 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162522&action=review > Source/WebKit2/ChangeLog:3 > + Build warning : fix warning about extended initializer lists on EWK2UnitTestBase.cpp. Good to add [EFL][WK2] 714163 4 162680 bw80.lee 2012-09-06 23:18:07 -0700 Created attachment 162680 Patch 714166 5 162680 ryuan.choi 2012-09-06 23:25:30 -0700 Comment on attachment 162680 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162680&action=review > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:44 > + static Ewk_View_Smart_Class ewkViewClass = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("Browser_View"); > + return ewkViewClass; Did you test whether this is fine although test cases does not clear the methods ? 714247 6 bw80.lee 2012-09-07 01:01:17 -0700 (In reply to comment #5) > (From update of attachment 162680 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=162680&action=review > > > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:44 > > + static Ewk_View_Smart_Class ewkViewClass = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("Browser_View"); > > + return ewkViewClass; > > Did you test whether this is fine although test cases does not clear the methods ? It's a good point. There was no regression with current test case. But there can be some problem because ewk2UnitTestBrowserViewSmartClass() returns reference. (The initial data can be changed.) Return by copying data will be better. Thanks for pointing this. 714278 7 162707 bw80.lee 2012-09-07 01:40:28 -0700 Created attachment 162707 Patch 714303 8 162707 gyuyoung.kim 2012-09-07 02:02:02 -0700 Comment on attachment 162707 Patch LGTM. 716827 9 162707 gyuyoung.kim 2012-09-10 21:40:48 -0700 Comment on attachment 162707 Patch Looks fine. 716837 10 162707 webkit.review.bot 2012-09-10 22:03:34 -0700 Comment on attachment 162707 Patch Clearing flags on attachment: 162707 Committed r128145: <http://trac.webkit.org/changeset/128145> 716838 11 webkit.review.bot 2012-09-10 22:03:38 -0700 All reviewed patches have been landed. Closing bug. 162522 2012-09-06 09:20:57 -0700 2012-09-06 23:18:00 -0700 Patch bug-95990-20120907012036.patch text/plain 2030 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTA0YjYxMjgyYTQ0YmZm MGI0NDk4ZGFmZGQyYjZmNWRkN2MwMzJmMS4uZmE4ZWZmZWZlYWNlZTM0M2E3NzAwYzA5OTlhMmQ3 NjUwMjExZWYyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTA2ICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBCdWlsZCB3YXJuaW5n IDogZml4IHdhcm5pbmcgYWJvdXQgZXh0ZW5kZWQgaW5pdGlhbGl6ZXIgbGlzdHMgb24gRVdLMlVu aXRUZXN0QmFzZS5jcHAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NTk5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCBidWlsZCB3YXJuaW5nIGFib3V0IGV4dGVuZGVkIGluaXRpYWxpemVyIGxpc3Rz IG9ubHkgYXZhaWxhYmxlIHdpdGgKKyAgICAgICAgLXN0ZD1jKysweCBvciAtc3RkPWdudSsrMHgu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJV bml0VGVzdEJhc2UuY3BwOgorICAgICAgICAoRVdLMlVuaXRUZXN0Ojpld2syVW5pdFRlc3RCcm93 c2VyVmlld1NtYXJ0Q2xhc3MpOgorICAgICAgICAoRVdLMlVuaXRUZXN0KToKKyAgICAgICAgKEVX SzJVbml0VGVzdDo6RVdLMlVuaXRUZXN0QmFzZTo6RVdLMlVuaXRUZXN0QmFzZSk6CisKIDIwMTIt MDktMDYgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAog ICAgICAgICBbRUZMXVtXSzJdIFByb3ZpZGUgaW1wbGVtZW50YXRpb24gZm9yIFdlYlBhZ2U6OnBl cmZvcm1EZWZhdWx0QmVoYXZpb3JGb3JLZXlFdmVudCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJh c2UuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RV dGlscy9FV0syVW5pdFRlc3RCYXNlLmNwcAppbmRleCA4MDMzZTI0OTg4ZWVhYjVjNjZkNTMxZmY0 ODliNmUxMzE4YzQ4ZTQ5Li44YjQ1NWY3NjQxNTA2ZmM0MzI0N2FlYTgxM2NjMDc4YjE4NTkxODg1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0 VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5jcHAKQEAg LTM4LDEwICszOCwxNiBAQCBzdGF0aWMgdm9pZCBvbkxvYWRGaW5pc2hlZCh2b2lkKiB1c2VyRGF0 YSwgRXZhc19PYmplY3QqIHdlYlZpZXcsIHZvaWQqIGV2ZW50SW5mbwogICAgICpsb2FkRmluaXNo ZWQgPSB0cnVlOwogfQogCitzdGF0aWMgRXdrX1ZpZXdfU21hcnRfQ2xhc3MmIGV3azJVbml0VGVz dEJyb3dzZXJWaWV3U21hcnRDbGFzcygpCit7CisgICAgc3RhdGljIEV3a19WaWV3X1NtYXJ0X0Ns YXNzIGV3a1ZpZXdDbGFzcyA9IEVXS19WSUVXX1NNQVJUX0NMQVNTX0lOSVRfTkFNRV9WRVJTSU9O KCJCcm93c2VyX1ZpZXciKTsKKyAgICByZXR1cm4gZXdrVmlld0NsYXNzOworfQorCiBFV0syVW5p dFRlc3RCYXNlOjpFV0syVW5pdFRlc3RCYXNlKCkKICAgICA6IG1fZWNvcmVFdmFzKDApCiAgICAg LCBtX3dlYlZpZXcoMCkKLSAgICAsIG1fZXdrVmlld0NsYXNzKEVXS19WSUVXX1NNQVJUX0NMQVNT X0lOSVRfTkFNRV9WRVJTSU9OKCJCcm93c2VyX1ZpZXciKSkKKyAgICAsIG1fZXdrVmlld0NsYXNz KGV3azJVbml0VGVzdEJyb3dzZXJWaWV3U21hcnRDbGFzcygpKQogewogICAgIGV3a192aWV3X3Nt YXJ0X2NsYXNzX3NldCgmbV9ld2tWaWV3Q2xhc3MpOwogfQo= 162680 2012-09-06 23:18:07 -0700 2012-09-07 01:40:20 -0700 Patch bug-95990-20120907151746.patch text/plain 2041 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTA0YjYxMjgyYTQ0YmZm MGI0NDk4ZGFmZGQyYjZmNWRkN2MwMzJmMS4uM2I0NGIzN2UyOGI4ZmUxZGEwOGIwOWZhMWVhMjIz NDk5YzhkNzIwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTA2ICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEJ1 aWxkIHdhcm5pbmcgOiBmaXggd2FybmluZyBhYm91dCBleHRlbmRlZCBpbml0aWFsaXplciBsaXN0 cyBvbiBFV0syVW5pdFRlc3RCYXNlLmNwcC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk1OTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5pbmcgYWJvdXQgZXh0ZW5kZWQgaW5pdGlh bGl6ZXIgbGlzdHMgb25seSBhdmFpbGFibGUgd2l0aAorICAgICAgICAtc3RkPWMrKzB4IG9yIC1z dGQ9Z251KysweC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0 VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5jcHA6CisgICAgICAgIChFV0syVW5pdFRlc3Q6OmV3azJV bml0VGVzdEJyb3dzZXJWaWV3U21hcnRDbGFzcyk6CisgICAgICAgIChFV0syVW5pdFRlc3QpOgor ICAgICAgICAoRVdLMlVuaXRUZXN0OjpFV0syVW5pdFRlc3RCYXNlOjpFV0syVW5pdFRlc3RCYXNl KToKKwogMjAxMi0wOS0wNiAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50 ZWwuY29tPgogCiAgICAgICAgIFtFRkxdW1dLMl0gUHJvdmlkZSBpbXBsZW1lbnRhdGlvbiBmb3Ig V2ViUGFnZTo6cGVyZm9ybURlZmF1bHRCZWhhdmlvckZvcktleUV2ZW50KCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdL MlVuaXRUZXN0QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0 cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuY3BwCmluZGV4IDgwMzNlMjQ5ODhlZWFi NWM2NmQ1MzFmZjQ4OWI2ZTEzMThjNDhlNDkuLjhiNDU1Zjc2NDE1MDZmYzQzMjQ3YWVhODEzY2Mw NzhiMTg1OTE4ODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RC YXNlLmNwcApAQCAtMzgsMTAgKzM4LDE2IEBAIHN0YXRpYyB2b2lkIG9uTG9hZEZpbmlzaGVkKHZv aWQqIHVzZXJEYXRhLCBFdmFzX09iamVjdCogd2ViVmlldywgdm9pZCogZXZlbnRJbmZvCiAgICAg KmxvYWRGaW5pc2hlZCA9IHRydWU7CiB9CiAKK3N0YXRpYyBFd2tfVmlld19TbWFydF9DbGFzcyYg ZXdrMlVuaXRUZXN0QnJvd3NlclZpZXdTbWFydENsYXNzKCkKK3sKKyAgICBzdGF0aWMgRXdrX1Zp ZXdfU21hcnRfQ2xhc3MgZXdrVmlld0NsYXNzID0gRVdLX1ZJRVdfU01BUlRfQ0xBU1NfSU5JVF9O QU1FX1ZFUlNJT04oIkJyb3dzZXJfVmlldyIpOworICAgIHJldHVybiBld2tWaWV3Q2xhc3M7Cit9 CisKIEVXSzJVbml0VGVzdEJhc2U6OkVXSzJVbml0VGVzdEJhc2UoKQogICAgIDogbV9lY29yZUV2 YXMoMCkKICAgICAsIG1fd2ViVmlldygwKQotICAgICwgbV9ld2tWaWV3Q2xhc3MoRVdLX1ZJRVdf U01BUlRfQ0xBU1NfSU5JVF9OQU1FX1ZFUlNJT04oIkJyb3dzZXJfVmlldyIpKQorICAgICwgbV9l d2tWaWV3Q2xhc3MoZXdrMlVuaXRUZXN0QnJvd3NlclZpZXdTbWFydENsYXNzKCkpCiB7CiAgICAg ZXdrX3ZpZXdfc21hcnRfY2xhc3Nfc2V0KCZtX2V3a1ZpZXdDbGFzcyk7CiB9Cg== 162707 2012-09-07 01:40:28 -0700 2012-09-10 22:03:34 -0700 Patch bug-95990-20120907174007.patch text/plain 2040 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTA0YjYxMjgyYTQ0YmZm MGI0NDk4ZGFmZGQyYjZmNWRkN2MwMzJmMS4uM2I0NGIzN2UyOGI4ZmUxZGEwOGIwOWZhMWVhMjIz NDk5YzhkNzIwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTA2ICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEJ1 aWxkIHdhcm5pbmcgOiBmaXggd2FybmluZyBhYm91dCBleHRlbmRlZCBpbml0aWFsaXplciBsaXN0 cyBvbiBFV0syVW5pdFRlc3RCYXNlLmNwcC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk1OTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5pbmcgYWJvdXQgZXh0ZW5kZWQgaW5pdGlh bGl6ZXIgbGlzdHMgb25seSBhdmFpbGFibGUgd2l0aAorICAgICAgICAtc3RkPWMrKzB4IG9yIC1z dGQ9Z251KysweC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0 VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5jcHA6CisgICAgICAgIChFV0syVW5pdFRlc3Q6OmV3azJV bml0VGVzdEJyb3dzZXJWaWV3U21hcnRDbGFzcyk6CisgICAgICAgIChFV0syVW5pdFRlc3QpOgor ICAgICAgICAoRVdLMlVuaXRUZXN0OjpFV0syVW5pdFRlc3RCYXNlOjpFV0syVW5pdFRlc3RCYXNl KToKKwogMjAxMi0wOS0wNiAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50 ZWwuY29tPgogCiAgICAgICAgIFtFRkxdW1dLMl0gUHJvdmlkZSBpbXBsZW1lbnRhdGlvbiBmb3Ig V2ViUGFnZTo6cGVyZm9ybURlZmF1bHRCZWhhdmlvckZvcktleUV2ZW50KCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdL MlVuaXRUZXN0QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0 cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuY3BwCmluZGV4IDgwMzNlMjQ5ODhlZWFi NWM2NmQ1MzFmZjQ4OWI2ZTEzMThjNDhlNDkuLjU0NTIzZjA0Njg3OTdlZmJjOGNlZDYzYzlkM2Q3 OTU4OGVkYzE1NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RC YXNlLmNwcApAQCAtMzgsMTAgKzM4LDE2IEBAIHN0YXRpYyB2b2lkIG9uTG9hZEZpbmlzaGVkKHZv aWQqIHVzZXJEYXRhLCBFdmFzX09iamVjdCogd2ViVmlldywgdm9pZCogZXZlbnRJbmZvCiAgICAg KmxvYWRGaW5pc2hlZCA9IHRydWU7CiB9CiAKK3N0YXRpYyBFd2tfVmlld19TbWFydF9DbGFzcyBl d2syVW5pdFRlc3RCcm93c2VyVmlld1NtYXJ0Q2xhc3MoKQoreworICAgIHN0YXRpYyBFd2tfVmll d19TbWFydF9DbGFzcyBld2tWaWV3Q2xhc3MgPSBFV0tfVklFV19TTUFSVF9DTEFTU19JTklUX05B TUVfVkVSU0lPTigiQnJvd3Nlcl9WaWV3Iik7CisgICAgcmV0dXJuIGV3a1ZpZXdDbGFzczsKK30K KwogRVdLMlVuaXRUZXN0QmFzZTo6RVdLMlVuaXRUZXN0QmFzZSgpCiAgICAgOiBtX2Vjb3JlRXZh cygwKQogICAgICwgbV93ZWJWaWV3KDApCi0gICAgLCBtX2V3a1ZpZXdDbGFzcyhFV0tfVklFV19T TUFSVF9DTEFTU19JTklUX05BTUVfVkVSU0lPTigiQnJvd3Nlcl9WaWV3IikpCisgICAgLCBtX2V3 a1ZpZXdDbGFzcyhld2syVW5pdFRlc3RCcm93c2VyVmlld1NtYXJ0Q2xhc3MoKSkKIHsKICAgICBl d2tfdmlld19zbWFydF9jbGFzc19zZXQoJm1fZXdrVmlld0NsYXNzKTsKIH0K