95977 2012-09-06 05:42:50 -0700 webkit build for 64-bit Mac chromium 2012-09-10 11:48:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac (Intel) OS X 10.7 RESOLVED FIXED P2 Normal --- 0 badea webkit-unassigned abarth dglazkov eric fishd jamesr mark mmaerean ossy thakis tkent+wkapi webkit.review.bot oldest_to_newest 713198 0 badea 2012-09-06 05:42:50 -0700 Webkit yields compilation errors when trying to build chromium for the x86_64 architecture (Mac OS X 10.7). 713259 1 162501 badea 2012-09-06 06:56:04 -0700 Created attachment 162501 Patch fix. 715859 2 webkit.review.bot 2012-09-10 02:30:07 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 716162 3 162501 eric 2012-09-10 09:35:43 -0700 Comment on attachment 162501 Patch fix. View in context: https://bugs.webkit.org/attachment.cgi?id=162501&action=review > Source/WebKit/chromium/public/mac/WebSubstringUtil.h:34 > +#include "../platform/WebCommon.h" This seems like an odd way to include a header? Are you sure this is proper form? Maybe <platform/WebCommon.h> ? > Source/WebKit/chromium/src/mac/WebSubstringUtil.mm:35 > +#import <Cocoa/Cocoa.h> Why the re-org? 716163 4 162501 eric 2012-09-10 09:36:01 -0700 Comment on attachment 162501 Patch fix. View in context: https://bugs.webkit.org/attachment.cgi?id=162501&action=review > Source/WebCore/platform/graphics/IntRect.h:236 > +#if (PLATFORM(MAC) || (PLATFORM(CHROMIUM) && OS(DARWIN))) \ > + && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES) \ > + || (PLATFORM(QT) && USE(QTKIT)) Is Qt wrong here too? 716208 5 badea 2012-09-10 10:07:47 -0700 Thank you for the review. (In reply to comment #3) > (From update of attachment 162501 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=162501&action=review > > > Source/WebKit/chromium/public/mac/WebSubstringUtil.h:34 > > +#include "../platform/WebCommon.h" > > This seems like an odd way to include a header? Are you sure this is proper form? Maybe <platform/WebCommon.h> ? I've followed the headers in WebKit/chromium/public/mac/ as examples. > > Source/WebKit/chromium/src/mac/WebSubstringUtil.mm:35 > > +#import <Cocoa/Cocoa.h> > > Why the re-org? Cocoa/Cocoa.h needs to be included first in order for the SGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES macro to be defined before the contents of FloatSize.h & similar headers are being preprocessed ensuring that no extra constructors will be declared. This also complies with header include ordering. 716305 6 162501 eric 2012-09-10 11:22:17 -0700 Comment on attachment 162501 Patch fix. Seems reasonable. 716332 7 162501 webkit.review.bot 2012-09-10 11:48:45 -0700 Comment on attachment 162501 Patch fix. Clearing flags on attachment: 162501 Committed r128085: <http://trac.webkit.org/changeset/128085> 716333 8 webkit.review.bot 2012-09-10 11:48:49 -0700 All reviewed patches have been landed. Closing bug. 162501 2012-09-06 06:56:04 -0700 2012-09-10 11:48:45 -0700 Patch fix. webkit_build.patch text/plain 5974 badea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjZWFkYjViLi5iYzFkOTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTItMDktMDYgIENhdGFsaW4gQmFkZWEgIDxiYWRlYUBhZG9iZS5jb20+CisKKyAgICAg ICAgd2Via2l0IGJ1aWxkIGZvciA2NC1iaXQgTWFjIGNocm9taXVtCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTk3NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB0aGUgY29ycmVjdCBkZWZpbml0aW9u cyBmb3IgTlMgdHlwZXMgaW4gb3JkZXIgdG8gZml4IGJ1aWxkIGlzc3VlcyBmb3IgNjQtYml0IGNo cm9taXVtIG9uIG1hYy4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtU3Vw cG9ydC5oOgorICAgICAgICBSZW1vdmUgYSBkZXByZWNhdGVkIENhcmJvbiB0eXBlZGVmLgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuaDoKKyAgICAgICAgKEZsb2F0UG9p bnQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UmVjdC5oOgorICAgICAgICAo RmxvYXRSZWN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFNpemUuaDoKKyAg ICAgICAgKEZsb2F0U2l6ZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvSW50UmVjdC5o OgorICAgICAgICAoSW50UmVjdCk6CisKIDIwMTItMDktMDYgIFBhdHJpY2sgR2Fuc3RlcmVyICA8 cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW9yZSBmaXhlcyBmb3IgU3RyaW5nOjpvcGVy YXRvcis9KCkgaW4gRGVidWcgbW9kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vUGxhdGZvcm1TdXBwb3J0LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9j aHJvbWl1bS9QbGF0Zm9ybVN1cHBvcnQuaAppbmRleCA2ZTc5NDllLi41YjAyZGJmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVN1cHBvcnQuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVN1cHBvcnQuaApA QCAtNTEsNyArNTEsNiBAQCB0eXBlZGVmIE5QUF90KiBOUFA7CiAKICNpZiBPUyhEQVJXSU4pCiB0 eXBlZGVmIHN0cnVjdCBDR0ZvbnQqIENHRm9udFJlZjsKLXR5cGVkZWYgdWludHB0cl90IEFUU0Zv bnRDb250YWluZXJSZWY7CiAjaWZkZWYgX19PQkpDX18KIEBjbGFzcyBOU0ZvbnQ7CiAjZWxzZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQb2ludC5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQb2ludC5oCmluZGV4IDkw ZTZjNGIuLjU4ZGI2YmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0Zsb2F0UG9pbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9G bG9hdFBvaW50LmgKQEAgLTE1NCw4ICsxNTQsOCBAQCBwdWJsaWM6CiAgICAgb3BlcmF0b3IgQ0dQ b2ludCgpIGNvbnN0OwogI2VuZGlmCiAKLSNpZiAoUExBVEZPUk0oTUFDKSAmJiAhZGVmaW5lZChO U0dFT01FVFJZX1RZUEVTX1NBTUVfQVNfQ0dHRU9NRVRSWV9UWVBFUykpIFwKLSAgICAgICAgfHwg KFBMQVRGT1JNKENIUk9NSVVNKSAmJiBPUyhEQVJXSU4pKQorI2lmIChQTEFURk9STShNQUMpIHx8 IChQTEFURk9STShDSFJPTUlVTSkgJiYgT1MoREFSV0lOKSkpIFwKKyAgICAgICAgJiYgIWRlZmlu ZWQoTlNHRU9NRVRSWV9UWVBFU19TQU1FX0FTX0NHR0VPTUVUUllfVFlQRVMpCiAgICAgRmxvYXRQ b2ludChjb25zdCBOU1BvaW50Jik7CiAgICAgb3BlcmF0b3IgTlNQb2ludCgpIGNvbnN0OwogI2Vu ZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFJl Y3QuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UmVjdC5oCmluZGV4 IDcyNTAxMmYuLjE2MWUyNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0Zsb2F0UmVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0Zsb2F0UmVjdC5oCkBAIC0xOTksOCArMTk5LDggQEAgcHVibGljOgogICAgIG9wZXJhdG9yIENH UmVjdCgpIGNvbnN0OwogI2VuZGlmCiAKLSNpZiAoUExBVEZPUk0oTUFDKSAmJiAhZGVmaW5lZChO U0dFT01FVFJZX1RZUEVTX1NBTUVfQVNfQ0dHRU9NRVRSWV9UWVBFUykpIFwKLSAgICAgICAgfHwg KFBMQVRGT1JNKENIUk9NSVVNKSAmJiBPUyhEQVJXSU4pKQorI2lmIChQTEFURk9STShNQUMpIHx8 IChQTEFURk9STShDSFJPTUlVTSkgJiYgT1MoREFSV0lOKSkpIFwKKyAgICAgICAgJiYgIWRlZmlu ZWQoTlNHRU9NRVRSWV9UWVBFU19TQU1FX0FTX0NHR0VPTUVUUllfVFlQRVMpCiAgICAgRmxvYXRS ZWN0KGNvbnN0IE5TUmVjdCYpOwogICAgIG9wZXJhdG9yIE5TUmVjdCgpIGNvbnN0OwogI2VuZGlm CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFNpemUu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0U2l6ZS5oCmluZGV4IGIx ZDcyYTUuLmMwMjljNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0Zsb2F0U2l6ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zs b2F0U2l6ZS5oCkBAIC0xMzUsOCArMTM1LDkgQEAgcHVibGljOgogICAgIG9wZXJhdG9yIENHU2l6 ZSgpIGNvbnN0OwogI2VuZGlmCiAKLSNpZiAoUExBVEZPUk0oTUFDKSAmJiAhZGVmaW5lZChOU0dF T01FVFJZX1RZUEVTX1NBTUVfQVNfQ0dHRU9NRVRSWV9UWVBFUykpIFwKLSAgICAgICAgfHwgKFBM QVRGT1JNKENIUk9NSVVNKSAmJiBPUyhEQVJXSU4pKSB8fCAoUExBVEZPUk0oUVQpICYmIFVTRShR VEtJVCkpCisjaWYgKFBMQVRGT1JNKE1BQykgfHwgKFBMQVRGT1JNKENIUk9NSVVNKSAmJiBPUyhE QVJXSU4pKSkgXAorICAgICAgICAmJiAhZGVmaW5lZChOU0dFT01FVFJZX1RZUEVTX1NBTUVfQVNf Q0dHRU9NRVRSWV9UWVBFUykgXAorICAgICAgICB8fCAoUExBVEZPUk0oUVQpICYmIFVTRShRVEtJ VCkpCiAgICAgZXhwbGljaXQgRmxvYXRTaXplKGNvbnN0IE5TU2l6ZSAmKTsgLy8gZG9uJ3QgZG8g dGhpcyBpbXBsaWNpdGx5IHNpbmNlIGl0J3MgbG9zc3kKICAgICBvcGVyYXRvciBOU1NpemUoKSBj b25zdDsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvSW50UmVjdC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UmVjdC5o CmluZGV4IDlhOWE3ZjcuLmVkYTU4MmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0ludFJlY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9JbnRSZWN0LmgKQEAgLTIzMSw4ICsyMzEsOSBAQCBwdWJsaWM6CiAgICAgb3BlcmF0b3Ig U2tJUmVjdCgpIGNvbnN0OwogI2VuZGlmCiAKLSNpZiAoUExBVEZPUk0oTUFDKSAmJiAhZGVmaW5l ZChOU0dFT01FVFJZX1RZUEVTX1NBTUVfQVNfQ0dHRU9NRVRSWV9UWVBFUykpIFwKLSAgICAgICAg fHwgKFBMQVRGT1JNKENIUk9NSVVNKSAmJiBPUyhEQVJXSU4pKSAgfHwgKFBMQVRGT1JNKFFUKSAm JiBVU0UoUVRLSVQpKQorI2lmIChQTEFURk9STShNQUMpIHx8IChQTEFURk9STShDSFJPTUlVTSkg JiYgT1MoREFSV0lOKSkpIFwKKyAgICAgICAgJiYgIWRlZmluZWQoTlNHRU9NRVRSWV9UWVBFU19T QU1FX0FTX0NHR0VPTUVUUllfVFlQRVMpIFwKKyAgICAgICAgfHwgKFBMQVRGT1JNKFFUKSAmJiBV U0UoUVRLSVQpKQogICAgIG9wZXJhdG9yIE5TUmVjdCgpIGNvbnN0OwogI2VuZGlmCiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZTcyOGFjNy4uODI5ZmUxYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOS0wNiAgQ2F0YWxpbiBCYWRlYSAg PGJhZGVhQGFkb2JlLmNvbT4KKworICAgICAgICB3ZWJraXQgYnVpbGQgZm9yIDY0LWJpdCBNYWMg Y2hyb21pdW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk1OTc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RW5zdXJlIGhlYWRlciBjb21wbGV0ZW5lc3MgYW5kIHVzZSB0aGUgY29ycmVjdCBpbmNsdWRlIG9y ZGVyLiBUaGlzIGZpeGVzIGEgY29tcGlsYXRpb24gaXNzdWVzIG5vdGljZWFibGUgd2hlbiBidWls ZGluZyBjaHJvbWl1bSBmb3IgNjQtYml0IE1hYy4gCisKKyAgICAgICAgKiBwdWJsaWMvbWFjL1dl YlN1YnN0cmluZ1V0aWwuaDoKKyAgICAgICAgKiBzcmMvbWFjL1dlYlN1YnN0cmluZ1V0aWwubW06 CisKIDIwMTItMDktMDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBDaHJvbWl1bSBzaG91bGQgY2FsbCByZXN0cmljdFNjYWxlRmFjdG9yVG9Jbml0aWFsU2NhbGVJ Zk5vdFVzZXJTY2FsYWJsZSB1bmxlc3MvdW50aWwgdXNlclNjYWxhYmxlIGlzIHN1cHBvcnRlZCBk aXJlY3RseS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL21hYy9X ZWJTdWJzdHJpbmdVdGlsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9tYWMvV2Vi U3Vic3RyaW5nVXRpbC5oCmluZGV4IGIyMWZlMjEuLjcxNDI3NjMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL21hYy9XZWJTdWJzdHJpbmdVdGlsLmgKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvbWFjL1dlYlN1YnN0cmluZ1V0aWwuaApAQCAtMzEs NiArMzEsOCBAQAogI2lmbmRlZiBXZWJTdWJzdHJpbmdVdGlsX2gKICNkZWZpbmUgV2ViU3Vic3Ry aW5nVXRpbF9oCiAKKyNpbmNsdWRlICIuLi9wbGF0Zm9ybS9XZWJDb21tb24uaCIKKwogbmFtZXNw YWNlIFdlYktpdCB7CiBjbGFzcyBXZWJGcmFtZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL21hYy9XZWJTdWJzdHJpbmdVdGlsLm1tIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvbWFjL1dlYlN1YnN0cmluZ1V0aWwubW0KaW5kZXggZGQ5OTUxZi4uNjgyZGEw ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dlYlN1YnN0cmlu Z1V0aWwubW0KKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dlYlN1YnN0cmlu Z1V0aWwubW0KQEAgLTMwLDkgKzMwLDEwIEBACiAgKi8KIAogI2luY2x1ZGUgImNvbmZpZy5oIgot I2luY2x1ZGUgIldlYkZyYW1lSW1wbC5oIgogI2luY2x1ZGUgIldlYlN1YnN0cmluZ1V0aWwuaCIK IAorI2ltcG9ydCA8Q29jb2EvQ29jb2EuaD4KKwogI2luY2x1ZGUgIkNvbG9yTWFjLmgiCiAjaW5j bHVkZSAiRG9jdW1lbnQuaCIKICNpbmNsdWRlICJFbGVtZW50LmgiCkBAIC00NSwxMCArNDYsOSBA QAogI2luY2x1ZGUgIlJlbmRlck9iamVjdC5oIgogI2luY2x1ZGUgIlJlbmRlclN0eWxlLmgiCiAj aW5jbHVkZSAiVGV4dEl0ZXJhdG9yLmgiCisjaW5jbHVkZSAiV2ViRnJhbWVJbXBsLmgiCiAjaW5j bHVkZSAicGxhdGZvcm0vV2ViUmVjdC5oIgogCi0jaW1wb3J0IDxDb2NvYS9Db2NvYS5oPgotCiB1 c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7Cg==