95973 2012-09-06 04:29:21 -0700 [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac 2012-09-06 07:35:45 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez darin gyuyoung.kim kenneth ossy ryuan.choi sam simon.fraser webkit.review.bot oldest_to_newest 713162 0 cdumez 2012-09-06 04:29:21 -0700 Currently EventSender in WebKitTestRunner unconditionally maps "addSelectionKey" to "Meta" modifier. This is fine on Mac but on others OSes, it should be mapped to "Control" instead. This is causing the following test cases to fail for WebKit2 on non-Mac: fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html fast/forms/listbox-deselect-scroll.html fast/forms/listbox-selection.html 713165 1 162475 cdumez 2012-09-06 04:38:29 -0700 Created attachment 162475 Patch 713167 2 cdumez 2012-09-06 04:43:28 -0700 Adding Ossy in CC since someone may want to check if the following tests can be unskipped on Qt with this fix: fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html fast/forms/listbox-deselect-scroll.html fast/forms/listbox-selection.html They are skipped in the global Skipped list, not in the WK2-specific one so I did not dare unskip them on Qt. 713271 3 162475 webkit.review.bot 2012-09-06 07:35:40 -0700 Comment on attachment 162475 Patch Clearing flags on attachment: 162475 Committed r127739: <http://trac.webkit.org/changeset/127739> 713272 4 webkit.review.bot 2012-09-06 07:35:45 -0700 All reviewed patches have been landed. Closing bug. 162475 2012-09-06 04:38:29 -0700 2012-09-06 07:35:40 -0700 Patch 95973_addSelectionKey.patch text/plain 5197 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjOWI0Njk0Li4xNDEyMWVmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDkt MDYgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBbV0tUUl0gYWRkU2VsZWN0aW9uS2V5IHNob3VsZCBiZSBtYXBwZWQgdG8gIkNvbnRyb2wi IG1vZGlmaWVycyBvbiBvdGhlciBPU2VzIHRoYW4gTWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTk3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcCBzZXZlcmFsIHRlc3QgY2FzZXMgdGhhdCBh cmUgcGFzc2luZyBvbiBXZWJLaXQyCisgICAgICAgIG5vdyB0aGF0ICJhZGRTZWxlY3Rpb25LZXki IGlzIHByb3Blcmx5IG1hcHBlZCB0bworICAgICAgICAiQ29udHJvbCIgbW9kaWZpZXIgb24gb3Ro ZXIgT1NlcyB0aGFuIE1hYyBPUyBYLCBpbgorICAgICAgICBXS1RSJ3MgRXZlbnRTZW5kZXIuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9lZmwtd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICog cGxhdGZvcm0vZ3RrLXdrMi9Ta2lwcGVkOgorICAgICAgICAqIHBsYXRmb3JtL3dpbi13azIvU2tp cHBlZDoKKwogMjAxMi0wOS0wNiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBnYXJkZW5pbmcsIHNraXAgb25lIG1vcmUgZmFp bGluZyB0ZXN0LApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9UZXN0 RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRp b25zCmluZGV4IDg5NmU2ZTQuLmEyNzA0MTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2VmbC13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9l Zmwtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTIzMSwxMCArMjMxLDcgQEAgQlVHV0tFRkwgOiBm YXN0L2V2ZW50cy9ub2RlLWV2ZW50LWFuY2hvci1sb2NrLmh0bWwgPSBURVhUCiBCVUdXS0VGTCA6 IGZhc3QvZXZlbnRzL3Njcm9sbC1hZnRlci1jbGljay1vbi10YWItaW5kZXguaHRtbCA9IFRFWFQK IEJVR1dLRUZMIDogZmFzdC9mb3Jtcy9hdXRvY29tcGxldGUtb2ZmLXdpdGgtZGVmYXVsdC12YWx1 ZS1kb2VzLW5vdC1jbGVhci5odG1sID0gVEVYVAogQlVHV0tFRkwgOiBmYXN0L2Zvcm1zL2xlZ2Vu ZC1hY2Nlc3Mta2V5Lmh0bWwgPSBURVhUCi1CVUdXS0VGTCA6IGZhc3QvZm9ybXMvbGlzdGJveC1k ZXNlbGVjdC1zY3JvbGwuaHRtbCA9IFRFWFQKLUJVR1dLRUZMIDogZmFzdC9mb3Jtcy9saXN0Ym94 LXNlbGVjdGlvbi5odG1sID0gVEVYVAogQlVHV0tFRkwgOiBmYXN0L2Zvcm1zL3BsYWludGV4dC1t b2RlLTEuaHRtbCA9IFRFWFQKLUJVR1dLRUZMIDogZmFzdC9mb3Jtcy9zZWxlY3QtbXVsdGlwbGUt ZWxlbWVudHMtd2l0aC1tb3VzZS1kcmFnLXdpdGgtb3B0aW9ucy1sZXNzLXRoYW4tc2l6ZS5odG1s ID0gVEVYVAogQlVHV0tFRkwgOiBmYXN0L2Zvcm1zL3NlbGVjdC13cml0aW5nLWRpcmVjdGlvbi1u YXR1cmFsLmh0bWwgPSBURVhUCiBCVUdXS0VGTCA6IGZhc3QvZm9ybXMvdmFsaWRhdGlvbi1tZXNz YWdlLWluLXJlbGF0aXZlLWJvZHkuaHRtbCA9IFRFWFQKIEJVR1dLRUZMIDogZmFzdC9mcmFtZXMv ZmxhdHRlbmluZy9pZnJhbWUtdGlueS5odG1sID0gVEVYVApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZ3RrLXdrMi9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrLXdr Mi9Ta2lwcGVkCmluZGV4IGM3NmU1ZWEuLjFlMmEzYzEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay13azIvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGst d2syL1NraXBwZWQKQEAgLTc5LDcgKzc5LDYgQEAgZmFzdC9ldmVudHMva2V5ZG93bi1udW1wYWQt a2V5cy5odG1sCiBmYXN0L2Zvcm1zL2ltcGxpY2l0LXN1Ym1pc3Npb24uaHRtbAogZmFzdC9mb3Jt cy9zZWxlY3QtdHlwZS1haGVhZC1ub24tbGF0aW4uaHRtbAogZmFzdC9mb3Jtcy9saXN0Ym94LXR5 cGVhaGVhZC1jeXJpbGxpYy5odG1sCi1mYXN0L2Zvcm1zL2xpc3Rib3gtc2VsZWN0aW9uLmh0bWwK IGZhc3QvZm9ybXMvbGlzdGJveC10eXBlYWhlYWQtZ3JlZWsuaHRtbAogZmFzdC9mb3Jtcy9sZWdl bmQtYWNjZXNzLWtleS5odG1sCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3dvcmtlcnMvYWJv cnQtZXhjZXB0aW9uLWFzc2VydC5odG1sCkBAIC0yMTYsNyArMjE1LDYgQEAgc3ZnL2N1c3RvbS9t b3VzZS1tb3ZlLW9uLXN2Zy1jb250YWluZXItc3RhbmRhbG9uZS5zdmcKIHN2Zy9jdXN0b20vbW91 c2UtbW92ZS1vbi1zdmctY29udGFpbmVyLnhodG1sCiBzdmcvY3VzdG9tL21vdXNlLW1vdmUtb24t c3ZnLXJvb3Qtc3RhbmRhbG9uZS5zdmcKIHN2Zy9jdXN0b20vbW91c2UtbW92ZS1vbi1zdmctcm9v dC54aHRtbAotZmFzdC9mb3Jtcy9saXN0Ym94LWRlc2VsZWN0LXNjcm9sbC5odG1sCiAKICMgV2Vi S2l0MiBuZWVkcyBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRTbWFydEluc2VydERlbGV0ZUVuYWJs ZWQKIGVkaXRpbmcvc2VsZWN0aW9uL2RvdWJsZWNsaWNrLWJlc2lkZS1jci1zcGFuLmh0bWwKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi13azIvU2tpcHBlZCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL3dpbi13azIvU2tpcHBlZAppbmRleCBlMTRhZTIxLi5kZDFhMmNmIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4td2syL1NraXBwZWQKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vd2luLXdrMi9Ta2lwcGVkCkBAIC0yODQsOSArMjg0LDcgQEAgZmFzdC9m b3Jtcy9pbnB1dC10ZXh0LW9wdGlvbi1kZWxldGUuaHRtbAogZmFzdC9mb3Jtcy9pbnB1dC10ZXh0 LXNjcm9sbC1sZWZ0LW9uLWJsdXIuaHRtbAogZmFzdC9mb3Jtcy9pbnB1dC10eXBlLWNoYW5nZS1p bi1vbmZvY3VzLWtleWJvYXJkLmh0bWwKIGZhc3QvZm9ybXMvbGVnZW5kLWFjY2Vzcy1rZXkuaHRt bAotZmFzdC9mb3Jtcy9saXN0Ym94LWRlc2VsZWN0LXNjcm9sbC5odG1sCiBmYXN0L2Zvcm1zL2xp c3Rib3gtb25jaGFuZ2UuaHRtbAotZmFzdC9mb3Jtcy9saXN0Ym94LXNlbGVjdGlvbi5odG1sCiBm YXN0L2Zvcm1zL2xpc3Rib3gtdHlwZWFoZWFkLWN5cmlsbGljLmh0bWwKIGZhc3QvZm9ybXMvbGlz dGJveC10eXBlYWhlYWQtZW1wdHkuaHRtbAogZmFzdC9mb3Jtcy9saXN0Ym94LXR5cGVhaGVhZC1n cmVlay5odG1sCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cK aW5kZXggOTdlZmE5ZC4uNGNiOTdiZiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTA2ICBDaHJpc3RvcGhl IER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CisKKyAgICAgICAgW1dLVFJdIGFk ZFNlbGVjdGlvbktleSBzaG91bGQgYmUgbWFwcGVkIHRvICJDb250cm9sIiBtb2RpZmllcnMgb24g b3RoZXIgT1NlcyB0aGFuIE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTU5NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDb3JyZWN0bHkgbWFwICJhZGRTZWxlY3Rpb25LZXkiIHRvICJDb250cm9sIiBt b2RpZmllcgorICAgICAgICBpbiBXS1RSJ3MgRXZlbnRTZW5kZXIgb24gb3RoZXIgT1NlcyB0aGFu IE1hYyBPUyBYLAorICAgICAgICBpbnN0ZWFkIG9mIG1hcHBpbmcgaXQgdG8gdGhlICJNZXRhIiBt b2RpZmllci4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvRXZl bnRTZW5kaW5nQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6OnBhcnNlTW9kaWZpZXIpOgor CiAyMDEyLTA5LTA2ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4K IAogICAgICAgICBbUXRdIFZhcmlvdXMgc21hbGwgV2luZG93cyAvIE1TVkMgYnVpbGQgZml4ZXMK ZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvRXZlbnRT ZW5kaW5nQ29udHJvbGxlci5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVu ZGxlL0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIuY3BwCmluZGV4IDJlZWViOWQuLmVjZmE2YjMgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvRXZlbnRTZW5k aW5nQ29udHJvbGxlci5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1 bmRsZS9FdmVudFNlbmRpbmdDb250cm9sbGVyLmNwcApAQCAtNDksOCArNDksMTUgQEAgc3RhdGlj IFdLRXZlbnRNb2RpZmllcnMgcGFyc2VNb2RpZmllcihKU1N0cmluZ1JlZiBtb2RpZmllcikKICAg ICAgICAgcmV0dXJuIGtXS0V2ZW50TW9kaWZpZXJzU2hpZnRLZXk7CiAgICAgaWYgKEpTU3RyaW5n SXNFcXVhbFRvVVRGOENTdHJpbmcobW9kaWZpZXIsICJhbHRLZXkiKSkKICAgICAgICAgcmV0dXJu IGtXS0V2ZW50TW9kaWZpZXJzQWx0S2V5OwotICAgIGlmIChKU1N0cmluZ0lzRXF1YWxUb1VURjhD U3RyaW5nKG1vZGlmaWVyLCAibWV0YUtleSIpIHx8IEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJp bmcobW9kaWZpZXIsICJhZGRTZWxlY3Rpb25LZXkiKSkKKyAgICBpZiAoSlNTdHJpbmdJc0VxdWFs VG9VVEY4Q1N0cmluZyhtb2RpZmllciwgIm1ldGFLZXkiKSkKICAgICAgICAgcmV0dXJuIGtXS0V2 ZW50TW9kaWZpZXJzTWV0YUtleTsKKyAgICBpZiAoSlNTdHJpbmdJc0VxdWFsVG9VVEY4Q1N0cmlu Zyhtb2RpZmllciwgImFkZFNlbGVjdGlvbktleSIpKSB7CisjaWYgT1MoTUFDX09TX1gpCisgICAg ICAgIHJldHVybiBrV0tFdmVudE1vZGlmaWVyc01ldGFLZXk7CisjZWxzZQorICAgICAgICByZXR1 cm4ga1dLRXZlbnRNb2RpZmllcnNDb250cm9sS2V5OworI2VuZGlmCisgICAgfQogICAgIHJldHVy biAwOwogfQogCg==