95969 2012-09-06 03:17:50 -0700 [Qt] Enable CSS Device Adaptation 2022-02-28 03:56:38 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 95959 102811 1 tmpsantos tmpsantos abecsi dbates donggwan.kim hausmann kenneth menard vestbo webkit.review.bot oldest_to_newest 713117 0 tmpsantos 2012-09-06 03:17:50 -0700 Do that when the implementation is stable enough. Unskip layout tests that should pass. 775514 1 176009 tmpsantos 2012-11-26 08:39:45 -0800 Created attachment 176009 Patch 775523 2 tmpsantos 2012-11-26 08:48:56 -0800 CSS Device Adaptation relies on the same backend used by viewport meta, already supported by the Qt port. The current implementation is passing 29/34 tests of the Opera test suite (being one failure a "orientation test" which is up to the port to implement). The pass rate is the same as EFL. The nice thing about enabling this flag is it will start to test fixed layout on the WebKitTestRunner (I landed the bits for Qt support at the bug 102811). We have examples already of regressions on the EFL port that were only caught because we run these tests with a flickable viewport. Now it is up to you guys. 935659 3 176009 andersca 2013-10-02 21:17:33 -0700 Comment on attachment 176009 Patch Qt has been removed, clearing review flags. 975552 4 jturcotte 2014-02-03 03:22:29 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 176009 2012-11-26 08:39:45 -0800 2022-02-28 03:56:38 -0800 Patch bug-95969-20121126184136.patch text/plain 6462 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NzExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2NjOWM3ODA3YzBhZDViODQwZDRkMjZhMjFmNWNlOGUx YmQ2OWFlYy4uYmIwYmJhZDdjNTIyMGE1ZjE4YjU5ZTMwYzc1YTZmZTA2MjYyZDA2NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTExLTI2ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgorCisgICAgICAgIFtRdF0gRW5hYmxlIENTUyBEZXZpY2UgQWRhcHRhdGlvbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU5NjkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgQ1NT IERldmljZSBBZGFwdGF0aW9uIGJ5IGRlZmF1bHQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHBlcmwvRmVhdHVyZUxpc3QucG06CisgICAgICAgICogcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9m ZWF0dXJlcy5wcmk6CisKIDIwMTItMTEtMjYgIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1z dW5nLmNvbT4KIAogICAgICAgICBUZXh0IEF1dG9zaXppbmc6IEFkZCBUZXh0IEF1dG9zaXppbmcg QVBJcyBmb3IgV0syCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVy ZUxpc3QucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KaW5kZXgg ZjVkMDI2NzVjZDIwNTI4MDM1Zjc2MDhlYjdkZWFhYTljZjhlYmRkZi4uZWY3ZTQzMjk2OGFjMDBj YTcwNGM0ZjA4OGQ4M2UwYzNlYWJhZTk4OSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRwZXJsL0ZlYXR1cmVMaXN0LnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0 dXJlTGlzdC5wbQpAQCAtMTY5LDcgKzE2OSw3IEBAIG15IEBmZWF0dXJlcyA9ICgKICAgICAgIGRl ZmluZSA9PiAiRU5BQkxFX0NTUF9ORVhUIiwgZGVmYXVsdCA9PiAwLCB2YWx1ZSA9PiBcJGNzcE5l eHRTdXBwb3J0IH0sCiAKICAgICB7IG9wdGlvbiA9PiAiY3NzLWRldmljZS1hZGFwdGF0aW9uIiwg ZGVzYyA9PiAiVG9nZ2xlIENTUyBEZXZpY2UgQWRhcHRhdGlvbiBzdXBwb3J0IiwKLSAgICAgIGRl ZmluZSA9PiAiRU5BQkxFX0NTU19ERVZJQ0VfQURBUFRBVElPTiIsIGRlZmF1bHQgPT4gaXNFZmwo KSwgdmFsdWUgPT4gXCRjc3NEZXZpY2VBZGFwdGF0aW9uIH0sCisgICAgICBkZWZpbmUgPT4gIkVO QUJMRV9DU1NfREVWSUNFX0FEQVBUQVRJT04iLCBkZWZhdWx0ID0+IGlzRWZsKCkgfHwgaXNRdCgp LCB2YWx1ZSA9PiBcJGNzc0RldmljZUFkYXB0YXRpb24gfSwKIAogICAgIHsgb3B0aW9uID0+ICJj c3MtZXhjbHVzaW9ucyIsIGRlc2MgPT4gIlRvZ2dsZSBDU1MgRXhjbHVzaW9ucyBzdXBwb3J0IiwK ICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX0NTU19FWENMVVNJT05TIiwgZGVmYXVsdCA9PiAxLCB2 YWx1ZSA9PiBcJGNzc0V4Y2x1c2lvbnNTdXBwb3J0IH0sCmRpZmYgLS1naXQgYS9Ub29scy9xbWFr ZS9ta3NwZWNzL2ZlYXR1cmVzL2ZlYXR1cmVzLnByaSBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVh dHVyZXMvZmVhdHVyZXMucHJpCmluZGV4IGMzNjg4OTIyYjdmZDkyZTE5YzcxNTIyZWMxOGQxMWFi Y2NhMzI1MDMuLmFlZGM3ZDgxZDRjZTQ5M2I3YmExYTNlMTYyOWVmNjk0NWY4ZjYyOGUgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJpCisrKyBiL1Rv b2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJpCkBAIC0yMiw2ICsyMiw3IEBA IEZFQVRVUkVfREVGQVVMVFMgPSBcCiAgICAgRU5BQkxFX0NTUF9ORVhUPTAgXAogICAgIEVOQUJM RV9DU1NfQk9YX0RFQ09SQVRJT05fQlJFQUs9MSBcCiAgICAgRU5BQkxFX0NTU19DT01QT1NJVElO Rz0xIFwKKyAgICBFTkFCTEVfQ1NTX0RFVklDRV9BREFQVEFUSU9OPTEgXAogICAgIEVOQUJMRV9D U1NfRVhDTFVTSU9OUz0xIFwKICAgICBFTkFCTEVfQ1NTX0ZJTFRFUlM9MSBcCiAgICAgRU5BQkxF X0NTU19HUklEX0xBWU9VVD0wIFwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlYmZiOGRkNTg3OWIwYzZiYTUyMzVhMTUyOTY5 ODI1ZGMwMDU5YmIxLi45ZWNkNzNkYmU3YTZlMWE3ODkzMjNmYTFkMDI4ZWU5NDg0NDg2ODBiIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTItMTEtMjYgIFRoaWFnbyBNYXJjb3MgUC4gU2FudG9z ICA8dGhpYWdvLnNhbnRvc0BpbnRlbC5jb20+CiAKKyAgICAgICAgW1F0XSBFbmFibGUgQ1NTIERl dmljZSBBZGFwdGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NTk2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFVuc2tpcCB0ZXN0cyB0aGF0IHdpbGwgbm93IHBhc3Mgb24gV0syLiBXZSBjYW5ub3Qg ZG8gdGhlIHNhbWUgZm9yCisgICAgICAgIFdlYktpdDEgYmVjYXVzZSBEUlQgZG9lc24ndCBzdXBw b3J0IGZpeGVkIGxheW91dC4KKworICAgICAgICAqIHBsYXRmb3JtL3F0LTQuOC9UZXN0RXhwZWN0 YXRpb25zOgorICAgICAgICAqIHBsYXRmb3JtL3F0LTUuMC13azEvVGVzdEV4cGVjdGF0aW9uczoK KyAgICAgICAgKiBwbGF0Zm9ybS9xdC01LjAtd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAgICAg ICogcGxhdGZvcm0vcXQvVGVzdEV4cGVjdGF0aW9uczoKKworMjAxMi0xMS0yNiAgVGhpYWdvIE1h cmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVsLmNvbT4KKwogICAgICAgICBJbXBv cnQgbW9yZSBDU1MgRGV2aWNlIEFkYXB0YXRpb24gbGF5b3V0IHRlc3RzCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTk2NwogCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC00LjgvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL3F0LTQuOC9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGUwYjI5NzU3Yzg2YzQ1Y2Ez YThiYmUxZWQ3YWVjNWExMWIxZWIzYTguLjU2OTdiZjk1M2M1ZTZlZDFjMGNmMTRhNWFlM2EzYTdl ZDc2ZjkxYTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTQuOC9UZXN0RXhw ZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTQuOC9UZXN0RXhwZWN0YXRp b25zCkBAIC02OTMsNiArNjkzLDkgQEAgd2Via2l0Lm9yZy9iLzYwMzMgY3NzMy9maWx0ZXJzL3Jl Z2lvbnMtZXhwYW5kaW5nLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIFBhc3MgXQogd2Via2l0Lm9y Zy9iLzYwMzMgY3NzMy9maWx0ZXJzL3NpbXBsZS1maWx0ZXItcmVuZGVyaW5nLmh0bWwgWyBJbWFn ZU9ubHlGYWlsdXJlIFBhc3MgXQogd2Via2l0Lm9yZy9iLzYwMzMgc3ZnL2ZpbHRlcnMvY29sb3It aW50ZXJwb2xhdGlvbi1maWx0ZXJzLnN2ZyBbIE1pc3NpbmcgUGFzcyBdCiAKKyMgRml4ZWQgbGF5 b3V0IG5vdCBzdXBwb3J0ZWQgYnkgRFJULgorY3NzMy9kZXZpY2UtYWRhcHQKKwogIyBDU1Mgc2hh ZGVycyBvbmx5IHdvcmsgaW4gcXQtd2syCiBjc3MzL2ZpbHRlcnMvY3VzdG9tCiAKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13azEvVGVzdEV4cGVjdGF0aW9ucyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13azEvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBkZDk3 N2Q1NmFlOTM4ZDM0MDU3NzgyY2IyOTZmYzQ5MzRkMzA5ZTQ2Li4yYTUxMWJhYWVjZDM5Nzk3ODA4 MDk1NDViOTJiMTNlNzBhYzJhNTFlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9x dC01LjAtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQt NS4wLXdrMS9UZXN0RXhwZWN0YXRpb25zCkBAIC0zMSw2ICszMSw5IEBAIGZhc3QvZG9tL1dpbmRv dy9tb3ppbGxhLWZvY3VzLWJsdXIuaHRtbAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzczODAKIGZhc3QvdXJsL3BhdGguaHRtbAogCisjIEZpeGVkIGxheW91dCBu b3Qgc3VwcG9ydGVkIGJ5IERSVC4KK2NzczMvZGV2aWNlLWFkYXB0CisKICMgW1F0XSBUZXN0cyBz dGlsbCBmYWlsIGFmdGVyIHRoZSB1cGRhdGUgdG8gbmV3IGZvbnRzCiAjIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTYxMAogY3NzMy9jYWxjL3RhYmxlLWNhbGNzLmh0 bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13azIvVGVzdEV4cGVj dGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13azIvVGVzdEV4cGVjdGF0aW9u cwppbmRleCA3MDdhMDY0ZThmNTAzZGQ2NzFkZDI2OWMyOGVkYjhmMjhjODNhZjFlLi5jYjNhN2Rj YWY3ZjdjZWVhMjk5Y2NmZTA1ZWY5ZTAzYTIyNzNiODNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC01LjAtd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQtNS4wLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC02NDAsNiArNjQwLDE3IEBA IHdlYmtpdC5vcmcvYi84NDg5MyBodHRwL3Rlc3RzL3czYy93ZWJwZXJmL3N1Ym1pc3Npb24vSW50 ZWwvdXNlci10aW1pbmcKICMgUmVzb3VyY2UgVGltaW5nIGlzIG5vdCBlbmFibGUgeWV0LCBza2lw IGl0Lgogd2Via2l0Lm9yZy9iLzYxMTM4IGh0dHAvdGVzdHMvdzNjL3dlYnBlcmYvc3VibWlzc2lv bi9JbnRlbC9yZXNvdXJjZS10aW1pbmcKIAorIyBXaW5kb3cgc2l6ZSBpcyBiZWluZyByZXBvcnRl ZCBhcyBzY3JlZW4gc2l6ZS4KK3dlYmtpdC5vcmcvYi8xMDMxMjcgY3NzMy9kZXZpY2UtYWRhcHQv b3BlcmEvY29uc3RyYWluLTAyMS54aHRtbCBbIEZhaWx1cmUgXQord2Via2l0Lm9yZy9iLzEwMzEy NyBjc3MzL2RldmljZS1hZGFwdC9vcGVyYS9jb25zdHJhaW4tMDIyLnhodG1sIFsgRmFpbHVyZSBd CisKKyMgSXNzdWUgd2l0aCB2aWV3cG9ydCB3aWR0aCBhbmQgcmVsYXRpdmUgdW5pdHMuCit3ZWJr aXQub3JnL2IvMTAyOTIyIGNzczMvZGV2aWNlLWFkYXB0L29wZXJhL2NvbnN0cmFpbi0wMDYueGh0 bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8xMDI5MjIgY3NzMy9kZXZpY2UtYWRhcHQvb3Bl cmEvY29uc3RyYWluLTAwNy54aHRtbCBbIEZhaWx1cmUgXQorCisjIFBhZ2UgY2xpZW50IGRvZXNu J3QgcmVhY3QgdG8gb3JpZW50YXRpb24gY2hhbmdlcyBmcm9tIENTUyBWaWV3cG9ydCBydWxlcy4K K2NzczMvZGV2aWNlLWFkYXB0L29wZXJhL29yaWVudGF0aW9uLTAwMS54aHRtbCBbIEZhaWx1cmUg XQorCiAjIFtRdF0gVW5pZGVudGlmaWVkIHBpeGVsIGZhaWx1cmVzCiB3ZWJraXQub3JnL2IvOTkz MDYgYW5pbWF0aW9ucy8zZC9zdGF0ZS1hdC1lbmQtZXZlbnQtdHJhbnNmb3JtLmh0bWwgWyBJbWFn ZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi85OTMwNiBhbmltYXRpb25zL2FkZGl0aXZlLXRy YW5zZm9ybS1hbmltYXRpb25zLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9xdC9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDk3MDg3NTM0ZjE1ODk1ZWZkMzczMmE3 MmIzOTM1NGFlMjg5MGFiN2MuLmQxYzcxNTBiNTU1NjM2N2U4NDYwMzVhY2FhMDdkNjk4MTYyZGEx YjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnMK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMjMyMCw5 ICsyMzIwLDYgQEAgd2Via2l0Lm9yZy9iLzIzMTY2IGlldGVzdGNlbnRlci9jc3MzL2JvcmRlcnNi YWNrZ3JvdW5kcy9ib3JkZXItcmFkaXVzLWNsaXAtMDAyLmgKICMgY3NzMy1jb25kaXRpb25hbHMg c3VwcG9ydCBpcyBub3QgeWV0IGVuYWJsZWQuCiB3ZWJraXQub3JnL2IvODYxNDYgY3NzMy9zdXBw b3J0cy5odG1sCiAKLSMgQ1NTIERldmljZSBBZGFwdGF0aW9uIGlzIG5vdCBlbmFibGVkLgotd2Vi a2l0Lm9yZy9iLzk1OTY5IGNzczMvZGV2aWNlLWFkYXB0IFsgU2tpcCBdCi0KICMgQWRkZWQgYnkg YnVnIDg5ODI2CiB3ZWJraXQub3JnL2IvOTQwMDUgY3NzMi4xLzIwMTEwMzIzL3dvcmQtc3BhY2lu Zy1yZW1vdmUtc3BhY2UtMDAzLmh0bSBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9i Lzk0MDA1IGNzczIuMS8yMDExMDMyMy93b3JkLXNwYWNpbmctcmVtb3ZlLXNwYWNlLTAwNi5odG0g WyBJbWFnZU9ubHlGYWlsdXJlIF0K