95948 2012-09-06 01:17:43 -0700 [BlackBerry] Always log shader compilation failure 2012-09-06 06:41:00 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson anilsson fspacek mifenton staikos tonikitoo webkit.review.bot oldest_to_newest 713009 0 anilsson 2012-09-06 01:17:43 -0700 Also add the shader source to the logs. This makes it easier for other teams to verify new graphics drivers. 713068 1 162455 anilsson 2012-09-06 02:26:20 -0700 Created attachment 162455 Patch 713252 2 162455 webkit.review.bot 2012-09-06 06:40:57 -0700 Comment on attachment 162455 Patch Clearing flags on attachment: 162455 Committed r127736: <http://trac.webkit.org/changeset/127736> 713253 3 webkit.review.bot 2012-09-06 06:41:00 -0700 All reviewed patches have been landed. Closing bug. 162455 2012-09-06 02:26:20 -0700 2012-09-06 06:40:57 -0700 Patch bug-95948-20120906112600.patch text/plain 4469 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTA1NjJjOTYwNTcyYzVh MWUxM2NlOTQ3MzdmZGQ1ZGRmNjIwMzMwYy4uNWNhNWFiNjE2MmU5NjYzNmJlZWQwNzA5MTMxNWZl YWExOGI5YjY3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTA2ICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQWx3 YXlzIGxvZyBzaGFkZXIgY29tcGlsYXRpb24gZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU5NDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHNvIGFkZCBzaGFkZXIgc291cmNlIHRvIHRoZSBs b2dzLiBJbiBhZGRpdGlvbiwgZG9uJ3QgYmFpbCBvbiB0aGUKKyAgICAgICAgZmlyc3QgZmFpbHVy ZSwgcnVuIHRocm91Z2ggYWxsIHNoYWRlcnMgc28gd2UgZ2V0IGEgY29tcGxldGUgc2V0IG9mCisg ICAgICAgIGxvZ3MuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOiBubyBjaGFuZ2UgaW4gZnVuY3Rp b25hbGl0eS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJS ZW5kZXJlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXllclJlbmRlcmVyOjpsb2FkU2hhZGVy KToKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyUmVuZGVyZXI6OmluaXRpYWxpemVTaGFyZWRHTE9i amVjdHMpOgorCiAyMDEyLTA4LTI5ICBKb3NodWEgTmV0dGVyZmllbGQgIDxqbmV0dGVyZmllbGRA cmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gRW5hYmxlIENTUyBTaGFkZXJzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVy UmVuZGVyZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJy eS9MYXllclJlbmRlcmVyLmNwcAppbmRleCA4OTdjM2Q0YjcxZTAzNTk5ZGZlZWE5NjE5ZmYzOTVm M2JkNThlN2FhLi44MWFlYmE0YzQ0OGQ0NmQ4YTQxMjE4YzkyZWQ3MzA0OTBlMWNiZDdmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVy UmVuZGVyZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNr YmVycnkvTGF5ZXJSZW5kZXJlci5jcHAKQEAgLTQ5LDcgKzQ5LDYgQEAKIAogI2RlZmluZSBFTkFC TEVfU0NJU1NPUiAxCiAKLSNkZWZpbmUgREVCVUdfU0hBREVSX0NPTVBJTEFUSU9OIDAKICNkZWZp bmUgREVCVUdfTEFZRVJfQU5JTUFUSU9OUyAwIC8vIFNob3cgcnVubmluZyBhbmltYXRpb25zIGFz IGdyZWVuLgogI2RlZmluZSBERUJVR19DTElQUElORyAwCiAKQEAgLTc2LDEyICs3NSwxMCBAQCBH THVpbnQgTGF5ZXJSZW5kZXJlcjo6bG9hZFNoYWRlcihHTGVudW0gdHlwZSwgY29uc3QgY2hhciog c2hhZGVyU291cmNlKQogICAgIEdMaW50IGNvbXBpbGVkOwogICAgIGdsR2V0U2hhZGVyaXYoc2hh ZGVyLCBHTF9DT01QSUxFX1NUQVRVUywgJmNvbXBpbGVkKTsKICAgICBpZiAoIWNvbXBpbGVkKSB7 Ci0jaWYgREVCVUdfU0hBREVSX0NPTVBJTEFUSU9OCiAgICAgICAgIGNoYXIgaW5mb0xvZ1syMDQ4 XTsKICAgICAgICAgR0xzaXplaSBsZW5ndGg7CiAgICAgICAgIGdsR2V0U2hhZGVySW5mb0xvZyhz aGFkZXIsIDIwNDgsICZsZW5ndGgsIGluZm9Mb2cpOwotICAgICAgICBmcHJpbnRmKHN0ZGVyciwg IkZhaWxlZCB0byBjb21waWxlIHNoYWRlcjogJXMiLCBpbmZvTG9nKTsKLSNlbmRpZgorICAgICAg ICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6bG9nQWx3YXlzKEJsYWNrQmVycnk6OlBsYXRmb3JtOjpM b2dMZXZlbENyaXRpY2FsLCAiRmFpbGVkIHRvIGNvbXBpbGUgc2hhZGVyOlxuJXNcbmxvZzogJXMi LCBzaGFkZXJTb3VyY2UsIGluZm9Mb2cpOwogICAgICAgICBnbERlbGV0ZVNoYWRlcihzaGFkZXIp OwogICAgICAgICByZXR1cm4gMDsKICAgICB9CkBAIC0xMTQzLDQzICsxMTQwLDMxIEBAIGJvb2wg TGF5ZXJSZW5kZXJlcjo6aW5pdGlhbGl6ZVNoYXJlZEdMT2JqZWN0cygpCiAKICAgICBtX2xheWVy UHJvZ3JhbU9iamVjdFtMYXllckRhdGE6OkxheWVyUHJvZ3JhbVNoYWRlclJHQkFdID0KICAgICAg ICAgbG9hZFNoYWRlclByb2dyYW0odmVydGV4U2hhZGVyU3RyaW5nLCBmcmFnbWVudFNoYWRlclN0 cmluZ1JHQkEpOwotICAgIGlmICghbV9sYXllclByb2dyYW1PYmplY3RbTGF5ZXJEYXRhOjpMYXll clByb2dyYW1TaGFkZXJSR0JBXSkgeworICAgIGlmICghbV9sYXllclByb2dyYW1PYmplY3RbTGF5 ZXJEYXRhOjpMYXllclByb2dyYW1TaGFkZXJSR0JBXSkKICAgICAgICAgTE9HX0VSUk9SKCJGYWls ZWQgdG8gY3JlYXRlIHNoYWRlciBwcm9ncmFtIGZvciBSR0JBIGxheWVycyIpOwotICAgICAgICBy ZXR1cm4gZmFsc2U7Ci0gICAgfQogCiAgICAgbV9sYXllclByb2dyYW1PYmplY3RbTGF5ZXJEYXRh OjpMYXllclByb2dyYW1TaGFkZXJCR1JBXSA9CiAgICAgICAgIGxvYWRTaGFkZXJQcm9ncmFtKHZl cnRleFNoYWRlclN0cmluZywgZnJhZ21lbnRTaGFkZXJTdHJpbmdCR1JBKTsKLSAgICBpZiAoIW1f bGF5ZXJQcm9ncmFtT2JqZWN0W0xheWVyRGF0YTo6TGF5ZXJQcm9ncmFtU2hhZGVyQkdSQV0pIHsK KyAgICBpZiAoIW1fbGF5ZXJQcm9ncmFtT2JqZWN0W0xheWVyRGF0YTo6TGF5ZXJQcm9ncmFtU2hh ZGVyQkdSQV0pCiAgICAgICAgIExPR19FUlJPUigiRmFpbGVkIHRvIGNyZWF0ZSBzaGFkZXIgcHJv Z3JhbSBmb3IgQkdSQSBsYXllcnMiKTsKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KIAog ICAgIG1fbGF5ZXJNYXNrUHJvZ3JhbU9iamVjdFtMYXllckRhdGE6OkxheWVyUHJvZ3JhbVNoYWRl clJHQkFdID0KICAgICAgICAgbG9hZFNoYWRlclByb2dyYW0odmVydGV4U2hhZGVyU3RyaW5nLCBm cmFnbWVudFNoYWRlclN0cmluZ01hc2tSR0JBKTsKLSAgICBpZiAoIW1fbGF5ZXJNYXNrUHJvZ3Jh bU9iamVjdFtMYXllckRhdGE6OkxheWVyUHJvZ3JhbVNoYWRlclJHQkFdKSB7CisgICAgaWYgKCFt X2xheWVyTWFza1Byb2dyYW1PYmplY3RbTGF5ZXJEYXRhOjpMYXllclByb2dyYW1TaGFkZXJSR0JB XSkKICAgICAgICAgTE9HX0VSUk9SKCJGYWlsZWQgdG8gY3JlYXRlIHNoYWRlciBtYXNrIHByb2dy YW0gZm9yIFJHQkEgbGF5ZXJzIik7Ci0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9CiAKICAg ICBtX2xheWVyTWFza1Byb2dyYW1PYmplY3RbTGF5ZXJEYXRhOjpMYXllclByb2dyYW1TaGFkZXJC R1JBXSA9CiAgICAgICAgIGxvYWRTaGFkZXJQcm9ncmFtKHZlcnRleFNoYWRlclN0cmluZywgZnJh Z21lbnRTaGFkZXJTdHJpbmdNYXNrQkdSQSk7Ci0gICAgaWYgKCFtX2xheWVyTWFza1Byb2dyYW1P YmplY3RbTGF5ZXJEYXRhOjpMYXllclByb2dyYW1TaGFkZXJCR1JBXSkgeworICAgIGlmICghbV9s YXllck1hc2tQcm9ncmFtT2JqZWN0W0xheWVyRGF0YTo6TGF5ZXJQcm9ncmFtU2hhZGVyQkdSQV0p CiAgICAgICAgIExPR19FUlJPUigiRmFpbGVkIHRvIGNyZWF0ZSBzaGFkZXIgbWFzayBwcm9ncmFt IGZvciBCR1JBIGxheWVycyIpOwotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgfQogCiAgICAg bV9jb2xvclByb2dyYW1PYmplY3QgPSBsb2FkU2hhZGVyUHJvZ3JhbShjb2xvclZlcnRleFNoYWRl clN0cmluZywgY29sb3JGcmFnbWVudFNoYWRlclN0cmluZyk7Ci0gICAgaWYgKCFtX2NvbG9yUHJv Z3JhbU9iamVjdCkgeworICAgIGlmICghbV9jb2xvclByb2dyYW1PYmplY3QpCiAgICAgICAgIExP R19FUlJPUigiRmFpbGVkIHRvIGNyZWF0ZSBzaGFkZXIgcHJvZ3JhbSBmb3IgZGVidWcgYm9yZGVy cyIpOwotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgfQogCiAgICAgbV9jaGVja2VyUHJvZ3Jh bU9iamVjdCA9IGxvYWRTaGFkZXJQcm9ncmFtKGNvbG9yVmVydGV4U2hhZGVyU3RyaW5nLCBjaGVj a2VyRnJhZ21lbnRTaGFkZXJTdHJpbmcuZGF0YSgpKTsKLSAgICBpZiAoIW1fY2hlY2tlclByb2dy YW1PYmplY3QpIHsKKyAgICBpZiAoIW1fY2hlY2tlclByb2dyYW1PYmplY3QpCiAgICAgICAgIExP R19FUlJPUigiRmFpbGVkIHRvIGNyZWF0ZSBzaGFkZXIgcHJvZ3JhbSBmb3IgY2hlY2tlcmJvYXJk IHBhdHRlcm4iKTsKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KIAogICAgIC8vIFNwZWNp ZnkgdGhlIGF0dHJpYiBsb2NhdGlvbiBmb3IgdGhlIHBvc2l0aW9uIGFuZCBtYWtlIGl0IHRoZSBz YW1lIGZvciBhbGwgcHJvZ3JhbXMgdG8KICAgICAvLyBhdm9pZCBiaW5kaW5nIHJlLWJpbmRpbmcg dGhlIHZlcnRleCBhdHRyaWJ1dGVzLgo=