95918 2012-09-05 17:42:59 -0700 ASM llint should not use the JIT when the useJIT() option is false 2012-09-06 03:12:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam webkit-unassigned fpizlo ggaren webkit.review.bot oldest_to_newest 712708 0 mark.lam 2012-09-05 17:42:59 -0700 r127554 (https://bugs.webkit.org/show_bug.cgi?id=95809) caused a regression where the ASM llint will still the JIT when the useJIT() option is false, but only when useRegExpJIT() (previously useYarrJIT() is true). Alsop renamed useYarrJIT() to useRegExpJIT(). 712713 1 162382 mark.lam 2012-09-05 17:48:25 -0700 Created attachment 162382 Fix. 712832 2 162382 ggaren 2012-09-05 20:57:33 -0700 Comment on attachment 162382 Fix. r=me 713113 3 162382 webkit.review.bot 2012-09-06 03:12:50 -0700 Comment on attachment 162382 Fix. Clearing flags on attachment: 162382 Committed r127719: <http://trac.webkit.org/changeset/127719> 713114 4 webkit.review.bot 2012-09-06 03:12:53 -0700 All reviewed patches have been landed. Closing bug. 162382 2012-09-05 17:48:25 -0700 2012-09-06 03:12:50 -0700 Fix. bug-95918.patch text/plain 4379 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI3NjY0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDEyLTA5LTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW5hbWVkIHVzZVlhcnJKSVQoKSBvcHRpb24gdG8gdXNlUmVnRXhwSklUKCkuIEFsc28gZml4ZWQg cmVncmVzc2lvbiBpbgorICAgICAgICB3aGljaCBpbmFkdmVydGFudGx5IGFsbG93cyB0aGUgQVNN IGxsaW50IHRvIHVzZSB0aGUgYmFzZWxpbmUgSklUIHdoZW4KKyAgICAgICAgdXNlUmVnRXhwSklU KCkgaXMgdHJ1ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk1OTE4LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcnVudGltZS9KU0dsb2JhbERhdGEuY3BwOgorICAgICAgICAoSlNDOjplbmFibGVBc3Nl bWJsZXIpOgorICAgICAgICAoSlNDOjpKU0dsb2JhbERhdGE6OkpTR2xvYmFsRGF0YSk6CisgICAg ICAgICogcnVudGltZS9KU0dsb2JhbERhdGEuaDoKKyAgICAgICAgKEpTQzo6SlNHbG9iYWxEYXRh OjpjYW5Vc2VKSVQpOgorICAgICAgICAoSlNDOjpKU0dsb2JhbERhdGE6OmNhblVzZVJlZ0V4cEpJ VCk6CisgICAgICAgIChKU0dsb2JhbERhdGEpOgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5j cHA6CisgICAgICAgIChKU0M6Ok9wdGlvbnM6OmluaXRpYWxpemUpOgorICAgICAgICAqIHJ1bnRp bWUvT3B0aW9ucy5oOgorICAgICAgICAoSlNDKToKKwogMjAxMi0wOS0wNSAgR2F2aW4gQmFycmFj bG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgTWVyZ2UgcHJlZml4L3Bv c3RmaXggbm9kZXMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFs RGF0YS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNH bG9iYWxEYXRhLmNwcAkocmV2aXNpb24gMTI3NjY0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNHbG9iYWxEYXRhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAwLDcgKzEwMCw3 IEBAIGV4dGVybiBjb25zdCBIYXNoVGFibGUgc3RyaW5nQ29uc3RydWN0b3IKICNpZiBFTkFCTEUo QVNTRU1CTEVSKSAmJiAoRU5BQkxFKENMQVNTSUNfSU5URVJQUkVURVIpIHx8IEVOQUJMRShMTElO VCkpCiBzdGF0aWMgYm9vbCBlbmFibGVBc3NlbWJsZXIoRXhlY3V0YWJsZUFsbG9jYXRvciYgZXhl Y3V0YWJsZUFsbG9jYXRvcikKIHsKLSAgICBpZiAoIWV4ZWN1dGFibGVBbGxvY2F0b3IuaXNWYWxp ZCgpIHx8ICghT3B0aW9uczo6dXNlSklUKCkgJiYgIU9wdGlvbnM6OnVzZVlhcnJKSVQoKSkpCisg ICAgaWYgKCFleGVjdXRhYmxlQWxsb2NhdG9yLmlzVmFsaWQoKSB8fCAoIU9wdGlvbnM6OnVzZUpJ VCgpICYmICFPcHRpb25zOjp1c2VSZWdFeHBKSVQoKSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK IAogI2lmIFVTRShDRikKQEAgLTE4Miw2ICsxODIsOCBAQCBKU0dsb2JhbERhdGE6OkpTR2xvYmFs RGF0YShHbG9iYWxEYXRhVHlwCiAgICAgLCBtX25ld1N0cmluZ3NTaW5jZUxhc3RIYXNoQ29uc3Qo MCkKICNpZiBFTkFCTEUoQVNTRU1CTEVSKSAmJiAoRU5BQkxFKENMQVNTSUNfSU5URVJQUkVURVIp IHx8IEVOQUJMRShMTElOVCkpCiAgICAgLCBtX2NhblVzZUFzc2VtYmxlcihlbmFibGVBc3NlbWJs ZXIoZXhlY3V0YWJsZUFsbG9jYXRvcikpCisgICAgLCBtX2NhblVzZUpJVChtX2NhblVzZUFzc2Vt YmxlciAmJiBPcHRpb25zOjp1c2VKSVQoKSkKKyAgICAsIG1fY2FuVXNlUmVnRXhwSklUKG1fY2Fu VXNlQXNzZW1ibGVyICYmIE9wdGlvbnM6OnVzZVJlZ0V4cEpJVCgpKQogI2VuZGlmCiAjaWYgRU5B QkxFKEdDX1ZBTElEQVRJT04pCiAgICAgLCBtX2luaXRpYWxpemluZ09iamVjdENsYXNzKDApCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbERhdGEuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbERhdGEuaAkocmV2 aXNpb24gMTI3NjY0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxE YXRhLmgJKHdvcmtpbmcgY29weSkKQEAgLTI4NCw3ICsyODQsNyBAQCBuYW1lc3BhY2UgSlNDIHsK ICNlbGlmICFFTkFCTEUoQ0xBU1NJQ19JTlRFUlBSRVRFUikgJiYgIUVOQUJMRShMTElOVCkKICAg ICAgICAgYm9vbCBjYW5Vc2VKSVQoKSB7IHJldHVybiB0cnVlOyB9IC8vIGppdCBvbmx5CiAjZWxz ZQotICAgICAgICBib29sIGNhblVzZUpJVCgpIHsgcmV0dXJuIG1fY2FuVXNlQXNzZW1ibGVyOyB9 CisgICAgICAgIGJvb2wgY2FuVXNlSklUKCkgeyByZXR1cm4gbV9jYW5Vc2VKSVQ7IH0KICNlbmRp ZgogCiAjaWYgIUVOQUJMRShZQVJSX0pJVCkKQEAgLTI5Miw3ICsyOTIsNyBAQCBuYW1lc3BhY2Ug SlNDIHsKICNlbGlmICFFTkFCTEUoQ0xBU1NJQ19JTlRFUlBSRVRFUikgJiYgIUVOQUJMRShMTElO VCkKICAgICAgICAgYm9vbCBjYW5Vc2VSZWdFeHBKSVQoKSB7IHJldHVybiB0cnVlOyB9IC8vIGpp dCBvbmx5CiAjZWxzZQotICAgICAgICBib29sIGNhblVzZVJlZ0V4cEpJVCgpIHsgcmV0dXJuIG1f Y2FuVXNlQXNzZW1ibGVyOyB9CisgICAgICAgIGJvb2wgY2FuVXNlUmVnRXhwSklUKCkgeyByZXR1 cm4gbV9jYW5Vc2VSZWdFeHBKSVQ7IH0KICNlbmRpZgogCiAgICAgICAgIFByaXZhdGVOYW1lIG1f aW5oZXJpdG9ySURLZXk7CkBAIC00NDEsNiArNDQxLDggQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAg ICAgIHZvaWQgY3JlYXRlTmF0aXZlVGh1bmsoKTsKICNpZiBFTkFCTEUoQVNTRU1CTEVSKSAmJiAo RU5BQkxFKENMQVNTSUNfSU5URVJQUkVURVIpIHx8IEVOQUJMRShMTElOVCkpCiAgICAgICAgIGJv b2wgbV9jYW5Vc2VBc3NlbWJsZXI7CisgICAgICAgIGJvb2wgbV9jYW5Vc2VKSVQ7CisgICAgICAg IGJvb2wgbV9jYW5Vc2VSZWdFeHBKSVQ7CiAjZW5kaWYKICNpZiBFTkFCTEUoR0NfVkFMSURBVElP TikKICAgICAgICAgY29uc3QgQ2xhc3NJbmZvKiBtX2luaXRpYWxpemluZ09iamVjdENsYXNzOwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAJKHJldmlzaW9u IDEyNzY2NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xNDMsNyArMTQzLDcgQEAgdm9pZCBPcHRpb25zOjppbml0aWFsaXpl KCkKICAgICB1c2VERkdKSVQoKSA9IGZhbHNlOwogI2VuZGlmCiAjaWYgIUVOQUJMRShZQVJSX0pJ VCkKLSAgICB1c2VZYXJySklUKCkgPSBmYWxzZTsKKyAgICB1c2VSZWdFeHBKSVQoKSA9IGZhbHNl OwogI2VuZGlmCiAKICAgICAvLyBEbyByYW5nZSBjaGVja3Mgd2hlcmUgbmVlZGVkIGFuZCBtYWtl IGNvcnJlY3Rpb25zIHRvIHRoZSBvcHRpb25zOgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvT3B0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL09wdGlvbnMuaAkocmV2aXNpb24gMTI3NjY0KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvT3B0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC02NSw3ICs2NSw3IEBAIG5h bWVzcGFjZSBKU0MgewogI2RlZmluZSBKU0NfT1BUSU9OUyh2KSBcCiAgICAgdihib29sLCB1c2VK SVQsICAgIHRydWUpIFwKICAgICB2KGJvb2wsIHVzZURGR0pJVCwgdHJ1ZSkgXAotICAgIHYoYm9v bCwgdXNlWWFyckpJVCwgdHJ1ZSkgXAorICAgIHYoYm9vbCwgdXNlUmVnRXhwSklULCB0cnVlKSBc CiAgICAgXAogICAgIC8qIHNob3dEaXNhc3NlbWJseSBpbXBsaWVzIHNob3dERkdEaXNhc3NlbWJs eS4gKi8gXAogICAgIHYoYm9vbCwgc2hvd0Rpc2Fzc2VtYmx5LCBmYWxzZSkgXAo=