95908 2012-09-05 16:29:44 -0700 Build failure with css filters enabled and accelerated compositing disabled 2012-10-03 15:28:56 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 a.renevier a.renevier achicu eric webkit.review.bot oldest_to_newest 712654 0 a.renevier 2012-09-05 16:29:44 -0700 Hi, when trying to build webkit with: build-webkit --gtk --css-filters --disable-accelerated-compositing I get following error: ../../Source/WebCore/rendering/RenderLayer.cpp: In member function ‘void WebCore::RenderLayer::styleChanged(WebCore::StyleDifference, const WebCore::RenderStyle*)’: ../../Source/WebCore/rendering/RenderLayer.cpp:4979:64: error: ‘backing’ was not declared in this scope ../../Source/WebCore/rendering/RenderLayer.cpp:5006:32: error: ‘setBackingNeedsRepaint’ was not declared in this scope 712656 1 162365 a.renevier 2012-09-05 16:33:03 -0700 Created attachment 162365 patch proposal 712660 2 a.renevier 2012-09-05 16:34:30 -0700 Ccing achicu as he has worked on css filters. 712679 3 achicu 2012-09-05 16:53:44 -0700 Looks good to me. I think isComposited() is defined in both cases, so maybe the code could look like this instead: bool RenderLayer::paintsWithFilters() const { // FIXME: Eventually there will be more factors than isComposited() to decide whether or not to render the filter if (!renderer()->hasFilter()) return false; if (!isComposited()) return true; #if USE(ACCELERATED_COMPOSITING) if (!m_backing || !m_backing->canCompositeFilters()) return true; #endif return false; } 712698 4 162376 a.renevier 2012-09-05 17:23:56 -0700 Created attachment 162376 updated patch 732177 5 166583 a.renevier 2012-10-01 18:07:26 -0700 Created attachment 166583 Patch updated patch: remove a pointless change 732737 6 166583 tony 2012-10-02 09:46:59 -0700 Comment on attachment 166583 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166583&action=review > Source/WebCore/rendering/RenderLayer.cpp:4887 > +#if ENABLE(CSS_FILTERS) && USE(ACCELERATED_COMPOSITING) > bool backingDidCompositeLayers = isComposited() && backing()->canCompositeFilters(); > #endif Can we move |backingDidCompositeLayers| down to the line before it is used? 733951 7 166944 a.renevier 2012-10-03 12:50:37 -0700 Created attachment 166944 Patch updated patch to addresse reviewer comment 734090 8 166944 webkit.review.bot 2012-10-03 15:28:53 -0700 Comment on attachment 166944 Patch Clearing flags on attachment: 166944 Committed r130331: <http://trac.webkit.org/changeset/130331> 734091 9 webkit.review.bot 2012-10-03 15:28:56 -0700 All reviewed patches have been landed. Closing bug. 162365 2012-09-05 16:33:03 -0700 2012-09-05 17:23:54 -0700 patch proposal bug-95908-20120905163242.patch text/plain 2616 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Y3Yjc5YjEwZmZmMWI2 NGZiOTAzMjJhMTNiM2ZjYjFkNWJmM2I3YS4uOWZhODE0MTg4NDc3YTQyNDFjNmIxYzdmOTRkNDgy OGUwNjVkMjE3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEyLTA5LTA1ICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgQnVp bGQgZmFpbHVyZSB3aXRoIGNzcyBmaWx0ZXJzIGVuYWJsZWQgYW5kIGFjY2VsZXJhdGVkIGNvbXBv c2l0aW5nIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NTkwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIERvIG5vdCB0cnkgdG8gc2V0QmFja2luZ05lZWRzUmVwYWludCB3aGVuIGJ1aWxkaW5n IHdpdGhvdXQgYWNjZWxlcmF0ZWQKKyAgICAgICAgY29tcG9zaXRpbmcuCisKKyAgICAgICAgQWxz bywgYWxsb3cgcGFpbnRpbmcgd2l0aCBmaWx0ZXIgKHBhaW50c1dpdGhGaWx0ZXJzIHJldHVybnMg dHJ1ZSBpZgorICAgICAgICByZW5kZXJlciBoYXMgZmlsdGVyKSB3aGVuIGFjY2VsZXJhdGVkIGNv bXBvc2l0aW5nIGlzIG5vdCBlbmFibGVkLgorCisgICAgICAgIE5vIGZ1bmN0aW9uYWwgY2hhbmdl LCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnBhaW50c1dpdGhGaWx0ZXJzKToKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpzdHlsZUNoYW5nZWQpOgorCisyMDEyLTA5LTA1 ICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKICAgICAg ICAgQnVpbGQgZmFpbHVyZSB3aXRoIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGRpc2FibGVkCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTg3MgogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCAwZDQ2MWRiM2RiNDIz YjQ3MmRkZjUyZWFkZDZhMjgzYzhkNTQzMjY5Li40ODM2MWQ5ZGI3MmY3N2QzMGFmMjdhOTQ1MzM5 MGVmOThlNTBmMGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAK QEAgLTI5MSw5ICsyOTEsMTEgQEAgYm9vbCBSZW5kZXJMYXllcjo6cGFpbnRzV2l0aEZpbHRlcnMo KSBjb25zdAogCiAgICAgaWYgKCFtX2JhY2tpbmcgfHwgIW1fYmFja2luZy0+Y2FuQ29tcG9zaXRl RmlsdGVycygpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKLSNlbmRpZgogCiAgICAgcmV0dXJuIGZh bHNlOworI2Vsc2UKKyAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgogfQogICAgIAogYm9vbCBSZW5k ZXJMYXllcjo6cmVxdWlyZXNGdWxsTGF5ZXJJbWFnZUZvckZpbHRlcnMoKSBjb25zdCAKQEAgLTQ5 NzUsNyArNDk3Nyw3IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnN0eWxlQ2hhbmdlZChTdHlsZURpZmZl cmVuY2UsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdHlsZSkKICAgICB1cGRhdGVTY3JvbGxDb3Ju ZXJTdHlsZSgpOwogICAgIHVwZGF0ZVJlc2l6ZXJTdHlsZSgpOwogCi0jaWYgRU5BQkxFKENTU19G SUxURVJTKQorI2lmIEVOQUJMRShDU1NfRklMVEVSUykgJiYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBP U0lUSU5HKQogICAgIGJvb2wgYmFja2luZ0RpZENvbXBvc2l0ZUxheWVycyA9IGlzQ29tcG9zaXRl ZCgpICYmIGJhY2tpbmcoKS0+Y2FuQ29tcG9zaXRlRmlsdGVycygpOwogI2VuZGlmCiAKQEAgLTUw MDAsMTIgKzUwMDIsMTQgQEAgdm9pZCBSZW5kZXJMYXllcjo6c3R5bGVDaGFuZ2VkKFN0eWxlRGlm ZmVyZW5jZSwgY29uc3QgUmVuZGVyU3R5bGUqIG9sZFN0eWxlKQogCiAjaWYgRU5BQkxFKENTU19G SUxURVJTKQogICAgIHVwZGF0ZU9yUmVtb3ZlRmlsdGVyRWZmZWN0KCk7CisjaWYgVVNFKEFDQ0VM RVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIGlmIChpc0NvbXBvc2l0ZWQoKSAmJiBiYWNraW5nRGlk Q29tcG9zaXRlTGF5ZXJzICYmICFiYWNraW5nKCktPmNhbkNvbXBvc2l0ZUZpbHRlcnMoKSkgewog ICAgICAgICAvLyBUaGUgZmlsdGVycyB1c2VkIHRvIGJlIGRyYXduIGJ5IHBsYXRmb3JtIGNvZGUs IGJ1dCBub3cgdGhlIHBsYXRmb3JtIGNhbm5vdCBkcmF3IHRoZW0gYW55bW9yZS4KICAgICAgICAg Ly8gRmFsbGJhY2sgdG8gZHJhd2luZyB0aGVtIGluIHNvZnR3YXJlLgogICAgICAgICBzZXRCYWNr aW5nTmVlZHNSZXBhaW50KCk7CiAgICAgfQogI2VuZGlmCisjZW5kaWYKIH0KIAogdm9pZCBSZW5k ZXJMYXllcjo6dXBkYXRlU2Nyb2xsYWJsZUFyZWFTZXQoYm9vbCBoYXNPdmVyZmxvdykK 162376 2012-09-05 17:23:56 -0700 2012-10-01 18:07:24 -0700 updated patch bug-95908-20120905172335.patch text/plain 2677 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Y3Yjc5YjEwZmZmMWI2 NGZiOTAzMjJhMTNiM2ZjYjFkNWJmM2I3YS4uOWZhODE0MTg4NDc3YTQyNDFjNmIxYzdmOTRkNDgy OGUwNjVkMjE3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEyLTA5LTA1ICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgQnVp bGQgZmFpbHVyZSB3aXRoIGNzcyBmaWx0ZXJzIGVuYWJsZWQgYW5kIGFjY2VsZXJhdGVkIGNvbXBv c2l0aW5nIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NTkwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIERvIG5vdCB0cnkgdG8gc2V0QmFja2luZ05lZWRzUmVwYWludCB3aGVuIGJ1aWxkaW5n IHdpdGhvdXQgYWNjZWxlcmF0ZWQKKyAgICAgICAgY29tcG9zaXRpbmcuCisKKyAgICAgICAgQWxz bywgYWxsb3cgcGFpbnRpbmcgd2l0aCBmaWx0ZXIgKHBhaW50c1dpdGhGaWx0ZXJzIHJldHVybnMg dHJ1ZSBpZgorICAgICAgICByZW5kZXJlciBoYXMgZmlsdGVyKSB3aGVuIGFjY2VsZXJhdGVkIGNv bXBvc2l0aW5nIGlzIG5vdCBlbmFibGVkLgorCisgICAgICAgIE5vIGZ1bmN0aW9uYWwgY2hhbmdl LCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnBhaW50c1dpdGhGaWx0ZXJzKToKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpzdHlsZUNoYW5nZWQpOgorCisyMDEyLTA5LTA1 ICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKICAgICAg ICAgQnVpbGQgZmFpbHVyZSB3aXRoIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGRpc2FibGVkCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTg3MgogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCAwZDQ2MWRiM2RiNDIz YjQ3MmRkZjUyZWFkZDZhMjgzYzhkNTQzMjY5Li41NTVhN2Y5YTljMTBlN2I5ZjdhOGVjODZjMGU5 OWFjZDgxN2M5ZTE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAK QEAgLTI4NSwxMCArMjg1LDEwIEBAIGJvb2wgUmVuZGVyTGF5ZXI6OnBhaW50c1dpdGhGaWx0ZXJz KCkgY29uc3QKICAgICBpZiAoIXJlbmRlcmVyKCktPmhhc0ZpbHRlcigpKQogICAgICAgICByZXR1 cm4gZmFsc2U7CiAgICAgICAgIAotI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAg ICBpZiAoIWlzQ29tcG9zaXRlZCgpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAorI2lmIFVTRShB Q0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICBpZiAoIW1fYmFja2luZyB8fCAhbV9iYWNraW5n LT5jYW5Db21wb3NpdGVGaWx0ZXJzKCkpCiAgICAgICAgIHJldHVybiB0cnVlOwogI2VuZGlmCkBA IC00OTc1LDcgKzQ5NzUsNyBAQCB2b2lkIFJlbmRlckxheWVyOjpzdHlsZUNoYW5nZWQoU3R5bGVE aWZmZXJlbmNlLCBjb25zdCBSZW5kZXJTdHlsZSogb2xkU3R5bGUpCiAgICAgdXBkYXRlU2Nyb2xs Q29ybmVyU3R5bGUoKTsKICAgICB1cGRhdGVSZXNpemVyU3R5bGUoKTsKIAotI2lmIEVOQUJMRShD U1NfRklMVEVSUykKKyNpZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpICYmIFVTRShBQ0NFTEVSQVRFRF9D T01QT1NJVElORykKICAgICBib29sIGJhY2tpbmdEaWRDb21wb3NpdGVMYXllcnMgPSBpc0NvbXBv c2l0ZWQoKSAmJiBiYWNraW5nKCktPmNhbkNvbXBvc2l0ZUZpbHRlcnMoKTsKICNlbmRpZgogCkBA IC01MDAwLDEyICs1MDAwLDE0IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnN0eWxlQ2hhbmdlZChTdHls ZURpZmZlcmVuY2UsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdHlsZSkKIAogI2lmIEVOQUJMRShD U1NfRklMVEVSUykKICAgICB1cGRhdGVPclJlbW92ZUZpbHRlckVmZmVjdCgpOworI2lmIFVTRShB Q0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICBpZiAoaXNDb21wb3NpdGVkKCkgJiYgYmFja2lu Z0RpZENvbXBvc2l0ZUxheWVycyAmJiAhYmFja2luZygpLT5jYW5Db21wb3NpdGVGaWx0ZXJzKCkp IHsKICAgICAgICAgLy8gVGhlIGZpbHRlcnMgdXNlZCB0byBiZSBkcmF3biBieSBwbGF0Zm9ybSBj b2RlLCBidXQgbm93IHRoZSBwbGF0Zm9ybSBjYW5ub3QgZHJhdyB0aGVtIGFueW1vcmUuCiAgICAg ICAgIC8vIEZhbGxiYWNrIHRvIGRyYXdpbmcgdGhlbSBpbiBzb2Z0d2FyZS4KICAgICAgICAgc2V0 QmFja2luZ05lZWRzUmVwYWludCgpOwogICAgIH0KICNlbmRpZgorI2VuZGlmCiB9CiAKIHZvaWQg UmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbGFibGVBcmVhU2V0KGJvb2wgaGFzT3ZlcmZsb3cpCg== 166583 2012-10-01 18:07:26 -0700 2012-10-03 12:50:33 -0700 Patch bug-95908-20121001180636.patch text/plain 2281 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTk2YTljYzIyNWI2NmUw OWI5YzE3YjFlYTRjMWJlZmMwMzUxZTU1Yi4uOGVmM2NlNzZmZGRiNTJmNzdmYTEwZmY1ZGM5NDhj ZjBkMGY3MDJiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTEwLTAxICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgQnVp bGQgZmFpbHVyZSB3aXRoIGNzcyBmaWx0ZXJzIGVuYWJsZWQgYW5kIGFjY2VsZXJhdGVkIGNvbXBv c2l0aW5nIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NTkwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIERvIG5vdCB0cnkgdG8gc2V0QmFja2luZ05lZWRzUmVwYWludCB3aGVuIGJ1aWxkaW5n IHdpdGhvdXQgYWNjZWxlcmF0ZWQKKyAgICAgICAgY29tcG9zaXRpbmcuCisKKyAgICAgICAgQWxz bywgYWxsb3cgcGFpbnRpbmcgd2l0aCBmaWx0ZXIgKHBhaW50c1dpdGhGaWx0ZXJzIHJldHVybnMg dHJ1ZSBpZgorICAgICAgICByZW5kZXJlciBoYXMgZmlsdGVyKSB3aGVuIGFjY2VsZXJhdGVkIGNv bXBvc2l0aW5nIGlzIG5vdCBlbmFibGVkLgorCisgICAgICAgIE5vIGZ1bmN0aW9uYWwgY2hhbmdl LCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnN0eWxlQ2hhbmdlZCk6CisKKzIwMTIt MTAtMDEgIEFybmF1ZCBSZW5ldmllciAgPGEucmVuZXZpZXJAc2lzYS5zYW1zdW5nLmNvbT4KKwog ICAgICAgICBbc291cF0gV2ViS2l0IGNyYXNoZXMgd2hlbiBkb2luZyBhIGh0dHAgcmVxdWVzdAog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgwNTUKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggNzU5ODYzMzVlZWY0 OGJmNDRhNDMyNzE2ZDJjNzk0MTk5YmM1YTBlNy4uNzM4NTBkMzI3ZDcyODA3MTc1ZDBhMzJhNzhk YTU2MDdkMDQ3ZDQxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw CkBAIC00ODgyLDcgKzQ4ODIsNyBAQCB2b2lkIFJlbmRlckxheWVyOjpzdHlsZUNoYW5nZWQoU3R5 bGVEaWZmZXJlbmNlLCBjb25zdCBSZW5kZXJTdHlsZSogb2xkU3R5bGUpCiAgICAgdXBkYXRlU2Ny b2xsQ29ybmVyU3R5bGUoKTsKICAgICB1cGRhdGVSZXNpemVyU3R5bGUoKTsKIAotI2lmIEVOQUJM RShDU1NfRklMVEVSUykKKyNpZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpICYmIFVTRShBQ0NFTEVSQVRF RF9DT01QT1NJVElORykKICAgICBib29sIGJhY2tpbmdEaWRDb21wb3NpdGVMYXllcnMgPSBpc0Nv bXBvc2l0ZWQoKSAmJiBiYWNraW5nKCktPmNhbkNvbXBvc2l0ZUZpbHRlcnMoKTsKICNlbmRpZgog CkBAIC00OTA3LDEyICs0OTA3LDE0IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnN0eWxlQ2hhbmdlZChT dHlsZURpZmZlcmVuY2UsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdHlsZSkKIAogI2lmIEVOQUJM RShDU1NfRklMVEVSUykKICAgICB1cGRhdGVPclJlbW92ZUZpbHRlckVmZmVjdCgpOworI2lmIFVT RShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICBpZiAoaXNDb21wb3NpdGVkKCkgJiYgYmFj a2luZ0RpZENvbXBvc2l0ZUxheWVycyAmJiAhYmFja2luZygpLT5jYW5Db21wb3NpdGVGaWx0ZXJz KCkpIHsKICAgICAgICAgLy8gVGhlIGZpbHRlcnMgdXNlZCB0byBiZSBkcmF3biBieSBwbGF0Zm9y bSBjb2RlLCBidXQgbm93IHRoZSBwbGF0Zm9ybSBjYW5ub3QgZHJhdyB0aGVtIGFueW1vcmUuCiAg ICAgICAgIC8vIEZhbGxiYWNrIHRvIGRyYXdpbmcgdGhlbSBpbiBzb2Z0d2FyZS4KICAgICAgICAg c2V0QmFja2luZ05lZWRzUmVwYWludCgpOwogICAgIH0KICNlbmRpZgorI2VuZGlmCiB9CiAKIHZv aWQgUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbGFibGVBcmVhU2V0KGJvb2wgaGFzT3ZlcmZsb3cp Cg== 166944 2012-10-03 12:50:37 -0700 2012-10-03 15:28:52 -0700 Patch bug-95908-20121003124942.patch text/plain 2350 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzZjZDQxOTU0MzgwOWNm ZWZkYWE2ZTI3YmI5ODZkOTlkZTU4MWMxNC4uODY3M2E0ZTE5NzE5YzUyNzlhOWNjMWFlMGNhYTQy NGQ0YTc4ZjU3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTAxICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKKyAgICAgICAgQnVp bGQgZmFpbHVyZSB3aXRoIGNzcyBmaWx0ZXJzIGVuYWJsZWQgYW5kIGFjY2VsZXJhdGVkIGNvbXBv c2l0aW5nIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NTkwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIERvIG5vdCB0cnkgdG8gc2V0QmFja2luZ05lZWRzUmVwYWludCB3aGVuIGJ1aWxkaW5n IHdpdGhvdXQgYWNjZWxlcmF0ZWQKKyAgICAgICAgY29tcG9zaXRpbmcuCisKKyAgICAgICAgQWxz bywgYWxsb3cgcGFpbnRpbmcgd2l0aCBmaWx0ZXIgKHBhaW50c1dpdGhGaWx0ZXJzIHJldHVybnMg dHJ1ZSBpZgorICAgICAgICByZW5kZXJlciBoYXMgZmlsdGVyKSB3aGVuIGFjY2VsZXJhdGVkIGNv bXBvc2l0aW5nIGlzIG5vdCBlbmFibGVkLgorCisgICAgICAgIE5vIGZ1bmN0aW9uYWwgY2hhbmdl LCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnN0eWxlQ2hhbmdlZCk6CisKIDIwMTIt MTAtMDMgIEFybmF1ZCBSZW5ldmllciAgPGEucmVuZXZpZXJAc2lzYS5zYW1zdW5nLmNvbT4KIAog ICAgICAgICBbc291cF0gV2ViS2l0IGNyYXNoZXMgd2hlbiBkb2luZyBhIGh0dHAgcmVxdWVzdApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggNzU5ODYzMzVlZWY0 OGJmNDRhNDMyNzE2ZDJjNzk0MTk5YmM1YTBlNy4uYzA5NmIwMWM4YzJlMmNkZWZhZTFhODVhMDVj MzlkNmEyZjNmNWJkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw CkBAIC00ODgyLDEwICs0ODgyLDYgQEAgdm9pZCBSZW5kZXJMYXllcjo6c3R5bGVDaGFuZ2VkKFN0 eWxlRGlmZmVyZW5jZSwgY29uc3QgUmVuZGVyU3R5bGUqIG9sZFN0eWxlKQogICAgIHVwZGF0ZVNj cm9sbENvcm5lclN0eWxlKCk7CiAgICAgdXBkYXRlUmVzaXplclN0eWxlKCk7CiAKLSNpZiBFTkFC TEUoQ1NTX0ZJTFRFUlMpCi0gICAgYm9vbCBiYWNraW5nRGlkQ29tcG9zaXRlTGF5ZXJzID0gaXND b21wb3NpdGVkKCkgJiYgYmFja2luZygpLT5jYW5Db21wb3NpdGVGaWx0ZXJzKCk7Ci0jZW5kaWYK LQogICAgIHVwZGF0ZURlc2NlbmRhbnREZXBlbmRlbnRGbGFncygpOwogICAgIHVwZGF0ZVRyYW5z Zm9ybSgpOwogI2lmIEVOQUJMRShDU1NfQ09NUE9TSVRJTkcpCkBAIC00OTA3LDEyICs0OTAzLDE1 IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnN0eWxlQ2hhbmdlZChTdHlsZURpZmZlcmVuY2UsIGNvbnN0 IFJlbmRlclN0eWxlKiBvbGRTdHlsZSkKIAogI2lmIEVOQUJMRShDU1NfRklMVEVSUykKICAgICB1 cGRhdGVPclJlbW92ZUZpbHRlckVmZmVjdCgpOworI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJ VElORykKKyAgICBib29sIGJhY2tpbmdEaWRDb21wb3NpdGVMYXllcnMgPSBpc0NvbXBvc2l0ZWQo KSAmJiBiYWNraW5nKCktPmNhbkNvbXBvc2l0ZUZpbHRlcnMoKTsKICAgICBpZiAoaXNDb21wb3Np dGVkKCkgJiYgYmFja2luZ0RpZENvbXBvc2l0ZUxheWVycyAmJiAhYmFja2luZygpLT5jYW5Db21w b3NpdGVGaWx0ZXJzKCkpIHsKICAgICAgICAgLy8gVGhlIGZpbHRlcnMgdXNlZCB0byBiZSBkcmF3 biBieSBwbGF0Zm9ybSBjb2RlLCBidXQgbm93IHRoZSBwbGF0Zm9ybSBjYW5ub3QgZHJhdyB0aGVt IGFueW1vcmUuCiAgICAgICAgIC8vIEZhbGxiYWNrIHRvIGRyYXdpbmcgdGhlbSBpbiBzb2Z0d2Fy ZS4KICAgICAgICAgc2V0QmFja2luZ05lZWRzUmVwYWludCgpOwogICAgIH0KICNlbmRpZgorI2Vu ZGlmCiB9CiAKIHZvaWQgUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbGFibGVBcmVhU2V0KGJvb2wg aGFzT3ZlcmZsb3cpCg==