95900 2012-09-05 15:14:15 -0700 Fix export macros in IntegerToStringConversion.h 2012-09-06 11:05:42 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 paroga paroga benjamin webkit.review.bot oldest_to_newest 712578 0 paroga 2012-09-05 15:14:15 -0700 Fix export macros in IntegerToStringConversion.h 712581 1 162348 paroga 2012-09-05 15:21:32 -0700 Created attachment 162348 Patch 712584 2 webkit.review.bot 2012-09-05 15:23:50 -0700 Attachment 162348 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1 Source/WTF/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 712586 3 162350 paroga 2012-09-05 15:24:32 -0700 Created attachment 162350 Patch 712869 4 162350 benjamin 2012-09-05 21:58:24 -0700 Comment on attachment 162350 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162350&action=review Let's already r+ this as it is correct. Feel free to land this patch, or to do the complete cleaning of IntegerToStringConversion. > Source/WTF/ChangeLog:13 > + (WTF): Useless. 713000 5 162444 paroga 2012-09-06 01:05:02 -0700 Created attachment 162444 Patch Land this now, since bug 95940 is more work. 713476 6 162444 webkit.review.bot 2012-09-06 11:05:39 -0700 Comment on attachment 162444 Patch Clearing flags on attachment: 162444 Committed r127761: <http://trac.webkit.org/changeset/127761> 713477 7 webkit.review.bot 2012-09-06 11:05:42 -0700 All reviewed patches have been landed. Closing bug. 162348 2012-09-05 15:21:32 -0700 2012-09-05 15:24:32 -0700 Patch bug-95900.patch text/plain 2067 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggN2U1ZWFiZS4uODkyYmRmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wOS0wNSAg UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggZXhw b3J0IG1hY3JvcyBpbiBJbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1OTAwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIFdURl9FWFBPUlRfU1RSSU5HX0FQ SSBtdXN0IGJlIHVzZWQgb25seSBmb3Igc3ltYm9scyB3aGljaCBhcmUgY29tcGlsZWQKKyAgICAg ICAgb24gd2luZG93cyBpbiAibm9uLVdURiIgYmluYXJpZXMgdG9vLiBTaW5jZSB0aGlzIGlzbid0 IHZhbGlkIGZvciB0aGUKKwkJSW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbiBmdW5jdGlvbiByZXBs YWNlIGl0IHdpdGggV1RGX0VYUE9SVF9QUklWQVRFLgorCisgICAgICAgICogd3RmL3RleHQvSW50 ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5oOgorICAgICAgICAoV1RGKToKKwogMjAxMi0wOS0wNSAg R2Fib3IgUmFwY3NhbnlpICA8cmdhYm9yQHdlYmtpdC5vcmc+CiAKICAgICAgICAgREZHIEpJVCBk b2Vzbid0IHdvcmsgcHJvcGVybHkgb24gQVJNIGhhcmRmcApkaWZmIC0tZ2l0IGEvU291cmNlL1dU Ri93dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmggYi9Tb3VyY2UvV1RGL3d0Zi90 ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNpb24uaAppbmRleCBjMzI1MDU5Li40YzYxY2M2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNpb24u aAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNpb24uaApA QCAtMjQsMTMgKzI0LDE1IEBACiAjaW5jbHVkZSAiU3RyaW5nSW1wbC5oIgogCiBuYW1lc3BhY2Ug V1RGIHsKLVdURl9FWFBPUlRfU1RSSU5HX0FQSSBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IG51bWJl clRvU3RyaW5nSW1wbChpbnQpOwotV1RGX0VYUE9SVF9TVFJJTkdfQVBJIFBhc3NSZWZQdHI8U3Ry aW5nSW1wbD4gbnVtYmVyVG9TdHJpbmdJbXBsKGxvbmcpOwotV1RGX0VYUE9SVF9TVFJJTkdfQVBJ IFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gbnVtYmVyVG9TdHJpbmdJbXBsKGxvbmcgbG9uZyk7CiAK LVdURl9FWFBPUlRfU1RSSU5HX0FQSSBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IG51bWJlclRvU3Ry aW5nSW1wbCh1bnNpZ25lZCk7Ci1XVEZfRVhQT1JUX1NUUklOR19BUEkgUGFzc1JlZlB0cjxTdHJp bmdJbXBsPiBudW1iZXJUb1N0cmluZ0ltcGwodW5zaWduZWQgbG9uZyk7Ci1XVEZfRVhQT1JUX1NU UklOR19BUEkgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBudW1iZXJUb1N0cmluZ0ltcGwodW5zaWdu ZWQgbG9uZyBsb25nKTsKLX0KK1dURl9FWFBPUlRfUFJJVkFURSBQYXNzUmVmUHRyPFN0cmluZ0lt cGw+IG51bWJlclRvU3RyaW5nSW1wbChpbnQpOworV1RGX0VYUE9SVF9QUklWQVRFIFBhc3NSZWZQ dHI8U3RyaW5nSW1wbD4gbnVtYmVyVG9TdHJpbmdJbXBsKGxvbmcpOworV1RGX0VYUE9SVF9QUklW QVRFIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gbnVtYmVyVG9TdHJpbmdJbXBsKGxvbmcgbG9uZyk7 CisKK1dURl9FWFBPUlRfUFJJVkFURSBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IG51bWJlclRvU3Ry aW5nSW1wbCh1bnNpZ25lZCk7CitXVEZfRVhQT1JUX1BSSVZBVEUgUGFzc1JlZlB0cjxTdHJpbmdJ bXBsPiBudW1iZXJUb1N0cmluZ0ltcGwodW5zaWduZWQgbG9uZyk7CitXVEZfRVhQT1JUX1BSSVZB VEUgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBudW1iZXJUb1N0cmluZ0ltcGwodW5zaWduZWQgbG9u ZyBsb25nKTsKKworfSAvLyBuYW1lc3BhY2UgV1RGCiAKICNlbmRpZiAvLyBJbnRlZ2VyVG9TdHJp bmdDb252ZXJzaW9uX2gK 162350 2012-09-05 15:24:32 -0700 2012-09-06 01:05:02 -0700 Patch bug-95900.patch text/plain 2073 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggN2U1ZWFiZS4uODkyYmRmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wOS0wNSAg UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggZXhw b3J0IG1hY3JvcyBpbiBJbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1OTAwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIFdURl9FWFBPUlRfU1RSSU5HX0FQ SSBtdXN0IGJlIHVzZWQgb25seSBmb3Igc3ltYm9scyB3aGljaCBhcmUgY29tcGlsZWQKKyAgICAg ICAgb24gd2luZG93cyBpbiAibm9uLVdURiIgYmluYXJpZXMgdG9vLiBTaW5jZSB0aGlzIGlzbid0 IHZhbGlkIGZvciB0aGUKKyAgICAgICAgSW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbiBmdW5jdGlv biByZXBsYWNlIGl0IHdpdGggV1RGX0VYUE9SVF9QUklWQVRFLgorCisgICAgICAgICogd3RmL3Rl eHQvSW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5oOgorICAgICAgICAoV1RGKToKKwogMjAxMi0w OS0wNSAgR2Fib3IgUmFwY3NhbnlpICA8cmdhYm9yQHdlYmtpdC5vcmc+CiAKICAgICAgICAgREZH IEpJVCBkb2Vzbid0IHdvcmsgcHJvcGVybHkgb24gQVJNIGhhcmRmcApkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmggYi9Tb3VyY2UvV1RG L3d0Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNpb24uaAppbmRleCBjMzI1MDU5Li40YzYx Y2M2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZl cnNpb24uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNp b24uaApAQCAtMjQsMTMgKzI0LDE1IEBACiAjaW5jbHVkZSAiU3RyaW5nSW1wbC5oIgogCiBuYW1l c3BhY2UgV1RGIHsKLVdURl9FWFBPUlRfU1RSSU5HX0FQSSBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+ IG51bWJlclRvU3RyaW5nSW1wbChpbnQpOwotV1RGX0VYUE9SVF9TVFJJTkdfQVBJIFBhc3NSZWZQ dHI8U3RyaW5nSW1wbD4gbnVtYmVyVG9TdHJpbmdJbXBsKGxvbmcpOwotV1RGX0VYUE9SVF9TVFJJ TkdfQVBJIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gbnVtYmVyVG9TdHJpbmdJbXBsKGxvbmcgbG9u Zyk7CiAKLVdURl9FWFBPUlRfU1RSSU5HX0FQSSBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IG51bWJl clRvU3RyaW5nSW1wbCh1bnNpZ25lZCk7Ci1XVEZfRVhQT1JUX1NUUklOR19BUEkgUGFzc1JlZlB0 cjxTdHJpbmdJbXBsPiBudW1iZXJUb1N0cmluZ0ltcGwodW5zaWduZWQgbG9uZyk7Ci1XVEZfRVhQ T1JUX1NUUklOR19BUEkgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBudW1iZXJUb1N0cmluZ0ltcGwo dW5zaWduZWQgbG9uZyBsb25nKTsKLX0KK1dURl9FWFBPUlRfUFJJVkFURSBQYXNzUmVmUHRyPFN0 cmluZ0ltcGw+IG51bWJlclRvU3RyaW5nSW1wbChpbnQpOworV1RGX0VYUE9SVF9QUklWQVRFIFBh c3NSZWZQdHI8U3RyaW5nSW1wbD4gbnVtYmVyVG9TdHJpbmdJbXBsKGxvbmcpOworV1RGX0VYUE9S VF9QUklWQVRFIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gbnVtYmVyVG9TdHJpbmdJbXBsKGxvbmcg bG9uZyk7CisKK1dURl9FWFBPUlRfUFJJVkFURSBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IG51bWJl clRvU3RyaW5nSW1wbCh1bnNpZ25lZCk7CitXVEZfRVhQT1JUX1BSSVZBVEUgUGFzc1JlZlB0cjxT dHJpbmdJbXBsPiBudW1iZXJUb1N0cmluZ0ltcGwodW5zaWduZWQgbG9uZyk7CitXVEZfRVhQT1JU X1BSSVZBVEUgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBudW1iZXJUb1N0cmluZ0ltcGwodW5zaWdu ZWQgbG9uZyBsb25nKTsKKworfSAvLyBuYW1lc3BhY2UgV1RGCiAKICNlbmRpZiAvLyBJbnRlZ2Vy VG9TdHJpbmdDb252ZXJzaW9uX2gK 162444 2012-09-06 01:05:02 -0700 2012-09-06 11:05:39 -0700 Patch bug-95900.patch text/plain 2059 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggN2U1ZWFiZS4uODkyYmRmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wOS0wNSAg UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggZXhw b3J0IG1hY3JvcyBpbiBJbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1OTAwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgQmVuamFtaW4gUG91bGFpbi4KKworICAgICAgICBUaGUgV1RGX0VYUE9SVF9TVFJJTkdf QVBJIG11c3QgYmUgdXNlZCBvbmx5IGZvciBzeW1ib2xzIHdoaWNoIGFyZSBjb21waWxlZAorICAg ICAgICBvbiB3aW5kb3dzIGluICJub24tV1RGIiBiaW5hcmllcyB0b28uIFNpbmNlIHRoaXMgaXNu J3QgdmFsaWQgZm9yIHRoZQorICAgICAgICBJbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uIGZ1bmN0 aW9uIHJlcGxhY2UgaXQgd2l0aCBXVEZfRVhQT1JUX1BSSVZBVEUuCisKKyAgICAgICAgKiB3dGYv dGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmg6CisKIDIwMTItMDktMDUgIEdhYm9yIFJh cGNzYW55aSAgPHJnYWJvckB3ZWJraXQub3JnPgogCiAgICAgICAgIERGRyBKSVQgZG9lc24ndCB3 b3JrIHByb3Blcmx5IG9uIEFSTSBoYXJkZnAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3Rl eHQvSW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5oIGIvU291cmNlL1dURi93dGYvdGV4dC9JbnRl Z2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKaW5kZXggYzMyNTA1OS4uNGM2MWNjNiAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKKysrIGIv U291cmNlL1dURi93dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKQEAgLTI0LDEz ICsyNCwxNSBAQAogI2luY2x1ZGUgIlN0cmluZ0ltcGwuaCIKIAogbmFtZXNwYWNlIFdURiB7Ci1X VEZfRVhQT1JUX1NUUklOR19BUEkgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBudW1iZXJUb1N0cmlu Z0ltcGwoaW50KTsKLVdURl9FWFBPUlRfU1RSSU5HX0FQSSBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+ IG51bWJlclRvU3RyaW5nSW1wbChsb25nKTsKLVdURl9FWFBPUlRfU1RSSU5HX0FQSSBQYXNzUmVm UHRyPFN0cmluZ0ltcGw+IG51bWJlclRvU3RyaW5nSW1wbChsb25nIGxvbmcpOwogCi1XVEZfRVhQ T1JUX1NUUklOR19BUEkgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBudW1iZXJUb1N0cmluZ0ltcGwo dW5zaWduZWQpOwotV1RGX0VYUE9SVF9TVFJJTkdfQVBJIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4g bnVtYmVyVG9TdHJpbmdJbXBsKHVuc2lnbmVkIGxvbmcpOwotV1RGX0VYUE9SVF9TVFJJTkdfQVBJ IFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gbnVtYmVyVG9TdHJpbmdJbXBsKHVuc2lnbmVkIGxvbmcg bG9uZyk7Ci19CitXVEZfRVhQT1JUX1BSSVZBVEUgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBudW1i ZXJUb1N0cmluZ0ltcGwoaW50KTsKK1dURl9FWFBPUlRfUFJJVkFURSBQYXNzUmVmUHRyPFN0cmlu Z0ltcGw+IG51bWJlclRvU3RyaW5nSW1wbChsb25nKTsKK1dURl9FWFBPUlRfUFJJVkFURSBQYXNz UmVmUHRyPFN0cmluZ0ltcGw+IG51bWJlclRvU3RyaW5nSW1wbChsb25nIGxvbmcpOworCitXVEZf RVhQT1JUX1BSSVZBVEUgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBudW1iZXJUb1N0cmluZ0ltcGwo dW5zaWduZWQpOworV1RGX0VYUE9SVF9QUklWQVRFIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gbnVt YmVyVG9TdHJpbmdJbXBsKHVuc2lnbmVkIGxvbmcpOworV1RGX0VYUE9SVF9QUklWQVRFIFBhc3NS ZWZQdHI8U3RyaW5nSW1wbD4gbnVtYmVyVG9TdHJpbmdJbXBsKHVuc2lnbmVkIGxvbmcgbG9uZyk7 CisKK30gLy8gbmFtZXNwYWNlIFdURgogCiAjZW5kaWYgLy8gSW50ZWdlclRvU3RyaW5nQ29udmVy c2lvbl9oCg==