95896 2012-09-05 14:38:31 -0700 Remove String::operator+=() from plugin code 2012-09-06 01:55:55 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 paroga paroga webkit.review.bot oldest_to_newest 712545 0 paroga 2012-09-05 14:38:31 -0700 Remove String::operator+=() from plugin code 712550 1 162339 paroga 2012-09-05 14:41:58 -0700 Created attachment 162339 Patch 712552 2 162341 paroga 2012-09-05 14:44:06 -0700 Created attachment 162341 Patch 713036 3 162341 webkit.review.bot 2012-09-06 01:55:53 -0700 Comment on attachment 162341 Patch Clearing flags on attachment: 162341 Committed r127708: <http://trac.webkit.org/changeset/127708> 713037 4 webkit.review.bot 2012-09-06 01:55:55 -0700 All reviewed patches have been landed. Closing bug. 162339 2012-09-05 14:41:58 -0700 2012-09-05 14:44:06 -0700 Patch bug-95896.patch text/plain 4291 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMWJlYmUzLi5iODI2YzgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDktMDUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmVtb3ZlIFN0cmluZzo6b3BlcmF0b3IrPSgpIGZyb20gcGx1Z2luIGNvZGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1ODk2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIG9wZXJhdG9y KygpIHRvIGNvbmNhdGVuYXRlIHN0cmluZ3MgaW5zdGVhZCBvZiBvcGVyYXRvcis9KCkuCisKKyAg ICAgICAgKiBwbHVnaW5zL1BsdWdpblZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFyc2VS RkM4MjJIZWFkZXJGaWVsZHMpOgorCiAyMDEyLTA5LTA1ICBCZW5qYW1pbiBQb3VsYWluICA8YnBv dWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgdXNlcyBvZiBTdHJpbmc6Om9wZXJh dG9yKz0oKSBmb3IgTWFjCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdp blZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmNwcAppbmRleCBk ZDIyMGQ4Li45NjcyZTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdp blZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKQEAg LTExMzMsMTIgKzExMzMsOCBAQCBzdGF0aWMgaW5saW5lIEhUVFBIZWFkZXJNYXAgcGFyc2VSRkM4 MjJIZWFkZXJGaWVsZHMoY29uc3QgVmVjdG9yPGNoYXI+JiBidWZmZXIsCiAgICAgICAgICAgICAg ICAgICAgIHZhbHVlID0gU3RyaW5nKGNvbG9uLCBlb2wgLSBjb2xvbik7CiAKICAgICAgICAgICAg ICAgICBTdHJpbmcgb2xkVmFsdWUgPSBoZWFkZXJGaWVsZHMuZ2V0KGxhc3RLZXkpOwotICAgICAg ICAgICAgICAgIGlmICghb2xkVmFsdWUuaXNOdWxsKCkpIHsKLSAgICAgICAgICAgICAgICAgICAg U3RyaW5nIHRtcCA9IG9sZFZhbHVlOwotICAgICAgICAgICAgICAgICAgICB0bXAgKz0gIiwgIjsK LSAgICAgICAgICAgICAgICAgICAgdG1wICs9IHZhbHVlOwotICAgICAgICAgICAgICAgICAgICB2 YWx1ZSA9IHRtcDsKLSAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgaWYgKCFvbGRW YWx1ZS5pc051bGwoKSkKKyAgICAgICAgICAgICAgICAgICAgdmFsdWUgPSBvbGRWYWx1ZSArICIs ICIgKyB2YWx1ZTsKIAogICAgICAgICAgICAgICAgIGhlYWRlckZpZWxkcy5zZXQobGFzdEtleSwg dmFsdWUpOwogICAgICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDU1ODhlMTcuLjIxZTVmYWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wOS0wNSAgUGF0cmljayBHYW5zdGVyZXIg IDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZW1vdmUgU3RyaW5nOjpvcGVyYXRvcis9 KCkgZnJvbSBwbHVnaW4gY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTU4OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBVc2Ugb3BlcmF0b3IrKCkgdG8gY29uY2F0ZW5hdGUgc3RyaW5ncyBpbnN0ZWFk IG9mIG9wZXJhdG9yKz0oKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2Fw ZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OnBhcnNlUkZDODIy SGVhZGVyRmllbGRzKToKKyAgICAgICAgKFdlYktpdCk6CisKIDIwMTItMDktMDUgIEJhbGF6cyBL ZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gUVJhd1dlYlZpZXdQ cml2YXRlIGRvZXMgbm90IGluaXRpYWxpemUgc29tZSBtZW1iZXJzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVCcm93c2VyRnVu Y3MuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNj YXBlQnJvd3NlckZ1bmNzLmNwcAppbmRleCBkNDBkYjc5Li4wM2MyMmVkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVCcm93c2Vy RnVuY3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2Fw ZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHAKQEAgLTE3MiwxMiArMTcyLDEyIEBAIHN0YXRpYyBI VFRQSGVhZGVyTWFwIHBhcnNlUkZDODIySGVhZGVyRmllbGRzKGNvbnN0IGNoYXIqIGJ5dGVzLCB1 bnNpZ25lZCBsZW5ndGgpCiAgICAgICAgICAgICBpZiAobGFzdEhlYWRlcktleS5pc051bGwoKSkg ewogICAgICAgICAgICAgICAgIC8vIG1hbGZvcm1lZCBoZWFkZXI7IGlnbm9yZSBpdCBhbmQgY29u dGludWUKICAgICAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgICAgIH0gCi0gICAgICAg ICAgICAKKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgLy8gTWVyZ2UgdGhlIGNvbnRpbnVh dGlvbiBvZiB0aGUgcHJldmlvdXMgaGVhZGVyCiAgICAgICAgICAgICBTdHJpbmcgY3VycmVudFZh bHVlID0gaGVhZGVyRmllbGRzLmdldChsYXN0SGVhZGVyS2V5KTsKICAgICAgICAgICAgIFN0cmlu ZyBuZXdWYWx1ZShsaW5lLCBsaW5lTGVuZ3RoKTsKLSAgICAgICAgICAgIAorCiAgICAgICAgICAg ICBoZWFkZXJGaWVsZHMuc2V0KGxhc3RIZWFkZXJLZXksIGN1cnJlbnRWYWx1ZSArIG5ld1ZhbHVl KTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIC8vIEJyYW5kIG5ldyBoZWFkZXIKQEAg LTE5MiwzMSArMTkyLDI4IEBAIHN0YXRpYyBIVFRQSGVhZGVyTWFwIHBhcnNlUkZDODIySGVhZGVy RmllbGRzKGNvbnN0IGNoYXIqIGJ5dGVzLCB1bnNpZ25lZCBsZW5ndGgpCiAKICAgICAgICAgICAg IGxhc3RIZWFkZXJLZXkgPSBjYXBpdGFsaXplUkZDODIySGVhZGVyRmllbGROYW1lKFN0cmluZyhs aW5lLCBjb2xvbiAtIGxpbmUpKTsKICAgICAgICAgICAgIFN0cmluZyB2YWx1ZTsKLSAgICAgICAg ICAgIAorCiAgICAgICAgICAgICBmb3IgKGNvbG9uKys7IGNvbG9uICE9IGVuZE9mTGluZTsgY29s b24rKykgewogICAgICAgICAgICAgICAgIGlmICgqY29sb24gIT0gJyAnICYmICpjb2xvbiAhPSAn XHQnKQogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KKwogICAgICAg ICAgICAgaWYgKGNvbG9uID09IGVuZE9mTGluZSkKICAgICAgICAgICAgICAgICB2YWx1ZSA9ICIi OwogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIHZhbHVlID0gU3RyaW5nKGNvbG9u LCBlbmRPZkxpbmUgLSBjb2xvbik7Ci0gICAgICAgICAgICAKKwogICAgICAgICAgICAgU3RyaW5n IG9sZFZhbHVlID0gaGVhZGVyRmllbGRzLmdldChsYXN0SGVhZGVyS2V5KTsKLSAgICAgICAgICAg IGlmICghb2xkVmFsdWUuaXNOdWxsKCkpIHsKLSAgICAgICAgICAgICAgICBTdHJpbmcgdG1wID0g b2xkVmFsdWU7Ci0gICAgICAgICAgICAgICAgdG1wICs9ICIsICI7Ci0gICAgICAgICAgICAgICAg dG1wICs9IHZhbHVlOwotICAgICAgICAgICAgICAgIHZhbHVlID0gdG1wOwotICAgICAgICAgICAg fQotICAgICAgICAgICAgCisgICAgICAgICAgICBpZiAoIW9sZFZhbHVlLmlzTnVsbCgpKQorICAg ICAgICAgICAgICAgIHZhbHVlID0gb2xkVmFsdWUgKyAiLCAiICsgdmFsdWU7CisKICAgICAgICAg ICAgIGhlYWRlckZpZWxkcy5zZXQobGFzdEhlYWRlcktleSwgdmFsdWUpOwogICAgICAgICB9CiAg ICAgfQogCiAgICAgcmV0dXJuIGhlYWRlckZpZWxkczsKIH0KLSAgICAKKwogc3RhdGljIE5QRXJy b3IgcGFyc2VQb3N0QnVmZmVyKGJvb2wgaXNGaWxlLCBjb25zdCBjaGFyICpidWZmZXIsIHVpbnQz Ml90IGxlbmd0aCwgYm9vbCBwYXJzZUhlYWRlcnMsIEhUVFBIZWFkZXJNYXAmIGhlYWRlckZpZWxk cywgVmVjdG9yPHVpbnQ4X3Q+JiBib2R5RGF0YSkKIHsKICAgICBSZWZQdHI8U2hhcmVkQnVmZmVy PiBmaWxlQ29udGVudHM7Cg== 162341 2012-09-05 14:44:06 -0700 2012-09-06 01:55:53 -0700 Patch bug-95896.patch text/plain 1448 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMWJlYmUzLi5iODI2YzgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDktMDUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmVtb3ZlIFN0cmluZzo6b3BlcmF0b3IrPSgpIGZyb20gcGx1Z2luIGNvZGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1ODk2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIG9wZXJhdG9y KygpIHRvIGNvbmNhdGVuYXRlIHN0cmluZ3MgaW5zdGVhZCBvZiBvcGVyYXRvcis9KCkuCisKKyAg ICAgICAgKiBwbHVnaW5zL1BsdWdpblZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFyc2VS RkM4MjJIZWFkZXJGaWVsZHMpOgorCiAyMDEyLTA5LTA1ICBCZW5qYW1pbiBQb3VsYWluICA8YnBv dWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgdXNlcyBvZiBTdHJpbmc6Om9wZXJh dG9yKz0oKSBmb3IgTWFjCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdp blZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmNwcAppbmRleCBk ZDIyMGQ4Li45NjcyZTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdp blZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKQEAg LTExMzMsMTIgKzExMzMsOCBAQCBzdGF0aWMgaW5saW5lIEhUVFBIZWFkZXJNYXAgcGFyc2VSRkM4 MjJIZWFkZXJGaWVsZHMoY29uc3QgVmVjdG9yPGNoYXI+JiBidWZmZXIsCiAgICAgICAgICAgICAg ICAgICAgIHZhbHVlID0gU3RyaW5nKGNvbG9uLCBlb2wgLSBjb2xvbik7CiAKICAgICAgICAgICAg ICAgICBTdHJpbmcgb2xkVmFsdWUgPSBoZWFkZXJGaWVsZHMuZ2V0KGxhc3RLZXkpOwotICAgICAg ICAgICAgICAgIGlmICghb2xkVmFsdWUuaXNOdWxsKCkpIHsKLSAgICAgICAgICAgICAgICAgICAg U3RyaW5nIHRtcCA9IG9sZFZhbHVlOwotICAgICAgICAgICAgICAgICAgICB0bXAgKz0gIiwgIjsK LSAgICAgICAgICAgICAgICAgICAgdG1wICs9IHZhbHVlOwotICAgICAgICAgICAgICAgICAgICB2 YWx1ZSA9IHRtcDsKLSAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgaWYgKCFvbGRW YWx1ZS5pc051bGwoKSkKKyAgICAgICAgICAgICAgICAgICAgdmFsdWUgPSBvbGRWYWx1ZSArICIs ICIgKyB2YWx1ZTsKIAogICAgICAgICAgICAgICAgIGhlYWRlckZpZWxkcy5zZXQobGFzdEtleSwg dmFsdWUpOwogICAgICAgICAgICAgfQo=