95895 2012-09-05 14:35:31 -0700 [Qt] Deprecate String += operator 2012-09-06 16:54:30 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lauro.neto lauro.neto benjamin webkit.review.bot oldest_to_newest 712542 0 lauro.neto 2012-09-05 14:35:31 -0700 WTF::String::operator+= is being removed. 712657 1 162366 lauro.neto 2012-09-05 16:33:17 -0700 Created attachment 162366 Patch Partial patch. Probably will need to be updated to remove PLATFORM(QT) from the guard added by #95797. 712662 2 lauro.neto 2012-09-05 16:35:23 -0700 (In reply to comment #1) > Created an attachment (id=162366) [details] > Patch > > Partial patch. Probably will need to be updated to remove PLATFORM(QT) from the guard added by #95797. s/added/will be added/ (but it's already on EWS) 712694 3 162366 benjamin 2012-09-05 17:17:58 -0700 Comment on attachment 162366 Patch Looks good. 713552 4 162551 lauro.neto 2012-09-06 12:08:09 -0700 Created attachment 162551 Patch Updated the test removing QT from the guard. 713557 5 162551 benjamin 2012-09-06 12:12:15 -0700 Comment on attachment 162551 Patch Yeah! Have checked the debug build, if yes we can cq+. 713859 6 162551 webkit.review.bot 2012-09-06 16:54:27 -0700 Comment on attachment 162551 Patch Clearing flags on attachment: 162551 Committed r127802: <http://trac.webkit.org/changeset/127802> 713860 7 webkit.review.bot 2012-09-06 16:54:30 -0700 All reviewed patches have been landed. Closing bug. 162366 2012-09-05 16:33:17 -0700 2012-09-06 12:08:04 -0700 Patch bug-95895-20120905203258.patch text/plain 1591 lauro.neto U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTFjYjM1OWExYWVhZDdj NGFlZmQyOTc1ZWFiZDFlNzYwNDg3ZjA3MS4uMGJjZjM2ZjI3ZjY5OTY0ZWViMDllOWNkNGQwZmJh NTQ3MWQzMWQyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTA1ICBMYXVy byBOZXRvICA8bGF1cm8ubmV0b0BvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtRdF0gRGVwcmVj YXRlIFN0cmluZyArPSBvcGVyYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTU4OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZXBsYWNlZCBTdHJpbmcgKz0oKSB3aXRoIGFwcGVuZC4KKworICAgICAg ICAqIHBsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyVGhlbWVRdDo6ZXh0cmFNZWRpYUNvbnRyb2xzU3R5bGVTaGVldCk6CisKIDIwMTItMDktMDUg IENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAg ICBbRUZMXVtXSzJdIFByb3ZpZGUgaW1wbGVtZW50YXRpb24gZm9yIFdlYlByb2Nlc3MgZnVuY3Rp b25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCmluZGV4 IGYzOTE3YjhhOTAzNzYxM2I0MWE3NTY5YmIxZDc0YWVhYzg5YjNlNjIuLjg4NDZlZTc2MzJkZmFj NzQxMWQ3MzA2ZjU5ZjEwMWFlMjQxZDM3NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3F0L1JlbmRlclRoZW1lUXQuY3BwCkBAIC01MzksNyArNTM5LDcgQEAgU3RyaW5nIFJlbmRlclRo ZW1lUXQ6OmV4dHJhTWVkaWFDb250cm9sc1N0eWxlU2hlZXQoKQogICAgIFN0cmluZyByZXN1bHQg PSBTdHJpbmcobWVkaWFDb250cm9sc1F0VXNlckFnZW50U3R5bGVTaGVldCwgc2l6ZW9mKG1lZGlh Q29udHJvbHNRdFVzZXJBZ2VudFN0eWxlU2hlZXQpKTsKIAogICAgIGlmIChtX3BhZ2UgJiYgbV9w YWdlLT5jaHJvbWUoKS0+cmVxdWlyZXNGdWxsc2NyZWVuRm9yVmlkZW9QbGF5YmFjaygpKQotICAg ICAgICByZXN1bHQgKz0gU3RyaW5nKG1lZGlhQ29udHJvbHNRdEZ1bGxzY3JlZW5Vc2VyQWdlbnRT dHlsZVNoZWV0LCBzaXplb2YobWVkaWFDb250cm9sc1F0RnVsbHNjcmVlblVzZXJBZ2VudFN0eWxl U2hlZXQpKTsKKyAgICAgICAgcmVzdWx0LmFwcGVuZChTdHJpbmcobWVkaWFDb250cm9sc1F0RnVs bHNjcmVlblVzZXJBZ2VudFN0eWxlU2hlZXQsIHNpemVvZihtZWRpYUNvbnRyb2xzUXRGdWxsc2Ny ZWVuVXNlckFnZW50U3R5bGVTaGVldCkpKTsKIAogICAgIHJldHVybiByZXN1bHQ7CiB9Cg== 162551 2012-09-06 12:08:09 -0700 2012-09-06 16:54:27 -0700 Patch bug-95895-20120906160749.patch text/plain 2607 lauro.neto U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDQ5ZjQ0YzdkN2Q1NWFhNTg3YmY3ZjBh MDEzNDc0MGQ2ZjA5M2RhOTIuLjk2MTc5MjNhNWEzZGNiOTU1MGM2N2VmNDYzMWEzMTc3ODQ1ZDRm OTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDktMDYgIExhdXJvIE5ldG8gIDxsYXVyby5u ZXRvQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1F0XSBEZXByZWNhdGUgU3RyaW5nICs9IG9w ZXJhdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NTg5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl bW92ZSBRdCBmcm9tIFdURl9ERVBSRUNBVEVEX1NUUklOR19PUEVSQVRPUlMgZ3VhcmQuCisKKyAg ICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxMi0wOS0wNiAgU2ltb24gSGF1c21hbm4gIDxz aW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBWYXJpb3VzIHNtYWxsIFdp bmRvd3MgLyBNU1ZDIGJ1aWxkIGZpeGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDY4NjJmOWE0MDRiMTE4ODc5 NThmYjlkNzc1NzA5ZjM2MTNlYTY1Mi4uY2Y0MDJhOGE2N2MxNDM5MDJlZTc5MmRlZDg3ZmVkMWJi ZDU1ZWI1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTA1ICBMYXVybyBO ZXRvICA8bGF1cm8ubmV0b0BvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtRdF0gRGVwcmVjYXRl IFN0cmluZyArPSBvcGVyYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTU4OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZXBsYWNlZCBTdHJpbmcgKz0oKSB3aXRoIGFwcGVuZC4KKworICAgICAgICAq IHBsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy VGhlbWVRdDo6ZXh0cmFNZWRpYUNvbnRyb2xzU3R5bGVTaGVldCk6CisKIDIwMTItMDktMDYgIEtl aXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVXNlIG5hdGl2ZSBm dW5jdGlvbiBiaW5kIGluIHBhZ2UgcG9wdXBzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCAxY2Y4NmYyZWE2OWY2 Zjg4MDBlOWM1NjRmYjhlYjI4NDM2YWFlNWM0Li4yZDM4M2M0Mjk3MzVmZmM1OWUyMmEzZTYxODA5 ZjFhN2FmMWVjNTVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBi L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTExODUsNyArMTE4NSw3IEBACiAjZGVmaW5l IFdURl9VU0VfWkxJQiAxCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKFFUKSB8fCBQTEFURk9STShH VEspIHx8IFBMQVRGT1JNKFdJTikKKyNpZiBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFdJTikK ICNkZWZpbmUgV1RGX0RFUFJFQ0FURURfU1RSSU5HX09QRVJBVE9SUwogI2VuZGlmCiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAKaW5kZXggZjM5MTdiOGE5 MDM3NjEzYjQxYTc1NjliYjFkNzRhZWFjODliM2U2Mi4uODg0NmVlNzYzMmRmYWM3NDExZDczMDZm NTlmMTAxYWUyNDFkMzc2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQv UmVuZGVyVGhlbWVRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVy VGhlbWVRdC5jcHAKQEAgLTUzOSw3ICs1MzksNyBAQCBTdHJpbmcgUmVuZGVyVGhlbWVRdDo6ZXh0 cmFNZWRpYUNvbnRyb2xzU3R5bGVTaGVldCgpCiAgICAgU3RyaW5nIHJlc3VsdCA9IFN0cmluZyht ZWRpYUNvbnRyb2xzUXRVc2VyQWdlbnRTdHlsZVNoZWV0LCBzaXplb2YobWVkaWFDb250cm9sc1F0 VXNlckFnZW50U3R5bGVTaGVldCkpOwogCiAgICAgaWYgKG1fcGFnZSAmJiBtX3BhZ2UtPmNocm9t ZSgpLT5yZXF1aXJlc0Z1bGxzY3JlZW5Gb3JWaWRlb1BsYXliYWNrKCkpCi0gICAgICAgIHJlc3Vs dCArPSBTdHJpbmcobWVkaWFDb250cm9sc1F0RnVsbHNjcmVlblVzZXJBZ2VudFN0eWxlU2hlZXQs IHNpemVvZihtZWRpYUNvbnRyb2xzUXRGdWxsc2NyZWVuVXNlckFnZW50U3R5bGVTaGVldCkpOwor ICAgICAgICByZXN1bHQuYXBwZW5kKFN0cmluZyhtZWRpYUNvbnRyb2xzUXRGdWxsc2NyZWVuVXNl ckFnZW50U3R5bGVTaGVldCwgc2l6ZW9mKG1lZGlhQ29udHJvbHNRdEZ1bGxzY3JlZW5Vc2VyQWdl bnRTdHlsZVNoZWV0KSkpOwogCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0K