95890 2012-09-05 14:00:53 -0700 seamless iframes should not inherit editability 2012-11-28 23:46:56 -0800 1 1 1 Unclassified WebKit Frames 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 45950 1 ojan mkwst abarth allan.jensen cmarcelo eric hayato ian macpherson menard mkwst webkit.review.bot oldest_to_newest 712515 0 ojan 2012-09-05 14:00:53 -0700 http://html5.org/tools/web-apps-tracker?from=7318&to=7319 712640 1 ian 2012-09-05 16:13:58 -0700 This was in response to feedback from WebKit people asking for it not to saying that it didn't in WebKit, FWIW... 712655 2 ojan 2012-09-05 16:32:57 -0700 Ah, I see. There's just a FIXME in the code that we should delete. http://trac.webkit.org/browser/trunk/Source/WebCore/css/StyleResolver.cpp?rev=127593#L1671 713536 3 eric 2012-09-06 11:53:11 -0700 rs=me on removing such. :) we first-implementors are just a confused lot, wandering unawares in the darkness of the unknown. 776729 4 mkwst 2012-11-27 07:26:34 -0800 Based on some quick fiddling around with http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=1929, it looks like WebKit is already behaving as the spec claims it should. Eric, did you mean "Remove that FIXME, we should totally inherit editability!" If so, I'm happy to pick it up. If not, I think we can close this bug. 777352 5 ojan 2012-11-27 16:33:50 -0800 Yes, I think we can remove the FIXME. 777663 6 176434 mkwst 2012-11-28 02:23:36 -0800 Created attachment 176434 Patch 778044 7 176434 ojan 2012-11-28 10:36:59 -0800 Comment on attachment 176434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176434&action=review Removing the FIXME is still correct since this only affects the document, but please update the test case to use js-test-pre and to fail in the second case (it's ok to check in tests that say FAIL if they are exposing a bug). > LayoutTests/fast/frames/seamless/seamless-contenteditable-not-inherited.html:22 > + if (window.testRunner) > + testRunner.dumpAsText(); > + > + function test() { > + var span = document.querySelector('div > iframe').contentWindow.document.querySelector('span'); > + var spanEditable = window.getComputedStyle(span).getPropertyCSSValue('-webkit-user-modify').cssText; > + if (spanEditable == 'read-only') > + console.log("PASS: An element inside a seamless iframe inside a contenteditable element does not inherit editability."); > + else > + console.log("FAIL: An element inside a seamless iframe inside a contenteditable element should not inherit editability."); > + > + var p = document.querySelector('body > iframe').contentWindow.document.querySelector('p'); > + var pEditable = window.getComputedStyle(p).getPropertyCSSValue('-webkit-user-modify').cssText; > + if (pEditable == 'read-only') > + console.log("PASS: An element inside a seamless iframe does not inherit editability via CSS cascade."); > + else > + console.log("FAIL: An element inside a seamless iframe should not inherit editability via CSS cascade."); > + } Please use js-test-pre.js for this. It makes for more developer friendly error messages when there are failures and would be less code. > LayoutTests/fast/frames/seamless/seamless-contenteditable-not-inherited.html:36 > + <iframe seamless srcdoc="<p>This paragraph is not editable.</p>"></iframe> Actually, I think this paragraph should be editable! The spec just says contentEditable doesn't inherit. It seems like all CSS styling should. In fact, it some cases it seems like it does. I think this is exposing a bug in the seamless implementation. Looks like this is a general seamless bug: http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=1932. 778087 8 176526 mkwst 2012-11-28 11:09:11 -0800 Created attachment 176526 Patch 778090 9 mkwst 2012-11-28 11:11:26 -0800 (In reply to comment #7) > (From update of attachment 176434 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176434&action=review > > Removing the FIXME is still correct since this only affects the document, but please update the test case to use js-test-pre and to fail in the second case (it's ok to check in tests that say FAIL if they are exposing a bug). > > Please use js-test-pre.js for this. It makes for more developer friendly error messages when there are failures and would be less code. Done, thanks for the tip. > Looks like this is a general seamless bug: http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=1932. Bleh. :( 778185 10 176526 ojan 2012-11-28 12:24:15 -0800 Comment on attachment 176526 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176526&action=review Thanks! > LayoutTests/fast/frames/seamless/seamless-contenteditable-not-inherited.html:10 > + window.span = document.querySelector('div > iframe').contentDocument.querySelector('span'); > + window.p = document.querySelector('body > iframe').contentDocument.querySelector('p'); Nit: This is fine, but I would have just made them globals (e.g. s/window.span/span/). 778725 11 mkwst 2012-11-28 23:21:11 -0800 (In reply to comment #10) > (From update of attachment 176526 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176526&action=review > > Thanks! Thank you! > > LayoutTests/fast/frames/seamless/seamless-contenteditable-not-inherited.html:10 > > + window.span = document.querySelector('div > iframe').contentDocument.querySelector('span'); > > + window.p = document.querySelector('body > iframe').contentDocument.querySelector('p'); > > Nit: This is fine, but I would have just made them globals (e.g. s/window.span/span/). I did it this way for consistency with the other seamless tests, which generally seem to follow this pattern. 778738 12 176526 webkit.review.bot 2012-11-28 23:46:51 -0800 Comment on attachment 176526 Patch Clearing flags on attachment: 176526 Committed r136105: <http://trac.webkit.org/changeset/136105> 778739 13 webkit.review.bot 2012-11-28 23:46:56 -0800 All reviewed patches have been landed. Closing bug. 176434 2012-11-28 02:23:36 -0800 2012-11-28 11:09:03 -0800 Patch bug-95890-20121128112113.patch text/plain 6012 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzMzMjRhMmU3MTI4ZGQ0 MmI1ZGMyOGM3Njk1ZDhmYThmZGE1YmIxNi4uYjEwZjVlYzRlMjAzNTQ2NzBkNGYxODAyY2VhZDNl ZmQ1OWQ5MDU3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTExLTI4ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWRkIGEgdGVzdCB0byBlbnN1 cmUgdGhhdCAnc2VhbWxlc3MnIGlmcmFtZXMgZG8gbm90IGluaGVyaXQgZWRpdGFiaWxpdHkuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTg5MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGRvbid0IGN1 cnJlbnRseSBzdXBwb3J0IGluaGVyaXRpbmcgZWRpdGFiaWxpdHkgaW50byBhIHNlYW1sZXNzIGZy YW1lLgorICAgICAgICBodHRwOi8vaHRtbDUub3JnL3Rvb2xzL3dlYi1hcHBzLXRyYWNrZXI/ZnJv bT03MzE4JnRvPTczMTkgYnJvdWdodCB0aGUKKyAgICAgICAgc3BlYyBpbiBsaW5lIHdpdGggV2Vi S2l0J3MgYmVoYXZpb3IgKGhhISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBkZWZlbmRzIHRoZSBi ZWhhdmlvciBieSBhZGRpbmcgYSB0ZXN0LCBhbmQgcmVtb3ZlcyBhIEZJWE1FCisgICAgICAgIGNv bW1lbnQgbm93IHRoYXQgdGhlIHF1ZXN0aW9uIGlzIHNldHRsZWQuCisKKyAgICAgICAgVGVzdDog ZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtY29udGVudGVkaXRhYmxlLW5vdC1pbmhlcml0 ZWQuaHRtbAorCisgICAgICAgICogY3NzL1N0eWxlUmVzb2x2ZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6U3R5bGVSZXNvbHZlcjo6c3R5bGVGb3JEb2N1bWVudCk6CisgICAgICAgICAgICBObyBm dW5jdGlvbmFsIGNoYW5nZSwganVzdCBkcm9wcGluZyBhIEZJWE1FIGNvbW1lbnQuCisKIDIwMTIt MTEtMjggIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdvb2dsZS5jb20+CiAKICAgICAgICAg QWRkIGJhc2ljIGltcGxlbWVudGF0aW9uIGZvciBNZWRpYVN0cmVhbUF1ZGlvRGVzdGluYXRpb25O b2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKaW5kZXggY2JmNmM4YTc1MWFkZGJk NDZjYzEwYjJiYjBlOGZlZmM3MjRlOTJkNy4uZTBlMmNmNTNkNDQwZDQ0YjA2ZGE1ODc2Y2RiOTkz YzRlZTc3YmRiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApAQCAtMTM5OCw3 ICsxMzk4LDcgQEAgUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gU3R5bGVSZXNvbHZlcjo6c3R5bGVG b3JEb2N1bWVudChEb2N1bWVudCogZG9jdW1lbnQsIENTU0YKICAgICAgICAgZG9jdW1lbnRTdHls ZS0+c2V0UGFnZVNjYWxlVHJhbnNmb3JtKGZyYW1lID8gZnJhbWUtPmZyYW1lU2NhbGVGYWN0b3Io KSA6IDEpOwogICAgICAgICBkb2N1bWVudFN0eWxlLT5zZXRMb2NhbGUoZG9jdW1lbnQtPmNvbnRl bnRMYW5ndWFnZSgpKTsKICAgICB9Ci0gICAgLy8gRklYTUU6IFRoaXMgb3ZlcnJpZGVzIGFueSAt d2Via2l0LXVzZXItbW9kaWZ5IGluaGVyaXRlZCBmcm9tIHRoZSBwYXJlbnQgaWZyYW1lLgorICAg IC8vIFRoaXMgb3ZlcnJpZGVzIGFueSAtd2Via2l0LXVzZXItbW9kaWZ5IGluaGVyaXRlZCBmcm9t IHRoZSBwYXJlbnQgaWZyYW1lLgogICAgIGRvY3VtZW50U3R5bGUtPnNldFVzZXJNb2RpZnkoZG9j dW1lbnQtPmluRGVzaWduTW9kZSgpID8gUkVBRF9XUklURSA6IFJFQURfT05MWSk7CiAKICAgICBF bGVtZW50KiBkb2NFbGVtZW50ID0gZG9jdW1lbnQtPmRvY3VtZW50RWxlbWVudCgpOwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IDliYjE0MjAxZjkzYTA1YmJhZTc0ODZmMGQxOTY4NjJkYWRkZTIxZGMuLjVlMDEzMzE1MmZjZTVi YjI4MzAyYjU5MTA1MTc0OTI4NzU0ZDQ2OTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0x MS0yOCAgTWlrZSBXZXN0ICA8bWt3c3RAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBhIHRl c3QgdG8gZW5zdXJlIHRoYXQgJ3NlYW1sZXNzJyBpZnJhbWVzIGRvIG5vdCBpbmhlcml0IGVkaXRh YmlsaXR5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTU4OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGZhc3QvZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNzLWNvbnRlbnRlZGl0YWJsZS1ub3QtaW5oZXJp dGVkLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mcmFtZXMvc2VhbWxlc3Mv c2VhbWxlc3MtY29udGVudGVkaXRhYmxlLW5vdC1pbmhlcml0ZWQuaHRtbDogQWRkZWQuCisKIDIw MTItMTEtMjggIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdvb2dsZS5jb20+CiAKICAgICAg ICAgQWRkIGJhc2ljIGltcGxlbWVudGF0aW9uIGZvciBNZWRpYVN0cmVhbUF1ZGlvRGVzdGluYXRp b25Ob2RlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9zZWFtbGVzcy9zZWFt bGVzcy1jb250ZW50ZWRpdGFibGUtbm90LWluaGVyaXRlZC1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9mYXN0L2ZyYW1lcy9zZWFtbGVzcy9zZWFtbGVzcy1jb250ZW50ZWRpdGFibGUtbm90LWlu aGVyaXRlZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzA0NGZlZDU5ODZhYjkyZmVmM2Q1MjUx ODk3MjIwMGRkNmVkMWE2OAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZnJh bWVzL3NlYW1sZXNzL3NlYW1sZXNzLWNvbnRlbnRlZGl0YWJsZS1ub3QtaW5oZXJpdGVkLWV4cGVj dGVkLnR4dApAQCAtMCwwICsxLDUgQEAKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAxMjogUEFTUzog QW4gZWxlbWVudCBpbnNpZGUgYSBzZWFtbGVzcyBpZnJhbWUgaW5zaWRlIGEgY29udGVudGVkaXRh YmxlIGVsZW1lbnQgZG9lcyBub3QgaW5oZXJpdCBlZGl0YWJpbGl0eS4KK0NPTlNPTEUgTUVTU0FH RTogbGluZSAxOTogUEFTUzogQW4gZWxlbWVudCBpbnNpZGUgYSBzZWFtbGVzcyBpZnJhbWUgZG9l cyBub3QgaW5oZXJpdCBlZGl0YWJpbGl0eSB2aWEgQ1NTIGNhc2NhZGUuCitUaGlzIHRlc3QgZW5z dXJlcyB0aGF0IGNvbnRlbnQgaW5zaWRlIGEgc2VhbWxlc3MgaWZyYW1lIGRvZXMgbm90IGluaGVy aXQgZWRpdGFiaWxpdHkgZWl0aGVyIHZpYSB0aGUgY29udGVudGVkaXRhYmxlIGF0dHJpYnV0ZSBv biBhIHBhcmVudCBlbGVtZW50LCBvciB2aWEgYSBDU1MgcnVsZSB0aGF0IHdvdWxkIGNhc2NhZGUg aW50byB0aGUgaWZyYW1lLiBJdCBwYXNzZXMgaWYgdHdvICJQQVNTIiBhbmQgbm8gIkZBSUwiIGNv bnNvbGUgbWVzc2FnZXMgYXJlIHByZXNlbnQuCisKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtY29udGVudGVkaXRhYmxlLW5vdC1pbmhlcml0 ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNzLWNvbnRl bnRlZGl0YWJsZS1ub3QtaW5oZXJpdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYzFlZjk3ODFlYmJlNGZj MGRkODc5MmI1MDA2MDAwYTY5NGQzM2Q4NwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNzLWNvbnRlbnRlZGl0YWJsZS1ub3QtaW5oZXJp dGVkLmh0bWwKQEAgLTAsMCArMSwzOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFk PgorICAgIDxzY3JpcHQ+CisgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAg ICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCisgICAgICAgIGZ1bmN0aW9uIHRlc3QoKSB7 CisgICAgICAgICAgICB2YXIgc3BhbiA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2RpdiA+IGlm cmFtZScpLmNvbnRlbnRXaW5kb3cuZG9jdW1lbnQucXVlcnlTZWxlY3Rvcignc3BhbicpOworICAg ICAgICAgICAgdmFyIHNwYW5FZGl0YWJsZSA9IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKHNwYW4p LmdldFByb3BlcnR5Q1NTVmFsdWUoJy13ZWJraXQtdXNlci1tb2RpZnknKS5jc3NUZXh0OworICAg ICAgICAgICAgaWYgKHNwYW5FZGl0YWJsZSA9PSAncmVhZC1vbmx5JykKKyAgICAgICAgICAgICAg ICBjb25zb2xlLmxvZygiUEFTUzogQW4gZWxlbWVudCBpbnNpZGUgYSBzZWFtbGVzcyBpZnJhbWUg aW5zaWRlIGEgY29udGVudGVkaXRhYmxlIGVsZW1lbnQgZG9lcyBub3QgaW5oZXJpdCBlZGl0YWJp bGl0eS4iKTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBjb25zb2xlLmxvZygi RkFJTDogQW4gZWxlbWVudCBpbnNpZGUgYSBzZWFtbGVzcyBpZnJhbWUgaW5zaWRlIGEgY29udGVu dGVkaXRhYmxlIGVsZW1lbnQgc2hvdWxkIG5vdCBpbmhlcml0IGVkaXRhYmlsaXR5LiIpOworCisg ICAgICAgICAgICB2YXIgcCA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2JvZHkgPiBpZnJhbWUn KS5jb250ZW50V2luZG93LmRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ3AnKTsKKyAgICAgICAgICAg IHZhciBwRWRpdGFibGUgPSB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShwKS5nZXRQcm9wZXJ0eUNT U1ZhbHVlKCctd2Via2l0LXVzZXItbW9kaWZ5JykuY3NzVGV4dDsKKyAgICAgICAgICAgIGlmIChw RWRpdGFibGUgPT0gJ3JlYWQtb25seScpCisgICAgICAgICAgICAgICAgY29uc29sZS5sb2coIlBB U1M6IEFuIGVsZW1lbnQgaW5zaWRlIGEgc2VhbWxlc3MgaWZyYW1lIGRvZXMgbm90IGluaGVyaXQg ZWRpdGFiaWxpdHkgdmlhIENTUyBjYXNjYWRlLiIpOworICAgICAgICAgICAgZWxzZQorICAgICAg ICAgICAgICAgIGNvbnNvbGUubG9nKCJGQUlMOiBBbiBlbGVtZW50IGluc2lkZSBhIHNlYW1sZXNz IGlmcmFtZSBzaG91bGQgbm90IGluaGVyaXQgZWRpdGFiaWxpdHkgdmlhIENTUyBjYXNjYWRlLiIp OworICAgICAgICB9CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InRlc3Qo KSI+CisgICAgPHA+VGhpcyB0ZXN0IGVuc3VyZXMgdGhhdCBjb250ZW50IGluc2lkZSBhIHNlYW1s ZXNzIGlmcmFtZSBkb2VzIG5vdCBpbmhlcml0CisgICAgZWRpdGFiaWxpdHkgZWl0aGVyIHZpYSB0 aGUgY29udGVudGVkaXRhYmxlIGF0dHJpYnV0ZSBvbiBhIHBhcmVudCBlbGVtZW50LCBvcgorICAg IHZpYSBhIENTUyBydWxlIHRoYXQgd291bGQgY2FzY2FkZSBpbnRvIHRoZSBpZnJhbWUuIEl0IHBh c3NlcyBpZiB0d28gIlBBU1MiCisgICAgYW5kIG5vICJGQUlMIiBjb25zb2xlIG1lc3NhZ2VzIGFy ZSBwcmVzZW50LjwvcD4KKyAgICA8ZGl2IGNvbnRlbnRlZGl0YWJsZT4KKyAgICAgICAgPGlmcmFt ZSBzZWFtbGVzcyBzcmNkb2M9IjxzcGFuPlRoaXMgc3BhbiBpcyBub3QgZWRpdGFibGUuPC9zcGFu PiI+PC9pZnJhbWU+CisgICAgPC9kaXY+CisgICAgPHN0eWxlPgorICAgICAgICBwIHsgLXdlYmtp dC11c2VyLW1vZGlmeTogcmVhZC13cml0ZTsgfQorICAgIDwvc3R5bGU+CisgICAgPGlmcmFtZSBz ZWFtbGVzcyBzcmNkb2M9IjxwPlRoaXMgcGFyYWdyYXBoIGlzIG5vdCBlZGl0YWJsZS48L3A+Ij48 L2lmcmFtZT4KKzwvYm9keT4KKzwvaHRtbD4K 176526 2012-11-28 11:09:11 -0800 2012-11-28 23:46:51 -0800 Patch bug-95890-20121128200642.patch text/plain 5315 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWZlNDc0ZDZiMWMzMTI2 ZDc2OWEzZTdjN2M3NmU2MzBkOTQ1YzgyMC4uZWM4Zjk1YjcyNGExMjM0MWUwNjBjYmZkN2ZjMzgy Yjk2MDRhYTAxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTExLTI4ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWRkIGEgdGVzdCB0byBlbnN1 cmUgdGhhdCAnc2VhbWxlc3MnIGlmcmFtZXMgZG8gbm90IGluaGVyaXQgY29udGVudGVkaXRhYmxl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU4OTAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBkb24n dCBjdXJyZW50bHkgc3VwcG9ydCBpbmhlcml0aW5nIGNvbnRlbnRlZGl0YWJsZSBpbnRvIGEgc2Vh bWxlc3MKKyAgICAgICAgZnJhbWUuIGh0dHA6Ly9odG1sNS5vcmcvdG9vbHMvd2ViLWFwcHMtdHJh Y2tlcj9mcm9tPTczMTgmdG89NzMxOQorICAgICAgICBicm91Z2h0IHRoZSBzcGVjIGluIGxpbmUg d2l0aCBXZWJLaXQncyBiZWhhdmlvciAoaGEhKS4gVGhpcyBwYXRjaAorICAgICAgICBkZWZlbmRz IHRoZSBiZWhhdmlvciBieSBhZGRpbmcgYSB0ZXN0LCBhbmQgcmVtb3ZlcyBhIEZJWE1FIGNvbW1l bnQKKyAgICAgICAgbm93IHRoYXQgdGhlIHF1ZXN0aW9uIGlzIHNldHRsZWQuCisKKyAgICAgICAg SXQgYWxzbyBleHBvc2VzIGEgYnJhbmQgbmV3IGJ1ZzogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMzUzOQorICAgICAgICBIb3cgZXhjaXRpbmcuCisKKyAgICAgICAg VGVzdDogZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtY29udGVudGVkaXRhYmxlLW5vdC1p bmhlcml0ZWQuaHRtbAorCisgICAgICAgICogY3NzL1N0eWxlUmVzb2x2ZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6U3R5bGVSZXNvbHZlcjo6c3R5bGVGb3JEb2N1bWVudCk6CisgICAgICAgICAg ICBObyBmdW5jdGlvbmFsIGNoYW5nZSwganVzdCBkcm9wcGluZyBhIEZJWE1FIGNvbW1lbnQuCisK IDIwMTItMTEtMjcgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVy cnldIEV2ZW50TG9vcCBzaG91bGQgZW5kIHdoZW4gV2ViS2l0IHRocmVhZCBpcyBleGl0aW5nCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKaW5kZXggY2JmNmM4YTc1MWFkZGJkNDZjYzEw YjJiYjBlOGZlZmM3MjRlOTJkNy4uZTBlMmNmNTNkNDQwZDQ0YjA2ZGE1ODc2Y2RiOTkzYzRlZTc3 YmRiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApAQCAtMTM5OCw3ICsxMzk4 LDcgQEAgUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gU3R5bGVSZXNvbHZlcjo6c3R5bGVGb3JEb2N1 bWVudChEb2N1bWVudCogZG9jdW1lbnQsIENTU0YKICAgICAgICAgZG9jdW1lbnRTdHlsZS0+c2V0 UGFnZVNjYWxlVHJhbnNmb3JtKGZyYW1lID8gZnJhbWUtPmZyYW1lU2NhbGVGYWN0b3IoKSA6IDEp OwogICAgICAgICBkb2N1bWVudFN0eWxlLT5zZXRMb2NhbGUoZG9jdW1lbnQtPmNvbnRlbnRMYW5n dWFnZSgpKTsKICAgICB9Ci0gICAgLy8gRklYTUU6IFRoaXMgb3ZlcnJpZGVzIGFueSAtd2Via2l0 LXVzZXItbW9kaWZ5IGluaGVyaXRlZCBmcm9tIHRoZSBwYXJlbnQgaWZyYW1lLgorICAgIC8vIFRo aXMgb3ZlcnJpZGVzIGFueSAtd2Via2l0LXVzZXItbW9kaWZ5IGluaGVyaXRlZCBmcm9tIHRoZSBw YXJlbnQgaWZyYW1lLgogICAgIGRvY3VtZW50U3R5bGUtPnNldFVzZXJNb2RpZnkoZG9jdW1lbnQt PmluRGVzaWduTW9kZSgpID8gUkVBRF9XUklURSA6IFJFQURfT05MWSk7CiAKICAgICBFbGVtZW50 KiBkb2NFbGVtZW50ID0gZG9jdW1lbnQtPmRvY3VtZW50RWxlbWVudCgpOwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg2Mzhk Y2JjZDZhY2RhODU3NjUzOGU2YTQyMWI3MGUxNjhkNDE3YmMuLjdmNjIzYjI0YTU0NTliODZlNjE4 ZGE1ZDVmMzU2MGZkOTZlZjA0NDIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0xMS0yOCAg TWlrZSBXZXN0ICA8bWt3c3RAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBhIHRlc3QgdG8g ZW5zdXJlIHRoYXQgJ3NlYW1sZXNzJyBpZnJhbWVzIGRvIG5vdCBpbmhlcml0IGNvbnRlbnRlZGl0 YWJsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1 ODkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBm YXN0L2ZyYW1lcy9zZWFtbGVzcy9zZWFtbGVzcy1jb250ZW50ZWRpdGFibGUtbm90LWluaGVyaXRl ZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZnJhbWVzL3NlYW1sZXNzL3Nl YW1sZXNzLWNvbnRlbnRlZGl0YWJsZS1ub3QtaW5oZXJpdGVkLmh0bWw6IEFkZGVkLgorCiAyMDEy LTExLTI3ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCBnYXJkZW5pbmcsIGZpeGluZyBsaW50IGVycm9ycyBpbiBUZXN0RXhwZWN0YXRpb25zLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtY29u dGVudGVkaXRhYmxlLW5vdC1pbmhlcml0ZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFz dC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtY29udGVudGVkaXRhYmxlLW5vdC1pbmhlcml0ZWQt ZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjIyNGRlNTI5MzI4ZjdmZDdjMDgyM2RhNTM0MzA2M2U3 YTM5ZWQ4YzcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9zZWFt bGVzcy9zZWFtbGVzcy1jb250ZW50ZWRpdGFibGUtbm90LWluaGVyaXRlZC1leHBlY3RlZC50eHQK QEAgLTAsMCArMSw0IEBACitUaGlzIHRlc3QgZW5zdXJlcyB0aGF0IGNvbnRlbnQgaW5zaWRlIGEg c2VhbWxlc3MgaWZyYW1lIGRvZXMgbm90IGluaGVyaXQgZWRpdGFiaWxpdHkgdmlhIHRoZSBjb250 ZW50ZWRpdGFibGUgYXR0cmlidXRlIG9uIGEgcGFyZW50IGVsZW1lbnQsIGJ1dCBkb2VzIHZpYSBh IENTUyBydWxlIHRoYXQgY2FzY2FkZXMgaW50byB0aGUgZnJhbWUuCitQQVNTIHdpbmRvdy5nZXRD b21wdXRlZFN0eWxlKHNwYW4pLmdldFByb3BlcnR5Q1NTVmFsdWUoJy13ZWJraXQtdXNlci1tb2Rp ZnknKS5jc3NUZXh0IGlzICJyZWFkLW9ubHkiCitGQUlMIHdpbmRvdy5nZXRDb21wdXRlZFN0eWxl KHApLmdldFByb3BlcnR5Q1NTVmFsdWUoJy13ZWJraXQtdXNlci1tb2RpZnknKS5jc3NUZXh0IHNo b3VsZCBiZSByZWFkLXdyaXRlLiBXYXMgcmVhZC1vbmx5LgorCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2ZyYW1lcy9zZWFtbGVzcy9zZWFtbGVzcy1jb250ZW50ZWRpdGFibGUtbm90LWlu aGVyaXRlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3Mt Y29udGVudGVkaXRhYmxlLW5vdC1pbmhlcml0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jYjdlNDMxMmRk MjQzNGEwN2RjZTY2YmFiODBjYWU1OWI5OWEwMGEzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtY29udGVudGVkaXRhYmxlLW5vdC1p bmhlcml0ZWQuaHRtbApAQCAtMCwwICsxLDI2IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PGhlYWQ+CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5q cyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdD4KKyAgICAgICAgd2luZG93Lm9ubG9hZCA9IGZ1bmN0 aW9uICgpIHsKKyAgICAgICAgICAgIGRlYnVnKCJUaGlzIHRlc3QgZW5zdXJlcyB0aGF0IGNvbnRl bnQgaW5zaWRlIGEgc2VhbWxlc3MgaWZyYW1lIGRvZXMgbm90IGluaGVyaXQgZWRpdGFiaWxpdHkg dmlhIHRoZSBjb250ZW50ZWRpdGFibGUgYXR0cmlidXRlIG9uIGEgcGFyZW50IGVsZW1lbnQsIGJ1 dCBkb2VzIHZpYSBhIENTUyBydWxlIHRoYXQgY2FzY2FkZXMgaW50byB0aGUgZnJhbWUuIik7CisK KyAgICAgICAgICAgIHdpbmRvdy5zcGFuID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcignZGl2ID4g aWZyYW1lJykuY29udGVudERvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ3NwYW4nKTsKKyAgICAgICAg ICAgIHdpbmRvdy5wID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcignYm9keSA+IGlmcmFtZScpLmNv bnRlbnREb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdwJyk7CisKKyAgICAgICAgICAgIHNob3VsZEJl RXF1YWxUb1N0cmluZygid2luZG93LmdldENvbXB1dGVkU3R5bGUoc3BhbikuZ2V0UHJvcGVydHlD U1NWYWx1ZSgnLXdlYmtpdC11c2VyLW1vZGlmeScpLmNzc1RleHQiLCAicmVhZC1vbmx5Iik7Cisg ICAgICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoIndpbmRvdy5nZXRDb21wdXRlZFN0eWxl KHApLmdldFByb3BlcnR5Q1NTVmFsdWUoJy13ZWJraXQtdXNlci1tb2RpZnknKS5jc3NUZXh0Iiwg InJlYWQtd3JpdGUiKTsKKyAgICAgICAgfTsKKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5 PgorICAgIDxkaXYgY29udGVudGVkaXRhYmxlPgorICAgICAgICA8aWZyYW1lIHNlYW1sZXNzIHNy Y2RvYz0iPHNwYW4+VGhpcyBzcGFuIGlzIG5vdCBlZGl0YWJsZS48L3NwYW4+Ij48L2lmcmFtZT4K KyAgICA8L2Rpdj4KKyAgICA8c3R5bGU+CisgICAgICAgIHAgeyAtd2Via2l0LXVzZXItbW9kaWZ5 OiByZWFkLXdyaXRlOyB9CisgICAgPC9zdHlsZT4KKyAgICA8aWZyYW1lIHNlYW1sZXNzIHNyY2Rv Yz0iPHA+VGhpcyBwYXJhZ3JhcGggaXMgbm90IGVkaXRhYmxlLjwvcD4iPjwvaWZyYW1lPgorPC9i b2R5PgorPC9odG1sPgo=