95872 2012-09-05 10:54:09 -0700 Build failure with accelerated compositing disabled 2012-09-05 20:14:24 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 a.renevier a.renevier jamesr kbr mrobinson webkit.review.bot oldest_to_newest 712273 0 a.renevier 2012-09-05 10:54:09 -0700 Hi, when I try to build webkit with: build-webkit --gtk --disable-accelerated-compositing the build fails with following error: ../../Source/WebCore/html/canvas/WebGLRenderingContext.cpp: In member function ‘void WebCore::WebGLRenderingContext::markContextChanged()’: ../../Source/WebCore/html/canvas/WebGLRenderingContext.cpp:606:26: error: ‘class WebCore::DrawingBuffer’ has no member named ‘markContentsChanged’ make[1]: *** [Source/WebCore/html/canvas/libWebCore_la-WebGLRenderingContext.lo] Error 1 I think the bug was introduced in #94961 I guess the problem also happens with other ports, but I'm not 100% sure of that. 712303 1 162288 a.renevier 2012-09-05 10:59:13 -0700 Created attachment 162288 patch proposal 712321 2 162288 jamesr 2012-09-05 11:02:37 -0700 Comment on attachment 162288 patch proposal OK 712811 3 162288 webkit.review.bot 2012-09-05 20:14:21 -0700 Comment on attachment 162288 patch proposal Clearing flags on attachment: 162288 Committed r127683: <http://trac.webkit.org/changeset/127683> 712812 4 webkit.review.bot 2012-09-05 20:14:24 -0700 All reviewed patches have been landed. Closing bug. 162288 2012-09-05 10:59:13 -0700 2012-09-05 20:14:21 -0700 patch proposal bug-95872-20120905105855.patch text/plain 1725 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGYxOWFiMGZkODAxOTEy ZGU3MTczN2Y4ODA4ZmUwNTI2ZTliYmQ0Yi4uN2Y3Yjc5YjEwZmZmMWI2NGZiOTAzMjJhMTNiM2Zj YjFkNWJmM2I3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTA1ICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKKyAgICAgICAgQnVp bGQgZmFpbHVyZSB3aXRoIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGRpc2FibGVkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTg3MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERlZmluZSBEcmF3aW5nQnVm ZmVyOjptYXJrQ29udGV4dENoYW5nZWQgZXZlbiB3aGVuIGFjY2VsZXJhdGVkCisgICAgICAgIGNv bXBvc2l0aW5nIGlzIG5vdCB1c2VkLgorCisgICAgICAgIE5vIGZ1bmN0aW9uYWwgY2hhbmdlLCBz byBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJhd2lu Z0J1ZmZlci5oOgorICAgICAgICAoV2ViQ29yZTo6RHJhd2luZ0J1ZmZlcjo6bWFya0NvbnRlbnRz Q2hhbmdlZCk6CisgICAgICAgIChEcmF3aW5nQnVmZmVyKToKKwogMjAxMi0wOC0zMSAgQXJuYXVk IFJlbmV2aWVyICA8YS5yZW5ldmllckBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFtHdGtd IGFsbG93IGJ1aWxkaW5nIHdpdGggY3NzLXNoYWRlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9EcmF3aW5nQnVmZmVyLmggYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJhd2luZ0J1ZmZlci5oCmluZGV4IDViMzMwMmI5Mjhh NmRhNzQ2MTU2MjVkYmJiMDRlOWU0NTIwOTY0YjQuLjk5MDQyNDJlNDlkMjEzYjViMWExODJkNzQx MTc4MDE3MmM5YjQ4NTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dwdS9EcmF3aW5nQnVmZmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3B1L0RyYXdpbmdCdWZmZXIuaApAQCAtMTIxLDEwICsxMjEsMTEgQEAgcHVibGljOgog ICAgIC8vIGdyYXBoaWNzIGNvbnRleHQgdG8gcHJldmVudCBmcmVlaW5nIGludmFsaWQgcmVzb3Vy Y2VzLgogICAgIHZvaWQgZGlzY2FyZFJlc291cmNlcygpOwogCisgICAgdm9pZCBtYXJrQ29udGVu dHNDaGFuZ2VkKCkgeyBtX2NvbnRlbnRzQ2hhbmdlZCA9IHRydWU7IH0KKwogI2lmIFVTRShBQ0NF TEVSQVRFRF9DT01QT1NJVElORykKICAgICBQbGF0Zm9ybUxheWVyKiBwbGF0Zm9ybUxheWVyKCk7 CiAgICAgdm9pZCBwcmVwYXJlQmFja0J1ZmZlcigpOwotICAgIHZvaWQgbWFya0NvbnRlbnRzQ2hh bmdlZCgpIHsgbV9jb250ZW50c0NoYW5nZWQgPSB0cnVlOyB9CiAgICAgYm9vbCByZXF1aXJlc0Nv cHlGcm9tQmFja1RvRnJvbnRCdWZmZXIoKSBjb25zdDsKICAgICB1bnNpZ25lZCBmcm9udENvbG9y QnVmZmVyKCkgY29uc3Q7CiAgICAgdm9pZCBwYWludENvbXBvc2l0ZWRSZXN1bHRzVG9DYW52YXMo SW1hZ2VCdWZmZXIqKTsK