95851 2012-09-05 07:06:56 -0700 [EFL] Keep placeholder text visible until first input from user. 2012-09-06 03:47:25 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 kangil.han kangil.han gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 712017 0 kangil.han 2012-09-05 07:06:56 -0700 Current specification, http://dev.w3.org/html5/spec/single-page.html#attr-input-placeholder, has allowed user agent to keep placeholder text until first input. 712018 1 162239 kangil.han 2012-09-05 07:08:08 -0700 Created attachment 162239 patch 712031 2 162239 kenneth 2012-09-05 07:34:29 -0700 Comment on attachment 162239 patch View in context: https://bugs.webkit.org/attachment.cgi?id=162239&action=review > Source/WebCore/platform/efl/RenderThemeEfl.h:211 > + virtual bool shouldShowPlaceholderWhenFocused() const { return true; } no OVERRIDE? 712038 3 162244 kangil.han 2012-09-05 07:51:10 -0700 Created attachment 162244 patch Done! 712070 4 162244 gyuyoung.kim 2012-09-05 08:15:49 -0700 Comment on attachment 162244 patch View in context: https://bugs.webkit.org/attachment.cgi?id=162244&action=review > Source/WebCore/platform/efl/RenderThemeEfl.h:211 > + virtual bool shouldShowPlaceholderWhenFocused() const OVERRIDE { return true; } I think it is better to move this virtual function to virtual function list side. 712075 5 162244 gyuyoung.kim 2012-09-05 08:18:45 -0700 Comment on attachment 162244 patch Oops, Kenneth r+ is removed. So, I set r+ again. 712794 6 162397 kangil.han 2012-09-05 19:40:09 -0700 Created attachment 162397 patch Done! 713140 7 162397 webkit.review.bot 2012-09-06 03:47:21 -0700 Comment on attachment 162397 patch Clearing flags on attachment: 162397 Committed r127723: <http://trac.webkit.org/changeset/127723> 713141 8 webkit.review.bot 2012-09-06 03:47:25 -0700 All reviewed patches have been landed. Closing bug. 162239 2012-09-05 07:08:08 -0700 2012-09-05 07:51:10 -0700 patch placeholder.txt text/plain 1356 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZDI4ODhhLi4zYWMxYzJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDktMDUgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtFRkxdIEtlZXAgcGxhY2Vob2xkZXIgdGV4dCB2aXNpYmxlIHVudGlsIGZpcnN0IGlu cHV0IGZyb20gdXNlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk1ODUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ3VycmVudCBzcGVjaWZpY2F0aW9uLCBodHRwOi8vZGV2LnczLm9yZy9odG1sNS9zcGVj L3NpbmdsZS1wYWdlLmh0bWwjYXR0ci1pbnB1dC1wbGFjZWhvbGRlciwgaGFzIGFsbG93ZWQgdXNl ciBhZ2VudCB0byBrZWVwIHBsYWNlaG9sZGVyIHRleHQgdW50aWwgZmlyc3QgaW5wdXQuCisgICAg ICAgIFRoZXJlZm9yZSwgdGhpcyBwYXRjaCBlbmFibGVkIGl0LgorCisgICAgICAgICogcGxhdGZv cm0vZWZsL1JlbmRlclRoZW1lRWZsLmg6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUVm bDo6c2hvdWxkU2hvd1BsYWNlaG9sZGVyV2hlbkZvY3VzZWQpOgorCiAyMDEyLTA5LTA0ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEy NjEzMik6IE1lZGlhU2xpZGVyIGFuZCBNZWRpYVZvbHVtZVNsaWRlciB0aHVtYnMgZG9uJ3QgbWF0 Y2ggbW91c2Ugd2hlbiBkcmFnZ2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9lZmwvUmVuZGVyVGhlbWVFZmwuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5k ZXJUaGVtZUVmbC5oCmluZGV4IGVkNDJmMzcuLjdhYzY0MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCkBAIC0yMDgsNiArMjA4LDcgQEAgcHVibGlj OgogCiAgICAgdm9pZCBzZXRUaGVtZVBhdGgoY29uc3QgU3RyaW5nJik7CiAgICAgU3RyaW5nIHRo ZW1lUGF0aCgpIHsgcmV0dXJuIG1fdGhlbWVQYXRoOyB9CisgICAgdmlydHVhbCBib29sIHNob3Vs ZFNob3dQbGFjZWhvbGRlcldoZW5Gb2N1c2VkKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQogcHJv dGVjdGVkOgogICAgIHN0YXRpYyBmbG9hdCBkZWZhdWx0Rm9udFNpemU7CiAK 162244 2012-09-05 07:51:10 -0700 2012-09-05 19:40:09 -0700 patch placeholder_2.txt text/plain 1365 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZDI4ODhhLi4zYWMxYzJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDktMDUgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtFRkxdIEtlZXAgcGxhY2Vob2xkZXIgdGV4dCB2aXNpYmxlIHVudGlsIGZpcnN0IGlu cHV0IGZyb20gdXNlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk1ODUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ3VycmVudCBzcGVjaWZpY2F0aW9uLCBodHRwOi8vZGV2LnczLm9yZy9odG1sNS9zcGVj L3NpbmdsZS1wYWdlLmh0bWwjYXR0ci1pbnB1dC1wbGFjZWhvbGRlciwgaGFzIGFsbG93ZWQgdXNl ciBhZ2VudCB0byBrZWVwIHBsYWNlaG9sZGVyIHRleHQgdW50aWwgZmlyc3QgaW5wdXQuCisgICAg ICAgIFRoZXJlZm9yZSwgdGhpcyBwYXRjaCBlbmFibGVkIGl0LgorCisgICAgICAgICogcGxhdGZv cm0vZWZsL1JlbmRlclRoZW1lRWZsLmg6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUVm bDo6c2hvdWxkU2hvd1BsYWNlaG9sZGVyV2hlbkZvY3VzZWQpOgorCiAyMDEyLTA5LTA0ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEy NjEzMik6IE1lZGlhU2xpZGVyIGFuZCBNZWRpYVZvbHVtZVNsaWRlciB0aHVtYnMgZG9uJ3QgbWF0 Y2ggbW91c2Ugd2hlbiBkcmFnZ2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9lZmwvUmVuZGVyVGhlbWVFZmwuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5k ZXJUaGVtZUVmbC5oCmluZGV4IGVkNDJmMzcuLjhiZDY0YTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCkBAIC0yMDgsNiArMjA4LDcgQEAgcHVibGlj OgogCiAgICAgdm9pZCBzZXRUaGVtZVBhdGgoY29uc3QgU3RyaW5nJik7CiAgICAgU3RyaW5nIHRo ZW1lUGF0aCgpIHsgcmV0dXJuIG1fdGhlbWVQYXRoOyB9CisgICAgdmlydHVhbCBib29sIHNob3Vs ZFNob3dQbGFjZWhvbGRlcldoZW5Gb2N1c2VkKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gdHJ1 ZTsgfQogcHJvdGVjdGVkOgogICAgIHN0YXRpYyBmbG9hdCBkZWZhdWx0Rm9udFNpemU7CiAK 162397 2012-09-05 19:40:09 -0700 2012-09-06 03:47:21 -0700 patch placeholder_3.txt text/plain 1510 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZDI4ODhhLi4zYWMxYzJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDktMDUgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtFRkxdIEtlZXAgcGxhY2Vob2xkZXIgdGV4dCB2aXNpYmxlIHVudGlsIGZpcnN0IGlu cHV0IGZyb20gdXNlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk1ODUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ3VycmVudCBzcGVjaWZpY2F0aW9uLCBodHRwOi8vZGV2LnczLm9yZy9odG1sNS9zcGVj L3NpbmdsZS1wYWdlLmh0bWwjYXR0ci1pbnB1dC1wbGFjZWhvbGRlciwgaGFzIGFsbG93ZWQgdXNl ciBhZ2VudCB0byBrZWVwIHBsYWNlaG9sZGVyIHRleHQgdW50aWwgZmlyc3QgaW5wdXQuCisgICAg ICAgIFRoZXJlZm9yZSwgdGhpcyBwYXRjaCBlbmFibGVkIGl0LgorCisgICAgICAgICogcGxhdGZv cm0vZWZsL1JlbmRlclRoZW1lRWZsLmg6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUVm bDo6c2hvdWxkU2hvd1BsYWNlaG9sZGVyV2hlbkZvY3VzZWQpOgorCiAyMDEyLTA5LTA0ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEy NjEzMik6IE1lZGlhU2xpZGVyIGFuZCBNZWRpYVZvbHVtZVNsaWRlciB0aHVtYnMgZG9uJ3QgbWF0 Y2ggbW91c2Ugd2hlbiBkcmFnZ2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9lZmwvUmVuZGVyVGhlbWVFZmwuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5k ZXJUaGVtZUVmbC5oCmluZGV4IGVkNDJmMzcuLjZiNDMzMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCkBAIC0yMDUsNiArMjA1LDcgQEAgcHVibGlj OgogICAgIHZpcnR1YWwgYm9vbCBwYWludE1lZGlhVm9sdW1lU2xpZGVyVGh1bWIoUmVuZGVyT2Jq ZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwogICAgIHZpcnR1YWwgYm9v bCBwYWludE1lZGlhQ3VycmVudFRpbWUoUmVuZGVyT2JqZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwg Y29uc3QgSW50UmVjdCYpOwogI2VuZGlmCisgICAgdmlydHVhbCBib29sIHNob3VsZFNob3dQbGFj ZWhvbGRlcldoZW5Gb2N1c2VkKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gdHJ1ZTsgfQogCiAg ICAgdm9pZCBzZXRUaGVtZVBhdGgoY29uc3QgU3RyaW5nJik7CiAgICAgU3RyaW5nIHRoZW1lUGF0 aCgpIHsgcmV0dXJuIG1fdGhlbWVQYXRoOyB9Cg==