95843 2012-09-05 05:29:09 -0700 [CMake] Add notifications path to the WebKit2/CMakeLists.txt 2012-09-06 05:28:59 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kihong.kwon webkit-unassigned gyuyoung.kim rakuco ryuan.choi webkit.review.bot oldest_to_newest 711973 0 kihong.kwon 2012-09-05 05:29:09 -0700 Add WebCore/Modules/Notifications path to the WebKit2/CMakeLists.txt. Because there are some build errors when ENABLE_NOTIFICATIONS feature is enabled. 711977 1 162227 kihong.kwon 2012-09-05 05:31:26 -0700 Created attachment 162227 Patch 712024 2 162227 laszlo.gombos 2012-09-05 07:21:16 -0700 Comment on attachment 162227 Patch Looks good to me. Should the ChangeLog title include the [EFL] prefix as well ? 712030 3 ryuan.choi 2012-09-05 07:31:00 -0700 (In reply to comment #2) > (From update of attachment 162227 [details]) > Looks good to me. > > Should the ChangeLog title include the [EFL] prefix as well ? I think that it looks enough because CMakeLists.txt is not port specific. (although only Efl uses WebKit2 among the cmake ports) 712080 4 162227 gyuyoung.kim 2012-09-05 08:27:21 -0700 Comment on attachment 162227 Patch I also think this is not port specific. But,it looks [CMAKE] prefix is more useful. 712721 5 162384 kihong.kwon 2012-09-05 18:01:33 -0700 Created attachment 162384 Patch for landing 713188 6 162384 webkit.review.bot 2012-09-06 05:28:56 -0700 Comment on attachment 162384 Patch for landing Clearing flags on attachment: 162384 Committed r127731: <http://trac.webkit.org/changeset/127731> 713189 7 webkit.review.bot 2012-09-06 05:28:59 -0700 All reviewed patches have been landed. Closing bug. 162227 2012-09-05 05:31:26 -0700 2012-09-05 18:01:33 -0700 Patch bug-95843-20120905213108.patch text/plain 1417 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmE4MDM4MWI3MWJiZWVk NjVkYmNhZjg0YTE0Nzc2ODI2MWJhNDg3Ni4uYzg2Mjk5ZDVmNjc4NWI1M2NlNTc1MGZkMjFlNzRi NGQ5NzY4YWY2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTA1ICBLaWhv bmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtXSzJdIEFkZCBu b3RpZmljYXRpb25zIHBhdGggdG8gdGhlIFdlYktpdDIvQ01ha2VMaXN0cy50eHQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1ODQzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIFdlYkNvcmUvTW9kdWxl cy9Ob3RpZmljYXRpb25zIHRvIHRoZSBXZWJLaXQyX0lOQ0xVREVfRElSRUNUT1JJRVMgb2YgV2Vi S2l0Mi9DTWFrZUxpc3RzLnR4dC4KKyAgICAgICAgVGhlcmUgYXJlIHNvbWUgYnVpbGQgZXJyb3Jz IHdoZW4gRU5BQkxFX05PVElGSUNBVElPTlMgZmVhdHVyZSBpcyBlbmFibGVkLgorCisgICAgICAg ICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTItMDktMDUgIEthdXN0dWJoIEF0cmF3YWxrYXIgIDxr YXVzdHViaEBtb3Rvcm9sYS5jb20+CiAKICAgICAgICAgW0RSVF0gTFRDOjogTW92ZSBwcmludGlu ZyByZWxhdGVkIEFQSXMgZnJvbSBMYXlvdXRUZXN0Q29udHJvbGxlciB0byBJbnRlcm5hbHMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktpdDIv Q01ha2VMaXN0cy50eHQKaW5kZXggYzQzZGQ0YWM4ZWFmNjNlMmVmOTZkYzhjMzIyNTBiYTFhZjlm MTgzOC4uZjJiYTc0NzFiZjRlN2FmZDdlYTViOGMyYWU2Y2M1YzUzMmI5NGQxNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvQ01h a2VMaXN0cy50eHQKQEAgLTQ4LDYgKzQ4LDcgQEAgU0VUKFdlYktpdDJfSU5DTFVERV9ESVJFQ1RP UklFUwogICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL2JhdHRlcnkiCiAgICAgIiR7V0VCQ09S RV9ESVJ9L01vZHVsZXMvaW50ZW50cyIKICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9uZXR3 b3JraW5mbyIKKyAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9ub3RpZmljYXRpb25zIgogICAg ICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL3ZpYnJhdGlvbiIKICAgICAiJHtXRUJDT1JFX0RJUn0v YWNjZXNzaWJpbGl0eSIKICAgICAiJHtXRUJDT1JFX0RJUn0vYmluZGluZ3MvanMiCg== 162384 2012-09-05 18:01:33 -0700 2012-09-06 05:28:55 -0700 Patch for landing patch text/plain 1258 kihong.kwon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktp dDIvQ01ha2VMaXN0cy50eHQKaW5kZXggYzQzZGQ0YS4uZjJiYTc0NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0 cy50eHQKQEAgLTQ4LDYgKzQ4LDcgQEAgU0VUKFdlYktpdDJfSU5DTFVERV9ESVJFQ1RPUklFUwog ICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL2JhdHRlcnkiCiAgICAgIiR7V0VCQ09SRV9ESVJ9 L01vZHVsZXMvaW50ZW50cyIKICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9uZXR3b3JraW5m byIKKyAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9ub3RpZmljYXRpb25zIgogICAgICIke1dF QkNPUkVfRElSfS9Nb2R1bGVzL3ZpYnJhdGlvbiIKICAgICAiJHtXRUJDT1JFX0RJUn0vYWNjZXNz aWJpbGl0eSIKICAgICAiJHtXRUJDT1JFX0RJUn0vYmluZGluZ3MvanMiCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZmE4MDM4MS4uY2YyYzU0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTA1 ICBLaWhvbmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtDTWFr ZV0gQWRkIG5vdGlmaWNhdGlvbnMgcGF0aCB0byB0aGUgV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU4NDMKKwor ICAgICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29tYm9zLgorCisgICAgICAgIEFkZCBXZWJDb3Jl L01vZHVsZXMvTm90aWZpY2F0aW9ucyB0byB0aGUgV2ViS2l0Ml9JTkNMVURFX0RJUkVDVE9SSUVT IG9mIFdlYktpdDIvQ01ha2VMaXN0cy50eHQuCisgICAgICAgIFRoZXJlIGFyZSBzb21lIGJ1aWxk IGVycm9ycyB3aGVuIEVOQUJMRV9OT1RJRklDQVRJT05TIGZlYXR1cmUgaXMgZW5hYmxlZC4KKwor ICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDEyLTA5LTA1ICBLYXVzdHViaCBBdHJhd2Fs a2FyICA8a2F1c3R1YmhAbW90b3JvbGEuY29tPgogCiAgICAgICAgIFtEUlRdIExUQzo6IE1vdmUg cHJpbnRpbmcgcmVsYXRlZCBBUElzIGZyb20gTGF5b3V0VGVzdENvbnRyb2xsZXIgdG8gSW50ZXJu YWxzCg==