95828 2012-09-05 01:10:46 -0700 [EFL] Remove unnecessary logic in ewk_frame_source_get. 2012-09-06 07:51:17 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 kangil.han kangil.han g.czajkowski gyuyoung.kim kenneth lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 711825 0 kangil.han 2012-09-05 01:10:46 -0700 ewk_frame_source_get has unnecessary logic that has never been used in any case. 713199 1 162483 kangil.han 2012-09-06 05:45:09 -0700 Created attachment 162483 patch 713218 2 162483 rakuco 2012-09-06 06:13:18 -0700 Comment on attachment 162483 patch Could we have a test for this? 713243 3 kangil.han 2012-09-06 06:34:47 -0700 (In reply to comment #2) > (From update of attachment 162483 [details]) > Could we have a test for this? This patch doesn't create a new API. Rather it removed unnecessary source lines in existing WK1 API, found while removing '+=' usage in String. See BUG 95808. :-) 713248 4 kenneth 2012-09-06 06:36:50 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 162483 [details] [details]) > > Could we have a test for this? > > This patch doesn't create a new API. > Rather it removed unnecessary source lines in existing WK1 API, found while removing '+=' usage in String. See BUG 95808. > :-) Still this can be tested. Like add a test not adding <html> etc and show that it still works. 713277 5 162483 webkit.review.bot 2012-09-06 07:38:07 -0700 Comment on attachment 162483 patch Clearing flags on attachment: 162483 Committed r127740: <http://trac.webkit.org/changeset/127740> 713278 6 webkit.review.bot 2012-09-06 07:38:11 -0700 All reviewed patches have been landed. Closing bug. 713282 7 ryuan.choi 2012-09-06 07:51:17 -0700 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 162483 [details] [details] [details]) > > > Could we have a test for this? > > > > This patch doesn't create a new API. > > Rather it removed unnecessary source lines in existing WK1 API, found while removing '+=' usage in String. See BUG 95808. > > :-) > > Still this can be tested. Like add a test not adding <html> etc and show that it still works. I agree with you. we need to test this. But I think that wk1 test framework should be improved. I think that we can create new bug for it now and make test case after bug 94925 landed. 162483 2012-09-06 05:45:09 -0700 2012-09-06 07:38:07 -0700 patch ewk_frame_source_get.txt text/plain 1596 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBiN2Y4YjE1Li5kYTdmYTBlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDktMDYgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtFRkxdIFJlbW92ZSB1bm5lY2Vzc2FyeSBsb2dpYyBpbiBld2tf ZnJhbWVfc291cmNlX2dldC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk1ODI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVtb3ZlZCB1bm5lY2Vzc2FyeSBsb2dpYyB0aGF0IGNoZWNrcyBpZiA8aHRtbD4g dGFnIGV4aXN0cyBpbiBkb2N1bWVudC4KKyAgICAgICAgV2ViS2l0IGF1dG9tYXRpY2FsbHkgZmls bCBvdXQgPGh0bWw+PC9odG1sPiB0YWdzIGlmIHRoZXkgYXJlIG5vdCBleGlzdGVkLgorCisgICAg ICAgICogZXdrL2V3a19mcmFtZS5jcHA6CisgICAgICAgIChld2tfZnJhbWVfc291cmNlX2dldCk6 CisKIDIwMTItMDktMDUgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgogCiAg ICAgICAgIFtFRkxdIFJlbW92ZSAnKz0nIHVzYWdlIGluIFN0cmluZwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX2ZyYW1lLmNwcAppbmRleCA2OGYyNjkwLi5lMmU1Zjc1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX2ZyYW1lLmNwcApAQCAtMTY1OSwxNSArMTY1OSw2IEBAIHNzaXplX3QgZXdrX2ZyYW1lX3Nv dXJjZV9nZXQoY29uc3QgRXZhc19PYmplY3QqIGV3a0ZyYW1lLCBjaGFyKiogZnJhbWVTb3VyY2Up CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAotICAgIC8vIFRyeSB0byBnZXQgPGhlYWQ+IGFu ZCA8Ym9keT4gdGFncyBpZiA8aHRtbD4gdGFnIHdhcyBub3QgZm91bmQuCi0gICAgaWYgKGJ1aWxk ZXIuaXNFbXB0eSgpKSB7Ci0gICAgICAgIGlmIChzbWFydERhdGEtPmZyYW1lLT5kb2N1bWVudCgp LT5oZWFkKCkpCi0gICAgICAgICAgICBidWlsZGVyLmFwcGVuZChzbWFydERhdGEtPmZyYW1lLT5k b2N1bWVudCgpLT5oZWFkKCktPm91dGVySFRNTCgpKTsKLQotICAgICAgICBpZiAoc21hcnREYXRh LT5mcmFtZS0+ZG9jdW1lbnQoKS0+Ym9keSgpKQotICAgICAgICAgICAgYnVpbGRlci5hcHBlbmQo c21hcnREYXRhLT5mcmFtZS0+ZG9jdW1lbnQoKS0+Ym9keSgpLT5vdXRlckhUTUwoKSk7Ci0gICAg fQotCiAgICAgQ1N0cmluZyB1dGY4U3RyaW5nID0gYnVpbGRlci50b1N0cmluZygpLnV0ZjgoKTsK ICAgICBzaXplX3Qgc291cmNlTGVuZ3RoID0gdXRmOFN0cmluZy5sZW5ndGgoKTsKICAgICAqZnJh bWVTb3VyY2UgPSBzdGF0aWNfY2FzdDxjaGFyKj4obWFsbG9jKHNvdXJjZUxlbmd0aCArIDEpKTsK