95824 2012-09-05 00:18:23 -0700 Test cases for Up/Down key behavior on field which has maximum/minimum in multiple fields time input UI 2012-09-05 00:55:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin tkent oldest_to_newest 711786 0 yosin 2012-09-05 00:18:23 -0700 There is no test cases for this edge case. 711793 1 162175 yosin 2012-09-05 00:33:50 -0700 Created attachment 162175 Patch 1 711794 2 162175 yosin 2012-09-05 00:34:17 -0700 Comment on attachment 162175 Patch 1 Could you review this patch? Thanks in advance. 711795 3 162175 tkent 2012-09-05 00:36:45 -0700 Comment on attachment 162175 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=162175&action=review > LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:113 > +beginTest('Up/Down keys on maximum value', '12:59:59.999'); Up/Down keys -> Up key > LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:123 > +beginTest('Up/Down keys on minimum value', '01:00'); Up/Down keys -> Down key 711809 4 162179 yosin 2012-09-05 00:53:39 -0700 Created attachment 162179 Patch 2 711812 5 162179 yosin 2012-09-05 00:55:42 -0700 Comment on attachment 162179 Patch 2 Clearing flags on attachment: 162179 Committed r127562: <http://trac.webkit.org/changeset/127562> 711813 6 yosin 2012-09-05 00:55:46 -0700 All reviewed patches have been landed. Closing bug. 162175 2012-09-05 00:33:50 -0700 2012-09-05 00:53:36 -0700 Patch 1 bug-95824-20120905163332.patch text/plain 3431 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NTU1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzljNjRkNDA4ZmVhNzY1YjRjNWQ4 NmUzMTFjMzQ5NWY1NzAyNDk5Zi4uNTQ4NmM4NjU4NmQ0MTQyZjA5NDU2NTEwNTcyMzYyNzBkMGZl M2RhNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTA1ICBZb3NoaWZ1bWkgSW5vdWUg IDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVGVzdCBjYXNlcyBmb3IgVXAvRG93biBr ZXkgYmVoYXZpb3Igb24gZmllbGQgd2hpY2ggaGFzIG1heGltdW0vbWluaW11bSBpbiBtdWx0aXBs ZSBmaWVsZHMgdGltZSBpbnB1dCBVSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTU4MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgdGVzdCBjYXNlcyBmb3IgVXAvRG93biBrZXkg YmVoYXZpb3Igb24gZmllbGQgd2hpY2ggaGFzCisgICAgICAgIG1heGltdW0vbWluaW11bSB2YWx1 ZSBpbiBtdWx0aXBsZSBmaWVsZHMgdGltZSBpbnB1dCBVSS4KKworICAgICAgICBUaGlzIHBhdGNo IGFmZmVjdHMgcG9ydHMgd2hpY2ggZW5hYmxlIGJvdGggRU5BQkxFX0lOUFVUX1RZUEVfVElNRSBh bmQKKyAgICAgICAgRU5BQkxFX0lOUFVUX1RZUEVfVElNRV9NVUxUSVBMRV9GSUVMRFMuCisKKyAg ICAgICAgKiBmYXN0L2Zvcm1zL3RpbWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmll bGRzLWtleWJvYXJkLWV2ZW50cy1leHBlY3RlZC50eHQ6IFVwZGF0ZWQgZXhwZWN0YXRpb24gZm9y IG5ldyB0ZXN0IGNhc2VzLgorICAgICAgICAqIGZhc3QvZm9ybXMvdGltZS1tdWx0aXBsZS1maWVs ZHMvdGltZS1tdWx0aXBsZS1maWVsZHMta2V5Ym9hcmQtZXZlbnRzLmh0bWw6IENoYW5nZWQgdG8g YWRkIHRlc3QgY2FzZXMgZm9yIFVwIGtleSBiZWhhdmlvciBmb3IgIjIzOjU5OjU5Ljk5OSIgKDEx OjU5OjU5Ljk5OVBNIGluIFVJKSBhbmQgRG93biBrZXkgYmVoYXZpb3IgZm9yICIwMTowMDowMC4w MDAiICgwMTowMDowMC4wMDAgQU0gaW4gVUkpCisKIDIwMTItMDktMDQgIEtlaXNoaSBIYXR0b3Jp ICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTI2MTMyKTogTWVk aWFTbGlkZXIgYW5kIE1lZGlhVm9sdW1lU2xpZGVyIHRodW1icyBkb24ndCBtYXRjaCBtb3VzZSB3 aGVuIGRyYWdnZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvdGltZS1tdWx0 aXBsZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVsZHMta2V5Ym9hcmQtZXZlbnRzLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGltZS1t dWx0aXBsZS1maWVsZHMta2V5Ym9hcmQtZXZlbnRzLWV4cGVjdGVkLnR4dAppbmRleCAyZjM5NWIy NTc2MTc2MmNjYWU5MzQzYzgzZTBkNDE0YzQ4ZWVmMDFhLi45ZjI2NjI4MTI1MWViZDk4NGRiOTgy MDIyYTI4NGJiYTU2OGVjMmU5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Rp bWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLWtleWJvYXJkLWV2ZW50cy1l eHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1lLW11bHRpcGxlLWZp ZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1rZXlib2FyZC1ldmVudHMtZXhwZWN0ZWQudHh0CkBA IC0zMCw2ICszMCwxMCBAQCBQQVNTIGRvY3VtZW50LmFjdGl2ZUVsZW1lbnQuaWQgaXMgImFub3Ro ZXIiCiBQQVNTIGlucHV0LnZhbHVlIGlzICIxNTowMCIKIFBBU1MgaW5wdXQudmFsdWUgaXMgIjE1 OjAzIgogUEFTUyBkb2N1bWVudC5hY3RpdmVFbGVtZW50LmlkIGlzICJiZWZvcmUiCis9PSBVcC9E b3duIGtleXMgb24gbWF4aW11bSB2YWx1ZSA9PQorUEFTUyBpbnB1dC52YWx1ZSBpcyAiMTM6MDAi Cis9PSBVcC9Eb3duIGtleXMgb24gbWluaW11bSB2YWx1ZSA9PQorUEFTUyBpbnB1dC52YWx1ZSBp cyAiMDA6NTk6NTkuOTk5IgogPT0gQmFja3NwYWNlIGtleSA9PQogUEFTUyBpbnB1dC52YWx1ZSBp cyAiIgogPT0gRGVsZXRlIGtleSA9PQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy90aW1lLW11bHRpcGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1rZXlib2FyZC1ldmVu dHMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGlt ZS1tdWx0aXBsZS1maWVsZHMta2V5Ym9hcmQtZXZlbnRzLmh0bWwKaW5kZXggMmFhNjkyZWViYmE2 MWU5YWI4YzMzNmU2NjAwMDZhMjMzODZkZDBlMS4uMWJkNmFiM2NjYmM1MGQyNjU1YWNkYjAwOGM0 OGZmYTVhMjQ2MGJjYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1lLW11 bHRpcGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1rZXlib2FyZC1ldmVudHMuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RpbWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVs dGlwbGUtZmllbGRzLWtleWJvYXJkLWV2ZW50cy5odG1sCkBAIC0xMTAsNiArMTEwLDI4IEBAIGtl eURvd24oJ1x0JywgWydzaGlmdEtleSddKTsKIGtleURvd24oJ1x0JywgWydzaGlmdEtleSddKTsK IHNob3VsZEJlRXF1YWxUb1N0cmluZygnZG9jdW1lbnQuYWN0aXZlRWxlbWVudC5pZCcsICdiZWZv cmUnKTsKIAorYmVnaW5UZXN0KCdVcC9Eb3duIGtleXMgb24gbWF4aW11bSB2YWx1ZScsICcxMjo1 OTo1OS45OTknKTsKK2tleURvd24oJ3VwQXJyb3cnKTsKK2tleURvd24oJ1x0Jyk7CitrZXlEb3du KCd1cEFycm93Jyk7CitrZXlEb3duKCdcdCcpOwora2V5RG93bigndXBBcnJvdycpOwora2V5RG93 bignXHQnKTsKK2tleURvd24oJ3VwQXJyb3cnKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygnaW5w dXQudmFsdWUnLCAnMTM6MDAnKTsKKworYmVnaW5UZXN0KCdVcC9Eb3duIGtleXMgb24gbWluaW11 bSB2YWx1ZScsICcwMTowMCcpOworaW5wdXQuc3RlcCA9IDAuMDAxOwora2V5RG93bignZG93bkFy cm93Jyk7CitrZXlEb3duKCdcdCcpOwora2V5RG93bignZG93bkFycm93Jyk7CitrZXlEb3duKCdc dCcpOwora2V5RG93bignZG93bkFycm93Jyk7CitrZXlEb3duKCdcdCcpOwora2V5RG93bignZG93 bkFycm93Jyk7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2lucHV0LnZhbHVlJywgJzAwOjU5OjU5 Ljk5OScpOworaW5wdXQuc3RlcCA9IDYwOworCiBiZWdpblRlc3QoJ0JhY2tzcGFjZSBrZXknLCAn MTI6MzQnKTsKIGtleURvd24oIlxiIik7CiBzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2lucHV0LnZh bHVlJywgJycpOwo= 162179 2012-09-05 00:53:39 -0700 2012-09-05 00:55:42 -0700 Patch 2 bug-95824-20120905165321.patch text/plain 3408 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NTU1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzljNjRkNDA4ZmVhNzY1YjRjNWQ4 NmUzMTFjMzQ5NWY1NzAyNDk5Zi4uZDY1ODgzMmYyMzE2ZTM3ODE0Mjk2ZDM4N2JlNWVmYWM4ZDMy YzlmYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTA1ICBZb3NoaWZ1bWkgSW5vdWUg IDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVGVzdCBjYXNlcyBmb3IgVXAvRG93biBr ZXkgYmVoYXZpb3Igb24gZmllbGQgd2hpY2ggaGFzIG1heGltdW0vbWluaW11bSBpbiBtdWx0aXBs ZSBmaWVsZHMgdGltZSBpbnB1dCBVSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTU4MjQKKworICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4K KworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgdGVzdCBjYXNlcyBmb3IgVXAvRG93biBrZXkgYmVo YXZpb3Igb24gZmllbGQgd2hpY2ggaGFzCisgICAgICAgIG1heGltdW0vbWluaW11bSB2YWx1ZSBp biBtdWx0aXBsZSBmaWVsZHMgdGltZSBpbnB1dCBVSS4KKworICAgICAgICBUaGlzIHBhdGNoIGFm ZmVjdHMgcG9ydHMgd2hpY2ggZW5hYmxlIGJvdGggRU5BQkxFX0lOUFVUX1RZUEVfVElNRSBhbmQK KyAgICAgICAgRU5BQkxFX0lOUFVUX1RZUEVfVElNRV9NVUxUSVBMRV9GSUVMRFMuCisKKyAgICAg ICAgKiBmYXN0L2Zvcm1zL3RpbWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRz LWtleWJvYXJkLWV2ZW50cy1leHBlY3RlZC50eHQ6IFVwZGF0ZWQgZXhwZWN0YXRpb24gZm9yIG5l dyB0ZXN0IGNhc2VzLgorICAgICAgICAqIGZhc3QvZm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMv dGltZS1tdWx0aXBsZS1maWVsZHMta2V5Ym9hcmQtZXZlbnRzLmh0bWw6IENoYW5nZWQgdG8gYWRk IHRlc3QgY2FzZXMgZm9yIFVwIGtleSBiZWhhdmlvciBmb3IgIjIzOjU5OjU5Ljk5OSIgKDExOjU5 OjU5Ljk5OVBNIGluIFVJKSBhbmQgRG93biBrZXkgYmVoYXZpb3IgZm9yICIwMTowMDowMC4wMDAi ICgwMTowMDowMC4wMDAgQU0gaW4gVUkpCisKIDIwMTItMDktMDQgIEtlaXNoaSBIYXR0b3JpICA8 a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTI2MTMyKTogTWVkaWFT bGlkZXIgYW5kIE1lZGlhVm9sdW1lU2xpZGVyIHRodW1icyBkb24ndCBtYXRjaCBtb3VzZSB3aGVu IGRyYWdnZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvdGltZS1tdWx0aXBs ZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVsZHMta2V5Ym9hcmQtZXZlbnRzLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGltZS1tdWx0 aXBsZS1maWVsZHMta2V5Ym9hcmQtZXZlbnRzLWV4cGVjdGVkLnR4dAppbmRleCAyZjM5NWIyNTc2 MTc2MmNjYWU5MzQzYzgzZTBkNDE0YzQ4ZWVmMDFhLi5iZGI1OWZkOTI0NGQyNTk1ZmI2YWVkMWYz YWQ1MWQ3MzlhZGFiMDlhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RpbWUt bXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLWtleWJvYXJkLWV2ZW50cy1leHBl Y3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1lLW11bHRpcGxlLWZpZWxk cy90aW1lLW11bHRpcGxlLWZpZWxkcy1rZXlib2FyZC1ldmVudHMtZXhwZWN0ZWQudHh0CkBAIC0z MCw2ICszMCwxMCBAQCBQQVNTIGRvY3VtZW50LmFjdGl2ZUVsZW1lbnQuaWQgaXMgImFub3RoZXIi CiBQQVNTIGlucHV0LnZhbHVlIGlzICIxNTowMCIKIFBBU1MgaW5wdXQudmFsdWUgaXMgIjE1OjAz IgogUEFTUyBkb2N1bWVudC5hY3RpdmVFbGVtZW50LmlkIGlzICJiZWZvcmUiCis9PSBVcCBrZXkg b24gbWF4aW11bSB2YWx1ZSA9PQorUEFTUyBpbnB1dC52YWx1ZSBpcyAiMTM6MDAiCis9PSBEb3du IGtleSBvbiBtaW5pbXVtIHZhbHVlID09CitQQVNTIGlucHV0LnZhbHVlIGlzICIwMDo1OTo1OS45 OTkiCiA9PSBCYWNrc3BhY2Uga2V5ID09CiBQQVNTIGlucHV0LnZhbHVlIGlzICIiCiA9PSBEZWxl dGUga2V5ID09CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RpbWUtbXVsdGlw bGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLWtleWJvYXJkLWV2ZW50cy5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1lLW11bHRpcGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZp ZWxkcy1rZXlib2FyZC1ldmVudHMuaHRtbAppbmRleCAyYWE2OTJlZWJiYTYxZTlhYjhjMzM2ZTY2 MDAwNmEyMzM4NmRkMGUxLi4zOTg1YzIzNjQyMTgyMTYxMDJhMGEwMDc5MzE4NGFhNmYxNTg5NjI3 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RpbWUtbXVsdGlwbGUtZmllbGRz L3RpbWUtbXVsdGlwbGUtZmllbGRzLWtleWJvYXJkLWV2ZW50cy5odG1sCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvZm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVsZHMt a2V5Ym9hcmQtZXZlbnRzLmh0bWwKQEAgLTExMCw2ICsxMTAsMjggQEAga2V5RG93bignXHQnLCBb J3NoaWZ0S2V5J10pOwoga2V5RG93bignXHQnLCBbJ3NoaWZ0S2V5J10pOwogc2hvdWxkQmVFcXVh bFRvU3RyaW5nKCdkb2N1bWVudC5hY3RpdmVFbGVtZW50LmlkJywgJ2JlZm9yZScpOwogCitiZWdp blRlc3QoJ1VwIGtleSBvbiBtYXhpbXVtIHZhbHVlJywgJzEyOjU5OjU5Ljk5OScpOwora2V5RG93 bigndXBBcnJvdycpOwora2V5RG93bignXHQnKTsKK2tleURvd24oJ3VwQXJyb3cnKTsKK2tleURv d24oJ1x0Jyk7CitrZXlEb3duKCd1cEFycm93Jyk7CitrZXlEb3duKCdcdCcpOwora2V5RG93bign dXBBcnJvdycpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdpbnB1dC52YWx1ZScsICcxMzowMCcp OworCitiZWdpblRlc3QoJ0Rvd24ga2V5IG9uIG1pbmltdW0gdmFsdWUnLCAnMDE6MDAnKTsKK2lu cHV0LnN0ZXAgPSAwLjAwMTsKK2tleURvd24oJ2Rvd25BcnJvdycpOwora2V5RG93bignXHQnKTsK K2tleURvd24oJ2Rvd25BcnJvdycpOwora2V5RG93bignXHQnKTsKK2tleURvd24oJ2Rvd25BcnJv dycpOwora2V5RG93bignXHQnKTsKK2tleURvd24oJ2Rvd25BcnJvdycpOworc2hvdWxkQmVFcXVh bFRvU3RyaW5nKCdpbnB1dC52YWx1ZScsICcwMDo1OTo1OS45OTknKTsKK2lucHV0LnN0ZXAgPSA2 MDsKKwogYmVnaW5UZXN0KCdCYWNrc3BhY2Uga2V5JywgJzEyOjM0Jyk7CiBrZXlEb3duKCJcYiIp Owogc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdpbnB1dC52YWx1ZScsICcnKTsK