95820 2012-09-04 22:46:38 -0700 [BlackBerry] Remove feature about:cache/disable and about:cache/enable 2012-09-07 10:09:27 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Unspecified RESOLVED FIXED P2 Normal --- 0 jasonliuwebkit rwlbuis mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 711734 0 jasonliuwebkit 2012-09-04 22:46:38 -0700 Remove this feature since we need to add a button in settings. 711739 1 162162 jasonliuwebkit 2012-09-04 22:50:49 -0700 Created attachment 162162 Patch 711930 2 162162 rwlbuis 2012-09-05 04:16:44 -0700 Comment on attachment 162162 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162162&action=review Ok. > Source/WebKit/blackberry/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Any internal Pr or reviewer? If so state them here please. 712034 3 yong.li.webkit 2012-09-05 07:44:54 -0700 (In reply to comment #0) > Remove this feature since we need to add a button in settings. is the button ready yet? 712760 4 jasonliuwebkit 2012-09-05 18:53:57 -0700 (In reply to comment #3) > (In reply to comment #0) > > Remove this feature since we need to add a button in settings. > > is the button ready yet? Yes, it is ready. 712779 5 162162 webkit.review.bot 2012-09-05 19:12:20 -0700 Comment on attachment 162162 Patch Clearing flags on attachment: 162162 Committed r127680: <http://trac.webkit.org/changeset/127680> 712781 6 webkit.review.bot 2012-09-05 19:12:23 -0700 All reviewed patches have been landed. Closing bug. 714568 7 rwlbuis 2012-09-07 08:58:09 -0700 Reopening to attach new patch. 714569 8 162784 rwlbuis 2012-09-07 08:58:11 -0700 Created attachment 162784 Patch 714655 9 rwlbuis 2012-09-07 10:09:27 -0700 Committed r127881: <http://trac.webkit.org/changeset/127881> 162162 2012-09-04 22:50:49 -0700 2012-09-07 08:58:03 -0700 Patch bug-95820-20120905135029.patch text/plain 1892 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBhZTkyZGMwNmMzMGIxOGU3ZTdkYzliNGIzM2M4YzZjODY1NjQ1ODY2Li5lOTNiNTIwMzUz NDJjYzRmZmMxZmQxZTllZGVhZjk2NzIxMzY5YjIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOS0wNCAgSmFzb24gTGl1ICA8amFzb24ubGl1 QHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gUmVtb3ZlIGZlYXR1 cmUgYWJvdXQ6Y2FjaGUvZGlzYWJsZSBhbmQgYWJvdXQ6Y2FjaGUvZW5hYmxlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTgyMAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB0aGlzIGZlYXR1cmUg c2luY2Ugd2UgbmVlZCB0byBhZGQgYSBidXR0b24gaW4gc2V0dGluZ3MuCisKKyAgICAgICAgKiBX ZWJLaXRTdXBwb3J0L0Fib3V0RGF0YS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6 OmNhY2hlUGFnZSk6CisKIDIwMTItMDktMDQgIFJvYiBCdWlzICA8cmJ1aXNAcmltLmNvbT4KIAog ICAgICAgICBbQmxhY2tCZXJyeV0gRmF0RmluZ2Vyczo6Y2FjaGluZ1N0cmF0ZWd5IHVzZXMgaW5j b3JyZWN0IGVudW0gdmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJLaXRTdXBwb3J0L0Fib3V0RGF0YS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9BYm91dERhdGEuY3BwCmluZGV4IDk1N2Q3NDMzNjE1ZjRkYzhhNGZmYmI4NjM1 YzIxNTE3NTFhYTRlMjUuLjE3YzQxNDY0YzEwNzcxZjgzOGZhNTc3ZTc0YjgyOWQ4NDUyOTU1OGMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0Fib3V0 RGF0YS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvQWJv dXREYXRhLmNwcApAQCAtNDY3LDE3ICs0NjcsNyBAQCBzdGF0aWMgU3RyaW5nIGNhY2hlUGFnZShT dHJpbmcgY2FjaGVDb21tYW5kKQogICAgICAgICByZXN1bHQuYXBwZW5kKFN0cmluZyhrZXkuZGF0 YSgpKSk7CiAgICAgICAgIHJlc3VsdC5hcHBlbmQoU3RyaW5nKCI8aHI+IikpOwogICAgICAgICBy ZXN1bHQuYXBwZW5kKFN0cmluZyhCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6Z2VuZXJhdGVIdG1sRnJh Z21lbnRGb3JDYWNoZUhlYWRlcnMoa2V5KS5kYXRhKCkpKTsKLSAgICB9Ci0jaWYgIWRlZmluZWQo UFVCTElDX0JVSUxEKSB8fCAhUFVCTElDX0JVSUxECi0gICAgZWxzZSBpZiAoZXF1YWxJZ25vcmlu Z0Nhc2UoY2FjaGVDb21tYW5kLCAiL2Rpc2FibGUiKSkgewotICAgICAgICBzZXR0aW5ncy0+c2V0 RGlza0NhY2hlRW5hYmxlZChmYWxzZSk7Ci0gICAgICAgIHJlc3VsdC5hcHBlbmQoIkh0dHAgZGlz ayBjYWNoZSBpcyBkaXNhYmxlZC4iKTsKLSAgICB9IGVsc2UgaWYgKGVxdWFsSWdub3JpbmdDYXNl KGNhY2hlQ29tbWFuZCwgIi9lbmFibGUiKSkgewotICAgICAgICBzZXR0aW5ncy0+c2V0RGlza0Nh Y2hlRW5hYmxlZCh0cnVlKTsKLSAgICAgICAgcmVzdWx0LmFwcGVuZCgiSHR0cCBkaXNrIGNhY2hl IGlzIGVuYWJsZWQuIik7Ci0gICAgfQotI2VuZGlmCi0gICAgZWxzZSB7CisgICAgfSBlbHNlIHsK ICAgICAgICAgLy8gVW5rbm93biBjYWNoZSBjb21tYW5kLgogICAgICAgICByZXR1cm4gU3RyaW5n KCk7CiAgICAgfQo= 162784 2012-09-07 08:58:11 -0700 2012-09-07 09:34:27 -0700 Patch bug-95820-20120907120045.patch text/plain 1581 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3ODcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4ZmMwZmQwZWMzNDQyYTVkNDJhZjAzMGRkNTY2ODBjMDBkZGM1YTdkLi5iZTkxNjVjYWNh OWRjNDBhODY0ZTY4YTk4ZWVkZmZiZGZlOWMwYjQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOS0wNyAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBSZW1vdmUgZmVhdHVyZSBhYm91dDpjYWNoZS9k aXNhYmxlIGFuZCBhYm91dDpjYWNoZS9lbmFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk1ODIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRml4IHdhcm5pbmcgdGhhdCB3YXMgY2F1c2VkIGJ5IHIxMjc2 ODAuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0Fib3V0RGF0YS5jcHA6CisgICAgICAgIChC bGFja0JlcnJ5OjpXZWJLaXQ6OmNhY2hlUGFnZSk6CisKIDIwMTItMDktMDcgIFJvYmluIENhbyAg PHJvYmluLmNhb0B0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFJl bmRlcmluZyBpc3N1ZSBhZnRlciByb3RhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvQWJvdXREYXRhLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L0Fib3V0RGF0YS5jcHAKaW5kZXggMTdjNDE0NjRjMTA3NzFm ODM4ZmE1NzdlNzRiODI5ZDg0NTI5NTU4Yy4uMDM5MDMyNDIzNDAyMWE0MTE5NTU2ZDk1N2UzNTkx MjVmMDc0ZmVkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvQWJvdXREYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9BYm91dERhdGEuY3BwCkBAIC00NTcsOSArNDU3LDYgQEAgc3RhdGljIFN0cmluZyBj YWNoZVBhZ2UoU3RyaW5nIGNhY2hlQ29tbWFuZCkKIAogICAgIHJlc3VsdC5hcHBlbmQoU3RyaW5n KCI8aHRtbD48aGVhZD48dGl0bGU+QmxhY2tCZXJyeSBCcm93c2VyIERpc2sgQ2FjaGU8L3RpdGxl PjwvaGVhZD48Ym9keT4iKSk7CiAKLSAgICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U2V0dGluZ3Mq IHNldHRpbmdzID0gQmxhY2tCZXJyeTo6UGxhdGZvcm06OlNldHRpbmdzOjppbnN0YW5jZSgpOwot ICAgIEFTU0VSVChzZXR0aW5ncyk7Ci0KICAgICBpZiAoY2FjaGVDb21tYW5kLmlzRW1wdHkoKSkK ICAgICAgICAgcmVzdWx0LmFwcGVuZChTdHJpbmcoQmxhY2tCZXJyeTo6UGxhdGZvcm06OmdlbmVy YXRlSHRtbEZyYWdtZW50Rm9yQ2FjaGVLZXlzKCkuZGF0YSgpKSk7CiAgICAgZWxzZSBpZiAoY2Fj aGVDb21tYW5kLnN0YXJ0c1dpdGgoIj9xdWVyeT0iLCBmYWxzZSkpIHsK