95819 2012-09-04 22:44:03 -0700 [chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test 2012-09-05 19:07:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth enne fishd webkit.review.bot oldest_to_newest 711730 0 jamesr 2012-09-04 22:44:03 -0700 [chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test 711732 1 162160 jamesr 2012-09-04 22:45:17 -0700 Created attachment 162160 Patch 711737 2 jamesr 2012-09-04 22:49:00 -0700 The test value here is marginal, but this is important for the component build in a rather convoluted way. When use_libcc_for_compositor=1, the implementations of the Web*Layer::create() family of static functions are in a static_library webkit/compositor_bindings/compositor_bindings.gyp:webkit_compositor_bindings instead of in a bunch of .cpp files in the webkit sources list. Because of this, these symbols are linked into a separate lib that is then linked into webkit.dll. If any symbols from this .lib are completely unreferenced, they're dropped from webkit.dll even if they have WEBKIT_EXPORT set on them. The fixes are to explicitly pull these in by either a linker flag (like -force_load, /INCLUDE, or /DEF) or to make sure they're referenced in webkit.dll. Since we link the unit tests into webkit.dll, that appears to do the trick. 712180 3 162160 abarth 2012-09-05 10:15:03 -0700 Comment on attachment 162160 Patch That seems a bit hacky, but ok. 712228 4 jamesr 2012-09-05 10:34:56 -0700 More than a bit! The test coverage is marginally useful on its own, though. 712776 5 162160 webkit.review.bot 2012-09-05 19:07:17 -0700 Comment on attachment 162160 Patch Clearing flags on attachment: 162160 Committed r127678: <http://trac.webkit.org/changeset/127678> 712777 6 webkit.review.bot 2012-09-05 19:07:21 -0700 All reviewed patches have been landed. Closing bug. 162160 2012-09-04 22:45:17 -0700 2012-09-05 19:07:17 -0700 Patch bug-95819-20120904224500.patch text/plain 2426 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3Mzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQ1ZTQxOGRjM2U1MjFmZDE4NDQ0ODZhOWU2Y2VlNGExMWEyMjExMmQuLjg5MjMwYjY0MDgzYTRk MTQ3NTE3NmFlYWNiNTQ4MmVhMDE0YmVmYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDktMDQgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIFRlc3QgV2ViU29saWRDb2xvckxheWVyIGlu IFdlYkxheWVyVGVzdC5DbGllbnQgdW5pdCB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTgxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgdW5pdCB0ZXN0IGRvZXNuJ3QgZG8gYWxsIHRoYXQg bXVjaCwgYnV0IGl0IGRvZXMgdmVyaWZ5IHRoYXQgV2ViU29saWRDb2xvckxheWVyIGRvZXNuJ3Qg Y29tcGxldGVseSBleHBsb2RlCisgICAgICAgIHVwb24gdXNlIGFuZCBhbHNvIG1ha2VzIHN1cmUg dGhhdCB0aGUgV2ViU29saWRDb2xvckxheWVyOjpjcmVhdGUoKSBzeW1ib2wgaXMgcmVmZXJlbmNl ZCBhbmQgbm90IGRyb3BwZWQgZnJvbQorICAgICAgICB3ZWJraXQuZGxsIGluIHRoZSBjb21wb25l bnQgYnVpbGQuCisKKyAgICAgICAgKiB0ZXN0cy9XZWJMYXllclRlc3QuY3BwOgorCiAyMDEyLTA5 LTAxICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5y ZXZpZXdlZCBjaHJvbWl1bSBidWlsZGZpeCB3aGVuIHVzZV9saWJjY19mb3JfY29tcG9zaXRvcj0x CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkxheWVyVGVzdC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkxheWVyVGVzdC5jcHAKaW5kZXgg ODBhMTAzMWZiNjJjYTc2MjMwMDM0MDU1ZWE3YWQ0ZDNiN2JkNzQ5NS4uZTc2NDkxNzZkZTE4YWNl Y2I2ODNlMDE5MjcxNDk5OGM5NTQ5NTE4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS90ZXN0cy9XZWJMYXllclRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v dGVzdHMvV2ViTGF5ZXJUZXN0LmNwcApAQCAtMzgsNiArMzgsNyBAQAogI2luY2x1ZGUgPHB1Ymxp Yy9XZWJMYXllclRyZWVWaWV3Q2xpZW50Lmg+CiAjaW5jbHVkZSA8cHVibGljL1dlYlJlY3QuaD4K ICNpbmNsdWRlIDxwdWJsaWMvV2ViU2l6ZS5oPgorI2luY2x1ZGUgPHB1YmxpYy9XZWJTb2xpZENv bG9yTGF5ZXIuaD4KIAogI2luY2x1ZGUgPGdtb2NrL2dtb2NrLmg+CiAKQEAgLTEzOSw3ICsxNDAs NyBAQCBURVNUX0YoV2ViTGF5ZXJUZXN0LCBDbGllbnQpCiAgICAgRVhQRUNUX0VRKHBvaW50LCBs YXllci0+cG9zaXRpb24oKSk7CiAKICAgICAvLyBUZXh0dXJlIGxheWVyLgotICAgIEVYUEVDVF9D QUxMKG1fY2xpZW50LCBzY2hlZHVsZUNvbXBvc2l0ZSgpKS5UaW1lcyhBbnlOdW1iZXIoKSk7Cisg ICAgRVhQRUNUX0NBTEwobV9jbGllbnQsIHNjaGVkdWxlQ29tcG9zaXRlKCkpLlRpbWVzKEF0TGVh c3QoMSkpOwogICAgIE93blB0cjxXZWJFeHRlcm5hbFRleHR1cmVMYXllcj4gdGV4dHVyZUxheWVy ID0gYWRvcHRQdHIoV2ViRXh0ZXJuYWxUZXh0dXJlTGF5ZXI6OmNyZWF0ZSgpKTsKICAgICBtX3Jv b3RMYXllci0+YWRkQ2hpbGQodGV4dHVyZUxheWVyLT5sYXllcigpKTsKICAgICBNb2NrOjpWZXJp ZnlBbmRDbGVhckV4cGVjdGF0aW9ucygmbV9jbGllbnQpOwpAQCAtMTcwLDYgKzE3MSwxMyBAQCBU RVNUX0YoV2ViTGF5ZXJUZXN0LCBDbGllbnQpCiAgICAgY29udGVudExheWVyLT5sYXllcigpLT5z ZXREcmF3c0NvbnRlbnQoZmFsc2UpOwogICAgIE1vY2s6OlZlcmlmeUFuZENsZWFyRXhwZWN0YXRp b25zKCZtX2NsaWVudCk7CiAgICAgRVhQRUNUX0ZBTFNFKGNvbnRlbnRMYXllci0+bGF5ZXIoKS0+ ZHJhd3NDb250ZW50KCkpOworCisgICAgLy8gU29saWQgY29sb3IgbGF5ZXIuCisgICAgRVhQRUNU X0NBTEwobV9jbGllbnQsIHNjaGVkdWxlQ29tcG9zaXRlKCkpLlRpbWVzKEF0TGVhc3QoMSkpOwor ICAgIE93blB0cjxXZWJTb2xpZENvbG9yTGF5ZXI+IHNvbGlkQ29sb3JMYXllciA9IGFkb3B0UHRy KFdlYlNvbGlkQ29sb3JMYXllcjo6Y3JlYXRlKCkpOworICAgIG1fcm9vdExheWVyLT5hZGRDaGls ZChzb2xpZENvbG9yTGF5ZXItPmxheWVyKCkpOworICAgIE1vY2s6OlZlcmlmeUFuZENsZWFyRXhw ZWN0YXRpb25zKCZtX2NsaWVudCk7CisKIH0KIAogfQo=