95815 2012-09-04 19:14:31 -0700 inc/dec behave incorrectly operating on a resolved const 2012-09-05 00:20:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 711671 0 barraclough 2012-09-04 19:14:31 -0700 There are two bugs here. (1) When the value being incremented is const, and the result is ignored, we assume this cannot be observed, and emit no code. However if the value being incremented is not a primitive & has a valueOf conversion, then this should be being called. (2) In the case of a pre-increment of a const value where the result is not ignored, we'll move +/-1 to the destination, then add the resolved const value being incremented to this. This is problematic if the destination is a local, and the const value being incremented has a valueOf conversion that throws - the destination will be modified erroneously. Instead, we need to use a temporary location. 711673 1 162148 barraclough 2012-09-04 19:21:03 -0700 Created attachment 162148 Fix 711674 2 162148 ggaren 2012-09-04 19:33:08 -0700 Comment on attachment 162148 Fix r=me 711787 3 barraclough 2012-09-05 00:20:06 -0700 Fixed in r127544 162148 2012-09-04 19:21:03 -0700 2012-09-04 19:33:08 -0700 Fix 95815.patch text/plain 7213 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI3NTQyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDEyLTA5LTA0ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBpbmMvZGVjIGJlaGF2ZSBpbmNvcnJlY3RseSBvcGVyYXRpbmcgb24gYSByZXNv bHZlZCBjb25zdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTU4MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGVyZSBhcmUgdHdvIGJ1Z3MgaGVyZS4KKworICAgICAgICAoMSkgV2hlbiB0aGUgdmFsdWUg YmVpbmcgaW5jcmVtZW50ZWQgaXMgY29uc3QsIGFuZCB0aGUgcmVzdWx0IGlzIGlnbm9yZWQsIHdl IGFzc3VtZSB0aGlzIGNhbm5vdCBiZSBvYnNlcnZlZCwgYW5kIGVtaXQgbm8gY29kZS4KKyAgICAg ICAgICAgIEhvd2V2ZXIgaWYgdGhlIHZhbHVlIGJlaW5nIGluY3JlbWVudGVkIGlzIG5vdCBhIHBy aW1pdGl2ZSAmIGhhcyBhIHZhbHVlT2YgY29udmVyc2lvbiwgdGhlbiB0aGlzIHNob3VsZCBiZSBi ZWluZyBjYWxsZWQuCisKKyAgICAgICAgKDIpIEluIHRoZSBjYXNlIG9mIGEgcHJlLWluY3JlbWVu dCBvZiBhIGNvbnN0IHZhbHVlIHdoZXJlIHRoZSByZXN1bHQgaXMgbm90IGlnbm9yZWQsIHdlJ2xs IG1vdmUgKy8tMSB0byB0aGUgZGVzdGluYXRpb24sIHRoZW4KKyAgICAgICAgICAgIGFkZCB0aGUg cmVzb2x2ZWQgY29uc3QgdmFsdWUgYmVpbmcgaW5jcmVtZW50ZWQgdG8gdGhpcy4gVGhpcyBpcyBw cm9ibGVtYXRpYyBpZiB0aGUgZGVzdGluYXRpb24gaXMgYSBsb2NhbCwgYW5kIHRoZSBjb25zdAor ICAgICAgICAgICAgdmFsdWUgYmVpbmcgaW5jcmVtZW50ZWQgaGFzIGEgdmFsdWVPZiBjb252ZXJz aW9uIHRoYXQgdGhyb3dzIC0gdGhlIGRlc3RpbmF0aW9uIHdpbGwgYmUgbW9kaWZpZWQgZXJyb25l b3VzbHkuIEluc3RlYWQsIHdlCisgICAgICAgICAgICBuZWVkIHRvIHVzZSBhIHRlbXBvcmFyeSBs b2NhdGlvbi4KKworICAgICAgICAqIGJ5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwOgorICAg ICAgICAoSlNDOjpQb3N0Zml4UmVzb2x2ZU5vZGU6OmVtaXRCeXRlY29kZSk6CisgICAgICAgIChK U0M6OlByZWZpeFJlc29sdmVOb2RlOjplbWl0Qnl0ZWNvZGUpOgorICAgICAgICAgICAgLSBhbHdh eXMgYXQgbGVhc3QgcGVyZm9ybSBhIHRvTnVtYmVyIGNvbnZlcnNpb24sIHVzZSB0ZW1wRGVzdGlu YXRpb24gd2hlbiByZWR1Y2luZyBpbmMvZGVjIHRvIGFuIGFkZCArLy0xLgorCiAyMDEyLTA5LTA0 ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgREZHIEdldEJ5VmFs IGZvciBKU0FycmF5cyBzaG91bGRuJ3QgT1NSIGV4aXQgZXZlcnkgdGltZSB0aGF0IHRoZSBpbmRl eCBpcyBvdXQgb2YgYm91bmQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGls ZXIvTm9kZXNDb2RlZ2VuLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHAJKHJldmlzaW9uIDEyNzQ4OCkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNjA5LDExICs2MDksOCBAQCBSZWdpc3RlcklEKiBQb3N0Zml4UmVzb2x2ZU5vZGU6 OmVtaXRCeXRlCiAgICAgUmVzb2x2ZVJlc3VsdCByZXNvbHZlUmVzdWx0ID0gZ2VuZXJhdG9yLnJl c29sdmUobV9pZGVudCk7CiAKICAgICBpZiAoUmVnaXN0ZXJJRCogbG9jYWwgPSByZXNvbHZlUmVz dWx0LmxvY2FsKCkpIHsKLSAgICAgICAgaWYgKHJlc29sdmVSZXN1bHQuaXNSZWFkT25seSgpKSB7 Ci0gICAgICAgICAgICBpZiAoZHN0ID09IGdlbmVyYXRvci5pZ25vcmVkUmVzdWx0KCkpCi0gICAg ICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIGlmIChyZXNvbHZlUmVzdWx0LmlzUmVhZE9u bHkoKSkKICAgICAgICAgICAgIHJldHVybiBnZW5lcmF0b3IuZW1pdFRvSlNOdW1iZXIoZ2VuZXJh dG9yLmZpbmFsRGVzdGluYXRpb24oZHN0KSwgbG9jYWwpOwotICAgICAgICB9CiAgICAgICAgIGlm IChkc3QgPT0gZ2VuZXJhdG9yLmlnbm9yZWRSZXN1bHQoKSkKICAgICAgICAgICAgIHJldHVybiBl bWl0UHJlSW5jT3JEZWMoZ2VuZXJhdG9yLCBsb2NhbCwgbV9vcGVyYXRvcik7CiAgICAgICAgIHJl dHVybiBlbWl0UG9zdEluY09yRGVjKGdlbmVyYXRvciwgZ2VuZXJhdG9yLmZpbmFsRGVzdGluYXRp b24oZHN0KSwgbG9jYWwsIG1fb3BlcmF0b3IpOwpAQCAtNzk2LDkgKzc5MywxMCBAQCBSZWdpc3Rl cklEKiBQcmVmaXhSZXNvbHZlTm9kZTo6ZW1pdEJ5dGVjCiAgICAgaWYgKFJlZ2lzdGVySUQqIGxv Y2FsID0gcmVzb2x2ZVJlc3VsdC5sb2NhbCgpKSB7CiAgICAgICAgIGlmIChyZXNvbHZlUmVzdWx0 LmlzUmVhZE9ubHkoKSkgewogICAgICAgICAgICAgaWYgKGRzdCA9PSBnZW5lcmF0b3IuaWdub3Jl ZFJlc3VsdCgpKQotICAgICAgICAgICAgICAgIHJldHVybiAwOwotICAgICAgICAgICAgUmVmUHRy PFJlZ2lzdGVySUQ+IHIwID0gZ2VuZXJhdG9yLmVtaXRMb2FkKGdlbmVyYXRvci5maW5hbERlc3Rp bmF0aW9uKGRzdCksIChtX29wZXJhdG9yID09IE9wUGx1c1BsdXMpID8gMS4wIDogLTEuMCk7Ci0g ICAgICAgICAgICByZXR1cm4gZ2VuZXJhdG9yLmVtaXRCaW5hcnlPcChvcF9hZGQsIHIwLmdldCgp LCBsb2NhbCwgcjAuZ2V0KCksIE9wZXJhbmRUeXBlcygpKTsKKyAgICAgICAgICAgICAgICByZXR1 cm4gZ2VuZXJhdG9yLmVtaXRUb0pTTnVtYmVyKGdlbmVyYXRvci5uZXdUZW1wb3JhcnkoKSwgbG9j YWwpOworICAgICAgICAgICAgUmVmUHRyPFJlZ2lzdGVySUQ+IHIwID0gZ2VuZXJhdG9yLmVtaXRM b2FkKGdlbmVyYXRvci50ZW1wRGVzdGluYXRpb24oZHN0KSwgKG1fb3BlcmF0b3IgPT0gT3BQbHVz UGx1cykgPyAxLjAgOiAtMS4wKTsKKyAgICAgICAgICAgIGdlbmVyYXRvci5lbWl0QmluYXJ5T3Ao b3BfYWRkLCByMC5nZXQoKSwgbG9jYWwsIHIwLmdldCgpLCBPcGVyYW5kVHlwZXMoKSk7CisgICAg ICAgICAgICByZXR1cm4gZ2VuZXJhdG9yLm1vdmVUb0Rlc3RpbmF0aW9uSWZOZWVkZWQoZHN0LCBy MC5nZXQoKSk7CiAgICAgICAgIH0KICAgICAgICAgZW1pdFByZUluY09yRGVjKGdlbmVyYXRvciwg bG9jYWwsIG1fb3BlcmF0b3IpOwogICAgICAgICByZXR1cm4gZ2VuZXJhdG9yLm1vdmVUb0Rlc3Rp bmF0aW9uSWZOZWVkZWQoZHN0LCBsb2NhbCk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjc1NDIpCisr KyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyNSBAQAor MjAxMi0wOS0wNCAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CisK KyAgICAgICAgaW5jL2RlYyBiZWhhdmUgaW5jb3JyZWN0bHkgb3BlcmF0aW5nIG9uIGEgcmVzb2x2 ZWQgY29uc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk1ODE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkZWQgdGVzdCBjYXNlcy4KKworICAgICAgICAqIGZhc3QvanMvaW5jLWNvbnN0LXZhbHVlT2Yt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2pzL2luYy1jb25zdC12YWx1ZU9m Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvanMvc2NyaXB0LXRlc3RzL2luYy1jb25zdC12 YWx1ZU9mLmpzOiBBZGRlZC4KKyAgICAgICAgKHRlc3RQb3N0SW5jQ29uc3RWYXJXaXRoSWdub3Jl ZFJlc3VsdC5jb25zdC5hLnZhbHVlT2YpOgorICAgICAgICAodGVzdFBvc3RJbmNDb25zdFZhcldp dGhJZ25vcmVkUmVzdWx0KToKKyAgICAgICAgICAgIHRlc3QgdGhhdCAnYSsrJyByZXN1bHRzIGlu IGEgdmFsdWVPZiBjYWxsLCB3aGVyZSAnYScgaXMgY29uc3QuCisgICAgICAgICh0ZXN0UHJlSW5j Q29uc3RWYXJXaXRoSWdub3JlZFJlc3VsdC5jb25zdC5hLnZhbHVlT2YpOgorICAgICAgICAodGVz dFByZUluY0NvbnN0VmFyV2l0aElnbm9yZWRSZXN1bHQpOgorICAgICAgICAgICAgdGVzdCB0aGF0 ICcrK2EnIHJlc3VsdHMgaW4gYSB2YWx1ZU9mIGNhbGwsIHdoZXJlICdhJyBpcyBjb25zdC4KKyAg ICAgICAgKHRlc3RQcmVJbmNDb25zdFZhcldpdGhBc3NpZ24uY29uc3QuYS52YWx1ZU9mKToKKyAg ICAgICAgKHRlc3RQcmVJbmNDb25zdFZhcldpdGhBc3NpZ24pOgorICAgICAgICAgICAgdGVzdCB0 aGF0ICdiID0gKythJyBkb2VzIG5vdCBlcnJvbmVvdXNseSB1cGRhdGUgJ2InLCB3aGVyZSAnYScg aXMgY29uc3QuCisKIDIwMTItMDktMDQgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLiBTb21lIGZsYWt5IG1lZGlhL3ZpZGVvIHRlc3RzIG9u IFdpbmRvd3MuIEFkZGluZyB0byBza2lwIGxpc3QuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pz L2luYy1jb25zdC12YWx1ZU9mLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2pzL2luYy1jb25zdC12YWx1ZU9mLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2Zhc3QvanMvaW5jLWNvbnN0LXZhbHVlT2YtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDEyIEBACitUZXN0IGZvciByZWdyZXNzaW9uIGFnYWluc3QKKwor T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgdGVzdFBvc3RJbmNDb25zdFZhcldp dGhJZ25vcmVkUmVzdWx0KCkgaXMgdHJ1ZQorUEFTUyB0ZXN0UHJlSW5jQ29uc3RWYXJXaXRoSWdu b3JlZFJlc3VsdCgpIGlzIHRydWUKK1BBU1MgdGVzdFByZUluY0NvbnN0VmFyV2l0aEFzc2lnbigp IGlzIHRydWUKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVU RQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL2luYy1jb25zdC12YWx1ZU9mLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9pbmMtY29uc3QtdmFsdWVPZi5odG1sCShy ZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9pbmMtY29uc3QtdmFsdWVPZi5odG1s CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEwIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0v L0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9InJlc291 cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQg c3JjPSJzY3JpcHQtdGVzdHMvaW5jLWNvbnN0LXZhbHVlT2YuanMiPjwvc2NyaXB0PgorPHNjcmlw dCBzcmM9InJlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvaW5jLWNvbnN0LXZh bHVlT2YuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMv aW5jLWNvbnN0LXZhbHVlT2YuanMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pz L3NjcmlwdC10ZXN0cy9pbmMtY29uc3QtdmFsdWVPZi5qcwkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSw1NiBAQAorZGVzY3JpcHRpb24oCisnVGVzdCBmb3IgcmVncmVzc2lvbiBhZ2FpbnN0IDxhIGhy ZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTgxNSI+JworKTsK KworZnVuY3Rpb24gdGVzdFBvc3RJbmNDb25zdFZhcldpdGhJZ25vcmVkUmVzdWx0KCkKK3sKKyAg ICB2YXIgb2theSA9IGZhbHNlOworICAgIGNvbnN0IGEgPSB7CisgICAgICAgIHZhbHVlT2Y6IChm dW5jdGlvbigpeworICAgICAgICAgICAgb2theSA9IHRydWU7CisgICAgICAgIH0pCisgICAgfTsK KworICAgIGErKzsKKworICAgIHJldHVybiBva2F5OworfQorCitmdW5jdGlvbiB0ZXN0UHJlSW5j Q29uc3RWYXJXaXRoSWdub3JlZFJlc3VsdCgpCit7CisgICAgdmFyIG9rYXkgPSBmYWxzZTsKKyAg ICBjb25zdCBhID0geworICAgICAgICB2YWx1ZU9mOiAoZnVuY3Rpb24oKXsKKyAgICAgICAgICAg IG9rYXkgPSB0cnVlOworICAgICAgICB9KQorICAgIH07CisKKyAgICArK2E7CisKKyAgICByZXR1 cm4gb2theTsKK30KKworZnVuY3Rpb24gdGVzdFByZUluY0NvbnN0VmFyV2l0aEFzc2lnbigpCit7 CisgICAgdmFyIG9rYXkgPSBmYWxzZTsKKyAgICB2YXIgeCA9IDQyOworICAgIGNvbnN0IGEgPSB7 CisgICAgICAgIHZhbHVlT2Y6IChmdW5jdGlvbigpeworICAgICAgICAgICAgdGhyb3cgeCA9PSA0 MjsKKyAgICAgICAgfSkKKyAgICB9OworCisgICAgdHJ5IHsKKyAgICAgICAgeCA9ICsrYTsKKyAg ICB9IGNhdGNoIChlKSB7CisgICAgICAgIG9rYXkgPSBlCisgICAgfTsKKworICAgIHJldHVybiBv a2F5OworfQorCitzaG91bGRCZVRydWUoJ3Rlc3RQb3N0SW5jQ29uc3RWYXJXaXRoSWdub3JlZFJl c3VsdCgpJyk7CitzaG91bGRCZVRydWUoJ3Rlc3RQcmVJbmNDb25zdFZhcldpdGhJZ25vcmVkUmVz dWx0KCknKTsKK3Nob3VsZEJlVHJ1ZSgndGVzdFByZUluY0NvbnN0VmFyV2l0aEFzc2lnbigpJyk7 CisKK3N1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg==