9581 2006-06-25 13:33:23 -0700 REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused. 2006-11-02 20:36:48 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 webkit-bugs adele daniele.metilli ian jon oldest_to_newest 47132 0 webkit-bugs 2006-06-25 13:33:23 -0700 If I have a lot of text In a textarea control, such that it makes the textarea get a scroll bar and I scroll to the bottom of the textarea control, then click on another control (such as a checkbox, radio control, or push button), the textarea scrolls to the top. This seems to be really "jarring". Especially if I'm trying to copy and paste something into the textarea from the webpage I'm commenting on. Since it means I have to scroll all the way down to the bottom again to find the location I was *just* at in order to paste the thing I am going to quote. 47133 1 webkit-bugs 2006-06-25 13:34:46 -0700 This is a test. There should be no line breaks in this comment. This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment. 47752 2 9096 adele 2006-06-29 11:09:58 -0700 Created attachment 9096 patch 47762 3 9096 adele 2006-06-29 12:21:45 -0700 Comment on attachment 9096 patch clearing review flag. this isn't quite right. 47764 4 adele 2006-06-29 12:49:16 -0700 That patch fixes some common cases of this problem, but RenderLayer::updateScrollInfoAfterLayout is still sometimes causing the layer to scroll back to the top. I'm not sure I understand this code.... we're calculating a new scroll position (line 1036): int newY = max(0, min(m_scrollY, scrollHeight() - m_object->clientHeight())); where m_scrollY is 26... which seems to be valid, but gets clobbered by this calculation. 49660 5 srab8378 2006-07-13 08:18:08 -0700 A more severe (and presumably related) problem with the scrolling of textareas is that touching the scrollbar instantly and reproducibly crashes the browser. 49671 6 adele 2006-07-13 09:28:01 -0700 Simon, please file a new bug about the crash, so we can fix that separately from this issue. Thanks! 49960 7 ddkilzer 2006-07-15 12:57:51 -0700 This is a regression from production Safari, so adding Regression keyword.  Regressions are P1, and should have a Radar associated with them (adding NeedsRadar). 49983 8 ddkilzer 2006-07-15 14:50:44 -0700 Bug 9942 may be related to this bug since it exhibits similar behavior. 54546 9 mitz 2006-09-01 00:48:22 -0700 *** Bug 10670 has been marked as a duplicate of this bug. *** 53981 10 jon 2006-10-05 22:06:22 -0700 Highlight scrolling is still crazy as of r16831. Major usability (i.e. testing) problem 47595 11 9096 adele 2006-11-02 20:17:27 -0800 Comment on attachment 9096 patch I actually do think this patch is right. The problem I was seeing before is caused by the flexbox double layout bugs. Now that we've moved textareas off of RenderFlexibleBox, this change should fully fix this scrolling problem. 47596 12 9096 adele 2006-11-02 20:18:14 -0800 Comment on attachment 9096 patch oh, and of course, I'll update this patch so RenderTextField --> RenderTextControl 47597 13 9096 andersca 2006-11-02 20:26:19 -0800 Comment on attachment 9096 patch r=me 47598 14 adele 2006-11-02 20:36:48 -0800 Committed revision 17560. 9096 2006-06-29 11:09:58 -0700 2006-11-02 20:26:19 -0800 patch patch_scroll_ta.txt text/plain 1295 adele SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDky KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMDYt MjkgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gRml4ZWQgaHR0cDovL2J1Z3ppbGxhLm9w ZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05NTgxCisgICAgICAgIFRoZSBuZXcgTmF0aXZl VGV4dEFyZWEgc2Nyb2xscyB0byB0aGUgdG9wIHdoZW4gdGhlIGNvbnRyb2wgaXMgdW5mb2N1c2Vk LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRleHRGaWVsZC5jcHA6IChXZWJDb3JlOjpS ZW5kZXJUZXh0RmllbGQ6OmZvcndhcmRFdmVudCk6CisgICAgICAgIE9uIGJsdXIsIG9ubHkgc2Ny b2xsIGJhY2sgdG8gdGhlIHN0YXJ0IGZvciB0ZXh0IGZpZWxkcy4KKwogMjAwNi0wNi0yOSAgRGF2 aWQgS2lsemVyICA8ZGRraWx6ZXJAa2lsemVyLm5ldD4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbi4KSW5kZXg6IHJlbmRlcmluZy9SZW5kZXJUZXh0RmllbGQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IHJlbmRlcmluZy9SZW5kZXJUZXh0RmllbGQuY3BwCShyZXZpc2lvbiAxNTA5MikKKysrIHJlbmRl cmluZy9SZW5kZXJUZXh0RmllbGQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zODgsNyArMzg4LDgg QEAKIHsKICAgICBpZiAoZXZ0LT50eXBlKCkgPT0gYmx1ckV2ZW50KSB7CiAgICAgICAgIFJlbmRl ck9iamVjdCogaW5uZXJSZW5kZXJlciA9IG1fZGl2LT5yZW5kZXJlcigpOwotICAgICAgICBpZiAo aW5uZXJSZW5kZXJlcikgeworICAgICAgICAvLyBTY3JvbGwgYmFjayB0byB0aGUgc3RhcnQgd2hl biBsZWF2aW5nIHRleHQgZmllbGRzCisgICAgICAgIGlmIChpbm5lclJlbmRlcmVyICYmICFtX211 bHRpTGluZSkgewogICAgICAgICAgICAgUmVuZGVyTGF5ZXIqIGlubmVyTGF5ZXIgPSBpbm5lclJl bmRlcmVyLT5sYXllcigpOwogICAgICAgICAgICAgaWYgKGlubmVyTGF5ZXIpCiAgICAgICAgICAg ICAgICAgaW5uZXJMYXllci0+c2Nyb2xsVG9PZmZzZXQoc3R5bGUoKS0+ZGlyZWN0aW9uKCkgPT0g UlRMID8gaW5uZXJMYXllci0+c2Nyb2xsV2lkdGgoKSA6IDAsIDApOwo=