95798 2012-09-04 17:01:01 -0700 Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS 2012-09-04 18:43:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth benjamin cmarcelo eric macpherson menard webkit.review.bot oldest_to_newest 711579 0 abarth 2012-09-04 17:01:01 -0700 Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS 711581 1 162134 abarth 2012-09-04 17:04:23 -0700 Created attachment 162134 Patch 711582 2 162134 eric 2012-09-04 17:07:18 -0700 Comment on attachment 162134 Patch Looks Great! 711654 3 162134 webkit.review.bot 2012-09-04 18:43:18 -0700 Comment on attachment 162134 Patch Clearing flags on attachment: 162134 Committed r127540: <http://trac.webkit.org/changeset/127540> 711655 4 webkit.review.bot 2012-09-04 18:43:22 -0700 All reviewed patches have been landed. Closing bug. 162134 2012-09-04 17:04:23 -0700 2012-09-04 18:43:18 -0700 Patch bug-95798-20120904170406.patch text/plain 7582 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjYwNjFlMDlkZDYxNzFl MzcwMWZkZTU0ZWM2MTJmMzkwOWU4YzY4Yy4uNDRlYmQxMmYxMjc1YTBhNTZjOTA1NzFlY2NiYjU0 N2U0ZTY5YTdlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTA0ICBBZGFt IEJhcnRoICA8YWJhcnRoQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIGNocm9taXVtLWxp bnV4IGJ1aWxkIHdpdGhvdXQgV1RGX0RFUFJFQ0FURURfU1RSSU5HX09QRVJBVE9SUworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU3OTgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIG1ha2Vz IHRoZSBjaHJvbWl1bS1saW51eCBwb3J0IGJ1aWxkIHdpdGhvdXQKKyAgICAgICAgV1RGOjpTdHJp bmc6Om9wZXJhdG9yKz0uICBUaGVyZSBhcmUgYSBjb3VwbGUgcGxhY2VzIHRoYXQgcmVxdWlyZSBz b21lCisgICAgICAgIG1vcmUgY2FyZWZ1bCBzdHVkeSwgYW5kIEkndmUgd2hpdGVsaXN0ZWQgdGhv c2UgdXNlcyBieSBkZWZpbmluZworICAgICAgICBXVEZfREVQUkVDQVRFRF9TVFJJTkdfT1BFUkFU T1JTIGF0IHRoZSB0b3Agb2YgdGhlIGZpbGVzLiAoU2VlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTc5NyBmb3IgYW4gZXhwbGFuYXRpb24gb2YKKyAg ICAgICAgV1RGX0RFUFJFQ0FURURfU1RSSU5HX09QRVJBVE9SUy4pCisKKyAgICAgICAgKiBjc3Mv U3R5bGVQcm9wZXJ0eVNldC5jcHA6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJs YXkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yT3ZlcmxheTo6ZHJhd05vZGVIaWdo bGlnaHQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvQ3VzdG9tRmlsdGVy VmFsaWRhdGVkUHJvZ3JhbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDdXN0b21GaWx0ZXJWYWxp ZGF0ZWRQcm9ncmFtOjpyZXdyaXRlTWl4VmVydGV4U2hhZGVyKToKKwogMjAxMi0wOS0wNCAgQW5k cmVpIEJ1Y3VyICA8YWJ1Y3VyQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NTIFJlZ2lvbnNdIERl c3Ryb3lpbmcgYSByZW5kZXIgbmFtZWQgZmxvdyB0aHJlYWQgd2l0aG91dCB1bnJlZ2lzdGVyaW5n IGxlZnQtb3ZlciBjb250ZW50IG5vZGVzIHRyaWdnZXJlZCBhbiBhc3NlcnRpb24uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCmluZGV4IGZjNDhlNTllMGFlNjZiYTA0MDU5MTg1Yjg2ZmY0MmY1NDg5 MTZlYzkuLmFiNzlmMzAxN2M3YTM0ZmIzZmMzZTYyYmIxOTBmNDFhY2Q4NjExNTAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDktMDQgIEFkYW0gQmFy dGggIDxhYmFydGhAY2hyb21pdW0ub3JnPgorCisgICAgICAgIE1ha2UgY2hyb21pdW0tbGludXgg YnVpbGQgd2l0aG91dCBXVEZfREVQUkVDQVRFRF9TVFJJTkdfT1BFUkFUT1JTCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTc5OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL1dlYkFjY2Vzc2liaWxp dHlPYmplY3QuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0Ojpr ZXlib2FyZFNob3J0Y3V0KToKKyAgICAgICAgICAtIFJlbW92ZSB1c2Ugb2YgV1RGOjpTdHJpbmc6 Om9wZXJhdG9yKz0KKyAgICAgICAgKiBzcmMvV2ViUGFnZVNlcmlhbGl6ZXJJbXBsLmNwcDoKKyAg ICAgICAgICAtIFdoaXRlbGlzdCB1c2Ugb2YgV1RGOjpTdHJpbmc6Om9wZXJhdG9yKz0uIFJlbW92 ZSB0aGlzIHVzZSB3aWxsIHRha2UKKyAgICAgICAgICAgIHNvbWUgbW9yZSBjYXJlZnVsIHRob3Vn aHQuCisKIDIwMTItMDktMDMgIFRhbyBCYWkgIDxtaWNoYWVsYmFpQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBBZGRlZCBBTkRST0lEX0dEQlNFUlZFUiBkZWZpbml0aW9uIGZvciBBbnQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2V0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2V0LmNwcAppbmRleCBlMGQ1NjNlNDg0MzIxMjkyMDkx NjU2YTViZTIyMzJmNTY0ZGViMGI0Li5iMDYzYWRhZmYzN2M3YTlhMWRkY2NiMTcwNDg3ZGQzNWUz NzFjNDM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNldC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTZXQuY3BwCkBAIC0xOSw2 ICsxOSw4IEBACiAgKiBCb3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4KICAqLwogCisjZGVmaW5l IFdURl9ERVBSRUNBVEVEX1NUUklOR19PUEVSQVRPUlMKKwogI2luY2x1ZGUgImNvbmZpZy5oIgog I2luY2x1ZGUgIlN0eWxlUHJvcGVydHlTZXQuaCIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwCmluZGV4IDlhOWRjMDM4NDc5ZmE3ZTNkZGYwYzRhYTA1 MWQxYjI0ZTI5ZWJiMDQuLjM5YTAzMTY0ZDllOTY4NGQzMjQ2YjE2MDU1NzMyOGViZDRlMTEyNWEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAKQEAg LTUwLDYgKzUwLDcgQEAKICNpbmNsdWRlICJTY3JpcHRWYWx1ZS5oIgogI2luY2x1ZGUgIlNldHRp bmdzLmgiCiAjaW5jbHVkZSAiU3R5bGVkRWxlbWVudC5oIgorI2luY2x1ZGUgPHd0Zi90ZXh0L1N0 cmluZ0J1aWxkZXIuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC0zNTEsNyArMzUyLDcg QEAgdm9pZCBJbnNwZWN0b3JPdmVybGF5OjpkcmF3Tm9kZUhpZ2hsaWdodCgpCiAgICAgICAgIGVs ZW1lbnRJbmZvLT5zZXRTdHJpbmcoImlkVmFsdWUiLCBlbGVtZW50LT5nZXRJZEF0dHJpYnV0ZSgp KTsKICAgICAgICAgSGFzaFNldDxBdG9taWNTdHJpbmc+IHVzZWRDbGFzc05hbWVzOwogICAgICAg ICBpZiAoZWxlbWVudC0+aGFzQ2xhc3MoKSAmJiBlbGVtZW50LT5pc1N0eWxlZEVsZW1lbnQoKSkg ewotICAgICAgICAgICAgU3RyaW5nIGNsYXNzTmFtZXM7CisgICAgICAgICAgICBTdHJpbmdCdWls ZGVyIGNsYXNzTmFtZXM7CiAgICAgICAgICAgICBjb25zdCBTcGFjZVNwbGl0U3RyaW5nJiBjbGFz c05hbWVzU3RyaW5nID0gc3RhdGljX2Nhc3Q8U3R5bGVkRWxlbWVudCo+KGVsZW1lbnQpLT5jbGFz c05hbWVzKCk7CiAgICAgICAgICAgICBzaXplX3QgY2xhc3NOYW1lQ291bnQgPSBjbGFzc05hbWVz U3RyaW5nLnNpemUoKTsKICAgICAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgY2xhc3NO YW1lQ291bnQ7ICsraSkgewpAQCAtMzU5LDkgKzM2MCwxMCBAQCB2b2lkIEluc3BlY3Rvck92ZXJs YXk6OmRyYXdOb2RlSGlnaGxpZ2h0KCkKICAgICAgICAgICAgICAgICBpZiAodXNlZENsYXNzTmFt ZXMuY29udGFpbnMoY2xhc3NOYW1lKSkKICAgICAgICAgICAgICAgICAgICAgY29udGludWU7CiAg ICAgICAgICAgICAgICAgdXNlZENsYXNzTmFtZXMuYWRkKGNsYXNzTmFtZSk7Ci0gICAgICAgICAg ICAgICAgY2xhc3NOYW1lcyArPSBtYWtlU3RyaW5nKCIuIiwgY2xhc3NOYW1lKTsKKyAgICAgICAg ICAgICAgICBjbGFzc05hbWVzLmFwcGVuZCgnLicpOworICAgICAgICAgICAgICAgIGNsYXNzTmFt ZXMuYXBwZW5kKGNsYXNzTmFtZSk7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICBlbGVtZW50 SW5mby0+c2V0U3RyaW5nKCJjbGFzc05hbWUiLCBjbGFzc05hbWVzKTsKKyAgICAgICAgICAgIGVs ZW1lbnRJbmZvLT5zZXRTdHJpbmcoImNsYXNzTmFtZSIsIGNsYXNzTmFtZXMudG9TdHJpbmcoKSk7 CiAgICAgICAgIH0KIAogICAgICAgICBSZW5kZXJPYmplY3QqIHJlbmRlcmVyID0gbm9kZS0+cmVu ZGVyZXIoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Zp bHRlcnMvQ3VzdG9tRmlsdGVyVmFsaWRhdGVkUHJvZ3JhbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0N1c3RvbUZpbHRlclZhbGlkYXRlZFByb2dyYW0uY3Bw CmluZGV4IDk5NjRjNWM3ZjZjYTZlNDEwZDU2YTIwZDk5NGIxOTk5NTdjNjMwMzYuLmYzN2MyZDAx MjQ1MDc3ZWQ5MmY4OWJkMTUwZWYwMWEzOTk3MGI3YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvQ3VzdG9tRmlsdGVyVmFsaWRhdGVkUHJvZ3Jh bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9DdXN0 b21GaWx0ZXJWYWxpZGF0ZWRQcm9ncmFtLmNwcApAQCAtMTE1LDcgKzExNSw3IEBAIHZvaWQgQ3Vz dG9tRmlsdGVyVmFsaWRhdGVkUHJvZ3JhbTo6cmV3cml0ZU1peFZlcnRleFNoYWRlcigpCiAgICAg Ly8gRHVyaW5nIHZhbGlkYXRpb24sIEFOR0xFIHJlbmFtZWQgdGhlIGF1dGhvcidzICJtYWluIiBm dW5jdGlvbiB0byAiY3NzX21haW4iLgogICAgIC8vIFdlIHdyaXRlIG91ciBvd24gIm1haW4iIGZ1 bmN0aW9uIGFuZCBjYWxsICJjc3NfbWFpbiIgZnJvbSBpdC4KICAgICAvLyBUaGlzIG1ha2VzIHJl d3JpdGluZyBlYXN5IGFuZCBlbnN1cmVzIHRoYXQgb3VyIGNvZGUgcnVucyBhZnRlciBhbGwgYXV0 aG9yIGNvZGUuCi0gICAgbV92YWxpZGF0ZWRWZXJ0ZXhTaGFkZXIgKz0gU0hBREVSKAorICAgIG1f dmFsaWRhdGVkVmVydGV4U2hhZGVyLmFwcGVuZChTSEFERVIoCiAgICAgICAgIGF0dHJpYnV0ZSBt ZWRpdW1wIHZlYzIgY3NzX2FfdGV4Q29vcmQ7CiAgICAgICAgIHZhcnlpbmcgbWVkaXVtcCB2ZWMy IGNzc192X3RleENvb3JkOwogCkBAIC0xMjQsNyArMTI0LDcgQEAgdm9pZCBDdXN0b21GaWx0ZXJW YWxpZGF0ZWRQcm9ncmFtOjpyZXdyaXRlTWl4VmVydGV4U2hhZGVyKCkKICAgICAgICAgICAgIGNz c19tYWluKCk7CiAgICAgICAgICAgICBjc3Nfdl90ZXhDb29yZCA9IGNzc19hX3RleENvb3JkOwog ICAgICAgICB9Ci0gICAgKTsKKyAgICApKTsKIH0KIAogdm9pZCBDdXN0b21GaWx0ZXJWYWxpZGF0 ZWRQcm9ncmFtOjpyZXdyaXRlTWl4RnJhZ21lbnRTaGFkZXIoKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAppbmRleCA2YzRm NTUxZWMzZjYxNDUwZWY0NTI5NWNhOTQ1ZWZjNzVhMTNiMTkxLi44NWVlNDFlYjczZjcxN2ZjZjUw ODQwOTI2NDM2OGM1OGZmNDFmNWY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcApAQCAtNTAsNiArNTAsNyBAQAogI2lu Y2x1ZGUgInBsYXRmb3JtL1dlYlJlY3QuaCIKICNpbmNsdWRlICJwbGF0Zm9ybS9XZWJTdHJpbmcu aCIKICNpbmNsdWRlICJwbGF0Zm9ybS9XZWJVUkwuaCIKKyNpbmNsdWRlIDx3dGYvdGV4dC9TdHJp bmdCdWlsZGVyLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC01MjIsMTQgKzUy MywxNiBAQCBXZWJTdHJpbmcgV2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6a2V5Ym9hcmRTaG9ydGN1 dCgpIGNvbnN0CiAgICAgICAgIC8vIEZvbGxvdyB0aGUgc2FtZSBvcmRlciBhcyBNb3ppbGxhIE1T QUEgaW1wbGVtZW50YXRpb246CiAgICAgICAgIC8vIEN0cmwrQWx0K1NoaWZ0K01ldGEra2V5LiBN U0ROIHN0YXRlcyB0aGF0IGtleWJvYXJkIHNob3J0Y3V0IHN0cmluZ3MKICAgICAgICAgLy8gc2hv dWxkIG5vdCBiZSBsb2NhbGl6ZWQgYW5kIGRlZmluZXMgdGhlIHNlcGFyYXRvciBhcyAiKyIuCisg ICAgICAgIFN0cmluZ0J1aWxkZXIgbW9kaWZpZXJTdHJpbmdCdWlsZGVyOwogICAgICAgICBpZiAo bW9kaWZpZXJzICYgUGxhdGZvcm1FdmVudDo6Q3RybEtleSkKLSAgICAgICAgICAgIG1vZGlmaWVy U3RyaW5nICs9ICJDdHJsKyI7CisgICAgICAgICAgICBtb2RpZmllclN0cmluZ0J1aWxkZXIuYXBw ZW5kTGl0ZXJhbCgiQ3RybCsiKTsKICAgICAgICAgaWYgKG1vZGlmaWVycyAmIFBsYXRmb3JtRXZl bnQ6OkFsdEtleSkKLSAgICAgICAgICAgIG1vZGlmaWVyU3RyaW5nICs9ICJBbHQrIjsKKyAgICAg ICAgICAgIG1vZGlmaWVyU3RyaW5nQnVpbGRlci5hcHBlbmRMaXRlcmFsKCJBbHQrIik7CiAgICAg ICAgIGlmIChtb2RpZmllcnMgJiBQbGF0Zm9ybUV2ZW50OjpTaGlmdEtleSkKLSAgICAgICAgICAg IG1vZGlmaWVyU3RyaW5nICs9ICJTaGlmdCsiOworICAgICAgICAgICAgbW9kaWZpZXJTdHJpbmdC dWlsZGVyLmFwcGVuZExpdGVyYWwoIlNoaWZ0KyIpOwogICAgICAgICBpZiAobW9kaWZpZXJzICYg UGxhdGZvcm1FdmVudDo6TWV0YUtleSkKLSAgICAgICAgICAgIG1vZGlmaWVyU3RyaW5nICs9ICJX aW4rIjsKKyAgICAgICAgICAgIG1vZGlmaWVyU3RyaW5nQnVpbGRlci5hcHBlbmRMaXRlcmFsKCJX aW4rIik7CisgICAgICAgIG1vZGlmaWVyU3RyaW5nID0gbW9kaWZpZXJTdHJpbmdCdWlsZGVyLnRv U3RyaW5nKCk7CiAgICAgfQogCiAgICAgcmV0dXJuIFN0cmluZyhtb2RpZmllclN0cmluZyArIGFj Y2Vzc0tleSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYWdl U2VyaWFsaXplckltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGFnZVNl cmlhbGl6ZXJJbXBsLmNwcAppbmRleCBkZDRiMTVlYmQ3ZjcyNDdiZmFhNTNlYjZkNjg1ZjFiNmIz ZGE4ZmU5Li43OTNjYThiODMzNjJhMDE0NzQ2NzAwNDYwYzUzYzI3NWVjMTJlMDIxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYWdlU2VyaWFsaXplckltcGwuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBhZ2VTZXJpYWxpemVySW1wbC5j cHAKQEAgLTc1LDYgKzc1LDggQEAKIC8vIG92ZXJyaWRlIHRoZSBpbmNvcnJlY3QgYmFzZSBVUkwg YW5kIG1ha2Ugc3VyZSB3ZSBhbHdheSBsb2FkIGNvcnJlY3QgbG9jYWwKIC8vIHNhdmVkIHJlc291 cmNlIGZpbGVzLgogCisjZGVmaW5lIFdURl9ERVBSRUNBVEVEX1NUUklOR19PUEVSQVRPUlMKKwog I2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIldlYlBhZ2VTZXJpYWxpemVySW1wbC5oIgog Cg==