95797 2012-09-04 16:52:18 -0700 Remove WTF::String::operator+= 2012-09-06 01:24:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth benjamin eric kangil.han lauro.neto mitz paroga webkit.review.bot oldest_to_newest 711573 0 abarth 2012-09-04 16:52:18 -0700 Remove WTF::String::operator+= 711577 1 162133 abarth 2012-09-04 16:57:39 -0700 Created attachment 162133 Patch 711583 2 162133 eric 2012-09-04 17:08:40 -0700 Comment on attachment 162133 Patch This looks great, once the other stuff lands. r- to make the EWS not freak out. 712254 3 162284 abarth 2012-09-05 10:50:17 -0700 Created attachment 162284 Patch 712267 4 webkit.review.bot 2012-09-05 10:53:33 -0700 Attachment 162284 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Pl..." exit_code: 1 Source/WTF/ChangeLog:13: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 712288 5 162284 eric 2012-09-05 10:56:39 -0700 Comment on attachment 162284 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162284&action=review > Source/WTF/wtf/Platform.h:1188 > +#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(WIN) You might want to add a comment above this line which explains what this does and that you want to get off this list. :) 712291 6 abarth 2012-09-05 10:57:03 -0700 (In reply to comment #5) > (From update of attachment 162284 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=162284&action=review > > > Source/WTF/wtf/Platform.h:1188 > > +#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(WIN) > > You might want to add a comment above this line which explains what this does and that you want to get off this list. :) Will do. 712318 7 benjamin 2012-09-05 11:02:09 -0700 Looks like I mixed my branches yesterday. I'll make one more patch for Mac. I do that ASAP. 712337 8 abarth 2012-09-05 11:10:04 -0700 (In reply to comment #7) > Looks like I mixed my branches yesterday. I'll make one more patch for Mac. I do that ASAP. Thanks! 712370 9 162284 buildbot 2012-09-05 11:40:34 -0700 Comment on attachment 162284 Patch Attachment 162284 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13765295 712394 10 benjamin 2012-09-05 12:02:09 -0700 (In reply to comment #9) > (From update of attachment 162284 [details]) > Attachment 162284 [details] did not pass mac-ews (mac): > Output: http://queues.webkit.org/results/13765295 My bad, I messed up yesterday. Here is the followup fix: https://bugs.webkit.org/show_bug.cgi?id=95880 712405 11 162284 gyuyoung.kim 2012-09-05 12:11:48 -0700 Comment on attachment 162284 Patch Attachment 162284 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13765304 712488 12 abarth 2012-09-05 13:42:25 -0700 @kangil: Thoughts on the EFL EWS failure? 712536 13 lauro.neto 2012-09-05 14:26:48 -0700 (In reply to comment #12) > @kangil: Thoughts on the EFL EWS failure? Failed on WebInspectorProxy, alread covered by Benjamin in https://bugs.webkit.org/show_bug.cgi?id=95880 712566 14 abarth 2012-09-05 14:59:44 -0700 Ok. Sounds like I should re-upload this patch and try again. 712567 15 162344 abarth 2012-09-05 15:00:22 -0700 Created attachment 162344 re-spin 712572 16 webkit.review.bot 2012-09-05 15:03:19 -0700 Attachment 162344 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Pl..." exit_code: 1 Source/WTF/ChangeLog:13: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 712943 17 abarth 2012-09-06 00:13:16 -0700 Thanks for the review! 712948 18 162344 abarth 2012-09-06 00:20:29 -0700 Comment on attachment 162344 re-spin Clearing flags on attachment: 162344 Committed r127702: <http://trac.webkit.org/changeset/127702> 712949 19 abarth 2012-09-06 00:20:32 -0700 All reviewed patches have been landed. Closing bug. 712967 20 mitz 2012-09-06 00:37:50 -0700 (In reply to comment #18) > (From update of attachment 162344 [details]) > Clearing flags on attachment: 162344 > > Committed r127702: <http://trac.webkit.org/changeset/127702> This broke the debug builds, because Element::formatForDebugger() uses operator+=. 712970 21 abarth 2012-09-06 00:41:09 -0700 > This broke the debug builds, because Element::formatForDebugger() uses operator+=. Hum... I thought paroga had the debug builds fixed. Maybe his patch didn't land? /me checks. 712971 22 paroga 2012-09-06 00:41:52 -0700 (In reply to comment #21) > > This broke the debug builds, because Element::formatForDebugger() uses operator+=. > > Hum... I thought paroga had the debug builds fixed. Maybe his patch didn't land? /me checks. Patch is at https://bugs.webkit.org/show_bug.cgi?id=95888, but CQ is to slow :-( 712976 23 abarth 2012-09-06 00:44:54 -0700 > Patch is at https://bugs.webkit.org/show_bug.cgi?id=95888, but CQ is to slow :-( Landing now. 713019 24 benjamin 2012-09-06 01:24:13 -0700 (In reply to comment #23) > > Patch is at https://bugs.webkit.org/show_bug.cgi?id=95888, but CQ is to slow :-( > > Landing now. Yup, that fixed the bots :) 162133 2012-09-04 16:57:39 -0700 2012-09-05 10:50:15 -0700 Patch bug-95797-20120904165722.patch text/plain 1527 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDc2ZDQxYTA1Yjk2ZWIxMDI3N2FkMzhk NjU3MThlODFiYTgxOGNmYmEuLmNiNTVmMjYwYzlkOTRkYWEzN2I1ZWRjMWEzMDc2OWQ1ZTViYTkw NGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDktMDQgIEFkYW0gQmFydGggIDxhYmFydGhA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBXVEY6OlN0cmluZzo6b3BlcmF0b3IrPQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU3OTcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNo IGVuY2xvc2VzIFdURjo6U3RyaW5nOjpvcGVyYXRvcis9IGluIGFuIGlmZGVmIHNvIHRoYXQgd2Ug Y2FuCisgICAgICAgIGdyYWR1YWxseSByZW1vdmUgaXQgZnJvbSB0aGUgdmFyaW91cyBwb3J0LXNw ZWNpZmljIGZpbGVzLiBUaGUgaWZkZWYKKyAgICAgICAgbGV0cyB1cyB3aGl0ZWxpc3QgdXNlIG9m IG9wZXJhdG9yKz0gaW4gaW5kaXZpZHVhbCBmaWxlcyBkdXJpbmcgdGhlCisgICAgICAgIHRyYW5z aXRpb24uCisKKyAgICAgICAgKiB3dGYvdGV4dC9XVEZTdHJpbmcuaDoKKwogMjAxMi0wOS0wMSAg TWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgTExJbnQgQyBsb29wIGJh Y2tlbmQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oIGIvU291 cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuaAppbmRleCA5MWQ2ZDczMTAzNDhmOGFiMDUwNjQy ZTkyOTk1NzM4Y2I5MTQ5OGU3Li5lMjAwN2Q2NTY1ODAyOTczMWUyZDJkYWU5MmM3NTIxNzgyMTQy ZGMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oCisrKyBiL1Nv dXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmgKQEAgLTQ2Niw3ICs0NjYsOSBAQCBRRGF0YVN0 cmVhbSYgb3BlcmF0b3I8PChRRGF0YVN0cmVhbSYgc3RyZWFtLCBjb25zdCBTdHJpbmcmIHN0cik7 CiBRRGF0YVN0cmVhbSYgb3BlcmF0b3I+PihRRGF0YVN0cmVhbSYgc3RyZWFtLCBTdHJpbmcmIHN0 cik7CiAjZW5kaWYKIAorI2lmZGVmIFdURl9ERVBSRUNBVEVEX1NUUklOR19PUEVSQVRPUlMKIGlu bGluZSBTdHJpbmcmIG9wZXJhdG9yKz0oU3RyaW5nJiBhLCBjb25zdCBTdHJpbmcmIGIpIHsgYS5h cHBlbmQoYik7IHJldHVybiBhOyB9CisjZW5kaWYKIAogaW5saW5lIGJvb2wgb3BlcmF0b3I9PShj b25zdCBTdHJpbmcmIGEsIGNvbnN0IFN0cmluZyYgYikgeyByZXR1cm4gZXF1YWwoYS5pbXBsKCks IGIuaW1wbCgpKTsgfQogaW5saW5lIGJvb2wgb3BlcmF0b3I9PShjb25zdCBTdHJpbmcmIGEsIGNv bnN0IExDaGFyKiBiKSB7IHJldHVybiBlcXVhbChhLmltcGwoKSwgYik7IH0K 162284 2012-09-05 10:50:17 -0700 2012-09-05 15:00:22 -0700 Patch bug-95797-20120905104959.patch text/plain 2070 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDdlNWVhYmUzZTA1ZmViMWMwZTVkMTlh NDY2YWFiOWJmYjRlMGQ3NDcuLjkwMGMyZTlhMGRjMjcwOGM1MTIyOGNjYTQ4Y2ViMTA0OTgzM2I3 ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDktMDUgIEFkYW0gQmFydGggIDxhYmFydGhA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBXVEY6OlN0cmluZzo6b3BlcmF0b3IrPQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU3OTcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNo IGVuY2xvc2VzIFdURjo6U3RyaW5nOjpvcGVyYXRvcis9IGluIGFuIGlmZGVmIHNvIHRoYXQgd2Ug Y2FuCisgICAgICAgIGdyYWR1YWxseSByZW1vdmUgaXQgZnJvbSB0aGUgdmFyaW91cyBwb3J0LXNw ZWNpZmljIGZpbGVzLiBUaGUgaWZkZWYKKyAgICAgICAgbGV0cyB1cyB3aGl0ZWxpc3QgdXNlIG9m IG9wZXJhdG9yKz0gaW4gaW5kaXZpZHVhbCBmaWxlcyBkdXJpbmcgdGhlCisgICAgICAgIHRyYW5z aXRpb24uCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaAorICAgICAgICAqIHd0Zi90ZXh0L1dU RlN0cmluZy5oOgorCiAyMDEyLTA5LTA1ICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0 Lm9yZz4KIAogICAgICAgICBERkcgSklUIGRvZXNuJ3Qgd29yayBwcm9wZXJseSBvbiBBUk0gaGFy ZGZwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93 dGYvUGxhdGZvcm0uaAppbmRleCA1MWM4OThmYWU5MTVmMTI2MmRiYjQ1MmEzNDgyYWRjMTk3NTg0 MzZjLi4xM2FkZjgyNjI1Mjg1ZDI2NjA4Y2IwOTI1OTIyNjI0ZjAxM2RkN2JiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt LmgKQEAgLTExODUsNiArMTE4NSwxMCBAQAogI2RlZmluZSBXVEZfVVNFX1pMSUIgMQogI2VuZGlm CiAKKyNpZiBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShXSU4pCisj ZGVmaW5lIFdURl9ERVBSRUNBVEVEX1NUUklOR19PUEVSQVRPUlMKKyNlbmRpZgorCiAjaWYgUExB VEZPUk0oUVQpCiAjaW5jbHVkZSA8cWdsb2JhbC5oPgogI2lmIGRlZmluZWQoUVRfT1BFTkdMX0VT XzIpICYmICFkZWZpbmVkKFdURl9VU0VfT1BFTkdMX0VTXzIpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oIGIvU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcu aAppbmRleCA5MWQ2ZDczMTAzNDhmOGFiMDUwNjQyZTkyOTk1NzM4Y2I5MTQ5OGU3Li5lMjAwN2Q2 NTY1ODAyOTczMWUyZDJkYWU5MmM3NTIxNzgyMTQyZGMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi90ZXh0L1dURlN0cmluZy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5n LmgKQEAgLTQ2Niw3ICs0NjYsOSBAQCBRRGF0YVN0cmVhbSYgb3BlcmF0b3I8PChRRGF0YVN0cmVh bSYgc3RyZWFtLCBjb25zdCBTdHJpbmcmIHN0cik7CiBRRGF0YVN0cmVhbSYgb3BlcmF0b3I+PihR RGF0YVN0cmVhbSYgc3RyZWFtLCBTdHJpbmcmIHN0cik7CiAjZW5kaWYKIAorI2lmZGVmIFdURl9E RVBSRUNBVEVEX1NUUklOR19PUEVSQVRPUlMKIGlubGluZSBTdHJpbmcmIG9wZXJhdG9yKz0oU3Ry aW5nJiBhLCBjb25zdCBTdHJpbmcmIGIpIHsgYS5hcHBlbmQoYik7IHJldHVybiBhOyB9CisjZW5k aWYKIAogaW5saW5lIGJvb2wgb3BlcmF0b3I9PShjb25zdCBTdHJpbmcmIGEsIGNvbnN0IFN0cmlu ZyYgYikgeyByZXR1cm4gZXF1YWwoYS5pbXBsKCksIGIuaW1wbCgpKTsgfQogaW5saW5lIGJvb2wg b3BlcmF0b3I9PShjb25zdCBTdHJpbmcmIGEsIGNvbnN0IExDaGFyKiBiKSB7IHJldHVybiBlcXVh bChhLmltcGwoKSwgYik7IH0K 162344 2012-09-05 15:00:22 -0700 2012-09-06 00:20:29 -0700 re-spin plusequals.patch text/plain 2070 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDdlNWVhYmUzZTA1ZmViMWMwZTVkMTlh NDY2YWFiOWJmYjRlMGQ3NDcuLjkwMGMyZTlhMGRjMjcwOGM1MTIyOGNjYTQ4Y2ViMTA0OTgzM2I3 ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDktMDUgIEFkYW0gQmFydGggIDxhYmFydGhA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBXVEY6OlN0cmluZzo6b3BlcmF0b3IrPQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU3OTcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNo IGVuY2xvc2VzIFdURjo6U3RyaW5nOjpvcGVyYXRvcis9IGluIGFuIGlmZGVmIHNvIHRoYXQgd2Ug Y2FuCisgICAgICAgIGdyYWR1YWxseSByZW1vdmUgaXQgZnJvbSB0aGUgdmFyaW91cyBwb3J0LXNw ZWNpZmljIGZpbGVzLiBUaGUgaWZkZWYKKyAgICAgICAgbGV0cyB1cyB3aGl0ZWxpc3QgdXNlIG9m IG9wZXJhdG9yKz0gaW4gaW5kaXZpZHVhbCBmaWxlcyBkdXJpbmcgdGhlCisgICAgICAgIHRyYW5z aXRpb24uCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaAorICAgICAgICAqIHd0Zi90ZXh0L1dU RlN0cmluZy5oOgorCiAyMDEyLTA5LTA1ICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0 Lm9yZz4KIAogICAgICAgICBERkcgSklUIGRvZXNuJ3Qgd29yayBwcm9wZXJseSBvbiBBUk0gaGFy ZGZwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93 dGYvUGxhdGZvcm0uaAppbmRleCA1MWM4OThmYWU5MTVmMTI2MmRiYjQ1MmEzNDgyYWRjMTk3NTg0 MzZjLi4xM2FkZjgyNjI1Mjg1ZDI2NjA4Y2IwOTI1OTIyNjI0ZjAxM2RkN2JiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt LmgKQEAgLTExODUsNiArMTE4NSwxMCBAQAogI2RlZmluZSBXVEZfVVNFX1pMSUIgMQogI2VuZGlm CiAKKyNpZiBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShXSU4pCisj ZGVmaW5lIFdURl9ERVBSRUNBVEVEX1NUUklOR19PUEVSQVRPUlMKKyNlbmRpZgorCiAjaWYgUExB VEZPUk0oUVQpCiAjaW5jbHVkZSA8cWdsb2JhbC5oPgogI2lmIGRlZmluZWQoUVRfT1BFTkdMX0VT XzIpICYmICFkZWZpbmVkKFdURl9VU0VfT1BFTkdMX0VTXzIpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oIGIvU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcu aAppbmRleCA5MWQ2ZDczMTAzNDhmOGFiMDUwNjQyZTkyOTk1NzM4Y2I5MTQ5OGU3Li5lMjAwN2Q2 NTY1ODAyOTczMWUyZDJkYWU5MmM3NTIxNzgyMTQyZGMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi90ZXh0L1dURlN0cmluZy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5n LmgKQEAgLTQ2Niw3ICs0NjYsOSBAQCBRRGF0YVN0cmVhbSYgb3BlcmF0b3I8PChRRGF0YVN0cmVh bSYgc3RyZWFtLCBjb25zdCBTdHJpbmcmIHN0cik7CiBRRGF0YVN0cmVhbSYgb3BlcmF0b3I+PihR RGF0YVN0cmVhbSYgc3RyZWFtLCBTdHJpbmcmIHN0cik7CiAjZW5kaWYKIAorI2lmZGVmIFdURl9E RVBSRUNBVEVEX1NUUklOR19PUEVSQVRPUlMKIGlubGluZSBTdHJpbmcmIG9wZXJhdG9yKz0oU3Ry aW5nJiBhLCBjb25zdCBTdHJpbmcmIGIpIHsgYS5hcHBlbmQoYik7IHJldHVybiBhOyB9CisjZW5k aWYKIAogaW5saW5lIGJvb2wgb3BlcmF0b3I9PShjb25zdCBTdHJpbmcmIGEsIGNvbnN0IFN0cmlu ZyYgYikgeyByZXR1cm4gZXF1YWwoYS5pbXBsKCksIGIuaW1wbCgpKTsgfQogaW5saW5lIGJvb2wg b3BlcmF0b3I9PShjb25zdCBTdHJpbmcmIGEsIGNvbnN0IExDaGFyKiBiKSB7IHJldHVybiBlcXVh bChhLmltcGwoKSwgYik7IH0K