95785 2012-09-04 14:48:25 -0700 [chromium] Move static WebCompositor functions to WebCompositorSupport 2012-09-05 18:16:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth dglazkov fishd tkent+wkapi webkit.review.bot oldest_to_newest 711466 0 jamesr 2012-09-04 14:48:25 -0700 [chromium] Move static WebCompositor functions to WebCompositorSupport 711467 1 162102 jamesr 2012-09-04 14:49:38 -0700 Created attachment 162102 Patch 711468 2 webkit.review.bot 2012-09-04 14:51:11 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 711470 3 jamesr 2012-09-04 14:52:38 -0700 The staging on this is awkward, but the plan is to: 1.a) Land this new API 1.b) Land implementations on chromium side 2) Roll everybody forward enough to see these 3) Switch all Chromium callers over to the WebCompositorSupport versions 4) Roll everything forward to see that change 5) Switch all WebKit callers over to WebCompositorSupport versions, empty out WebCompositor interface. 1.a and 1.b can be done concurrently, I think everything has to happen roughly in serial. 711502 4 162109 jamesr 2012-09-04 15:23:09 -0700 Created attachment 162109 add forward declaration of WebThread 712255 5 162109 fishd 2012-09-05 10:50:47 -0700 Comment on attachment 162109 add forward declaration of WebThread View in context: https://bugs.webkit.org/attachment.cgi?id=162109&action=review > Source/Platform/chromium/public/WebCompositorSupport.h:62 > + virtual bool threadingEnabled() { return false; } nit: add a verb: "isThreadingEnabled" > Source/Platform/chromium/public/WebCompositorSupport.h:73 > + nit: extra new line 712733 6 jamesr 2012-09-05 18:16:18 -0700 Committed r127672: <http://trac.webkit.org/changeset/127672> 162102 2012-09-04 14:49:38 -0700 2012-09-04 15:23:06 -0700 Patch bug-95785-20120904144921.patch text/plain 2929 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAzMDEzMzk2NzRkNTdh M2NhMjQyYzNkMmJjYTIwZWY5MThiOWM0NjFkLi5jMDMzZGE2ZmYwMGVkN2RjMzU3YzhiYjFkY2Q0 N2Q2MWZmNGM0ZGRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMi0wOS0wNCAg SmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1 bV0gTW92ZSBzdGF0aWMgV2ViQ29tcG9zaXRvciBmdW5jdGlvbnMgdG8gV2ViQ29tcG9zaXRvclN1 cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1 Nzg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IHN0YXRpY3Mgb24gV2ViQ29tcG9zaXRvciBuZWVkIHRvIGJlIG1vdmVkIHRvIFdlYkNvbXBvc2l0 b3JTdXBwb3J0IHNvIHRoZSBlbWJlZGRlciBjYW4gaW5qZWN0IGFuCisgICAgICAgIGltcGxlbWVu dGF0aW9uIGZvciB0aGVzZSB2aWEgUGxhdGZvcm1TdXBwb3J0LiBUaGlzIGFkZHMgdGhlIGludGVy ZmFjZSBmb3IgdGhlIHN0YXRpY3MgdG8gV2ViQ29tcG9zaXRvclN1cHBvcnQuCisgICAgICAgIEFm dGVyIGFuIGltcGxlbWVudGF0aW9uIG9mIHRoZXNlIGxhbmRzIG9uIHRoZSBjaHJvbWl1bSBzaWRl LCBJJ2xsIHN3aXRjaCBhbGwgY2FsbGVycyBvdmVyIHRvIHVzZSB0aGVzZSBhbmQKKyAgICAgICAg cmVtb3ZlIHRoZSBXZWJDb21wb3NpdG9yIGludGVyZmFjZSBmcm9tIHRoZSBBUEkuCisKKyAgICAg ICAgKiBjaHJvbWl1bS9wdWJsaWMvV2ViQ29tcG9zaXRvclN1cHBvcnQuaDoKKyAgICAgICAgKFdl YkNvbXBvc2l0b3JTdXBwb3J0KToKKyAgICAgICAgKFdlYktpdDo6V2ViQ29tcG9zaXRvclN1cHBv cnQ6OmluaXRpYWxpemUpOgorICAgICAgICAoV2ViS2l0OjpXZWJDb21wb3NpdG9yU3VwcG9ydDo6 dGhyZWFkaW5nRW5hYmxlZCk6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbXBvc2l0b3JTdXBwb3J0 OjpzaHV0ZG93bik6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbXBvc2l0b3JTdXBwb3J0OjpzZXRQ ZXJUaWxlUGFpbnRpbmdFbmFibGVkKToKKyAgICAgICAgKFdlYktpdDo6V2ViQ29tcG9zaXRvclN1 cHBvcnQ6OnNldFBhcnRpYWxTd2FwRW5hYmxlZCk6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbXBv c2l0b3JTdXBwb3J0OjpzZXRBY2NlbGVyYXRlZEFuaW1hdGlvbkVuYWJsZWQpOgorCiAyMDEyLTA5 LTAzICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIE1l ZGlhU3RyZWFtIEFQSTogQWRkIEljZS1yZWxhdGVkIGZ1bmN0aW9uYWxpdHkgdG8gUlRDUGVlckNv bm5lY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi Q29tcG9zaXRvclN1cHBvcnQuaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi Q29tcG9zaXRvclN1cHBvcnQuaAppbmRleCA4OWQzZGZjOWE0YmY3MTdmMDIyOTg3NzIzOTRjN2E2 NmFhZDE5NmE4Li43YWZjNzc3YWYxOGM2ZGY1MWUwNTk1YmE1YmVhNWUzZWNiNzFiYjI1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkNvbXBvc2l0b3JTdXBw b3J0LmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJDb21wb3NpdG9y U3VwcG9ydC5oCkBAIC01Miw2ICs1MiwyNSBAQCBjbGFzcyBXZWJWaWRlb0xheWVyOwogCiBjbGFz cyBXZWJDb21wb3NpdG9yU3VwcG9ydCB7CiBwdWJsaWM6CisgICAgLy8gSW5pdGlhbGl6ZXMgdGhl IGNvbXBvc2l0b3IuIFRocmVhZGVkIGNvbXBvc2l0aW5nIGlzIGVuYWJsZWQgYnkgcGFzc2luZyBp bgorICAgIC8vIGEgbm9uLW51bGwgV2ViVGhyZWFkLiBObyBjb21wb3NpdG9yIGNsYXNzZXMgb3Ig bWV0aG9kcyBzaG91bGQgYmUgdXNlZAorICAgIC8vIHByaW9yIHRvIGNhbGxpbmcgaW5pdGlhbGl6 ZS4KKyAgICB2aXJ0dWFsIHZvaWQgaW5pdGlhbGl6ZShXZWJUaHJlYWQqKSB7IH0KKworICAgIC8v IFJldHVybnMgd2hldGhlciB0aGUgY29tcG9zaXRvciB3YXMgaW5pdGlhbGl6ZWQgd2l0aCB0aHJl YWRpbmcgZW5hYmxlZC4KKyAgICB2aXJ0dWFsIGJvb2wgdGhyZWFkaW5nRW5hYmxlZCgpIHsgcmV0 dXJuIGZhbHNlOyB9CisKKyAgICAvLyBTaHV0cyBkb3duIHRoZSBjb21wb3NpdG9yLiBUaGlzIG11 c3QgYmUgY2FsbGVkIHdoZW4gYWxsIGNvbXBvc2l0b3IgZGF0YQorICAgIC8vIHR5cGVzIGhhdmUg YmVlbiBkZWxldGVkLiBObyBjb21wb3NpdG9yIGNsYXNzZXMgb3IgbWV0aG9kcyBzaG91bGQgYmUg dXNlZAorICAgIC8vIGFmdGVyIHNodXRkb3duLgorICAgIHZpcnR1YWwgdm9pZCBzaHV0ZG93bigp IHsgfQorCisgICAgLy8gVGhlc2UgbWF5IG9ubHkgYmUgY2FsbGVkIGJlZm9yZSBpbml0aWFsaXpl LgorICAgIHZpcnR1YWwgdm9pZCBzZXRQZXJUaWxlUGFpbnRpbmdFbmFibGVkKGJvb2wpIHsgfQor ICAgIHZpcnR1YWwgdm9pZCBzZXRQYXJ0aWFsU3dhcEVuYWJsZWQoYm9vbCkgeyB9CisgICAgdmly dHVhbCB2b2lkIHNldEFjY2VsZXJhdGVkQW5pbWF0aW9uRW5hYmxlZChib29sKSB7IH0KKworCiAg ICAgLy8gTWF5IHJldHVybiAwIGlmIGluaXRpYWxpemF0aW9uIGZhaWxzLgogICAgIHZpcnR1YWwg V2ViTGF5ZXJUcmVlVmlldyogY3JlYXRlTGF5ZXJUcmVlVmlldyhXZWJMYXllclRyZWVWaWV3Q2xp ZW50KiwgY29uc3QgV2ViTGF5ZXImIHJvb3QsIGNvbnN0IFdlYkxheWVyVHJlZVZpZXc6OlNldHRp bmdzJikgeyByZXR1cm4gMDsgfQogCg== 162109 2012-09-04 15:23:09 -0700 2012-09-05 10:50:47 -0700 add forward declaration of WebThread bug-95785-20120904152251.patch text/plain 3121 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAzMDEzMzk2NzRkNTdh M2NhMjQyYzNkMmJjYTIwZWY5MThiOWM0NjFkLi5jMDMzZGE2ZmYwMGVkN2RjMzU3YzhiYjFkY2Q0 N2Q2MWZmNGM0ZGRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMi0wOS0wNCAg SmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1 bV0gTW92ZSBzdGF0aWMgV2ViQ29tcG9zaXRvciBmdW5jdGlvbnMgdG8gV2ViQ29tcG9zaXRvclN1 cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1 Nzg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IHN0YXRpY3Mgb24gV2ViQ29tcG9zaXRvciBuZWVkIHRvIGJlIG1vdmVkIHRvIFdlYkNvbXBvc2l0 b3JTdXBwb3J0IHNvIHRoZSBlbWJlZGRlciBjYW4gaW5qZWN0IGFuCisgICAgICAgIGltcGxlbWVu dGF0aW9uIGZvciB0aGVzZSB2aWEgUGxhdGZvcm1TdXBwb3J0LiBUaGlzIGFkZHMgdGhlIGludGVy ZmFjZSBmb3IgdGhlIHN0YXRpY3MgdG8gV2ViQ29tcG9zaXRvclN1cHBvcnQuCisgICAgICAgIEFm dGVyIGFuIGltcGxlbWVudGF0aW9uIG9mIHRoZXNlIGxhbmRzIG9uIHRoZSBjaHJvbWl1bSBzaWRl LCBJJ2xsIHN3aXRjaCBhbGwgY2FsbGVycyBvdmVyIHRvIHVzZSB0aGVzZSBhbmQKKyAgICAgICAg cmVtb3ZlIHRoZSBXZWJDb21wb3NpdG9yIGludGVyZmFjZSBmcm9tIHRoZSBBUEkuCisKKyAgICAg ICAgKiBjaHJvbWl1bS9wdWJsaWMvV2ViQ29tcG9zaXRvclN1cHBvcnQuaDoKKyAgICAgICAgKFdl YkNvbXBvc2l0b3JTdXBwb3J0KToKKyAgICAgICAgKFdlYktpdDo6V2ViQ29tcG9zaXRvclN1cHBv cnQ6OmluaXRpYWxpemUpOgorICAgICAgICAoV2ViS2l0OjpXZWJDb21wb3NpdG9yU3VwcG9ydDo6 dGhyZWFkaW5nRW5hYmxlZCk6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbXBvc2l0b3JTdXBwb3J0 OjpzaHV0ZG93bik6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbXBvc2l0b3JTdXBwb3J0OjpzZXRQ ZXJUaWxlUGFpbnRpbmdFbmFibGVkKToKKyAgICAgICAgKFdlYktpdDo6V2ViQ29tcG9zaXRvclN1 cHBvcnQ6OnNldFBhcnRpYWxTd2FwRW5hYmxlZCk6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbXBv c2l0b3JTdXBwb3J0OjpzZXRBY2NlbGVyYXRlZEFuaW1hdGlvbkVuYWJsZWQpOgorCiAyMDEyLTA5 LTAzICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIE1l ZGlhU3RyZWFtIEFQSTogQWRkIEljZS1yZWxhdGVkIGZ1bmN0aW9uYWxpdHkgdG8gUlRDUGVlckNv bm5lY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi Q29tcG9zaXRvclN1cHBvcnQuaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi Q29tcG9zaXRvclN1cHBvcnQuaAppbmRleCA4OWQzZGZjOWE0YmY3MTdmMDIyOTg3NzIzOTRjN2E2 NmFhZDE5NmE4Li41ZmU5MzJjNTJlZDljMDg1NTc1NzdjNzFmODBiMDIxNzQ0YzIxZmY2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkNvbXBvc2l0b3JTdXBw b3J0LmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJDb21wb3NpdG9y U3VwcG9ydC5oCkBAIC00NiwxMiArNDYsMzIgQEAgY2xhc3MgV2ViU2Nyb2xsYmFyOwogY2xhc3Mg V2ViU2Nyb2xsYmFyTGF5ZXI7CiBjbGFzcyBXZWJTY3JvbGxiYXJUaGVtZUdlb21ldHJ5OwogY2xh c3MgV2ViU29saWRDb2xvckxheWVyOworY2xhc3MgV2ViVGhyZWFkOwogY2xhc3MgV2ViVHJhbnNm b3JtQW5pbWF0aW9uQ3VydmU7CiBjbGFzcyBXZWJWaWRlb0ZyYW1lUHJvdmlkZXI7CiBjbGFzcyBX ZWJWaWRlb0xheWVyOwogCiBjbGFzcyBXZWJDb21wb3NpdG9yU3VwcG9ydCB7CiBwdWJsaWM6Cisg ICAgLy8gSW5pdGlhbGl6ZXMgdGhlIGNvbXBvc2l0b3IuIFRocmVhZGVkIGNvbXBvc2l0aW5nIGlz IGVuYWJsZWQgYnkgcGFzc2luZyBpbgorICAgIC8vIGEgbm9uLW51bGwgV2ViVGhyZWFkLiBObyBj b21wb3NpdG9yIGNsYXNzZXMgb3IgbWV0aG9kcyBzaG91bGQgYmUgdXNlZAorICAgIC8vIHByaW9y IHRvIGNhbGxpbmcgaW5pdGlhbGl6ZS4KKyAgICB2aXJ0dWFsIHZvaWQgaW5pdGlhbGl6ZShXZWJU aHJlYWQqKSB7IH0KKworICAgIC8vIFJldHVybnMgd2hldGhlciB0aGUgY29tcG9zaXRvciB3YXMg aW5pdGlhbGl6ZWQgd2l0aCB0aHJlYWRpbmcgZW5hYmxlZC4KKyAgICB2aXJ0dWFsIGJvb2wgdGhy ZWFkaW5nRW5hYmxlZCgpIHsgcmV0dXJuIGZhbHNlOyB9CisKKyAgICAvLyBTaHV0cyBkb3duIHRo ZSBjb21wb3NpdG9yLiBUaGlzIG11c3QgYmUgY2FsbGVkIHdoZW4gYWxsIGNvbXBvc2l0b3IgZGF0 YQorICAgIC8vIHR5cGVzIGhhdmUgYmVlbiBkZWxldGVkLiBObyBjb21wb3NpdG9yIGNsYXNzZXMg b3IgbWV0aG9kcyBzaG91bGQgYmUgdXNlZAorICAgIC8vIGFmdGVyIHNodXRkb3duLgorICAgIHZp cnR1YWwgdm9pZCBzaHV0ZG93bigpIHsgfQorCisgICAgLy8gVGhlc2UgbWF5IG9ubHkgYmUgY2Fs bGVkIGJlZm9yZSBpbml0aWFsaXplLgorICAgIHZpcnR1YWwgdm9pZCBzZXRQZXJUaWxlUGFpbnRp bmdFbmFibGVkKGJvb2wpIHsgfQorICAgIHZpcnR1YWwgdm9pZCBzZXRQYXJ0aWFsU3dhcEVuYWJs ZWQoYm9vbCkgeyB9CisgICAgdmlydHVhbCB2b2lkIHNldEFjY2VsZXJhdGVkQW5pbWF0aW9uRW5h YmxlZChib29sKSB7IH0KKworCiAgICAgLy8gTWF5IHJldHVybiAwIGlmIGluaXRpYWxpemF0aW9u IGZhaWxzLgogICAgIHZpcnR1YWwgV2ViTGF5ZXJUcmVlVmlldyogY3JlYXRlTGF5ZXJUcmVlVmll dyhXZWJMYXllclRyZWVWaWV3Q2xpZW50KiwgY29uc3QgV2ViTGF5ZXImIHJvb3QsIGNvbnN0IFdl YkxheWVyVHJlZVZpZXc6OlNldHRpbmdzJikgeyByZXR1cm4gMDsgfQogCg==