95777 2012-09-04 13:43:16 -0700 IndexedDB: IDBRequest leaks if IDBCursor closes and no further events fired 2012-09-04 16:33:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jsbell jsbell alecflett dgrogan tony webkit.review.bot oldest_to_newest 711413 0 jsbell 2012-09-04 13:43:16 -0700 IndexedDB: IDBRequest leaks if IDBCursor closes and no further events fired 711422 1 162098 jsbell 2012-09-04 13:48:49 -0700 Created attachment 162098 Patch 711479 2 jsbell 2012-09-04 15:08:40 -0700 dgrogan@ - can you take a look? 711485 3 jsbell 2012-09-04 15:14:38 -0700 *sigh* - Digging back through history, finishCursor used to read: void IDBRequest::finishCursor() { m_cursorFinished = true; if (m_readyState != PENDING) m_requestFinished = true; } It looks like http://trac.webkit.org/changeset/123275 introduced this, and the partial reversion in http://trac.webkit.org/changeset/126254 really should have reintroduced this change, but did not. The m_readyState != PENDING actually looks better, so I'll re-up the patch. 711488 4 162107 jsbell 2012-09-04 15:16:17 -0700 Created attachment 162107 Patch 711491 5 162107 dgrogan 2012-09-04 15:16:43 -0700 Comment on attachment 162107 Patch LGTM 711493 6 jsbell 2012-09-04 15:18:07 -0700 tony@ - r? 711555 7 162107 webkit.review.bot 2012-09-04 16:33:55 -0700 Comment on attachment 162107 Patch Clearing flags on attachment: 162107 Committed r127518: <http://trac.webkit.org/changeset/127518> 711556 8 webkit.review.bot 2012-09-04 16:33:58 -0700 All reviewed patches have been landed. Closing bug. 162098 2012-09-04 13:48:49 -0700 2012-09-04 15:16:16 -0700 Patch bug-95777-20120904134832.patch text/plain 1889 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzhkYzY2NGZlNzhlY2Fh NmViZDE5YmMyNWQzZjEzODdhYTVkOGY2MS4uOTViOTk2NWQzMDM2MDkyOTM5OWI3MmNjMTJjM2E3 OGI5NWRkNGIzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTA0ICBKb3No dWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhlZERCOiBJREJS ZXF1ZXN0IGxlYWtzIGlmIElEQkN1cnNvciBjbG9zZXMgYW5kIG5vIGZ1cnRoZXIgZXZlbnRzIGZp cmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTc3 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElEQlJl cXVlc3RzIGFyZSBrZXB0IGFsaXZlIGFzIGxvbmcgYXMgdGhleSBtYXkgZmlyZSBldmVudHMsIHdo aWNoIGluY2x1ZGVzCisgICAgICAgIGlmIHRoZSBhc3NvY2lhdGVkIElEQkN1cnNvciBvYmplY3Qg Y2FuIGJlIGFkdmFuY2VkLiBXaGVuIHRoZSB0cmFuc2FjdGlvbgorICAgICAgICBpcyBmaW5pc2hl ZCB0aGUgSURCQ3Vyc29yIGlzIG5vdGlmaWVkIHdoaWNoIGluIHR1cm4gdGVsbHMgdGhlIElEQlJl cXVlc3QKKyAgICAgICAgdGhhdCB0aGUgY3Vyc29yIHdvbid0IGJlIHRoZSBzb3VyY2Ugb2YgbW9y ZSBldmVudHMuIEhvd2V2ZXIsIGlmIHRoaXMgb2NjdXJzCisgICAgICAgIGFuZCBubyBmdXJ0aGVy IGV2ZW50cyBmaXJlIHRoZSBJREJSZXF1ZXN0IGRvZXNuJ3QgY2xlYXIgaXQncyAiaGFzIHBlbmRp bmcKKyAgICAgICAgYWN0aXZpdHkgZmxhZyIuIENsZWFyIHRoZSBmbGFnIG9uIHRoZSBub3RpZmlj YXRpb24gaWYgdGhlIHJlcXVlc3QgaXMKKyAgICAgICAgb3RoZXJ3aXNlIGNvbXBsZXRlLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cyAtIEFjdGl2ZURPTU9iamVjdHMgYW5kIGxlYWtzIGFyZSBwZXJz bmlja2V0eS4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL0lEQlJlcXVlc3QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6SURCUmVxdWVzdDo6ZmluaXNoQ3Vyc29yKToKKwogMjAxMi0wOS0w MyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyNzQyNy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQlJlcXVlc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9pbmRleGVkZGIvSURCUmVxdWVzdC5jcHAKaW5kZXggYTk0YWYzM2NhMGQ3NWFjYjZmZTc5 MzQzMjI3ZDY3ZGRkZjQ1NjkyYi4uNjFjN2RhZTdjMTUzZWY5ZjBiYjhhNjVlYmI1ODM0ZjgzNmIz NTM0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCUmVx dWVzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCUmVxdWVz dC5jcHAKQEAgLTIzMiw2ICsyMzIsOCBAQCB2b2lkIElEQlJlcXVlc3Q6OnNldFJlc3VsdEN1cnNv cihQYXNzUmVmUHRyPElEQkN1cnNvcj4gY3Vyc29yLCBQYXNzUmVmUHRyPElEQktleQogdm9pZCBJ REJSZXF1ZXN0OjpmaW5pc2hDdXJzb3IoKQogewogICAgIG1fY3Vyc29yRmluaXNoZWQgPSB0cnVl OworICAgIGlmIChtX3JlYWR5U3RhdGUgPT0gRE9ORSkKKyAgICAgICAgbV9oYXNQZW5kaW5nQWN0 aXZpdHkgPSBmYWxzZTsKIH0KIAogYm9vbCBJREJSZXF1ZXN0OjpzaG91bGRFbnF1ZXVlRXZlbnQo KSBjb25zdAo= 162107 2012-09-04 15:16:17 -0700 2012-09-04 16:33:55 -0700 Patch bug-95777-20120904151600.patch text/plain 1892 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzhkYzY2NGZlNzhlY2Fh NmViZDE5YmMyNWQzZjEzODdhYTVkOGY2MS4uOTViOTk2NWQzMDM2MDkyOTM5OWI3MmNjMTJjM2E3 OGI5NWRkNGIzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTA0ICBKb3No dWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhlZERCOiBJREJS ZXF1ZXN0IGxlYWtzIGlmIElEQkN1cnNvciBjbG9zZXMgYW5kIG5vIGZ1cnRoZXIgZXZlbnRzIGZp cmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTc3 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElEQlJl cXVlc3RzIGFyZSBrZXB0IGFsaXZlIGFzIGxvbmcgYXMgdGhleSBtYXkgZmlyZSBldmVudHMsIHdo aWNoIGluY2x1ZGVzCisgICAgICAgIGlmIHRoZSBhc3NvY2lhdGVkIElEQkN1cnNvciBvYmplY3Qg Y2FuIGJlIGFkdmFuY2VkLiBXaGVuIHRoZSB0cmFuc2FjdGlvbgorICAgICAgICBpcyBmaW5pc2hl ZCB0aGUgSURCQ3Vyc29yIGlzIG5vdGlmaWVkIHdoaWNoIGluIHR1cm4gdGVsbHMgdGhlIElEQlJl cXVlc3QKKyAgICAgICAgdGhhdCB0aGUgY3Vyc29yIHdvbid0IGJlIHRoZSBzb3VyY2Ugb2YgbW9y ZSBldmVudHMuIEhvd2V2ZXIsIGlmIHRoaXMgb2NjdXJzCisgICAgICAgIGFuZCBubyBmdXJ0aGVy IGV2ZW50cyBmaXJlIHRoZSBJREJSZXF1ZXN0IGRvZXNuJ3QgY2xlYXIgaXQncyAiaGFzIHBlbmRp bmcKKyAgICAgICAgYWN0aXZpdHkgZmxhZyIuIENsZWFyIHRoZSBmbGFnIG9uIHRoZSBub3RpZmlj YXRpb24gaWYgdGhlIHJlcXVlc3QgaXMKKyAgICAgICAgb3RoZXJ3aXNlIGNvbXBsZXRlLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cyAtIEFjdGl2ZURPTU9iamVjdHMgYW5kIGxlYWtzIGFyZSBwZXJz bmlja2V0eS4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL0lEQlJlcXVlc3QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6SURCUmVxdWVzdDo6ZmluaXNoQ3Vyc29yKToKKwogMjAxMi0wOS0w MyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyNzQyNy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQlJlcXVlc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9pbmRleGVkZGIvSURCUmVxdWVzdC5jcHAKaW5kZXggYTk0YWYzM2NhMGQ3NWFjYjZmZTc5 MzQzMjI3ZDY3ZGRkZjQ1NjkyYi4uNDNmMjVhOGMzY2VhZTY2YWNjMDMxZGQ3ODUwMDFjY2MwZGVi OTFiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCUmVx dWVzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCUmVxdWVz dC5jcHAKQEAgLTIzMiw2ICsyMzIsOCBAQCB2b2lkIElEQlJlcXVlc3Q6OnNldFJlc3VsdEN1cnNv cihQYXNzUmVmUHRyPElEQkN1cnNvcj4gY3Vyc29yLCBQYXNzUmVmUHRyPElEQktleQogdm9pZCBJ REJSZXF1ZXN0OjpmaW5pc2hDdXJzb3IoKQogewogICAgIG1fY3Vyc29yRmluaXNoZWQgPSB0cnVl OworICAgIGlmIChtX3JlYWR5U3RhdGUgIT0gUEVORElORykKKyAgICAgICAgbV9oYXNQZW5kaW5n QWN0aXZpdHkgPSBmYWxzZTsKIH0KIAogYm9vbCBJREJSZXF1ZXN0OjpzaG91bGRFbnF1ZXVlRXZl bnQoKSBjb25zdAo=