95773 2012-09-04 12:57:20 -0700 [BlackBerry] PlatformKeyboardEvent::getCurrentModifierState should initialize values. 2012-09-05 11:16:37 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton tonikitoo webkit.review.bot oldest_to_newest 711364 0 mifenton 2012-09-04 12:57:20 -0700 Even though PlatformKeyboardEvent::getCurrentModifierState is notImplemented, it should follow the other ports and initialize the values to false to ensure deterministic behaviour. 711369 1 162085 mifenton 2012-09-04 12:59:15 -0700 Created attachment 162085 Patch 711371 2 162085 rwlbuis 2012-09-04 13:01:30 -0700 Comment on attachment 162085 Patch Looks good. 711505 3 162085 webkit.review.bot 2012-09-04 15:29:20 -0700 Comment on attachment 162085 Patch Rejecting attachment 162085 from commit-queue. New failing tests: http/tests/cache/subresource-expiration-1.html http/tests/cache/stopped-revalidation.html Full output: http://queues.webkit.org/results/13753553 712345 4 162085 webkit.review.bot 2012-09-05 11:16:35 -0700 Comment on attachment 162085 Patch Clearing flags on attachment: 162085 Committed r127613: <http://trac.webkit.org/changeset/127613> 712346 5 webkit.review.bot 2012-09-05 11:16:37 -0700 All reviewed patches have been landed. Closing bug. 162085 2012-09-04 12:59:15 -0700 2012-09-05 11:16:35 -0700 Patch 0001-2012-09-04-Mike-Fenton-mifenton-rim.com.patch text/plain 2394 mifenton RnJvbSA3ZTA5OTg2ZTgxZTNjNzhmNzQwZDlhZmRiOWM2MTJhMmVlMzg5ZTVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VHVlLCA0IFNlcCAyMDEyIDE1OjQ2OjE5IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMi0wOS0w NCAgTWlrZSBGZW50b24gIDxtaWZlbnRvbkByaW0uY29tPgoKICAgICAgICBQcm9wZXJseSBpbml0 aWFsaXplIHRoZSBwYXNzZWQgdmFyaWFibGVzIGV2ZW4KICAgICAgICB0aG91Z2ggd2UgaGF2ZW4n dCBpbXBsZW1lbnRlZCB0aGUgbW9kaWZpZXIgc3RhdGUKICAgICAgICB0byBlbnN1cmUgdGhlIHZh bHVlcyBhcmUgZGV0ZXJtaW5pc3RpYy4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCgogICAgICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9QbGF0Zm9ybUtleWJvYXJkRXZlbnRC bGFja0JlcnJ5LmNwcDoKICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1LZXlib2FyZEV2ZW50Ojpn ZXRDdXJyZW50TW9kaWZpZXJTdGF0ZSk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiAuLi4vYmxhY2ti ZXJyeS9QbGF0Zm9ybUtleWJvYXJkRXZlbnRCbGFja0JlcnJ5LmNwcCB8ICAgIDYgKysrKystCiAy IGZpbGVzIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggNzhmODhiMi4uYjgwZmZlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTA5LTA0ICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNr QmVycnldIFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6Z2V0Q3VycmVudE1vZGlmaWVyU3RhdGUgc2hv dWxkIGluaXRpYWxpemUgdmFsdWVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTU3NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBQcm9wZXJseSBpbml0aWFsaXplIHRoZSBwYXNzZWQgdmFyaWFibGVzIGV2 ZW4KKyAgICAgICAgdGhvdWdoIHdlIGhhdmVuJ3QgaW1wbGVtZW50ZWQgdGhlIG1vZGlmaWVyIHN0 YXRlCisgICAgICAgIHRvIGVuc3VyZSB0aGUgdmFsdWVzIGFyZSBkZXRlcm1pbmlzdGljLgorCisg ICAgICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9QbGF0Zm9ybUtleWJvYXJkRXZlbnRCbGFja0Jl cnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6Z2V0Q3Vy cmVudE1vZGlmaWVyU3RhdGUpOgorCiAyMDEyLTA5LTA0ICBUb21teSBXaWRlbmZseWNodCAgPHRv bW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIE1lZGlhU3RyZWFtIEFQSTogQ2hhbmdlIHRoZSBN ZWRpYVN0cmVhbVRyYWNrTGlzdCB0cmFjayBhZGRlZC9yZW1vdmVkIHNpZ25hbGluZwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9QbGF0Zm9ybUtleWJvYXJk RXZlbnRCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkv UGxhdGZvcm1LZXlib2FyZEV2ZW50QmxhY2tCZXJyeS5jcHAKaW5kZXggOGZmZDhlMy4uNDkxNDMw NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9QbGF0Zm9y bUtleWJvYXJkRXZlbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ibGFja2JlcnJ5L1BsYXRmb3JtS2V5Ym9hcmRFdmVudEJsYWNrQmVycnkuY3BwCkBAIC00Nzks OSArNDc5LDEzIEBAIHZvaWQgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpkaXNhbWJpZ3VhdGVLZXlE b3duRXZlbnQoUGxhdGZvcm1FdmVudDo6VHlwZSB0eXBlLCBiCiAgICAgfQogfQogCi12b2lkIFBs YXRmb3JtS2V5Ym9hcmRFdmVudDo6Z2V0Q3VycmVudE1vZGlmaWVyU3RhdGUoYm9vbCYsIGJvb2wm LCBib29sJiwgYm9vbCYpCit2b2lkIFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6Z2V0Q3VycmVudE1v ZGlmaWVyU3RhdGUoYm9vbCYgc2hpZnRLZXksIGJvb2wmIGN0cmxLZXksIGJvb2wmIGFsdEtleSwg Ym9vbCYgbWV0YUtleSkKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIHNoaWZ0S2V5ID0g ZmFsc2U7CisgICAgY3RybEtleSA9IGZhbHNlOworICAgIGFsdEtleSA9IGZhbHNlOworICAgIG1l dGFLZXkgPSBmYWxzZTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQotLSAKMS43LjkuNQoK