95771 2012-09-04 12:31:35 -0700 [BlackBerry] Fix memory leak in InputHandler 2012-09-04 13:21:57 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 staikos staikos mifenton tonikitoo webkit.review.bot oldest_to_newest 711344 0 staikos 2012-09-04 12:31:35 -0700 The arrays were never deleted in openSelectPopup 711345 1 162080 staikos 2012-09-04 12:32:50 -0700 Created attachment 162080 Patch 711350 2 162080 rwlbuis 2012-09-04 12:39:44 -0700 Comment on attachment 162080 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162080&action=review Looks good. > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1647 > + delete[] selecteds; I slightly prefer delete [] foo style. Up to you :) 711390 3 162080 webkit.review.bot 2012-09-04 13:21:54 -0700 Comment on attachment 162080 Patch Clearing flags on attachment: 162080 Committed r127493: <http://trac.webkit.org/changeset/127493> 711391 4 webkit.review.bot 2012-09-04 13:21:57 -0700 All reviewed patches have been landed. Closing bug. 162080 2012-09-04 12:32:50 -0700 2012-09-04 13:21:54 -0700 Patch 95771.patch text/plain 1416 staikos SW5kZXg6IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkocmV2aXNpb24gMTI3NDgzKQorKysg U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTA5LTA0ICBHZW9yZ2UgU3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9y Zz4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRml4IG1lbW9yeSBsZWFrIGluIElucHV0SGFuZGxl cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU3NzEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW1wbHkg ZGVsZXRlIHRoZSBhcnJheXMgYXQgZnVuY3Rpb24gZXhpdC4KKworICAgICAgICAqIFdlYktpdFN1 cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5w dXRIYW5kbGVyOjpvcGVuU2VsZWN0UG9wdXApOgorCiAyMDEyLTA5LTA0ICBNYXJ5IFd1ICA8bWFy eS53dUB0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkZCB3ZWJw bGF0Zm9ybSBhbmQgYnJvd3NlciB0byBidWlsZCBpbmZvCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAJKHJl dmlzaW9uIDEyNjA1NykKKysrIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0 L0lucHV0SGFuZGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2NDIsNiArMTY0Miw5IEBAIGJv b2wgSW5wdXRIYW5kbGVyOjpvcGVuU2VsZWN0UG9wdXAoSFRNTFMKICAgICAvLyBGYWlsIHRvIGNy ZWF0ZSBIVE1MIHBvcHVwLCB1c2UgdGhlIG9sZCBwYXRoCiAgICAgaWYgKCFtX3dlYlBhZ2UtPm1f cGFnZS0+Y2hyb21lKCktPmNsaWVudCgpLT5vcGVuUGFnZVBvcHVwKHNlbGVjdENsaWVudCwgZWxl bWVudFJlY3RJblJvb3RWaWV3KSkKICAgICAgICAgbV93ZWJQYWdlLT5tX2NsaWVudC0+b3BlblBv cHVwTGlzdChtdWx0aXBsZSwgc2l6ZSwgbGFiZWxzLCBlbmFibGVkcywgaXRlbVR5cGVzLCBzZWxl Y3RlZHMpOworICAgIGRlbGV0ZVtdIGVuYWJsZWRzOworICAgIGRlbGV0ZVtdIGl0ZW1UeXBlczsK KyAgICBkZWxldGVbXSBzZWxlY3RlZHM7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAK