95769 2012-09-04 12:13:46 -0700 [BlackBerry] Provide virtual dtor for DumpRenderTreeClient 2012-09-04 13:16:42 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rwlbuis rwlbuis mifenton tonikitoo webkit.review.bot oldest_to_newest 711330 0 rwlbuis 2012-09-04 12:13:46 -0700 We have virtual methods in DumpRenderTreeClient but no virtual dtor. This seems wrong since we delete a pointer to it in WebPage, so the subclass dtor in DumpRenderTree is not called. 711334 1 162077 rwlbuis 2012-09-04 12:16:51 -0700 Created attachment 162077 Patch 711387 2 rwlbuis 2012-09-04 13:16:42 -0700 Committed r127486: <http://trac.webkit.org/changeset/127486> 162077 2012-09-04 12:16:51 -0700 2012-09-04 12:20:19 -0700 Patch bug-95769-20120904151925.patch text/plain 3926 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA0YzczODExNzRlNDFlODVkZmUzNmI0YTZjMDFjN2MwZjFhMjliY2ZhLi5jOTE0MWQ4NjA4 NDU1ZDUzYmFlYWU2OTJjNjU1MTVmNTRkZGFkZmVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wOS0wNCAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBQcm92aWRlIHZpcnR1YWwgZHRvciBmb3IgRHVt cFJlbmRlclRyZWVDbGllbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk1NzY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWxzbyByZW1vdmUgV1RGIHByZWZpeGVzLgorCisgICAgICAgICogQXBpL0R1bXBS ZW5kZXJUcmVlQ2xpZW50Lmg6CisKIDIwMTItMDgtMzEgIEpvc2h1YSBOZXR0ZXJmaWVsZCAgPGpu ZXR0ZXJmaWVsZEByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBFbGltaW5hdGUgV2Vi R0wgSVQgcG9saWN5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0R1 bXBSZW5kZXJUcmVlQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0R1bXBS ZW5kZXJUcmVlQ2xpZW50LmgKaW5kZXggY2U2ZGQyNzQzMTZmNTY5ZDUyMWYzZDQ2YWNlNmFjY2I3 NWQzNGQyYy4uYjAxYTU0OTQ3OWZkZjc4MGZlY2ZhMzQ4ZTQ3NTk2MmIyNjY0NDY3YyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9EdW1wUmVuZGVyVHJlZUNsaWVudC5o CisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvRHVtcFJlbmRlclRyZWVDbGllbnQu aApAQCAtNDIsNiArNDIsNyBAQCBjbGFzcyBXZWJQYWdlOwogCiBjbGFzcyBCTEFDS0JFUlJZX0VY UE9SVCBEdW1wUmVuZGVyVHJlZUNsaWVudCB7CiBwdWJsaWM6CisgICAgdmlydHVhbCB+RHVtcFJl bmRlclRyZWVDbGllbnQoKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgcnVuVGVzdHMoKSA9IDA7CiAK ICAgICAvLyBGcmFtZUxvYWRlckNsaWVudCBkZWxlZ2F0ZXMKQEAgLTUzLDE5ICs1NCwxOSBAQCBw dWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGRpZEZpbmlzaExvYWRGb3JGcmFtZShXZWJDb3JlOjpG cmFtZSopID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgZGlkRmluaXNoRG9jdW1lbnRMb2FkRm9yRnJh bWUoV2ViQ29yZTo6RnJhbWUqKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGRpZENsZWFyV2luZG93 T2JqZWN0SW5Xb3JsZChXZWJDb3JlOjpET01XcmFwcGVyV29ybGQqLCBKU0dsb2JhbENvbnRleHRS ZWYsIEpTT2JqZWN0UmVmIHdpbmRvd09iamVjdCkgPSAwOwotICAgIHZpcnR1YWwgdm9pZCBkaWRS ZWNlaXZlVGl0bGVGb3JGcmFtZShjb25zdCBXVEY6OlN0cmluZyYgdGl0bGUsIFdlYkNvcmU6OkZy YW1lKikgPSAwOworICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlVGl0bGVGb3JGcmFtZShjb25z dCBTdHJpbmcmIHRpdGxlLCBXZWJDb3JlOjpGcmFtZSopID0gMDsKICAgICB2aXJ0dWFsIHZvaWQg ZGlkRGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbihjb25zdCBXZWJDb3JlOjpOYXZpZ2F0 aW9uQWN0aW9uJiwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JikgPSAwOwogICAgIHZp cnR1YWwgdm9pZCBkaWREaXNwYXRjaFdpbGxQZXJmb3JtQ2xpZW50UmVkaXJlY3QoKSA9IDA7CiAg ICAgdmlydHVhbCB2b2lkIGRpZEhhbmRsZU9ubG9hZEV2ZW50c0ZvckZyYW1lKFdlYkNvcmU6OkZy YW1lKikgPSAwOwogCiAgICAgLy8gQ2hyb21lQ2xpZW50IGRlbGVnYXRlcwotICAgIHZpcnR1YWwg dm9pZCBhZGRNZXNzYWdlVG9Db25zb2xlKGNvbnN0IFdURjo6U3RyaW5nJiBtZXNzYWdlLCB1bnNp Z25lZCBpbnQgbGluZU51bWJlciwgY29uc3QgV1RGOjpTdHJpbmcmIHNvdXJjZUlEKSA9IDA7Ci0g ICAgdmlydHVhbCB2b2lkIHJ1bkphdmFTY3JpcHRBbGVydChjb25zdCBXVEY6OlN0cmluZyYgbWVz c2FnZSkgPSAwOwotICAgIHZpcnR1YWwgYm9vbCBydW5KYXZhU2NyaXB0Q29uZmlybShjb25zdCBX VEY6OlN0cmluZyYgbWVzc2FnZSkgPSAwOwotICAgIHZpcnR1YWwgV1RGOjpTdHJpbmcgcnVuSmF2 YVNjcmlwdFByb21wdChjb25zdCBXVEY6OlN0cmluZyYgbWVzc2FnZSwgY29uc3QgV1RGOjpTdHJp bmcmIGRlZmF1bHRWYWx1ZSkgPSAwOwotICAgIHZpcnR1YWwgYm9vbCBydW5CZWZvcmVVbmxvYWRD b25maXJtUGFuZWwoY29uc3QgV1RGOjpTdHJpbmcmIG1lc3NhZ2UpID0gMDsKLSAgICB2aXJ0dWFs IHZvaWQgc2V0U3RhdHVzVGV4dChjb25zdCBXVEY6OlN0cmluZyYpID0gMDsKLSAgICB2aXJ0dWFs IHZvaWQgZXhjZWVkZWREYXRhYmFzZVF1b3RhKFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2luKiwgY29u c3QgV1RGOjpTdHJpbmcmIG5hbWUpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgYWRkTWVzc2FnZVRv Q29uc29sZShjb25zdCBTdHJpbmcmIG1lc3NhZ2UsIHVuc2lnbmVkIGludCBsaW5lTnVtYmVyLCBj b25zdCBTdHJpbmcmIHNvdXJjZUlEKSA9IDA7CisgICAgdmlydHVhbCB2b2lkIHJ1bkphdmFTY3Jp cHRBbGVydChjb25zdCBTdHJpbmcmIG1lc3NhZ2UpID0gMDsKKyAgICB2aXJ0dWFsIGJvb2wgcnVu SmF2YVNjcmlwdENvbmZpcm0oY29uc3QgU3RyaW5nJiBtZXNzYWdlKSA9IDA7CisgICAgdmlydHVh bCBTdHJpbmcgcnVuSmF2YVNjcmlwdFByb21wdChjb25zdCBTdHJpbmcmIG1lc3NhZ2UsIGNvbnN0 IFN0cmluZyYgZGVmYXVsdFZhbHVlKSA9IDA7CisgICAgdmlydHVhbCBib29sIHJ1bkJlZm9yZVVu bG9hZENvbmZpcm1QYW5lbChjb25zdCBTdHJpbmcmIG1lc3NhZ2UpID0gMDsKKyAgICB2aXJ0dWFs IHZvaWQgc2V0U3RhdHVzVGV4dChjb25zdCBTdHJpbmcmKSA9IDA7CisgICAgdmlydHVhbCB2b2lk IGV4Y2VlZGVkRGF0YWJhc2VRdW90YShXZWJDb3JlOjpTZWN1cml0eU9yaWdpbiosIGNvbnN0IFN0 cmluZyYgbmFtZSkgPSAwOwogICAgIHZpcnR1YWwgYm9vbCBhbGxvd3NPcGVuaW5nV2luZG93KCkg PSAwOwogICAgIHZpcnR1YWwgdm9pZCB3aW5kb3dDcmVhdGVkKFdlYlBhZ2UqKSA9IDA7CiAKQEAg LTgwLDcgKzgxLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBzaG91bGREZWxldGVET01S YW5nZShXZWJDb3JlOjpSYW5nZSopID0gMDsKICAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkQ2hhbmdl U2VsZWN0ZWRET01SYW5nZVRvRE9NUmFuZ2VBZmZpbml0eVN0aWxsU2VsZWN0aW5nKFdlYkNvcmU6 OlJhbmdlKiBmcm9tUmFuZ2UsIFdlYkNvcmU6OlJhbmdlKiB0b1JhbmdlLCBpbnQgYWZmaW5pdHks IGJvb2wgc3RpbGxTZWxlY3RpbmcpID0gMDsKICAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkSW5zZXJ0 Tm9kZShXZWJDb3JlOjpOb2RlKiwgV2ViQ29yZTo6UmFuZ2UqLCBpbnQgaW5zZXJ0QWN0aW9uKSA9 IDA7Ci0gICAgdmlydHVhbCBib29sIHNob3VsZEluc2VydFRleHQoY29uc3QgV1RGOjpTdHJpbmcm LCBXZWJDb3JlOjpSYW5nZSosIGludCBpbnNlcnRBY3Rpb24pID0gMDsKKyAgICB2aXJ0dWFsIGJv b2wgc2hvdWxkSW5zZXJ0VGV4dChjb25zdCBTdHJpbmcmLCBXZWJDb3JlOjpSYW5nZSosIGludCBp bnNlcnRBY3Rpb24pID0gMDsKICAgICB2aXJ0dWFsIGJvb2wgaXNTZWxlY3RUcmFpbGluZ1doaXRl c3BhY2VFbmFibGVkKCkgY29uc3QgPSAwOwogICAgIHZpcnR1YWwgYm9vbCBkaWRSZWNlaXZlQXV0 aGVudGljYXRpb25DaGFsbGVuZ2UoV2ViQ29yZTo6Q3JlZGVudGlhbCYpID0gMDsKIAo=