95755 2012-09-04 09:45:12 -0700 ResourceErrorBase needs to identify timeouts 2012-09-04 13:29:51 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74802 94796 1 d-r d-r abarth ap aroben ggaren levin webkit.review.bot oldest_to_newest 711187 0 d-r 2012-09-04 09:45:12 -0700 For bug 74802 I need to be able to distinguish resource errors which are caused by network timeouts. XHR uses a CachedResourceLoader, which in turn uses a SubResourceLoader. If a load failure occurs there, I'd like to set the status of the Cached resource to a new state TimedOut. I need to be able to identify timeouts in SubResourceLoader to be able to do that. That's why I'd like to introduce this distinction. 711236 1 162061 d-r 2012-09-04 11:00:20 -0700 Created attachment 162061 Adding isTimeout property. 711291 2 d-r 2012-09-04 11:39:11 -0700 Thanks for the quick review, Alexey. 711400 3 162061 webkit.review.bot 2012-09-04 13:29:46 -0700 Comment on attachment 162061 Adding isTimeout property. Clearing flags on attachment: 162061 Committed r127495: <http://trac.webkit.org/changeset/127495> 711402 4 webkit.review.bot 2012-09-04 13:29:51 -0700 All reviewed patches have been landed. Closing bug. 162061 2012-09-04 11:00:20 -0700 2012-09-04 13:29:46 -0700 Adding isTimeout property. bug-95755-20120904210254.patch text/plain 3759 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmNmMWI4YWZiZWM2MmE4 NmE0YTRkZmUyZGM5YTY3NTk5MmNjYWJmMC4uMmJjN2U1MjgyZjA1ZThiYWQzYTAwNjg0ZDBmMDFm YmM5NzkyODE1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA5LTA0ICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg UmVzb3VyY2VFcnJvckJhc2UgbmVlZHMgdG8gaWRlbnRpZnkgdGltZW91dHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1NzU1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaW5nIGEgcHJvcGVydHkgdG8g Y2hlY2sgd2hldGhlciB0aGlzIFJlc291cmNlRXJyb3Igd2FzIHJhaXNlZCBkdWUgdG8gYSB0aW1l b3V0LgorICAgICAgICBUaGlzIGlzIHByZXBhcmF0b3J5IHdvcmsgZm9yIGJ1ZyA3NDgwMi4gSW4g b3JkZXIgdG8gaW1wbGVtZW50IFhIUjIgdGltZW91dCBmdW5jdGlvbmFsaXR5LAorICAgICAgICBJ IG5lZWQgdG8gaWRlbnRpZnkgc29tZSBsYXllcnMgdXAgd2hldGhlciB0aGUgb3JpZ2luYWwgbmV0 d29yayBwcm9ibGVtIGhhcyBiZWVuIGEgdGltZW91dC4KKworICAgICAgICBObyBuZXcgdGVzdHMs IG5vIGNoYW5nZSBpbiBiZWhhdmlvciB5ZXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3Jr L1Jlc291cmNlRXJyb3JCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlRXJyb3JC YXNlOjpjb3B5KTogQ29weWluZyBuZXcgbWVtYmVyLgorICAgICAgICAoV2ViQ29yZTo6UmVzb3Vy Y2VFcnJvckJhc2U6OmNvbXBhcmUpOiBDb21wYXJpbmcgbmV3IG1lbWJlci4KKyAgICAgICAgKiBw bGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlRXJyb3JCYXNlLmg6CisgICAgICAgIChXZWJDb3JlOjpS ZXNvdXJjZUVycm9yQmFzZTo6c2V0SXNUaW1lb3V0KTogTmV3IHNldHRlci4KKyAgICAgICAgKFdl YkNvcmU6OlJlc291cmNlRXJyb3JCYXNlOjppc1RpbWVvdXQpOiBOZXcgZ2V0dGVyLgorICAgICAg ICAoUmVzb3VyY2VFcnJvckJhc2UpLAorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VFcnJvckJh c2U6OlJlc291cmNlRXJyb3JCYXNlKTogQWRkaW5nIG1faXNUaW1lb3V0IG1lbWJlci4KKwogMjAx Mi0wOS0wNCAgQW5kcmV5IEFkYWlraW4gIDxhYW5kcmV5QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBbV2ViR0xdIFNhdmUgZ2wuZ2V0RXJyb3IoKSBzdGF0dXMgYmVmb3Jl IHRha2luZyBhIFdlYkdMIHN0YXRlIHNuYXBzaG90IGFuZCByZXN0b3JlIGl0IGFmdGVyd2FyZHMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VFcnJv ckJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZUVycm9y QmFzZS5jcHAKaW5kZXggZjliMTBiNTVkMjY1YTk0ZmYxNGY4YTI1NTUzZTA1ZWUyMzllZWViOC4u MDA0YTE5OTJiZDE3N2FhNDk5ZDBmYzdkOWE1NzgxNjZkNDE3ZGU4NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZUVycm9yQmFzZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZUVycm9yQmFzZS5jcHAKQEAg LTQyLDYgKzQyLDcgQEAgUmVzb3VyY2VFcnJvciBSZXNvdXJjZUVycm9yQmFzZTo6Y29weSgpIGNv bnN0CiAgICAgZXJyb3JDb3B5Lm1fbG9jYWxpemVkRGVzY3JpcHRpb24gPSBtX2xvY2FsaXplZERl c2NyaXB0aW9uLmlzb2xhdGVkQ29weSgpOwogICAgIGVycm9yQ29weS5tX2lzTnVsbCA9IG1faXNO dWxsOwogICAgIGVycm9yQ29weS5tX2lzQ2FuY2VsbGF0aW9uID0gbV9pc0NhbmNlbGxhdGlvbjsK KyAgICBlcnJvckNvcHkubV9pc1RpbWVvdXQgPSBtX2lzVGltZW91dDsKICAgICBwbGF0Zm9ybUNv cHkoZXJyb3JDb3B5KTsKICAgICByZXR1cm4gZXJyb3JDb3B5OwogfQpAQCAtNzQsNiArNzUsOSBA QCBib29sIFJlc291cmNlRXJyb3JCYXNlOjpjb21wYXJlKGNvbnN0IFJlc291cmNlRXJyb3ImIGEs IGNvbnN0IFJlc291cmNlRXJyb3ImIGIpCiAgICAgaWYgKGEuaXNDYW5jZWxsYXRpb24oKSAhPSBi LmlzQ2FuY2VsbGF0aW9uKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgIGlmIChhLmlz VGltZW91dCgpICE9IGIuaXNUaW1lb3V0KCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAg IHJldHVybiBwbGF0Zm9ybUNvbXBhcmUoYSwgYik7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VFcnJvckJhc2UuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VFcnJvckJhc2UuaAppbmRleCAyZDdiZTcwZGU1 MWU2YjBlMjg1MzI4ZDY3NzdiMTBjMzEwYTkxYjM1Li5kMzQ3MmZiYjRjYzFkOTY3MDE2YWM5OTdm MWQwYmUwNTM3ZWEwOWZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL1Jlc291cmNlRXJyb3JCYXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9SZXNvdXJjZUVycm9yQmFzZS5oCkBAIC00OSw2ICs0OSw5IEBAIHB1YmxpYzoKICAgICB2 b2lkIHNldElzQ2FuY2VsbGF0aW9uKGJvb2wgaXNDYW5jZWxsYXRpb24pIHsgbV9pc0NhbmNlbGxh dGlvbiA9IGlzQ2FuY2VsbGF0aW9uOyB9CiAgICAgYm9vbCBpc0NhbmNlbGxhdGlvbigpIGNvbnN0 IHsgcmV0dXJuIG1faXNDYW5jZWxsYXRpb247IH0KIAorICAgIHZvaWQgc2V0SXNUaW1lb3V0KGJv b2wgaXNUaW1lb3V0KSB7IG1faXNUaW1lb3V0ID0gaXNUaW1lb3V0OyB9CisgICAgYm9vbCBpc1Rp bWVvdXQoKSBjb25zdCB7IHJldHVybiBtX2lzVGltZW91dDsgfQorCiAgICAgc3RhdGljIGJvb2wg Y29tcGFyZShjb25zdCBSZXNvdXJjZUVycm9yJiwgY29uc3QgUmVzb3VyY2VFcnJvciYpOwogCiBw cm90ZWN0ZWQ6CkBAIC01Niw2ICs1OSw3IEBAIHByb3RlY3RlZDoKICAgICAgICAgOiBtX2Vycm9y Q29kZSgwKQogICAgICAgICAsIG1faXNOdWxsKHRydWUpCiAgICAgICAgICwgbV9pc0NhbmNlbGxh dGlvbihmYWxzZSkKKyAgICAgICAgLCBtX2lzVGltZW91dChmYWxzZSkKICAgICB7CiAgICAgfQog CkBAIC02Niw2ICs3MCw3IEBAIHByb3RlY3RlZDoKICAgICAgICAgLCBtX2xvY2FsaXplZERlc2Ny aXB0aW9uKGxvY2FsaXplZERlc2NyaXB0aW9uKQogICAgICAgICAsIG1faXNOdWxsKGZhbHNlKQog ICAgICAgICAsIG1faXNDYW5jZWxsYXRpb24oZmFsc2UpCisgICAgICAgICwgbV9pc1RpbWVvdXQo ZmFsc2UpCiAgICAgewogICAgIH0KIApAQCAtODYsNiArOTEsNyBAQCBwcm90ZWN0ZWQ6CiAgICAg U3RyaW5nIG1fbG9jYWxpemVkRGVzY3JpcHRpb247CiAgICAgYm9vbCBtX2lzTnVsbDsKICAgICBi b29sIG1faXNDYW5jZWxsYXRpb247CisgICAgYm9vbCBtX2lzVGltZW91dDsKIH07CiAKIGlubGlu ZSBib29sIG9wZXJhdG9yPT0oY29uc3QgUmVzb3VyY2VFcnJvciYgYSwgY29uc3QgUmVzb3VyY2VF cnJvciYgYikgeyByZXR1cm4gUmVzb3VyY2VFcnJvckJhc2U6OmNvbXBhcmUoYSwgYik7IH0K