95751 2012-09-04 08:10:16 -0700 [GStreamer] 0.11 build breaks due to rename of gst_message_new_duration 2012-09-04 08:45:40 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned gustavo menard mrobinson webkit.review.bot oldest_to_newest 711126 0 pnormand 2012-09-04 08:10:16 -0700 In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45 gst_message_new_duration was renamed to gst_message_new_duration_changed. However the only place where we used this is in the HTTP source element and only if appsrc < 0.10.27 is used at runtime. In the case of GStreamer 1.0 this condition will be always false so we can disable this code at build time. 711128 1 162045 pnormand 2012-09-04 08:13:11 -0700 Created attachment 162045 Patch 711151 2 pnormand 2012-09-04 08:45:40 -0700 Committed r127469: <http://trac.webkit.org/changeset/127469> 162045 2012-09-04 08:13:11 -0700 2012-09-04 08:33:16 -0700 Patch Patch.patch text/plain 2703 pnormand RnJvbSBmNmZkYWMxMWY0ODhkN2VjNGQ2ZTM2OGExZWMzNTU1Y2U4NmU1MDk0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDQgU2VwIDIwMTIgMTc6MTE6MzUgKzAyMDAKU3ViamVjdDogW1BBVENIXSBQ YXRjaAoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDE5ICsrKysrKysrKysrKysrKysrKysKIC4uLi9ncmFwaGljcy9nc3RyZWFtZXIv V2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcCB8ICAgIDkgKysrLS0tLS0tCiAyIGZpbGVzIGNo YW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQy MDY3M2EuLjhmYzg2NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0wOS0wNCAg UGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJl YW1lcl0gMC4xMSBidWlsZCBicmVha3MgZHVlIHRvIHJlbmFtZSBvZiBnc3RfbWVzc2FnZV9uZXdf ZHVyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk1NzUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW4gZ3N0cmVhbWVyIGNvbW1pdCBmNzEyYTk1OTZjMmJjMTg2M2VkZjliODE2ZDk4NTRlZWZjYTli YTQ1CisgICAgICAgIGdzdF9tZXNzYWdlX25ld19kdXJhdGlvbiB3YXMgcmVuYW1lZCB0bworICAg ICAgICBnc3RfbWVzc2FnZV9uZXdfZHVyYXRpb25fY2hhbmdlZC4KKworICAgICAgICBIb3dldmVy IHRoZSBvbmx5IHBsYWNlIHdoZXJlIHdlIHVzZWQgdGhpcyBpcyBpbiB0aGUgSFRUUCBzb3VyY2UK KyAgICAgICAgZWxlbWVudCBhbmQgb25seSBpZiBhcHBzcmMgPCAwLjEwLjI3IGlzIHVzZWQgYXQg cnVudGltZS4gSW4gdGhlCisgICAgICAgIGNhc2Ugb2YgR1N0cmVhbWVyIDEuMCB0aGlzIGNvbmRp dGlvbiB3aWxsIGJlIGFsd2F5cyBmYWxzZSBzbyB3ZQorICAgICAgICBjYW4gZGlzYWJsZSB0aGlz IGNvZGUgYXQgYnVpbGQgdGltZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAoU3RyZWFtaW5nQ2xp ZW50OjpkaWRSZWNlaXZlUmVzcG9uc2UpOgorCiAyMDEyLTA5LTA0ICBKb25hdGhhbiBMaXUgIDxu ZXQxNDdAZ21haWwuY29tPgogCiAgICAgICAgIEZpeCBJREwgZGVwZW5kZW5jeSBnZW5lcmF0aW9u IGNvcnJlY3RseQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcApp bmRleCBlNTg0YmUyLi43NTA4MTIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNl R1N0cmVhbWVyLmNwcApAQCAtNzgyLDE4ICs3ODIsMTUgQEAgdm9pZCBTdHJlYW1pbmdDbGllbnQ6 OmRpZFJlY2VpdmVSZXNwb25zZShSZXNvdXJjZUhhbmRsZSosIGNvbnN0IFJlc291cmNlUmVzcG9u c2UKICAgICBpZiAobGVuZ3RoID4gMCkgewogICAgICAgICBsZW5ndGggKz0gcHJpdi0+cmVxdWVz dGVkT2Zmc2V0OwogICAgICAgICBnc3RfYXBwX3NyY19zZXRfc2l6ZShwcml2LT5hcHBzcmMsIGxl bmd0aCk7CisKKyNpZm5kZWYgR1NUX0FQSV9WRVJTSU9OXzEKICAgICAgICAgaWYgKCFwcml2LT5o YXZlQXBwU3JjMjcpIHsKLSNpZmRlZiBHU1RfQVBJX1ZFUlNJT05fMQotICAgICAgICAgICAgR3N0 U2VnbWVudCogc2VnbWVudCA9ICZHU1RfQkFTRV9TUkMocHJpdi0+YXBwc3JjKS0+c2VnbWVudDsK LSAgICAgICAgICAgIHNlZ21lbnQtPmR1cmF0aW9uID0gbGVuZ3RoOwotICAgICAgICAgICAgc2Vn bWVudC0+Zm9ybWF0ID0gR1NUX0ZPUk1BVF9CWVRFUzsKLSNlbHNlCiAgICAgICAgICAgICBnc3Rf c2VnbWVudF9zZXRfZHVyYXRpb24oJkdTVF9CQVNFX1NSQyhwcml2LT5hcHBzcmMpLT5zZWdtZW50 LCBHU1RfRk9STUFUX0JZVEVTLCBsZW5ndGgpOwotI2VuZGlmCiAgICAgICAgICAgICBnc3RfZWxl bWVudF9wb3N0X21lc3NhZ2UoR1NUX0VMRU1FTlQocHJpdi0+YXBwc3JjKSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBnc3RfbWVzc2FnZV9uZXdfZHVyYXRpb24oR1NUX09C SkVDVChwcml2LT5hcHBzcmMpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBHU1RfRk9STUFUX0JZVEVTLCBsZW5ndGgpKTsKICAg ICAgICAgfQorI2VuZGlmCiAgICAgfQogCiAgICAgcHJpdi0+c2l6ZSA9IGxlbmd0aCA+PSAwID8g bGVuZ3RoIDogMDsKLS0gCjEuNy4xMC40