95744 2012-09-04 06:47:54 -0700 [chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium 2012-09-04 09:52:32 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 94822 0 kojii peter gavinp peter scottmg oldest_to_newest 711075 0 kojii 2012-09-04 06:47:54 -0700 From https://bugs.webkit.org/show_bug.cgi?id=94822#c9 > Hi, having OpenTypeVerticalData.cpp in both webcore_remaining and > webcore_platform seems to break incremental linking on Windows > Chromium. Is it possible to remove it from one of those libraries? 711080 1 kojii 2012-09-04 06:50:25 -0700 There was a line for webcore_remaining ['OS=="win"', { 'sources/': [ ['include', '/opentype/'], ], so, addition of 3 lines to WebCore.gyp in bug 94822 might be not necessary. Testing... 711131 2 kojii 2012-09-04 08:19:21 -0700 hmm...I just followed the instructions at wiki to enable incremental linking without luck, so I can't verify the fix. I'm using msbuild with VS2010. Scott, can you? 711137 3 162047 kojii 2012-09-04 08:25:46 -0700 Created attachment 162047 Patch 711168 4 scottmg 2012-09-04 09:16:00 -0700 Yes, the removal of the three lines in WebCore.gyp makes the incremental build work again. I'll test now that it doesn't break non-incremental. 711179 5 scottmg 2012-09-04 09:35:28 -0700 Confirmed, this works in both styles of builds. 711191 6 162056 peter 2012-09-04 09:47:09 -0700 Created attachment 162056 Patch 711194 7 peter 2012-09-04 09:50:23 -0700 Committed r127471: <http://trac.webkit.org/changeset/127471> 711196 8 162056 peter 2012-09-04 09:52:32 -0700 Comment on attachment 162056 Patch Committed by request as a buildfix, verified by Scott. Koji also was the person who added these lines initially. 162047 2012-09-04 08:25:46 -0700 2012-09-04 09:47:02 -0700 Patch bug-95744-20120905002529.patch text/plain 1934 kojii U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MzUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOThiMDUyNDNhZWQ4NGRl OWRkZGM1NzJhZWJiZGQyNTAzYTNmNTdkNi4uZTIyMTRiYjY3OTI0YjhjY2ZjMDdkZjU2ZTgwMWNh MTBkZTM2NzlhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTA0ICBLb2pp IElzaGlpICA8a29qaWlzaGlAZ21haWwuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gT3BlblR5 cGVWZXJ0aWNhbERhdGEuY3BwIGluIGJvdGggd2ViY29yZV9yZW1haW5pbmcgYW5kIHdlYmNvcmVf cGxhdGZvcm0gc2VlbXMgdG8gYnJlYWsgaW5jcmVtZW50YWwgbGlua2luZyBvbiBXaW5kb3dzIENo cm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NTc0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBhZGRpdGlvbiBvZiAncGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5cGUvKicgdG8gd2ViY29yZV9w bGF0Zm9ybSBpbiBXZWJDb3JlLmd5cCB3YXMgcmVkdW5kYW50CisgICAgICAgIGJlY2F1c2UgJy9v cGVudHlwZS8nIHdhcyBhbHJlYWR5IGluY2x1ZGVkIHRvIHdlYmNvcmVfcmVtYWluaW5nLgorICAg ICAgICBJdCB3YXMgbm90IG9ubHkgcmVkdW5kYW50IGJ1dCBhbHNvIGJyZWFrcyBpbmNyZW1lbnRh bCBsaW5raW5nLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcmUgcmVxdWlyZWQgYmVjYXVzZSBu byBiZWhhdmlvciBjaGFuZ2VzLgorCisgICAgICAgICogV2ViQ29yZS5neXAvV2ViQ29yZS5neXA6 IFJlbW92ZWQgcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5cGUvKiBmcm9tIHdlYmNvcmVfcGxhdGZv cm0uCisKIDIwMTItMDgtMzEgIENocmlzIEh1dHRlbi1DemFwc2tpICA8Y2h1dHRlbkByaW0uY29t PgogCiAgICAgICAgIC13ZWJraXQtZmxleDogMCBpbiBpbnNwZWN0b3IuY3NzIGlzIGNvbmZ1c2lu ZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAgYi9T b3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCBmYzBmNmRjMzY5YWYz MGZiZWEyYzY2NmUwYzA1YTYyNDk0ZDEwMzA5Li42MjFkYzQ5NGRmMjQ0YTRkNWVjNjM1NzE4M2Fk M2U3ZGVkNmE0MmQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJD b3JlLmd5cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAt MTg0MywxMCArMTg0Myw2IEBACiAgICAgICAgICAgJ3NvdXJjZXMvJzogWwogICAgICAgICAgICAg WydleGNsdWRlJywgJ1Bvc2l4XFwuY3BwJCddLAogCi0gICAgICAgICAgICBbJ2luY2x1ZGUnLCAn cGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5cGUvT3BlblR5cGVUeXBlc1xcLmgkJ10sCi0gICAgICAg ICAgICBbJ2luY2x1ZGUnLCAncGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5cGUvT3BlblR5cGVWZXJ0 aWNhbERhdGFcXC5jcHAkJ10sCi0gICAgICAgICAgICBbJ2luY2x1ZGUnLCAncGxhdGZvcm0vZ3Jh cGhpY3Mvb3BlbnR5cGUvT3BlblR5cGVWZXJ0aWNhbERhdGFcXC5oJCddLAotCiAgICAgICAgICAg ICAjIFRoZSBDaHJvbWl1bSBXaW4gY3VycmVudGx5IHVzZXMgR2x5cGhQYWdlVHJlZU5vZGVDaHJv bWl1bVdpbi5jcHAgZnJvbQogICAgICAgICAgICAgIyBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bSwgaW5jbHVkZWQgYnkgcmVnZXggYWJvdmUsIGluc3RlYWQuCiAgICAgICAgICAgICBbJ2V4Y2x1 ZGUnLCAncGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Gb250Q2FjaGVTa2lhXFwuY3BwJCddLAo= 162056 2012-09-04 09:47:09 -0700 2012-09-04 09:52:32 -0700 Patch bug-95744-20120904174652.patch text/plain 2058 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmExNzMwYjAzNmVkNGZh OWFiN2JiNzg3ZmQxM2ZmMGVlMzA0MDhkMS4uMTE1NzcxNzJjMDQ3YjQ1NTUxOWFiOGY2YjczZTRl ODU4MjAyY2Y2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTA0ICBLb2pp IElzaGlpICA8a29qaWlzaGlAZ21haWwuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gT3BlblR5 cGVWZXJ0aWNhbERhdGEuY3BwIGluIGJvdGggd2ViY29yZV9yZW1haW5pbmcgYW5kIHdlYmNvcmVf cGxhdGZvcm0gc2VlbXMgdG8gYnJlYWsgaW5jcmVtZW50YWwgbGlua2luZyBvbiBXaW5kb3dzIENo cm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NTc0NAorCisgICAgICAgIFBhdGNoIGJ5IEtvamkgSXNoaWkgPGtvamlpc2hpQGdtYWlsLmNvbT4g b24gMjAxMi0wOS0wNAorICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCwgdmVyaWZpZWQgYnkg U2NvdHQgR3JhaGFtLgorCisgICAgICAgIFRoZSBhZGRpdGlvbiBvZiAncGxhdGZvcm0vZ3JhcGhp Y3Mvb3BlbnR5cGUvKicgdG8gd2ViY29yZV9wbGF0Zm9ybSBpbiBXZWJDb3JlLmd5cCB3YXMgcmVk dW5kYW50CisgICAgICAgIGJlY2F1c2UgJy9vcGVudHlwZS8nIHdhcyBhbHJlYWR5IGluY2x1ZGVk IHRvIHdlYmNvcmVfcmVtYWluaW5nLgorICAgICAgICBJdCB3YXMgbm90IG9ubHkgcmVkdW5kYW50 IGJ1dCBhbHNvIGJyZWFrcyBpbmNyZW1lbnRhbCBsaW5raW5nLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyBhcmUgcmVxdWlyZWQgYmVjYXVzZSBubyBiZWhhdmlvciBjaGFuZ2VzLgorCisgICAgICAg ICogV2ViQ29yZS5neXAvV2ViQ29yZS5neXA6IFJlbW92ZWQgcGxhdGZvcm0vZ3JhcGhpY3Mvb3Bl bnR5cGUvKiBmcm9tIHdlYmNvcmVfcGxhdGZvcm0uCisKIDIwMTItMDktMDQgIE90dG8gRGVyZWsg Q2hldW5nICA8b3RjaGV1bmdAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQnJvd3Nl ciBpcyBub3Qgc2VuZGluZyBzZWN1cmVkIENvb2tpZSBiYWNrIHRvIHNlcnZlciBvdmVyIEhUVFBT IGNvbm5lY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNv cmUuZ3lwIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKaW5kZXggZmMw ZjZkYzM2OWFmMzBmYmVhMmM2NjZlMGMwNWE2MjQ5NGQxMDMwOS4uNjIxZGM0OTRkZjI0NGE0ZDVl YzYzNTcxODNhZDNlN2RlZDZhNDJkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29y ZS5neXAvV2ViQ29yZS5neXAKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29y ZS5neXAKQEAgLTE4NDMsMTAgKzE4NDMsNiBAQAogICAgICAgICAgICdzb3VyY2VzLyc6IFsKICAg ICAgICAgICAgIFsnZXhjbHVkZScsICdQb3NpeFxcLmNwcCQnXSwKIAotICAgICAgICAgICAgWydp bmNsdWRlJywgJ3BsYXRmb3JtL2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlVHlwZXNcXC5oJCdd LAotICAgICAgICAgICAgWydpbmNsdWRlJywgJ3BsYXRmb3JtL2dyYXBoaWNzL29wZW50eXBlL09w ZW5UeXBlVmVydGljYWxEYXRhXFwuY3BwJCddLAotICAgICAgICAgICAgWydpbmNsdWRlJywgJ3Bs YXRmb3JtL2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlVmVydGljYWxEYXRhXFwuaCQnXSwKLQog ICAgICAgICAgICAgIyBUaGUgQ2hyb21pdW0gV2luIGN1cnJlbnRseSB1c2VzIEdseXBoUGFnZVRy ZWVOb2RlQ2hyb21pdW1XaW4uY3BwIGZyb20KICAgICAgICAgICAgICMgcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0sIGluY2x1ZGVkIGJ5IHJlZ2V4IGFib3ZlLCBpbnN0ZWFkLgogICAgICAgICAg ICAgWydleGNsdWRlJywgJ3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvRm9udENhY2hlU2tpYVxcLmNw cCQnXSwK