95737 2012-09-04 05:06:49 -0700 Extend the coverage of the Custom Allocation Framework in WTF and in JavaScriptCore 2012-09-04 13:29:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zoltan zoltan benjamin darin eric.carlson eric feature-media-reviews ossy webkit.review.bot oldest_to_newest 710996 0 zoltan 2012-09-04 05:06:49 -0700 Add WTF_MAKE_FAST_ALLOCATED macro to some class declarations in WTF and in JavaScriptCore because these are instantiated by 'new'. 711012 1 162020 zoltan 2012-09-04 05:25:31 -0700 Created attachment 162020 proposed patch 711135 2 eric 2012-09-04 08:22:38 -0700 What happens w/o this change? Are there ports whcih would end up using sytem malloc for these objects by mistake? 711136 3 zoltan 2012-09-04 08:25:46 -0700 (In reply to comment #2) > What happens w/o this change? Are there ports whcih would end up using sytem malloc for these objects by mistake? Ports that don't customize ::new (e.g. qt) use system malloc for these allocations. The macro makes it straightforward for every port. 711139 4 eric 2012-09-04 08:28:24 -0700 ok 711319 5 benjamin 2012-09-04 12:01:06 -0700 May I suggest to extend the style checker to cover that? Chances are people will forget it again. I know I am guilty of this. 711335 6 zoltan 2012-09-04 12:17:09 -0700 (In reply to comment #5) > May I suggest to extend the style checker to cover that? > > Chances are people will forget it again. I know I am guilty of this. It would be good, but we couldn't do that, since static source code analysis is required to find the places. For example some JSValue classes don't have allocation operators, but stored on the JSGC's heap with placement new, or e.g. we don't want to customize memory allocation for QObjects. I'm working on the WebCore's coverage now. I think it's not critical and it's okay if I check it sometimes. 711346 7 162020 webkit.review.bot 2012-09-04 12:35:32 -0700 Comment on attachment 162020 proposed patch Clearing flags on attachment: 162020 Committed r127484: <http://trac.webkit.org/changeset/127484> 711347 8 webkit.review.bot 2012-09-04 12:35:35 -0700 All reviewed patches have been landed. Closing bug. 711348 9 zoltan 2012-09-04 12:38:54 -0700 (In reply to comment #6) > For example some JSValue classes don't have allocation operators, but stored on the JSGC's heap with placement new Let me correct myself. So it can happen that you customize the operator new of a class and you should have not done it. (e.g. basically it inherits the operator new from its base class what you can't see with a grep) 711384 10 benjamin 2012-09-04 13:14:46 -0700 (In reply to comment #9) > Let me correct myself. So it can happen that you customize the operator new of a class and you should have not done it. (e.g. basically it inherits the operator new from its base class what you can't see with a grep) It does not have to be perfect. You'd be surprised how dumb are some test in webkitpy, and yet they work 99% of the time :) 711403 11 zoltan 2012-09-04 13:29:58 -0700 (In reply to comment #10) > (In reply to comment #9) > > Let me correct myself. So it can happen that you customize the operator new of a class and you should have not done it. (e.g. basically it inherits the operator new from its base class what you can't see with a grep) > > It does not have to be perfect. > You'd be surprised how dumb are some test in webkitpy, and yet they work 99% of the time :) I see your point, but the incorrect use of this macro can lead to random crashes. Of course if anyone wants to give it a try to implement a checker for this in check-webkit-style I'd gladly support him. 162020 2012-09-04 05:25:31 -0700 2012-09-04 12:35:31 -0700 proposed patch allocationJSCore.patch text/plain 8158 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDc2NzU1NTYuLjFmMTAyYTAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA5LTA0ICBab2x0YW4gSG9ydmF0 aCAgPHpvbHRhbkB3ZWJraXQub3JnPgorCisgICAgICAgIEV4dGVuZCB0aGUgY292ZXJhZ2Ugb2Yg dGhlIEN1c3RvbSBBbGxvY2F0aW9uIEZyYW1ld29yayBpbiBXVEYgYW5kIGluIEphdmFTY3JpcHRD b3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTcz NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBX VEZfTUFLRV9GQVNUX0FMTE9DQVRFRCBtYWNybyB0byB0aGUgZm9sbG93aW5nIGNsYXNzIGRlY2xh cmF0aW9ucyBiZWNhdXNlIHRoZXNlIGFyZSBpbnN0YW50aWF0ZWQgYnkgb3BlcmF0b3IgbmV3Lgor CisgICAgICAgICogd3RmL0NyeXB0b2dyYXBoaWNhbGx5UmFuZG9tTnVtYmVyLmNwcDogQ3J5cHRv Z3JhcGhpY2FsbHlSYW5kb21OdW1iZXIgaXMgaW5zdGFudGlhdGVkIGF0IHd0Zi9DcnlwdG9ncmFw aGljYWxseVJhbmRvbU51bWJlci5jcHA6MTYyLgorCisgICAgICAgICogaGVhcC9NYWNoaW5lU3Rh Y2tNYXJrZXIuY3BwOgorICAgICAgICAoTWFjaGluZVRocmVhZHM6OlRocmVhZCk6IFRocmVhZCBp cyBpbnN0YW50aWF0ZWQgYXQgaGVhcC9NYWNoaW5lU3RhY2tNYXJrZXIuY3BwOjE5Ni4KKyAgICAg ICAgKiBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcDoKKyAgICAgICAgKEZp eGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvcik6IEZpeGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9j YXRvciBpcyBpbnN0YW50aWF0ZWQgYXQgaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9v bC5jcHA6MTExCisgICAgICAgICogcGFyc2VyL1NvdXJjZVByb3ZpZGVyQ2FjaGUuaDoKKyAgICAg ICAgKFNvdXJjZVByb3ZpZGVyQ2FjaGUpOiBTb3VyY2VQcm92aWRlckNhY2hlIGlzIGluc3RhbnRp YXRlZCBhdCBwYXJzZXIvU291cmNlUHJvdmlkZXIuaDo0OS4KKyAgICAgICAgKiBwYXJzZXIvU291 cmNlUHJvdmlkZXJDYWNoZUl0ZW0uaDoKKyAgICAgICAgKFNvdXJjZVByb3ZpZGVyQ2FjaGVJdGVt KTogU291cmNlUHJvdmlkZXJDYWNoZUl0ZW0gaXMgaW5zdGFudGlhdGVkIGF0IHBhcnNlci9QYXJz ZXIuY3BwOjg0My4KKyAgICAgICAgKiBydW50aW1lL0dDQWN0aXZpdHlDYWxsYmFjay5oOgorICAg ICAgICAoR0NBY3Rpdml0eUNhbGxiYWNrKTogR0NBY3Rpdml0eUNhbGxiYWNrIGlzIGluc3RhbnRp YXRlZCBhdCBydW50aW1lL0dDQWN0aXZpdHlDYWxsYmFjay5oOjk2LgorICAgICAgICAqIHRvb2xz L0NvZGVQcm9maWxlLmg6CisgICAgICAgIChDb2RlUHJvZmlsZSk6IENvZGVQcm9maWxlIGlzIGlu c3RhbnRpYXRlZCBhdCBKYXZhU2NyaXB0Q29yZS90b29scy9Db2RlUHJvZmlsaW5nLmNwcDoxNDAu CisKIDIwMTItMDktMDMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZC4gQnVpbGQgZml4IGZvciBFTkFCTEUoQ0xBU1NJQ19JTlRFUlBS RVRFUikgYWZ0ZXIgcjEyNzM5My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL01hY2hpbmVTdGFja01hcmtlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9N YWNoaW5lU3RhY2tNYXJrZXIuY3BwCmluZGV4IDNjN2ZmOWMuLjI2NDUzYzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hY2hpbmVTdGFja01hcmtlci5jcHAKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFjaGluZVN0YWNrTWFya2VyLmNwcApAQCAtMTA3 LDYgKzEwNyw3IEBAIHN0YXRpYyB2b2lkIHB0aHJlYWRTaWduYWxIYW5kbGVyU3VzcGVuZFJlc3Vt ZShpbnQgc2lnbm8pCiAjZW5kaWYKIAogY2xhc3MgTWFjaGluZVRocmVhZHM6OlRocmVhZCB7Cisg ICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAgVGhyZWFkKGNvbnN0IFBs YXRmb3JtVGhyZWFkJiBwbGF0VGhyZWFkLCB2b2lkKiBiYXNlKQogICAgICAgICA6IHBsYXRmb3Jt VGhyZWFkKHBsYXRUaHJlYWQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAKaW5kZXggYWQzMzQzZC4u N2E1M2I4ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxl QWxsb2NhdG9yRml4ZWRWTVBvb2wuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv RXhlY3V0YWJsZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcApAQCAtNDgsNiArNDgsNyBAQCBuYW1l c3BhY2UgSlNDIHsKIHVpbnRwdHJfdCBzdGFydE9mRml4ZWRFeGVjdXRhYmxlTWVtb3J5UG9vbDsK IAogY2xhc3MgRml4ZWRWTVBvb2xFeGVjdXRhYmxlQWxsb2NhdG9yIDogcHVibGljIE1ldGFBbGxv Y2F0b3IgeworICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgogICAgIEZpeGVk Vk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvcigpCiAgICAgICAgIDogTWV0YUFsbG9jYXRvcihqaXRB bGxvY2F0aW9uR3JhbnVsZSkgLy8gcm91bmQgdXAgYWxsIGFsbG9jYXRpb25zIHRvIDMyIGJ5dGVz CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1NvdXJjZVByb3ZpZGVy Q2FjaGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvU291cmNlUHJvdmlkZXJDYWNo ZS5oCmluZGV4IGU5NDIzMGQuLmMzNDZmYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9wYXJzZXIvU291cmNlUHJvdmlkZXJDYWNoZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9wYXJzZXIvU291cmNlUHJvdmlkZXJDYWNoZS5oCkBAIC0zNCw2ICszNCw3IEBACiBuYW1l c3BhY2UgSlNDIHsKIAogY2xhc3MgU291cmNlUHJvdmlkZXJDYWNoZSB7CisgICAgV1RGX01BS0Vf RkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAgU291cmNlUHJvdmlkZXJDYWNoZSgpIDogbV9j b250ZW50Qnl0ZVNpemUoMCkge30KICAgICBKU19FWFBPUlRfUFJJVkFURSB+U291cmNlUHJvdmlk ZXJDYWNoZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Tb3Vy Y2VQcm92aWRlckNhY2hlSXRlbS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Tb3Vy Y2VQcm92aWRlckNhY2hlSXRlbS5oCmluZGV4IGJmZDM1NjQuLjljYTEyMWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvU291cmNlUHJvdmlkZXJDYWNoZUl0ZW0uaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1NvdXJjZVByb3ZpZGVyQ2FjaGVJdGVt LmgKQEAgLTMzLDYgKzMzLDcgQEAKIG5hbWVzcGFjZSBKU0MgewogCiBjbGFzcyBTb3VyY2VQcm92 aWRlckNhY2hlSXRlbSB7CisgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAg ICAgU291cmNlUHJvdmlkZXJDYWNoZUl0ZW0oaW50IGNsb3NlQnJhY2VMaW5lLCBpbnQgY2xvc2VC cmFjZVBvcykKICAgICAgICAgOiBjbG9zZUJyYWNlTGluZShjbG9zZUJyYWNlTGluZSkgCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9HQ0FjdGl2aXR5Q2FsbGJhY2su aCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0dDQWN0aXZpdHlDYWxsYmFjay5oCmlu ZGV4IDY3ZWUxNzQuLmMxMTJhNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0dDQWN0aXZpdHlDYWxsYmFjay5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0dDQWN0aXZpdHlDYWxsYmFjay5oCkBAIC00Miw2ICs0Miw3IEBAIG5hbWVzcGFjZSBK U0MgewogY2xhc3MgSGVhcDsKIAogY2xhc3MgR0NBY3Rpdml0eUNhbGxiYWNrIDogcHVibGljIEhl YXBUaW1lciB7CisgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAgdmly dHVhbCB2b2lkIGRpZEFsbG9jYXRlKHNpemVfdCkgeyB9CiAgICAgdmlydHVhbCB2b2lkIHdpbGxD b2xsZWN0KCkgeyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvQ29k ZVByb2ZpbGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9Db2RlUHJvZmlsZS5oCmlu ZGV4IGVhMzYwYmMuLmRiMzgwZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90 b29scy9Db2RlUHJvZmlsZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9Db2Rl UHJvZmlsZS5oCkBAIC0zMyw2ICszMyw3IEBACiBuYW1lc3BhY2UgSlNDIHsKIAogY2xhc3MgQ29k ZVByb2ZpbGUgeworICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgogICAgIENv ZGVQcm9maWxlKGNvbnN0IFNvdXJjZUNvZGUmIHNvdXJjZSwgQ29kZVByb2ZpbGUqIHBhcmVudCkK ICAgICAgICAgOiBtX2ZpbGUoc291cmNlLnByb3ZpZGVyKCktPnVybCgpLnV0ZjgoKSkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXgg NzZkNDFhMC4uZDA1NGFlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0wOS0wNCAgWm9sdGFu IEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBFeHRlbmQgdGhlIGNvdmVy YWdlIG9mIHRoZSBDdXN0b20gQWxsb2NhdGlvbiBGcmFtZXdvcmsgaW4gV1RGIGFuZCBpbiBKYXZh U2NyaXB0Q29yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTU3MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQgbWFjcm8gdG8gdGhlIGZvbGxvd2luZyBjbGFz cyBkZWNsYXJhdGlvbnMgYmVjYXVzZSB0aGVzZSBhcmUgaW5zdGFudGlhdGVkIGJ5IG9wZXJhdG9y IG5ldy4KKworICAgICAgICAqIHd0Zi9DcnlwdG9ncmFwaGljYWxseVJhbmRvbU51bWJlci5jcHA6 IENyeXB0b2dyYXBoaWNhbGx5UmFuZG9tTnVtYmVyIGlzIGluc3RhbnRpYXRlZCBhdCB3dGYvQ3J5 cHRvZ3JhcGhpY2FsbHlSYW5kb21OdW1iZXIuY3BwOjE2Mi4KKyAgICAgICAgKiB3dGYvTWVkaWFU aW1lLmg6IE1lZGlhVGltZSBpcyBpbnN0YW50aWF0ZWQgYXQgd3RmL01lZGlhVGltZS5jcHA6Mjg4 LgorICAgICAgICAqIHd0Zi9NZXRhQWxsb2NhdG9yLmg6CisgICAgICAgIChNZXRhQWxsb2NhdG9y VHJhY2tlcik6IE1ldGFBbGxvY2F0b3JUcmFja2VyIGlzIGluc3RhbnRpYXRlZCBhdCBKYXZhU2Ny aXB0Q29yZS90b29scy9Db2RlUHJvZmlsaW5nLmNwcDoxMjAuCisgICAgICAgICogd3RmL1RocmVh ZGluZ1B0aHJlYWRzLmNwcDoKKyAgICAgICAgKFB0aHJlYWRTdGF0ZSk6IFB0aHJlYWRTdGF0ZSBp cyBpbnN0YW50aWF0ZWQgYXQgd3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcDoxNjUuCisgICAgICAg ICogd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcDoKKyAgICAgICAgKEF0b21pY1N0cmluZ1RhYmxl KTogQXRvbWljU3RyaW5nVGFibGUgaXMgaW5zdGFudGlhdGVkIGF0IHd0Zi90ZXh0L0F0b21pY1N0 cmluZy5jcHA6NDMuCisKIDIwMTItMDktMDEgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29t PgogCiAgICAgICAgIExMSW50IEMgbG9vcCBiYWNrZW5kLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dU Ri93dGYvQ3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21OdW1iZXIuY3BwIGIvU291cmNlL1dURi93dGYv Q3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21OdW1iZXIuY3BwCmluZGV4IDhjMTZmNTMuLmU4OTZkNmYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0NyeXB0b2dyYXBoaWNhbGx5UmFuZG9tTnVtYmVy LmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9DcnlwdG9ncmFwaGljYWxseVJhbmRvbU51bWJlci5j cHAKQEAgLTUwLDYgKzUwLDcgQEAgcHVibGljOgogfTsKIAogY2xhc3MgQVJDNFJhbmRvbU51bWJl ckdlbmVyYXRvciB7CisgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAg QVJDNFJhbmRvbU51bWJlckdlbmVyYXRvcigpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0 Zi9NZWRpYVRpbWUuaCBiL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5oCm9sZCBtb2RlIDEwMDY0 NApuZXcgbW9kZSAxMDA3NTUKaW5kZXggNjFkMWU0MS4uNDEzYjFhNwotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9NZWRpYVRpbWUuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9NZWRpYVRpbWUuaApAQCAtMjYs NiArMjYsOCBAQAogICogVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NT SUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCisjaW5jbHVkZSAiRmFzdEFsbG9jQmFzZS5o IgorCiAjaW5jbHVkZSA8Y21hdGg+CiAjaW5jbHVkZSA8bGltaXRzPgogI2luY2x1ZGUgPG1hdGgu aD4KQEAgLTM0LDYgKzM2LDcgQEAKIG5hbWVzcGFjZSBXVEYgewogCiBjbGFzcyBXVEZfRVhQT1JU X1BSSVZBVEUgTWVkaWFUaW1lIHsKKyAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1Ymxp YzoKICAgICBlbnVtIHsKICAgICAgICAgVmFsaWQgPSAxIDw8IDAsCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9NZXRhQWxsb2NhdG9yLmggYi9Tb3VyY2UvV1RGL3d0Zi9NZXRhQWxsb2NhdG9y LmgKaW5kZXggZmRhZDJjOS4uZWNlNjQxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWV0 YUFsbG9jYXRvci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL01ldGFBbGxvY2F0b3IuaApAQCAtNDQs NiArNDQsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICNkZWZpbmUgRU5BQkxFX01FVEFfQUxMT0NBVE9S X1BST0ZJTEUgMAogCiBjbGFzcyBNZXRhQWxsb2NhdG9yVHJhY2tlciB7CisgICAgV1RGX01BS0Vf RkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAgdm9pZCBub3RpZnkoTWV0YUFsbG9jYXRvckhh bmRsZSopOwogICAgIHZvaWQgcmVsZWFzZShNZXRhQWxsb2NhdG9ySGFuZGxlKik7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAgYi9Tb3VyY2UvV1RGL3d0 Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAKaW5kZXggMjI2ZWNiZC4uMGEyNTQ4YyAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwCisrKyBiL1NvdXJjZS9XVEYv d3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcApAQCAtNjIsNiArNjIsNyBAQAogbmFtZXNwYWNlIFdU RiB7CiAKIGNsYXNzIFB0aHJlYWRTdGF0ZSB7CisgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7 CiBwdWJsaWM6CiAgICAgZW51bSBKb2luYWJsZVN0YXRlIHsKICAgICAgICAgSm9pbmFibGUsIC8v IFRoZSBkZWZhdWx0IHRocmVhZCBzdGF0ZS4gVGhlIHRocmVhZCBjYW4gYmUgam9pbmVkIG9uLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwIGIvU291cmNl L1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCmluZGV4IDhmMTRhNWYuLmNiYjVhMjAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcAorKysgYi9Tb3Vy Y2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5jcHAKQEAgLTM3LDYgKzM3LDcgQEAgdXNpbmcg bmFtZXNwYWNlIFVuaWNvZGU7CiBDT01QSUxFX0FTU0VSVChzaXplb2YoQXRvbWljU3RyaW5nKSA9 PSBzaXplb2YoU3RyaW5nKSwgYXRvbWljX3N0cmluZ19hbmRfc3RyaW5nX211c3RfYmVfc2FtZV9z aXplKTsKIAogY2xhc3MgQXRvbWljU3RyaW5nVGFibGUgeworICAgIFdURl9NQUtFX0ZBU1RfQUxM T0NBVEVEOwogcHVibGljOgogICAgIHN0YXRpYyBBdG9taWNTdHJpbmdUYWJsZSogY3JlYXRlKCkK ICAgICB7Cg==