95736 2012-09-04 05:05:09 -0700 hybridPixmap test fails to compile 2012-09-06 04:58:23 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Windows 7 RESOLVED INVALID P2 Normal --- 76773 0 net147 webkit-unassigned ap hausmann kent.hansen ossy oldest_to_newest 710994 0 net147 2012-09-04 05:05:09 -0700 I get a compile error compiling the hybridPixmap test while building WebKit for Qt 5. It complains while compiling ui_widget.h that it is unable to find widget.h. The directory containing widget.h is not in any of the include paths. 710999 1 162016 net147 2012-09-04 05:07:59 -0700 Created attachment 162016 Patch 712889 2 hausmann 2012-09-05 22:35:59 -0700 This is happening for you only on Windows, right? I'm a bit puzzled since I don't see the problem with nmake and msvc (different qmake backend) or with gcc on other platforms (pretty much same backend as mingw) 712894 3 net147 2012-09-05 22:40:24 -0700 I am compiling Qt 5 and QtWebkit with MinGW on Windows as described on http://qt-project.org/wiki/Building_Qt_5_from_Git with the Tools/Scripts/build-webkit script. There is a -I include for the parent directory of hybridPixmap but there is no include for the hybridPixmap directory itself. 713156 4 hausmann 2012-09-06 04:15:22 -0700 I think I've found the reason as to why you're seeing this and I don't. Here's a simplified test-case to illustrate the issue. Imagine the following directory / file structure: main.cpp somedirectory\someheader.h anotherheader.h Suppose someheader.h contains #include "anotherheader.h" and main.cpp includes "someheader.h". When someheader.h is pre-processed the pre-processor will look for anotherheader.h first inside somedirectory. After that GNU CPP stops, whereas MSVC continues "in the directories of any previously opened include files in the reverse order in which they were opened" (from http://msdn.microsoft.com/en-us/library/36k2cdd4.aspx ). qmake seems to have a mechanism for g++ on Linux to make sure that at least the initial "source" directory is in the include search paths, covering this particular issue, but that doesn't seem to be in place for windows builds. Maybe because MSVC doesn't need it, but then it's leaving out g++ on Windows. I'll dig a bit further into qmake for this. 713176 5 hausmann 2012-09-06 04:58:05 -0700 I believe that this is a qmake issue. I've made a patch that can be tracked at https://codereview.qt-project.org/#change,34323 I'm closing this as INVALID, as I believe the bug is in qmake. Let's hope we can fix it there :) 713177 6 162016 hausmann 2012-09-06 04:58:23 -0700 Comment on attachment 162016 Patch Clearing review on the patch, I don't believe that patch should be needed. 162016 2012-09-04 05:07:59 -0700 2012-09-06 04:58:23 -0700 Patch bug-95736.patch text/plain 1080 net147 SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEyNzQ1 NykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5 LTA0ICBKb25hdGhhbiBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAgICAgIEFkZCBtaXNz aW5nIGluY2x1ZGUgcGF0aCBmb3IgaHlicmlkUGl4bWFwIHRlc3QuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTczNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbXBpbGluZyB1aV93aWRnZXQuaCBmYWls cyB0byBmaW5kIHdpZGdldC5oIGJlY2F1c2UgdGhlIGRpcmVjdG9yeQorICAgICAgICBjb250YWlu aW5nIGl0IGlzIG5vdCBpbiBhbnkgb2YgdGhlIGluY2x1ZGUgcGF0aHMuCisKKyAgICAgICAgKiBT b3VyY2UvV2ViS2l0L3F0L3Rlc3RzL2h5YnJpZFBpeG1hcC9oeWJyaWRQaXhtYXAucHJvOgorCiAy MDEyLTA5LTA0ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29t PgogCiAgICAgICAgIEFsbG93IGNoaWxkLWZyYW1lIGNvbnRlbnQgaW4gaGl0LXRlc3RzLgpJbmRl eDogU291cmNlL1dlYktpdC9xdC90ZXN0cy9oeWJyaWRQaXhtYXAvaHlicmlkUGl4bWFwLnBybwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL2h5YnJpZFBpeG1hcC9oeWJyaWRQ aXhtYXAucHJvCShyZXZpc2lvbiAxMjc0NTcpCisrKyBTb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL2h5 YnJpZFBpeG1hcC9oeWJyaWRQaXhtYXAucHJvCSh3b3JraW5nIGNvcHkpCkBAIC04LDMgKzgsNCBA QCBIRUFERVJTICs9IHdpZGdldC5oCiBGT1JNUyArPSB3aWRnZXQudWkKIFJFU09VUkNFUyArPSBy ZXNvdXJjZXMucXJjCiBDT05GSUcgKz0gY29uc29sZQorSU5DTFVERVBBVEggKz0gJCRQV0QK