95730 2012-09-04 04:13:27 -0700 [Qt][Win] Fix IDL dependency generation correctly 2012-09-06 04:04:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P1 Blocker --- 76773 1 net147 webkit-unassigned abecsi ap hausmann ossy vestbo webkit.review.bot oldest_to_newest 710954 0 net147 2012-09-04 04:13:27 -0700 IDL dependency generation is still not working after https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces added after the filename in an echo command end up being added to the file (e.g. "echo test>> test.txt " would add a space at the end of the line in test.txt). 710957 1 162006 net147 2012-09-04 04:22:28 -0700 Created attachment 162006 Patch 710969 2 ossy 2012-09-04 04:36:54 -0700 The trailing whitespace is ugly at the end of the command. But why does it cause problem for you? Windows simple ignores these trailing whitespaces. 710971 3 net147 2012-09-04 04:38:31 -0700 It doesn't ignore the trailing whitespace at least on Windows 7. Try it from a command prompt: type "echo test>> test.txt " (without the quotes and with a space at the end) and press enter. Open test.txt and you will see a trailing space after "test". 710980 4 ossy 2012-09-04 04:43:36 -0700 (In reply to comment #3) > It doesn't ignore the trailing whitespace at least on Windows 7. Try it from a command prompt: type "echo test>> test.txt " (without the quotes and with a space at the end) and press enter. Open test.txt and you will see a trailing space after "test". OMG, you're right, same result on Win XP, crazy Windows' cmd.exe :) 710981 5 162006 ossy 2012-09-04 04:45:18 -0700 Comment on attachment 162006 Patch r=me 710982 6 net147 2012-09-04 04:45:36 -0700 An alternative syntax for echo to a file is: echo>>test.txt blah blah blah That's why it adds the space. 711077 7 162006 webkit.review.bot 2012-09-04 06:48:28 -0700 Comment on attachment 162006 Patch Clearing flags on attachment: 162006 Committed r127467: <http://trac.webkit.org/changeset/127467> 711078 8 webkit.review.bot 2012-09-04 06:48:31 -0700 All reviewed patches have been landed. Closing bug. 162006 2012-09-04 04:22:28 -0700 2012-09-04 06:48:28 -0700 Patch bug-95730.patch text/plain 1867 net147 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNzQ1NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTA0ICBKb25hdGhh biBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAgICAgIEZpeCBJREwgZGVwZW5kZW5jeSBn ZW5lcmF0aW9uIGNvcnJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTU3MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJREwgZGVwZW5kZW5jeSBnZW5lcmF0aW9uIGlzIHN0aWxsIG5vdCB3b3JraW5n IGFmdGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 ODMwNC4gVGhpcyBpcyBiZWNhdXNlIHNwYWNlcworICAgICAgICBhZGRlZCBhZnRlciB0aGUgZmls ZW5hbWUgaW4gYW4gZWNobyBjb21tYW5kIGVuZCB1cCBiZWluZyBhZGRlZCB0byB0aGUKKyAgICAg ICAgZmlsZSB3aGljaCBpc24ndCBoYW5kbGVkIGNvcnJlY3RseSBieSBwcmVwcm9jZXNzLWlkbHMu cGwuIFRoZSBwcm9ibGVtCisgICAgICAgIGlzIGZpeGVkIGJ5IHJlbW92aW5nIHRoZSBzcGFjZSBh ZnRlciB0aGUgZmlsZW5hbWUuCisKKyAgICAgICAgKiBEZXJpdmVkU291cmNlcy5wcmk6CisKIDIw MTItMDktMDQgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogQ3JlYXRlIEphdmFTY3JpcHRTb3VyY2VzIGJhc2VkIG9uIG5ldHdv cmsgcmVzb3VyY2VzLgpJbmRleDogU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMucHJpCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLnByaQkocmV2aXNpb24g MTI3NDU0KQorKysgU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMucHJpCSh3b3JraW5nIGNv cHkpCkBAIC03MDUsNyArNzA1LDggQEAgd2luX2NtZF9zaGVsbDogcHJlcHJvY2Vzc0lkbHMuY29t bWFuZHMgPQogZWxzZTogcHJlcHJvY2Vzc0lkbHMuY29tbWFuZHMgPSBjYXQgL2Rldi9udWxsID4g JCRJRExfRklMRVNfVE1QICQkRU9DCiBmb3IoYmluZGluZywgSURMX0JJTkRJTkdTKSB7CiAgICAg IyBXZSBuZWVkICIkJGJpbmRpbmciIGluc3RlYWQgb2YgIiQkYmluZGluZyAiLCBiZWNhdXNlIFdp bmRvd3MnIGVjaG8gd3JpdGVzIHRyYWlsaW5nIHdoaXRlc3BhY2VzLiAoaHR0cDovL3drYi51Zy84 ODMwNCkKLSAgICBwcmVwcm9jZXNzSWRscy5jb21tYW5kcyArPSBlY2hvICQkYmluZGluZz4+ICQk SURMX0ZJTEVTX1RNUCAkJEVPQworICAgICMgQSBzcGFjZSBpcyBvbWl0dGVkIGJldHdlZW4gIiQk SURMX0ZJTEVTX1RNUCIgYW5kICIkJEVPQyIgdG8gYWxzbyBhdm9pZCB3cml0aW5nIHRyYWlsaW5n IHdoaXRlc3BhY2UuIChodHRwOi8vd2tiLnVnLzk1NzMwKQorICAgIHByZXByb2Nlc3NJZGxzLmNv bW1hbmRzICs9IGVjaG8gJCRiaW5kaW5nPj4gJCRJRExfRklMRVNfVE1QJCRFT0MKIH0KIHByZXBy b2Nlc3NJZGxzLmNvbW1hbmRzICs9IHBlcmwgLUkkJFBXRC9iaW5kaW5ncy9zY3JpcHRzICQkcHJl cHJvY2Vzc0lkbHMuc2NyaXB0IFwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLWRl ZmluZXMgXCIkJHtGRUFUVVJFX0RFRklORVNfSkFWQVNDUklQVH1cIiBcCg==