95728 2012-09-04 03:59:43 -0700 [XMLHttpRequest] overrideMimeType(mime) should throw if state is LOADING or DONE 2018-10-28 10:56:19 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#dom-xmlhttprequest-overridemimetype P2 Normal --- 1 cdumez cdumez abarth ap eric haraken jamesr jonas kenneth oliver rbuis sam syoichi webkit.review.bot youennf oldest_to_newest 710947 0 cdumez 2012-09-04 03:59:43 -0700 According to the latest XMLHttpRequest specification (http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#dom-xmlhttprequest-overridemimetype): The overrideMimeType(mime) throws an "InvalidStateError" exception if the state is LOADING or DONE. The current implementation never throws. 710998 1 162015 cdumez 2012-09-04 05:07:09 -0700 Created attachment 162015 Patch 711008 2 162015 haraken 2012-09-04 05:19:07 -0700 Comment on attachment 162015 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162015&action=review > LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalid-state.html:15 > + finishJSTest(); Is it OK to finish the test here? (I'm not sure why this test proceeds to xhr.readyState == xhr.Done.) > Source/WebCore/ChangeLog:11 > + This behavior is according to the latest XMLHttpRequest specification: Would you check the behavior of other browsers (Firefox, IE, Opera)? You need to take care of compatibility when you try to throw an exception for the code that has not thrown an exception. 711011 3 162015 kenneth 2012-09-04 05:25:17 -0700 Comment on attachment 162015 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162015&action=review >> LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalid-state.html:15 >> + finishJSTest(); > > Is it OK to finish the test here? (I'm not sure why this test proceeds to xhr.readyState == xhr.Done.) Yeah it could just return, or the next if could be an else if 711019 4 haraken 2012-09-04 05:38:32 -0700 (In reply to comment #3) > >> LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalid-state.html:15 > >> + finishJSTest(); > > > > Is it OK to finish the test here? (I'm not sure why this test proceeds to xhr.readyState == xhr.Done.) > > Yeah it could just return, or the next if could be an else if I'm sorry if I'm wrong: (1) xhr.onreadystatechange is invoked. (2) if (xhr.readyState == xhr.LOADING) calls finishJSTest(). (3) finishJSTest() calls testRunner.notifyDone(), which tells the testRunner that the asynchronous test has finished. (4) xhr.onreadystatechange is invoked. (5) if (xhr.readyState == xhr.DONE) calls finishJSTest(). My question is why (4) and (5) run, even though the test has already finished at the point of (3). 711023 5 kenneth 2012-09-04 05:45:39 -0700 (In reply to comment #4) > (In reply to comment #3) > > >> LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalid-state.html:15 > > >> + finishJSTest(); > > > > > > Is it OK to finish the test here? (I'm not sure why this test proceeds to xhr.readyState == xhr.Done.) > > > > Yeah it could just return, or the next if could be an else if > > I'm sorry if I'm wrong: > > (1) xhr.onreadystatechange is invoked. > (2) if (xhr.readyState == xhr.LOADING) calls finishJSTest(). > (3) finishJSTest() calls testRunner.notifyDone(), which tells the testRunner that the asynchronous test has finished. > (4) xhr.onreadystatechange is invoked. > (5) if (xhr.readyState == xhr.DONE) calls finishJSTest(). > > My question is why (4) and (5) run, even though the test has already finished at the point of (3). You are right, of course it should not finish before everything has been tested. 711029 6 cdumez 2012-09-04 05:50:59 -0700 (In reply to comment #4) > (In reply to comment #3) > > >> LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalid-state.html:15 > > >> + finishJSTest(); > > > > > > Is it OK to finish the test here? (I'm not sure why this test proceeds to xhr.readyState == xhr.Done.) > > > > Yeah it could just return, or the next if could be an else if > > I'm sorry if I'm wrong: > > (1) xhr.onreadystatechange is invoked. > (2) if (xhr.readyState == xhr.LOADING) calls finishJSTest(). > (3) finishJSTest() calls testRunner.notifyDone(), which tells the testRunner that the asynchronous test has finished. > (4) xhr.onreadystatechange is invoked. > (5) if (xhr.readyState == xhr.DONE) calls finishJSTest(). > > My question is why (4) and (5) run, even though the test has already finished at the point of (3). Yes, my bad, the finishJSTest() for LOADING case should not be there. I'll remove it. I have checked with Firefox and Opera. None of them throw for this case. I don't have access to IE to test it. 711033 7 haraken 2012-09-04 05:53:29 -0700 (In reply to comment #6) > I have checked with Firefox and Opera. None of them throw for this case. > I don't have access to IE to test it. Then you might want to fix the spec instead. Throwing an exception for the code that has not thrown an exception sounds dangerous. Let's hear opinions of XHR experts. 711041 8 162027 cdumez 2012-09-04 06:05:01 -0700 Created attachment 162027 Patch Fixed the LayoutTest as reported by Haraken. 711043 9 cdumez 2012-09-04 06:09:45 -0700 For your information: The old spec (http://www.w3.org/TR/2010/WD-XMLHttpRequest2-20100907/#the-overridemimetype-method) did not indicate that we should throw for this case. This was corrected later in: http://www.w3.org/TR/2011/WD-XMLHttpRequest2-20110816/#the-overridemimetype-method And the latest working draft still indicates we should throw: http://www.w3.org/TR/2012/WD-XMLHttpRequest-20120117/#the-overridemimetype-method 711170 10 ap 2012-09-04 09:20:04 -0700 Can you find working group discussion that led to this change? We need to somehow verify that this change would be good for WebKit users. 711195 11 cdumez 2012-09-04 09:50:41 -0700 I added James Robinson in CC since it seems he proposed the throwing behavior in: http://lists.w3.org/Archives/Public/public-webapps/2010OctDec/0022.html This thread seems related as well: http://lists.w3.org/Archives/Public/public-webapps/2011AprJun/0261.html 711200 12 cdumez 2012-09-04 09:56:19 -0700 Third related thread: http://lists.w3.org/Archives/Public/public-webapps/2011OctDec/0883.html This relates to the following change in the latest spec: client . overrideMimeType(mime) Sets the Content-Type header for the response to mime. - Throws an INVALID_STATE_ERR exception if the state is not OPENED or HEADERS_RECEIVED. + Throws an "InvalidStateError" exception if the state is LOADING or DONE. 711210 13 ap 2012-09-04 10:24:46 -0700 It's curious that the discussion seems to have revolved around charset only. That case is undoubtedly unfortunate, but what about changing MIME type in order to use responseXML? That should be fine to do later. 976958 14 162027 andersca 2014-02-05 11:13:16 -0800 Comment on attachment 162027 Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag. 1461304 15 rbuis 2018-09-20 05:07:40 -0700 This was fixed in https://bugs.webkit.org/show_bug.cgi?id=136699. 1472828 16 rbuis 2018-10-28 10:56:19 -0700 As stated in Comment 15, I think this is fixed. 162015 2012-09-04 05:07:09 -0700 2012-09-04 06:05:01 -0700 Patch 95728_xhr_overridemime_throw.patch text/plain 6581 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkNTM0OTEzLi44MjM2YmZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDkt MDQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBbWE1MSHR0cFJlcXVlc3RdIG92ZXJyaWRlTWltZVR5cGUobWltZSkgc2hvdWxkIHRocm93 IGlmIHN0YXRlIGlzIExPQURJTkcgb3IgRE9ORQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU3MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IHRvIGNoZWNrIHRoYXQgYW4gIkludmFsaWRT dGF0ZUVycm9yIiBleGNlcHRpb24gaXMgdGhyb3duCisgICAgICAgIGlmIFhNTEh0dHBSZXF1ZXN0 Lm92ZXJyaWRlTWltZVR5cGUoKSBpcyBjYWxsZWQgd2hlbiB0aGUgc3RhdGUgaXMKKyAgICAgICAg TE9BRElORyBvciBET05FLgorCisgICAgICAgICogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC94 bWxodHRwcmVxdWVzdC1vdmVycmlkZW1pbWV0eXBlLWludmFsaWQtc3RhdGUtZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1 ZXN0LW92ZXJyaWRlbWltZXR5cGUtaW52YWxpZC1zdGF0ZS5odG1sOiBBZGRlZC4KKwogMjAxMi0w OS0wNCAgQW5kcmV5IEFkYWlraW4gIDxhYW5kcmV5QGNocm9taXVtLm9yZz4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBbV2ViR0xdIFNhdmUgZ2wuZ2V0RXJyb3IoKSBzdGF0dXMgYmVmb3JlIHRh a2luZyBhIFdlYkdMIHN0YXRlIHNuYXBzaG90IGFuZCByZXN0b3JlIGl0IGFmdGVyd2FyZHMKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1saHR0cHJl cXVlc3Qtb3ZlcnJpZGVtaW1ldHlwZS1pbnZhbGlkLXN0YXRlLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtb3ZlcnJpZGVt aW1ldHlwZS1pbnZhbGlkLXN0YXRlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwLi43NzczOGFhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1vdmVycmlkZW1pbWV0eXBlLWlu dmFsaWQtc3RhdGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTEgQEAKK1RoaXMgdGVzdHMgdGhh dCBYTUxIdHRwUmVxdWVzdCBvdmVycmlkZU1pbWVUeXBlKCkgdGhyb3dzIGFuICJJbnZhbGlkU3Rh dGVFcnJvciIgZXhjZXB0aW9uIGlmIHN0YXRlIGlzIExPQURJTkcgb3IgRE9ORS4KKworT24gc3Vj Y2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQg YnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgeGhyLm92ZXJyaWRlTWltZVR5cGUoInRleHQv cGxhaW4iKSB0aHJldyBleGNlcHRpb24gRXJyb3I6IElOVkFMSURfU1RBVEVfRVJSOiBET00gRXhj ZXB0aW9uIDExLgorUEFTUyB4aHIub3ZlcnJpZGVNaW1lVHlwZSgidGV4dC9wbGFpbiIpIHRocmV3 IGV4Y2VwdGlvbiBFcnJvcjogSU5WQUxJRF9TVEFURV9FUlI6IERPTSBFeGNlcHRpb24gMTEuCitQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVz dC1vdmVycmlkZW1pbWV0eXBlLWludmFsaWQtc3RhdGUuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAv dGVzdHMveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtb3ZlcnJpZGVtaW1ldHlwZS1pbnZh bGlkLXN0YXRlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZGU2YmZl ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVl c3QveG1saHR0cHJlcXVlc3Qtb3ZlcnJpZGVtaW1ldHlwZS1pbnZhbGlkLXN0YXRlLmh0bWwKQEAg LTAsMCArMSwzNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDxsaW5r IHJlbD0iaGVscCIgaHJlZj0iaHR0cDovL3d3dy53My5vcmcvVFIvMjAxMi9XRC1YTUxIdHRwUmVx dWVzdC0yMDEyMDExNy8jdGhlLW92ZXJyaWRlbWltZXR5cGUtbWV0aG9kIiAvPgorICAgIDxzY3Jp cHQgc3JjPSIvanMtdGVzdC1yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorICAg IDxzY3JpcHQ+CisgICAgICAgIGRlc2NyaXB0aW9uKCdUaGlzIHRlc3RzIHRoYXQgWE1MSHR0cFJl cXVlc3Qgb3ZlcnJpZGVNaW1lVHlwZSgpIHRocm93cyBhbiAiSW52YWxpZFN0YXRlRXJyb3IiIGV4 Y2VwdGlvbiBpZiBzdGF0ZSBpcyBMT0FESU5HIG9yIERPTkUuJyk7CisgICAgICAgIHdpbmRvdy5q c1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKworICAgICAgICB2YXIgeGhyID0gbmV3IFhNTEh0dHBSZXF1 ZXN0KCksCisgICAgICAgICAgICB1cmwgPSAncmVzb3VyY2VzL2xvYWQtaWNvbi54aHRtbCc7Cisg ICAgICAgIHhoci5vbnJlYWR5c3RhdGVjaGFuZ2UgPSBmdW5jdGlvbiAoKSB7CisgICAgICAgICAg ICBpZiAoeGhyLnJlYWR5U3RhdGUgPT0geGhyLkxPQURJTkcpIHsKKyAgICAgICAgICAgICAgICBz aG91bGRUaHJvdygneGhyLm92ZXJyaWRlTWltZVR5cGUoInRleHQvcGxhaW4iKScsICciRXJyb3I6 IElOVkFMSURfU1RBVEVfRVJSOiBET00gRXhjZXB0aW9uIDExIicpOworICAgICAgICAgICAgICAg IGZpbmlzaEpTVGVzdCgpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgaWYgKHhoci5yZWFk eVN0YXRlID09IHhoci5ET05FKSB7CisgICAgICAgICAgICAgICAgc2hvdWxkVGhyb3coJ3hoci5v dmVycmlkZU1pbWVUeXBlKCJ0ZXh0L3BsYWluIiknLCAnIkVycm9yOiBJTlZBTElEX1NUQVRFX0VS UjogRE9NIEV4Y2VwdGlvbiAxMSInKTsKKyAgICAgICAgICAgICAgICBmaW5pc2hKU1Rlc3QoKTsK KyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCisgICAgICAgIHhoci5vbmVycm9yID0gZnVuY3Rp b24oKSB7CisgICAgICAgICAgICB0ZXN0RmFpbGVkKCdUaGUgWEhSIHJlcXVlc3QgdG8gYW4gZXhp c3RpbmcgcmVzb3VyY2UgZmFpbGVkOiAiJyArIHVybCArICciJyk7CisgICAgICAgICAgICBmaW5p c2hKU1Rlc3QoKTsKKyAgICAgICAgfTsKKyAgICAgICAgeGhyLm9wZW4oJ0dFVCcsIHVybCk7Cisg ICAgICAgIHhoci5zZW5kKG51bGwpOworICAgIDwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSIv anMtdGVzdC1yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxi b2R5PgorICAgIDxkaXYgaWQ9ImRlc2NyaXB0aW9uIj48L2Rpdj4KKyAgICA8ZGl2IGlkPSJjb25z b2xlIj48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmY2YxYjhhLi4yM2Vj ODEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTItMDktMDQgIENocmlzdG9waGUg RHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbWE1MSHR0cFJl cXVlc3RdIG92ZXJyaWRlTWltZVR5cGUobWltZSkgc2hvdWxkIHRocm93IGlmIHN0YXRlIGlzIExP QURJTkcgb3IgRE9ORQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTU3MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBYTUxIdHRwUmVxdWVzdC5vdmVycmlkZU1pbWVUeXBlKCkgbm93IHRocm93cyBhbiAiSW52 YWxpZFN0YXRlRXJyb3IiCisgICAgICAgIGV4Y2VwdGlvbiBpcyB0aGUgY3VycmVudCBzdGF0ZSBp cyBMT0FESU5HIG9yIERPTkUuCisKKyAgICAgICAgVGhpcyBiZWhhdmlvciBpcyBhY2NvcmRpbmcg dG8gdGhlIGxhdGVzdCBYTUxIdHRwUmVxdWVzdCBzcGVjaWZpY2F0aW9uOgorICAgICAgICBodHRw Oi8vd3d3LnczLm9yZy9UUi8yMDEyL1dELVhNTEh0dHBSZXF1ZXN0LTIwMTIwMTE3LyN0aGUtb3Zl cnJpZGVtaW1ldHlwZS1tZXRob2QKKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL3htbGh0dHBy ZXF1ZXN0L3htbGh0dHByZXF1ZXN0LW92ZXJyaWRlbWltZXR5cGUtaW52YWxpZC1zdGF0ZS5odG1s CisKKyAgICAgICAgKiB4bWwvWE1MSHR0cFJlcXVlc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 WE1MSHR0cFJlcXVlc3Q6Om92ZXJyaWRlTWltZVR5cGUpOgorICAgICAgICAqIHhtbC9YTUxIdHRw UmVxdWVzdC5oOgorICAgICAgICAoWE1MSHR0cFJlcXVlc3QpOgorICAgICAgICAqIHhtbC9YTUxI dHRwUmVxdWVzdC5pZGw6CisKIDIwMTItMDktMDQgIEFuZHJleSBBZGFpa2luICA8YWFuZHJleUBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW1dlYkdMXSBTYXZlIGdsLmdl dEVycm9yKCkgc3RhdHVzIGJlZm9yZSB0YWtpbmcgYSBXZWJHTCBzdGF0ZSBzbmFwc2hvdCBhbmQg cmVzdG9yZSBpdCBhZnRlcndhcmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1M SHR0cFJlcXVlc3QuY3BwIGIvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcApp bmRleCA4ZmI3Y2UwLi5iYzAyYmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1M SHR0cFJlcXVlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5j cHAKQEAgLTg4NCw4ICs4ODQsMTMgQEAgdm9pZCBYTUxIdHRwUmVxdWVzdDo6ZHJvcFByb3RlY3Rp b24oKQogICAgIHVuc2V0UGVuZGluZ0FjdGl2aXR5KHRoaXMpOwogfQogCi12b2lkIFhNTEh0dHBS ZXF1ZXN0OjpvdmVycmlkZU1pbWVUeXBlKGNvbnN0IFN0cmluZyYgb3ZlcnJpZGUpCit2b2lkIFhN TEh0dHBSZXF1ZXN0OjpvdmVycmlkZU1pbWVUeXBlKGNvbnN0IFN0cmluZyYgb3ZlcnJpZGUsIEV4 Y2VwdGlvbkNvZGUmIGVjKQogeworICAgIGlmIChtX3N0YXRlID09IExPQURJTkcgfHwgbV9zdGF0 ZSA9PSBET05FKSB7CisgICAgICAgIGVjID0gSU5WQUxJRF9TVEFURV9FUlI7CisgICAgICAgIHJl dHVybjsKKyAgICB9CisKICAgICBtX21pbWVUeXBlT3ZlcnJpZGUgPSBvdmVycmlkZTsKIH0KIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmggYi9Tb3VyY2Uv V2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaAppbmRleCA2MDY0MjhiLi5hOGIxMmIzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaApAQCAtOTYsNyArOTYsNyBAQCBwdWJsaWM6CiAg ICAgdm9pZCBzZW5kKEFycmF5QnVmZmVyVmlldyosIEV4Y2VwdGlvbkNvZGUmKTsKICAgICB2b2lk IGFib3J0KCk7CiAgICAgdm9pZCBzZXRSZXF1ZXN0SGVhZGVyKGNvbnN0IEF0b21pY1N0cmluZyYg bmFtZSwgY29uc3QgU3RyaW5nJiB2YWx1ZSwgRXhjZXB0aW9uQ29kZSYpOwotICAgIHZvaWQgb3Zl cnJpZGVNaW1lVHlwZShjb25zdCBTdHJpbmcmIG92ZXJyaWRlKTsKKyAgICB2b2lkIG92ZXJyaWRl TWltZVR5cGUoY29uc3QgU3RyaW5nJiBvdmVycmlkZSwgRXhjZXB0aW9uQ29kZSYpOwogICAgIFN0 cmluZyBnZXRBbGxSZXNwb25zZUhlYWRlcnMoRXhjZXB0aW9uQ29kZSYpIGNvbnN0OwogICAgIFN0 cmluZyBnZXRSZXNwb25zZUhlYWRlcihjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUsIEV4Y2VwdGlv bkNvZGUmKSBjb25zdDsKICAgICBTdHJpbmcgcmVzcG9uc2VUZXh0KEV4Y2VwdGlvbkNvZGUmKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5pZGwgYi9Tb3Vy Y2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaWRsCmluZGV4IGM5NTU3YjMuLjVlNjRjODYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5pZGwKKysrIGIv U291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmlkbApAQCAtMTA3LDcgKzEwNyw4IEBA IG1vZHVsZSB4bWwgewogICAgICAgICAgICAgZ2V0dGVyIHJhaXNlcyhET01FeGNlcHRpb24pOwog CiAgICAgICAgIC8vIEV4dGVuc2lvbgotICAgICAgICB2b2lkIG92ZXJyaWRlTWltZVR5cGUoaW4g RE9NU3RyaW5nIG92ZXJyaWRlKTsKKyAgICAgICAgdm9pZCBvdmVycmlkZU1pbWVUeXBlKGluIERP TVN0cmluZyBvdmVycmlkZSkKKyAgICAgICAgICAgIHJhaXNlcyhET01FeGNlcHRpb24pOwogCiAg ICAgICAgIC8vIEV2ZW50VGFyZ2V0IGludGVyZmFjZQogICAgICAgICB2b2lkIGFkZEV2ZW50TGlz dGVuZXIoaW4gRE9NU3RyaW5nIHR5cGUsIAo= 162027 2012-09-04 06:05:01 -0700 2014-02-05 11:13:14 -0800 Patch 95728_xhr_overridemime_throw.patch text/plain 6427 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxYWEzOTVlLi4wOTEyOWRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDkt MDQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBbWE1MSHR0cFJlcXVlc3RdIG92ZXJyaWRlTWltZVR5cGUobWltZSkgc2hvdWxkIHRocm93 IGlmIHN0YXRlIGlzIExPQURJTkcgb3IgRE9ORQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU3MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IHRvIGNoZWNrIHRoYXQgYW4gIkludmFsaWRT dGF0ZUVycm9yIiBleGNlcHRpb24gaXMgdGhyb3duCisgICAgICAgIGlmIFhNTEh0dHBSZXF1ZXN0 Lm92ZXJyaWRlTWltZVR5cGUoKSBpcyBjYWxsZWQgd2hlbiB0aGUgc3RhdGUgaXMKKyAgICAgICAg TE9BRElORyBvciBET05FLgorCisgICAgICAgICogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC94 bWxodHRwcmVxdWVzdC1vdmVycmlkZW1pbWV0eXBlLWludmFsaWQtc3RhdGUtZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1 ZXN0LW92ZXJyaWRlbWltZXR5cGUtaW52YWxpZC1zdGF0ZS5odG1sOiBBZGRlZC4KKwogMjAxMi0w OS0wNCAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNvbT4KIAog ICAgICAgICBBbGxvdyBjaGlsZC1mcmFtZSBjb250ZW50IGluIGhpdC10ZXN0cy4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qt b3ZlcnJpZGVtaW1ldHlwZS1pbnZhbGlkLXN0YXRlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtb3ZlcnJpZGVtaW1ldHlw ZS1pbnZhbGlkLXN0YXRlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi43NzczOGFhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1vdmVycmlkZW1pbWV0eXBlLWludmFsaWQt c3RhdGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTEgQEAKK1RoaXMgdGVzdHMgdGhhdCBYTUxI dHRwUmVxdWVzdCBvdmVycmlkZU1pbWVUeXBlKCkgdGhyb3dzIGFuICJJbnZhbGlkU3RhdGVFcnJv ciIgZXhjZXB0aW9uIGlmIHN0YXRlIGlzIExPQURJTkcgb3IgRE9ORS4KKworT24gc3VjY2Vzcywg eW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRF U1QgQ09NUExFVEUiLgorCisKK1BBU1MgeGhyLm92ZXJyaWRlTWltZVR5cGUoInRleHQvcGxhaW4i KSB0aHJldyBleGNlcHRpb24gRXJyb3I6IElOVkFMSURfU1RBVEVfRVJSOiBET00gRXhjZXB0aW9u IDExLgorUEFTUyB4aHIub3ZlcnJpZGVNaW1lVHlwZSgidGV4dC9wbGFpbiIpIHRocmV3IGV4Y2Vw dGlvbiBFcnJvcjogSU5WQUxJRF9TVEFURV9FUlI6IERPTSBFeGNlcHRpb24gMTEuCitQQVNTIHN1 Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1vdmVy cmlkZW1pbWV0eXBlLWludmFsaWQtc3RhdGUuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMv eG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtb3ZlcnJpZGVtaW1ldHlwZS1pbnZhbGlkLXN0 YXRlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMmIyNTg1MwotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1s aHR0cHJlcXVlc3Qtb3ZlcnJpZGVtaW1ldHlwZS1pbnZhbGlkLXN0YXRlLmh0bWwKQEAgLTAsMCAr MSwzNSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDxsaW5rIHJlbD0i aGVscCIgaHJlZj0iaHR0cDovL3d3dy53My5vcmcvVFIvMjAxMi9XRC1YTUxIdHRwUmVxdWVzdC0y MDEyMDExNy8jdGhlLW92ZXJyaWRlbWltZXR5cGUtbWV0aG9kIiAvPgorICAgIDxzY3JpcHQgc3Jj PSIvanMtdGVzdC1yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorICAgIDxzY3Jp cHQ+CisgICAgICAgIGRlc2NyaXB0aW9uKCdUaGlzIHRlc3RzIHRoYXQgWE1MSHR0cFJlcXVlc3Qg b3ZlcnJpZGVNaW1lVHlwZSgpIHRocm93cyBhbiAiSW52YWxpZFN0YXRlRXJyb3IiIGV4Y2VwdGlv biBpZiBzdGF0ZSBpcyBMT0FESU5HIG9yIERPTkUuJyk7CisgICAgICAgIHdpbmRvdy5qc1Rlc3RJ c0FzeW5jID0gdHJ1ZTsKKworICAgICAgICB2YXIgeGhyID0gbmV3IFhNTEh0dHBSZXF1ZXN0KCks CisgICAgICAgICAgICB1cmwgPSAncmVzb3VyY2VzL2xvYWQtaWNvbi54aHRtbCc7CisgICAgICAg IHhoci5vbnJlYWR5c3RhdGVjaGFuZ2UgPSBmdW5jdGlvbiAoKSB7CisgICAgICAgICAgICBpZiAo eGhyLnJlYWR5U3RhdGUgPT0geGhyLkxPQURJTkcpIHsKKyAgICAgICAgICAgICAgICBzaG91bGRU aHJvdygneGhyLm92ZXJyaWRlTWltZVR5cGUoInRleHQvcGxhaW4iKScsICciRXJyb3I6IElOVkFM SURfU1RBVEVfRVJSOiBET00gRXhjZXB0aW9uIDExIicpOworICAgICAgICAgICAgfQorICAgICAg ICAgICAgZWxzZSBpZiAoeGhyLnJlYWR5U3RhdGUgPT0geGhyLkRPTkUpIHsKKyAgICAgICAgICAg ICAgICBzaG91bGRUaHJvdygneGhyLm92ZXJyaWRlTWltZVR5cGUoInRleHQvcGxhaW4iKScsICci RXJyb3I6IElOVkFMSURfU1RBVEVfRVJSOiBET00gRXhjZXB0aW9uIDExIicpOworICAgICAgICAg ICAgICAgIGZpbmlzaEpTVGVzdCgpOworICAgICAgICAgICAgfQorICAgICAgICB9CisKKyAgICAg ICAgeGhyLm9uZXJyb3IgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHRlc3RGYWlsZWQoJ1Ro ZSBYSFIgcmVxdWVzdCB0byBhbiBleGlzdGluZyByZXNvdXJjZSBmYWlsZWQ6ICInICsgdXJsICsg JyInKTsKKyAgICAgICAgICAgIGZpbmlzaEpTVGVzdCgpOworICAgICAgICB9OworICAgICAgICB4 aHIub3BlbignR0VUJywgdXJsKTsKKyAgICAgICAgeGhyLnNlbmQobnVsbCk7CisgICAgPC9zY3Jp cHQ+CisgICAgPHNjcmlwdCBzcmM9Ii9qcy10ZXN0LXJlc291cmNlcy9qcy10ZXN0LXBvc3QuanMi Pjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisgICAgPGRpdiBpZD0iZGVzY3JpcHRpb24iPjwv ZGl2PgorICAgIDxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IGM1NDc0ODMuLjFiODdiYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAor MjAxMi0wOS0wNCAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29t PgorCisgICAgICAgIFtYTUxIdHRwUmVxdWVzdF0gb3ZlcnJpZGVNaW1lVHlwZShtaW1lKSBzaG91 bGQgdGhyb3cgaWYgc3RhdGUgaXMgTE9BRElORyBvciBET05FCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTcyOAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFhNTEh0dHBSZXF1ZXN0Lm92ZXJyaWRlTWltZVR5 cGUoKSBub3cgdGhyb3dzIGFuICJJbnZhbGlkU3RhdGVFcnJvciIKKyAgICAgICAgZXhjZXB0aW9u IGlzIHRoZSBjdXJyZW50IHN0YXRlIGlzIExPQURJTkcgb3IgRE9ORS4KKworICAgICAgICBUaGlz IGJlaGF2aW9yIGlzIGFjY29yZGluZyB0byB0aGUgbGF0ZXN0IFhNTEh0dHBSZXF1ZXN0IHNwZWNp ZmljYXRpb246CisgICAgICAgIGh0dHA6Ly93d3cudzMub3JnL1RSLzIwMTIvV0QtWE1MSHR0cFJl cXVlc3QtMjAxMjAxMTcvI3RoZS1vdmVycmlkZW1pbWV0eXBlLW1ldGhvZAorCisgICAgICAgIFRl c3Q6IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtb3ZlcnJpZGVtaW1l dHlwZS1pbnZhbGlkLXN0YXRlLmh0bWwKKworICAgICAgICAqIHhtbC9YTUxIdHRwUmVxdWVzdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpYTUxIdHRwUmVxdWVzdDo6b3ZlcnJpZGVNaW1lVHlwZSk6 CisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0Lmg6CisgICAgICAgIChYTUxIdHRwUmVxdWVz dCk6CisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0LmlkbDoKKwogMjAxMi0wOS0wNCAgQWxs YW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNvbT4KIAogICAgICAgICBB bGxvdyBjaGlsZC1mcmFtZSBjb250ZW50IGluIGhpdC10ZXN0cy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS94bWwvWE1M SHR0cFJlcXVlc3QuY3BwCmluZGV4IDhmYjdjZTAuLmJjMDJiYTggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUveG1s L1hNTEh0dHBSZXF1ZXN0LmNwcApAQCAtODg0LDggKzg4NCwxMyBAQCB2b2lkIFhNTEh0dHBSZXF1 ZXN0Ojpkcm9wUHJvdGVjdGlvbigpCiAgICAgdW5zZXRQZW5kaW5nQWN0aXZpdHkodGhpcyk7CiB9 CiAKLXZvaWQgWE1MSHR0cFJlcXVlc3Q6Om92ZXJyaWRlTWltZVR5cGUoY29uc3QgU3RyaW5nJiBv dmVycmlkZSkKK3ZvaWQgWE1MSHR0cFJlcXVlc3Q6Om92ZXJyaWRlTWltZVR5cGUoY29uc3QgU3Ry aW5nJiBvdmVycmlkZSwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7CisgICAgaWYgKG1fc3RhdGUgPT0g TE9BRElORyB8fCBtX3N0YXRlID09IERPTkUpIHsKKyAgICAgICAgZWMgPSBJTlZBTElEX1NUQVRF X0VSUjsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIG1fbWltZVR5cGVPdmVycmlkZSA9 IG92ZXJyaWRlOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJl cXVlc3QuaCBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5oCmluZGV4IDYwNjQy OGIuLmE4YjEyYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVz dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5oCkBAIC05Niw3ICs5 Niw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHNlbmQoQXJyYXlCdWZmZXJWaWV3KiwgRXhjZXB0aW9u Q29kZSYpOwogICAgIHZvaWQgYWJvcnQoKTsKICAgICB2b2lkIHNldFJlcXVlc3RIZWFkZXIoY29u c3QgQXRvbWljU3RyaW5nJiBuYW1lLCBjb25zdCBTdHJpbmcmIHZhbHVlLCBFeGNlcHRpb25Db2Rl Jik7Ci0gICAgdm9pZCBvdmVycmlkZU1pbWVUeXBlKGNvbnN0IFN0cmluZyYgb3ZlcnJpZGUpOwor ICAgIHZvaWQgb3ZlcnJpZGVNaW1lVHlwZShjb25zdCBTdHJpbmcmIG92ZXJyaWRlLCBFeGNlcHRp b25Db2RlJik7CiAgICAgU3RyaW5nIGdldEFsbFJlc3BvbnNlSGVhZGVycyhFeGNlcHRpb25Db2Rl JikgY29uc3Q7CiAgICAgU3RyaW5nIGdldFJlc3BvbnNlSGVhZGVyKGNvbnN0IEF0b21pY1N0cmlu ZyYgbmFtZSwgRXhjZXB0aW9uQ29kZSYpIGNvbnN0OwogICAgIFN0cmluZyByZXNwb25zZVRleHQo RXhjZXB0aW9uQ29kZSYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBS ZXF1ZXN0LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5pZGwKaW5kZXgg Yzk1NTdiMy4uNWU2NGM4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBS ZXF1ZXN0LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaWRsCkBA IC0xMDcsNyArMTA3LDggQEAgbW9kdWxlIHhtbCB7CiAgICAgICAgICAgICBnZXR0ZXIgcmFpc2Vz KERPTUV4Y2VwdGlvbik7CiAKICAgICAgICAgLy8gRXh0ZW5zaW9uCi0gICAgICAgIHZvaWQgb3Zl cnJpZGVNaW1lVHlwZShpbiBET01TdHJpbmcgb3ZlcnJpZGUpOworICAgICAgICB2b2lkIG92ZXJy aWRlTWltZVR5cGUoaW4gRE9NU3RyaW5nIG92ZXJyaWRlKQorICAgICAgICAgICAgcmFpc2VzKERP TUV4Y2VwdGlvbik7CiAKICAgICAgICAgLy8gRXZlbnRUYXJnZXQgaW50ZXJmYWNlCiAgICAgICAg IHZvaWQgYWRkRXZlbnRMaXN0ZW5lcihpbiBET01TdHJpbmcgdHlwZSwgCg==