95724 2012-09-04 03:14:09 -0700 [EFL] Fix build error in NetworkStateNotifierEfl.cpp 2012-09-04 04:24:54 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kangil.han kenneth lucas.de.marchi ryuan.choi webkit.review.bot oldest_to_newest 710928 0 cdumez 2012-09-04 03:14:09 -0700 People have reported the following build error when using Ubuntu 11.10: Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:144:10: error: ‘struct sockaddr_nl’ has no member named ‘nl_family’ This builds just fine on Ubuntu 12.04 though. The reason for the compilation order is that on some systems, <sys/socket.h> must be included BEFORE <linux/netlink.h>. Unfortunately, this is against coding style (includes should be in alphabetical order) but I don't think we have a choice here. 710929 1 161998 cdumez 2012-09-04 03:16:42 -0700 Created attachment 161998 Patch 710930 2 webkit.review.bot 2012-09-04 03:19:01 -0700 Attachment 161998 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:38: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 710931 3 cdumez 2012-09-04 03:21:49 -0700 The style error is expected. We have to code against style here to include headers in a specific order. 710959 4 161998 webkit.review.bot 2012-09-04 04:24:50 -0700 Comment on attachment 161998 Patch Clearing flags on attachment: 161998 Committed r127455: <http://trac.webkit.org/changeset/127455> 710960 5 webkit.review.bot 2012-09-04 04:24:54 -0700 All reviewed patches have been landed. Closing bug. 161998 2012-09-04 03:16:42 -0700 2012-09-04 04:24:50 -0700 Patch 95724_build_fix.patch text/plain 1615 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNjY1MzJjLi5lYTY0Y2IyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDktMDQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXSBGaXggYnVpbGQgZXJyb3IgaW4gTmV0d29ya1N0YXRlTm90 aWZpZXJFZmwuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NTcyNAorCisgICAgICAgIFVucmV2aWV3ZWQgRUZMIGJ1aWxkIGZpeC4KKworICAgICAg ICBNYWtlIHN1cmUgPHN5cy9zb2NrZXQuaD4gaXMgaW5jbHVkZWQgYmVmb3JlCisgICAgICAgIDxs aW51eC9uZXRsaW5rLmg+IHRvIGZpeCBidWlsZCBlcnJvcnMgb24gc29tZQorICAgICAgICBzeXN0 ZW1zIChlLmcuIFVidW50dSAxMS4xMCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhh dmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2VmbC9OZXR3b3JrU3Rh dGVOb3RpZmllckVmbC5jcHA6CisKIDIwMTItMDktMDMgIENocmlzdG9waGUgRHVtZXogIDxjaHJp c3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBBdXRvbWF0aWMgZmVhdHVyZXMgc2hv dWxkIHdvcmsgaW4gc2FuZGJveGVkIGlmcmFtZXMgaWYgImFsbG93LXNjcmlwdHMiIGZsYWcgaXMg c2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2VmbC9OZXR3 b3JrU3RhdGVOb3RpZmllckVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2VmbC9OZXR3b3JrU3RhdGVOb3RpZmllckVmbC5jcHAKaW5kZXggY2I4OTczOC4uNGIxYTQ3ZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9lZmwvTmV0d29ya1N0 YXRlTm90aWZpZXJFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv ZWZsL05ldHdvcmtTdGF0ZU5vdGlmaWVyRWZsLmNwcApAQCAtMzEsMTIgKzMxLDE0IEBACiAjaW5j bHVkZSA8RWV6ZS5oPgogI2luY2x1ZGUgPEVlemVfTmV0Lmg+CiAjaW5jbHVkZSA8YXNtL3R5cGVz Lmg+Ci0jaW5jbHVkZSA8bGludXgvbmV0bGluay5oPgotI2luY2x1ZGUgPGxpbnV4L3J0bmV0bGlu ay5oPgogI2luY2x1ZGUgPHN0cmluZy5oPgogI2luY2x1ZGUgPHN5cy9zb2NrZXQuaD4KICNpbmNs dWRlIDx1bmlzdGQuaD4KIAorLy8gTXVzdCBjb21lIGF0IHRoZSBlbmQgc28gdGhhdCBzeXMvc29j a2V0LmggaXMgaW5jbHVkZWQgZmlyc3QuCisjaW5jbHVkZSA8bGludXgvbmV0bGluay5oPgorI2lu Y2x1ZGUgPGxpbnV4L3J0bmV0bGluay5oPgorCiBzdGF0aWMgY29uc3QgY2hhciB1ZGV2TG9vcEJh Y2tJbnRlcmZhY2VTeXNQYXRoW10gPSAibG8iOwogc3RhdGljIGNvbnN0IGNoYXIgdWRldk9wZXJz dGF0ZUF0dHJpYnV0ZVtdID0gIm9wZXJzdGF0ZSI7CiBzdGF0aWMgY29uc3QgY2hhciB1ZGV2T3Bl cnN0YXRlVXBbXSA9ICJ1cCI7Cg==