95710 2012-09-03 23:02:05 -0700 [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver 2012-09-06 06:20:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kbalazs kbalazs abarth dpranke ojan webkit.review.bot oldest_to_newest 710823 0 kbalazs 2012-09-03 23:02:05 -0700 It has been revealed when I tested a patch that makes a lot of tests failing. In driver.run_test an exception can raise here: if stop_when_done or crashed or timed_out: # We call stop() even if we crashed or timed out in order to get any remaining stdout/stderr output. # In the timeout case, we kill the hung process as well. out, err = self._server_process.stop(self._port.driver_stop_timeout() if stop_when_done else 0.0) text += out self.error_from_test += err at the += if out or err is None. Although it probably not shown on trunk we should make sure the harness can handle a driver in a bad state. 710825 1 161968 kbalazs 2012-09-03 23:06:13 -0700 Created attachment 161968 Patch 713227 2 161968 kbalazs 2012-09-06 06:20:50 -0700 Comment on attachment 161968 Patch Clearing flags on attachment: 161968 Committed r127734: <http://trac.webkit.org/changeset/127734> 713228 3 kbalazs 2012-09-06 06:20:54 -0700 All reviewed patches have been landed. Closing bug. 161968 2012-09-03 23:06:13 -0700 2012-09-06 06:20:50 -0700 Patch bug-95710-20120904080552.patch text/plain 1735 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTM2MDllMmUzZWNhMTFlMjNjYzA5NjM2NDFkZjNmYzYz OTZmNzA2MC4uMWNjMzk1NWYyMjIyOGZhY2FmZGZkYjE3ZGRmODRlZmJkYjA1MDkwNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA5LTAzICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKwor ICAgICAgICBbbnJ3dF0gSGFyZGVuIGFnYWluc3QgZW1wdHkgc3Rkb3V0L3N0ZGVyciBhZnRlciBz dG9wcGluZyBhIGNyYXNoZWQvdGltZWQgb3V0IGRyaXZlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU3MTAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc3Rkb3V0IC8gc3RkZXJyIG91dHB1dCBjYW4g YmUgTm9uZSBzbyBtYWtlIHN1cmUKKyAgICAgICAgd2Ugd29uJ3QgcmFpc2UgYW4gZXhjZXB0aW9u IGluIHRoaXMgY2FzZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvZHJpdmVyLnB5OgorICAgICAgICAoRHJpdmVyLnJ1bl90ZXN0KToKKwogMjAxMi0wOS0w MyAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0g Q2hhbmdlIHRoZSBmb2N1cyB3aGVuIHRoZSB3ZWIgdmlldyBpcyBjbGlja2VkIGluIE1pbmlCcm93 c2VyIGFuZCBFV2ViTGF1bmNoZXIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvZHJpdmVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9kcml2ZXIucHkKaW5kZXggY2MyNTExOWNiNzZlODBjNzZkOWM5ZTNkNWMz ZjBjODA1NjMwY2NiNy4uMGM2ZWY3MGZlYzVmYjA4MDJlODU4OGZhOWYwMjNiMDE1ZmUwNjVmMiAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9kcml2 ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9kcml2 ZXIucHkKQEAgLTE2NSw4ICsxNjUsMTAgQEAgY2xhc3MgRHJpdmVyKG9iamVjdCk6CiAgICAgICAg ICAgICAjIFdlIGNhbGwgc3RvcCgpIGV2ZW4gaWYgd2UgY3Jhc2hlZCBvciB0aW1lZCBvdXQgaW4g b3JkZXIgdG8gZ2V0IGFueSByZW1haW5pbmcgc3Rkb3V0L3N0ZGVyciBvdXRwdXQuCiAgICAgICAg ICAgICAjIEluIHRoZSB0aW1lb3V0IGNhc2UsIHdlIGtpbGwgdGhlIGh1bmcgcHJvY2VzcyBhcyB3 ZWxsLgogICAgICAgICAgICAgb3V0LCBlcnIgPSBzZWxmLl9zZXJ2ZXJfcHJvY2Vzcy5zdG9wKHNl bGYuX3BvcnQuZHJpdmVyX3N0b3BfdGltZW91dCgpIGlmIHN0b3Bfd2hlbl9kb25lIGVsc2UgMC4w KQotICAgICAgICAgICAgdGV4dCArPSBvdXQKLSAgICAgICAgICAgIHNlbGYuZXJyb3JfZnJvbV90 ZXN0ICs9IGVycgorICAgICAgICAgICAgaWYgb3V0OgorICAgICAgICAgICAgICAgIHRleHQgKz0g b3V0CisgICAgICAgICAgICBpZiBlcnI6CisgICAgICAgICAgICAgICAgc2VsZi5lcnJvcl9mcm9t X3Rlc3QgKz0gZXJyCiAgICAgICAgICAgICBzZWxmLl9zZXJ2ZXJfcHJvY2VzcyA9IE5vbmUKIAog ICAgICAgICBjcmFzaF9sb2cgPSBOb25lCg==