95704 2012-09-03 19:25:17 -0700 Add performance test for Entry.getFile 2014-02-05 11:12:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 95668 1 tzik tzik ap ericu kinuko rniwa oldest_to_newest 710793 0 tzik 2012-09-03 19:25:17 -0700 I'm adding performance test for Entry.getFile. 710795 1 161959 tzik 2012-09-03 19:45:58 -0700 Created attachment 161959 Patch 711690 2 161959 kinuko 2012-09-04 20:54:52 -0700 Comment on attachment 161959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161959&action=review > PerformanceTests/FileSystem/create-file.html:13 > + description: "This benchmark tests creating new file using FileSystem API", It'd be more informative to include the method we're testing (E.g. "...tests tests creating new files by Entry.getFile()") > PerformanceTests/FileSystem/create-file.html:26 > + fileSystem.root.getFile(dir_name + "/" + i++, {create: true, exclusive: true}, done); If error occurs we never call done or log anything? 976954 3 161959 andersca 2014-02-05 11:12:55 -0800 Comment on attachment 161959 Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag. 161959 2012-09-03 19:45:58 -0700 2014-02-05 11:12:55 -0800 Patch bug-95704-20120904114541.patch text/plain 2184 tzik U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDM2CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg5ZjkwZmZkODQx ODA5YzBiYmQ2MjVjNDY4NDk1MWVjMGRjMDkzMmUuLmYyNmYwOGU0OTYzNTY1MjZmN2MzMWUyODY5 Mjk0NDE5OGM1MTM0MDcgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTItMDkt MDMgIFRhaWp1IFRzdWlraSAgPHR6aWtAY2hyb21pdW0ub3JnPgogCisgICAgICAgIEFkZCBwZXJm b3JtYW5jZSB0ZXN0IGZvciBFbnRyeS5nZXRGaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTcwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHBlcmZvcm1hbmNlIHRlc3QgZm9yIGNyZWF0aW5n IGZpbGUgYnkgRW50cnkuZ2V0RmlsZSB0byBjaGVjayBpZgorICAgICAgICB3ZSBkb24ndCBodXJ0 IGl0cyBwZXJmb3JtYW5jZS4KKworICAgICAgICAqIEZpbGVTeXN0ZW0vY3JlYXRlLWZpbGUuaHRt bDogQWRkZWQuCisKKzIwMTItMDktMDMgIFRhaWp1IFRzdWlraSAgPHR6aWtAY2hyb21pdW0ub3Jn PgorCiAgICAgICAgIFBlcmZvcm1hbmNlIHRlc3Qgc2hvdWxkIHN1cHBvcnQgYXN5bmNocm9ub3Vz IHRlc3RzLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTU2NjgKIApkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9GaWxlU3lzdGVtL2NyZWF0ZS1m aWxlLmh0bWwgYi9QZXJmb3JtYW5jZVRlc3RzL0ZpbGVTeXN0ZW0vY3JlYXRlLWZpbGUuaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi4zM2FkNGM4NzdjODdmNDA5YzE0OTA4NTNkYTJkNjViOGZiMGY4Y2QyCi0tLSAv ZGV2L251bGwKKysrIGIvUGVyZm9ybWFuY2VUZXN0cy9GaWxlU3lzdGVtL2NyZWF0ZS1maWxlLmh0 bWwKQEAgLTAsMCArMSwzMCBAQAorPCFET0NUWVBFIGh0bWw+Cis8bWV0YSBjaGFyc2V0PSJVVEYt OCI+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL3J1bm5lci5qcyI+PC9zY3JpcHQ+Cis8c2Ny aXB0PgoraWYgKCF3aW5kb3cud2Via2l0UmVxdWVzdEZpbGVTeXN0ZW0pCisgICAgY29uc29sZS5s b2coIlRoaXMgdGVzdCByZXF1aXJlcyB3ZWJraXRSZXF1ZXN0RmlsZVN5c3RlbS4iKTsKKword2Vi a2l0UmVxdWVzdEZpbGVTeXN0ZW0oVEVNUE9SQVJZLCAxLCBydW5UZXN0KTsKK3ZhciBkaXJfbmFt ZSA9ICIvcGVyZnRlc3QtY3JlYXRlLWZpbGUiOworZnVuY3Rpb24gcnVuVGVzdChmaWxlU3lzdGVt KSB7CisgICAgdmFyIGkgPSAwOworICAgIFBlcmZUZXN0UnVubmVyLnJ1blBlclNlY29uZEFzeW5j KHsKKyAgICAgICAgZGVzY3JpcHRpb246ICJUaGlzIGJlbmNobWFyayB0ZXN0cyBjcmVhdGluZyBu ZXcgZmlsZSB1c2luZyBGaWxlU3lzdGVtIEFQSSIsCisgICAgICAgIHNldHVwOiBmdW5jdGlvbihk b25lKSB7CisgICAgICAgICAgICBpID0gMDsKKyAgICAgICAgICAgIGZpbGVTeXN0ZW0ucm9vdC5n ZXREaXJlY3RvcnkoZGlyX25hbWUsIHtjcmVhdGU6IGZhbHNlfSwgY2xlYXJEaXJlY3RvcnksIGNy ZWF0ZURpcmVjdG9yeSk7CisgICAgICAgICAgICBmdW5jdGlvbiBjbGVhckRpcmVjdG9yeShkaXJl Y3RvcnkpIHsKKyAgICAgICAgICAgICAgICBkaXJlY3RvcnkucmVtb3ZlUmVjdXJzaXZlbHkoY3Jl YXRlRGlyZWN0b3J5KTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gY3Jl YXRlRGlyZWN0b3J5KCkgeworICAgICAgICAgICAgICAgIGZpbGVTeXN0ZW0ucm9vdC5nZXREaXJl Y3RvcnkoZGlyX25hbWUsIHtjcmVhdGU6IHRydWUsIGV4Y2x1c2l2ZTogdHJ1ZX0sIGRvbmUpOwor ICAgICAgICAgICAgfQorICAgICAgICB9LAorICAgICAgICBydW46IGZ1bmN0aW9uKGRvbmUpIHsK KyAgICAgICAgICAgIGZpbGVTeXN0ZW0ucm9vdC5nZXRGaWxlKGRpcl9uYW1lICsgIi8iICsgaSsr LCB7Y3JlYXRlOiB0cnVlLCBleGNsdXNpdmU6IHRydWV9LCBkb25lKTsKKyAgICAgICAgfSwKKyAg fSk7Cit9Cis8L3NjcmlwdD4K