95703 2012-09-03 17:18:24 -0700 [GTK] Print API missing documentation when generating gtkdoc 2012-09-04 11:32:51 -0700 1 1 1 Unclassified WebKit WebKitGTK 523.x (Safari 3) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson cgarcia webkit.review.bot oldest_to_newest 710762 0 mrobinson 2012-09-03 17:18:24 -0700 It's a bit of a pain now to continually check the -unused.txt file when you are adding new documentation. We should print the missing documentation when running generate-gtkdoc. 710770 1 161953 mrobinson 2012-09-03 18:06:03 -0700 Created attachment 161953 Patch 710844 2 161953 cgarcia 2012-09-04 00:04:03 -0700 Comment on attachment 161953 Patch Patch looks good to me, but it seems there are two independent changes, one is raising an exception when rebase is called before doc is generated, instead of just showing a message, I guess to make sure the script fails in such case, because the exception is not handled. And the other change is showing missing api when errors are reported. You could you split the patch before landing, please? 711036 3 mrobinson 2012-09-04 05:55:33 -0700 (In reply to comment #2) > (From update of attachment 161953 [details]) > Patch looks good to me, but it seems there are two independent changes, one is raising an exception when rebase is called before doc is generated, instead of just showing a message, I guess to make sure the script fails in such case, because the exception is not handled. And the other change is showing missing api when errors are reported. You could you split the patch before landing, please? In this case, it was a small cleanup that I did while fixing the issue. If you feel it's serious enough that it needs to be in another patch, I'm happy to do that. Can I have a review in advance though? 711040 4 cgarcia 2012-09-04 06:04:18 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 161953 [details] [details]) > > Patch looks good to me, but it seems there are two independent changes, one is raising an exception when rebase is called before doc is generated, instead of just showing a message, I guess to make sure the script fails in such case, because the exception is not handled. And the other change is showing missing api when errors are reported. You could you split the patch before landing, please? > > In this case, it was a small cleanup that I did while fixing the issue. If you feel it's serious enough that it needs to be in another patch, I'm happy to do that. Can I have a review in advance though? I already set r+ 711096 5 mrobinson 2012-09-04 07:17:47 -0700 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 161953 [details] [details] [details]) > > > Patch looks good to me, but it seems there are two independent changes, one is raising an exception when rebase is called before doc is generated, instead of just showing a message, I guess to make sure the script fails in such case, because the exception is not handled. And the other change is showing missing api when errors are reported. You could you split the patch before landing, please? > > > > In this case, it was a small cleanup that I did while fixing the issue. If you feel it's serious enough that it needs to be in another patch, I'm happy to do that. Can I have a review in advance though? > > I already set r+ I'm still not sure if you consider the cleanup serious enough to split after my comment. 711098 6 161953 mrobinson 2012-09-04 07:19:28 -0700 Comment on attachment 161953 Patch Oops. Guess I'll wait on this one. :) 711124 7 cgarcia 2012-09-04 08:06:53 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > (In reply to comment #2) > > > > (From update of attachment 161953 [details] [details] [details] [details]) > > > > Patch looks good to me, but it seems there are two independent changes, one is raising an exception when rebase is called before doc is generated, instead of just showing a message, I guess to make sure the script fails in such case, because the exception is not handled. And the other change is showing missing api when errors are reported. You could you split the patch before landing, please? > > > > > > In this case, it was a small cleanup that I did while fixing the issue. If you feel it's serious enough that it needs to be in another patch, I'm happy to do that. Can I have a review in advance though? > > > > I already set r+ > > I'm still not sure if you consider the cleanup serious enough to split after my comment. Not because it's serious, but because it's unrelated change, but I don't mind if you commit both in a single commit, I was just suggesting to split it before landing, no need to file new bug reports and patches. But still, feel free to cq+, I don't want to give you more work :-P 711147 8 161953 mrobinson 2012-09-04 08:33:54 -0700 Comment on attachment 161953 Patch Okay. Thanks. I'll try to be more careful in the future. 711282 9 161953 webkit.review.bot 2012-09-04 11:32:48 -0700 Comment on attachment 161953 Patch Clearing flags on attachment: 161953 Committed r127475: <http://trac.webkit.org/changeset/127475> 711283 10 webkit.review.bot 2012-09-04 11:32:51 -0700 All reviewed patches have been landed. Closing bug. 161953 2012-09-03 18:06:03 -0700 2012-09-04 11:32:47 -0700 Patch bug-95703-20120903180543.patch text/plain 5101 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTM2MDllMmUzZWNhMTFlMjNjYzA5NjM2NDFkZjNmYzYz OTZmNzA2MC4uYTVlNTQ0OWM5N2JjZGY5YzI4N2IzMWJiOGI0MDVmMjdmNjM4OGY3YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEyLTA5LTAzICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBQcmludCBBUEkgbWlzc2luZyBkb2N1bWVudGF0aW9uIHdoZW4gZ2Vu ZXJhdGluZyBndGtkb2MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk1NzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUHJpbnQgb3V0IEFQSSBtaXNzaW5nIGRvY3VtZW50YXRpb24gd2hlbiBnZW5lcmF0aW5n IGd0a2RvYy4gVGhpcyBtYWtlcyBpdAorICAgICAgICBlYXNpZXIgdG8gZml4IGRvY3VtZW50YXRp b24gZXJyb3JzLgorCisgICAgICAgICogZ3RrL2dlbmVyYXRlLWd0a2RvYzoKKyAgICAgICAgKHBy aW50X21pc3NpbmdfYXBpKTogQWRkZWQuCisgICAgICAgIChnZW5lcmF0ZV9kb2MpOiBJbmxpbmUg dGhlIHJlYmFzZSBzdGVwLCBzaW5jZSBpdCBub3cgcmVwb3J0cyBhbiBlcnJvcgorICAgICAgICB3 aGVuIHlvdSB0cnkgdG8gcmViYXNlIHdpdGhvdXQgZ2VuZXJhdGluZyBkb2N1bWVudGF0aW9uIGZp cnN0LgorICAgICAgICAqIGd0ay9ndGtkb2MucHk6CisgICAgICAgIChHVEtEb2MucmViYXNlX2lu c3RhbGxlZF9kb2NzKTogUmFpc2UgYW4gZXJyb3Igd2hlbiByZWJhc2luZyB3aXRob3V0CisgICAg ICAgIGdlbmVyYXRpbmcgZG9jdW1lbnRhdGlvbiBmaXJzdCB0byBlbmFibGUgYSBzbWFsbCBjbGVh bnVwIGF0IHRoZSBjYWxsZXIuCisgICAgICAgIChHVEtEb2MuYXBpX21pc3NpbmdfZG9jdW1lbnRh dGlvbik6IEFkZGVkLgorCiAyMDEyLTA5LTAzICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1z dW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBDaGFuZ2UgdGhlIGZvY3VzIHdoZW4gdGhlIHdlYiB2 aWV3IGlzIGNsaWNrZWQgaW4gTWluaUJyb3dzZXIgYW5kIEVXZWJMYXVuY2hlcgpkaWZmIC0tZ2l0 IGEvVG9vbHMvZ3RrL2dlbmVyYXRlLWd0a2RvYyBiL1Rvb2xzL2d0ay9nZW5lcmF0ZS1ndGtkb2MK aW5kZXggYjAwMjIyNDE3NmFjZmE5NjlmZmU1NTliNWFlOGYzZTQ0MzY3NmNjYy4uNDczZWQyNTJk MjIxYzMyZTIxYzg4NDI5ZjNmOGFiOTQ5MzdjNzhmZCAxMDA3NTUKLS0tIGEvVG9vbHMvZ3RrL2dl bmVyYXRlLWd0a2RvYworKysgYi9Ub29scy9ndGsvZ2VuZXJhdGUtZ3RrZG9jCkBAIC0xMzcsMTgg KzEzNywyMCBAQCBkZWYgZ2V0X3dlYmtpdDFfb3B0aW9ucyhndGtfdmVyc2lvbik6CiAgICAgfSkK ICAgICByZXR1cm4gb3B0aW9ucwogCi1kZWYgZ2VuZXJhdGVfZG9jKHBrZ19jb25maWdfcGF0aCwg b3B0aW9ucyk6Ci0gICAgZ2VuZXJhdG9yID0gZ3RrZG9jLlBrZ0NvbmZpZ0dUS0RvYyhwa2dfY29u ZmlnX3BhdGgsIG9wdGlvbnMpCitkZWYgcHJpbnRfbWlzc2luZ19hcGkoZ2VuZXJhdG9yKToKKyAg ICBtaXNzaW5nX2FwaSA9IGdlbmVyYXRvci5hcGlfbWlzc2luZ19kb2N1bWVudGF0aW9uKCkKKyAg ICBpZiBub3QgbWlzc2luZ19hcGk6CisgICAgICAgIHJldHVybgorICAgIHByaW50ICJcblRoZSBm b2xsb3dpbmcgQVBJIGFyZSBtaXNzaW5nIGRvY3VtZW50YXRpb246IgorICAgIGZvciBhcGkgaW4g bWlzc2luZ19hcGk6CisgICAgICAgIHByaW50ICJcdCVzIiAlIGFwaQorCitkZWYgZ2VuZXJhdGVf ZG9jKGdlbmVyYXRvcik6CiAgICAgZ2VuZXJhdG9yLmdlbmVyYXRlKGh0bWw9Jy0tc2tpcC1odG1s JyBub3QgaW4gc3lzLmFyZ3YpCisgICAgaWYgZ2VuZXJhdG9yLnNhd193YXJuaW5nczoKKyAgICAg ICAgcHJpbnRfbWlzc2luZ19hcGkoZ2VuZXJhdG9yKQogICAgIHJldHVybiBnZW5lcmF0b3Iuc2F3 X3dhcm5pbmdzCiAKLWRlZiByZWJhc2VfaW5zdGFsbGVkX2RvY3MocGtnX2NvbmZpZ19wYXRoLCBv cHRpb25zKToKLSAgICBpZiBub3Qgb3MucGF0aC5pc2RpcihvcHRpb25zWydvdXRwdXRfZGlyJ10p OgotICAgICAgICBwcmludCAiRG9jdW1lbnRhdGlvbiB3YXMgbm90IGdlbmVyYXRlZCIKLSAgICAg ICAgcmV0dXJuCi0gICAgZ2VuZXJhdG9yID0gZ3RrZG9jLlBrZ0NvbmZpZ0dUS0RvYyhwa2dfY29u ZmlnX3BhdGgsIG9wdGlvbnMpCi0gICAgZ2VuZXJhdG9yLnJlYmFzZV9pbnN0YWxsZWRfZG9jcygp Ci0KIGNvbmZpZ3VyZV9sb2dnaW5nKCkKIAogIyBXZSBuZWVkIHRvIGFkZCB0aGUgSmF2YVNjcmlw dENvcmUgYnVpbGQgZGlyZWN0b3J5IHRvIHRoZSBQS0dfQ09ORklHX1BBVEgKQEAgLTE2NSwyMiAr MTY3LDIzIEBAIGlmIG5vdCBvcy5wYXRoLmV4aXN0cyhwa2dfY29uZmlnX3BhdGgpOgogICAgIHBr Z19jb25maWdfcGF0aCA9IGNvbW1vbi5idWlsZF9wYXRoKCdTb3VyY2UnLCAnV2ViS2l0JywgJ2d0 aycsICd3ZWJraXQtMS4wLnBjJykKIGlmIG9zLnBhdGguZXhpc3RzKHBrZ19jb25maWdfcGF0aCk6 CiAgICAgb3B0aW9ucyA9IGdldF93ZWJraXQxX29wdGlvbnMoY29tbW9uLmd0a192ZXJzaW9uX29m X3BrZ19jb25maWdfZmlsZShwa2dfY29uZmlnX3BhdGgpKQorICAgIGdlbmVyYXRvciA9IGd0a2Rv Yy5Qa2dDb25maWdHVEtEb2MocGtnX2NvbmZpZ19wYXRoLCBvcHRpb25zKQogICAgIGlmICctLXJl YmFzZScgbm90IGluIHN5cy5hcmd2OgogICAgICAgICBwcmludCAiR2VuZXJhdGluZyBXZWJLaXQx IGRvY3VtZW50YXRpb24uLi4iCi0gICAgICAgIHNhd193ZWJraXQxX3dhcm5pbmdzID0gZ2VuZXJh dGVfZG9jKHBrZ19jb25maWdfcGF0aCwgb3B0aW9ucykKKyAgICAgICAgc2F3X3dlYmtpdDFfd2Fy bmluZ3MgPSBnZW5lcmF0ZV9kb2MoZ2VuZXJhdG9yKQogICAgIGVsc2U6CiAgICAgICAgIHByaW50 ICJSZWJhc2luZyBXZWJLaXQxIGRvY3VtZW50YXRpb24uLi4iCi0gICAgICAgIHJlYmFzZV9pbnN0 YWxsZWRfZG9jcyhwa2dfY29uZmlnX3BhdGgsIG9wdGlvbnMpCisgICAgICAgIGdlbmVyYXRvci5y ZWJhc2VfaW5zdGFsbGVkX2RvY3MoKQogCiAjIFdlYktpdDIgbWlnaHQgbm90IGJlIGVuYWJsZWQs IHNvIGNoZWNrIGZvciB0aGUgcGtnLWNvbmZpZyBmaWxlIGJlZm9yZSBidWlsZGluZyBkb2N1bWVu dGF0aW9uLgogcGtnX2NvbmZpZ19wYXRoID0gY29tbW9uLmJ1aWxkX3BhdGgoJ1NvdXJjZScsICdX ZWJLaXQyJywgJ3dlYmtpdDJndGstMy4wLnBjJykKIGlmIG9zLnBhdGguZXhpc3RzKHBrZ19jb25m aWdfcGF0aCk6Ci0gICAgb3B0aW9ucyA9IGdldF93ZWJraXQyX29wdGlvbnMoKQorICAgIGdlbmVy YXRvciA9IGd0a2RvYy5Qa2dDb25maWdHVEtEb2MocGtnX2NvbmZpZ19wYXRoLCBnZXRfd2Via2l0 Ml9vcHRpb25zKCkpCiAgICAgaWYgJy0tcmViYXNlJyBub3QgaW4gc3lzLmFyZ3Y6CiAgICAgICAg IHByaW50ICJcbkdlbmVyYXRpbmcgV2ViS2l0MiBkb2N1bWVudGF0aW9uLi4uIgotICAgICAgICBz YXdfd2Via2l0Ml93YXJuaW5ncyA9IGdlbmVyYXRlX2RvYyhwa2dfY29uZmlnX3BhdGgsIG9wdGlv bnMpCisgICAgICAgIHNhd193ZWJraXQyX3dhcm5pbmdzID0gZ2VuZXJhdGVfZG9jKGdlbmVyYXRv cikKICAgICBlbHNlOgogICAgICAgICBwcmludCAiXG5SZWJhc2luZyBXZWJLaXQyIGRvY3VtZW50 YXRpb24uLi4iCi0gICAgICAgIHJlYmFzZV9pbnN0YWxsZWRfZG9jcyhwa2dfY29uZmlnX3BhdGgs IG9wdGlvbnMpCisgICAgICAgIGdlbmVyYXRvci5yZWJhc2VfaW5zdGFsbGVkX2RvY3MoKQogCiBz eXMuZXhpdChzYXdfd2Via2l0MV93YXJuaW5ncyBvciBzYXdfd2Via2l0Ml93YXJuaW5ncykKZGlm ZiAtLWdpdCBhL1Rvb2xzL2d0ay9ndGtkb2MucHkgYi9Ub29scy9ndGsvZ3RrZG9jLnB5CmluZGV4 IGEyNTg2YWM1Y2I4YWI3MmMwOTMwYWZiN2NjYjExNTAxN2U5ODUyOTkuLjdmN2YwYWQzMTM4MDk2 MDBjYjMzOWNiNDc4ZjM1Mjc3NWRkNjM1MmMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9ndGtkb2Mu cHkKKysrIGIvVG9vbHMvZ3RrL2d0a2RvYy5weQpAQCAtMzYxLDYgKzM2MSw4IEBAIGNsYXNzIEdU S0RvYyhvYmplY3QpOgogICAgICAgICBzZWxmLl9ydW5fY29tbWFuZChhcmdzLCBjd2Q9c2VsZi5v dXRwdXRfZGlyLCBpZ25vcmVfd2FybmluZ3M9VHJ1ZSkKIAogICAgIGRlZiByZWJhc2VfaW5zdGFs bGVkX2RvY3Moc2VsZik6CisgICAgICAgIGlmIG5vdCBvcy5wYXRoLmlzZGlyKHNlbGYub3V0cHV0 X2Rpcik6CisgICAgICAgICAgICByYWlzZSBFeGNlcHRpb24oIlRyaWVkIHRvIHJlYmFzZSBkb2N1 bWVudGF0aW9uIGJlZm9yZSBnZW5lcmF0aW5nIGl0LiIpCiAgICAgICAgIGh0bWxfZGlyID0gb3Mu cGF0aC5qb2luKHNlbGYudmlydHVhbF9yb290ICsgc2VsZi5wcmVmaXgsICdzaGFyZScsICdndGst ZG9jJywgJ2h0bWwnLCBzZWxmLm1vZHVsZV9uYW1lKQogICAgICAgICBpZiBub3Qgb3MucGF0aC5p c2RpcihodG1sX2Rpcik6CiAgICAgICAgICAgICByZXR1cm4KQEAgLTM3Miw2ICszNzQsMTEgQEAg Y2xhc3MgR1RLRG9jKG9iamVjdCk6CiAgICAgICAgICAgICBhcmdzLmV4dGVuZChbJy0tZGVzdC1k aXI9JXMnICUgc2VsZi52aXJ0dWFsX3Jvb3RdKQogICAgICAgICBzZWxmLl9ydW5fY29tbWFuZChh cmdzLCBjd2Q9c2VsZi5vdXRwdXRfZGlyKQogCisgICAgZGVmIGFwaV9taXNzaW5nX2RvY3VtZW50 YXRpb24oc2VsZik6CisgICAgICAgIHVudXNlZF9kb2NfZmlsZSA9IG9zLnBhdGguam9pbihzZWxm Lm91dHB1dF9kaXIsIHNlbGYubW9kdWxlX25hbWUgKyAiLXVudXNlZC50eHQiKQorICAgICAgICBp ZiBub3Qgb3MucGF0aC5leGlzdHModW51c2VkX2RvY19maWxlKSBvciBub3Qgb3MuYWNjZXNzKHVu dXNlZF9kb2NfZmlsZSwgb3MuUl9PSyk6CisgICAgICAgICAgICByZXR1cm4gW10KKyAgICAgICAg cmV0dXJuIG9wZW4odW51c2VkX2RvY19maWxlKS5yZWFkKCkuc3BsaXRsaW5lcygpCiAKIGNsYXNz IFBrZ0NvbmZpZ0dUS0RvYyhHVEtEb2MpOgogCg==