95698 2012-09-03 12:39:28 -0700 HTML file input elements do not support file extensions in the "accept" attribute 2017-08-02 13:52:20 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 dgatwood bburg ap bburg buildbot cgarcia darin joepeck jonlee thorton tkent webkit-bug-importer oldest_to_newest 710742 0 dgatwood 2012-09-03 12:39:28 -0700 According to the current HTML spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#attr-input-accept The following is valid: <input type="file" accept=".myextension"> and should restrict the input to files with that extension. Safari 6 does not seem to support this form of that attribute. Please implement this functionality. 711231 1 ap 2012-09-04 10:55:46 -0700 Could you please provide complete steps to reproduce? What specifically do you see that looks wrong - are you trying drag and drop, file chooser, or something else? 711455 2 dgatwood 2012-09-04 14:29:02 -0700 Step 1: Put the element in an HTML file. Step 2: Click on it. Step 3: Look at the file chooser. All files that do not match the above extension should be greyed out. They are not. Alternatively, include both an extension and one or more MIME types in the value, separated by commas. Click on the "Choose File" button. Notice that everything is greyed out except for files that match the MIME type(s), and you cannot choose anything that matches against the specified extension unless it also matches against one or more of the specified MIME types. 711461 3 jonlee 2012-09-04 14:40:54 -0700 Currently it looks like WK2 only looks at MIME types, and ignores extensions. Chrome looks at the aggregate. 711462 4 webkit-bug-importer 2012-09-04 14:41:29 -0700 <rdar://problem/12231850> 711756 5 joepeck 2012-09-04 23:32:09 -0700 Supporting extensions in <input type="file">'s accept attribute was a relatively recent addition to the HTML5 spec: <http://html5.org/tools/web-apps-tracker?from=7056&to=7057> It wasn't in the spec at the time that support was added to Safari. Neat, I didn't know about that. 1334062 6 316918 bburg 2017-08-01 17:25:28 -0700 Created attachment 316918 Patch 1334065 7 buildbot 2017-08-01 17:28:16 -0700 Attachment 316918 did not pass style-queue: ERROR: Source/WebKit/UIProcess/API/C/WKOpenPanelParametersRef.h:45: The parameter name "parameters" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. 1334081 8 316918 darin 2017-08-01 18:22:08 -0700 Comment on attachment 316918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316918&action=review > Source/WebCore/ChangeLog:9 > + Serialize the accepted file extensions so they can be accessed in UIPRrocess. "UIPRrocess" -> "the UI process" > Source/WebKit/ChangeLog:12 > + Plumb accepted file extensions out to the C API. It is not > + added to the Cocoa API since the accepted MIME types are not > + available through that either. Better to add both together > + when they are actually needed. Not sure that is the right thing for our future direction. Instead I was hoping that we could make sure there was a way to bridge C API to Cocoa API so they can be mixed and then we would add this feature *only* to the Cocoa API. > Source/WebCore/platform/FileChooser.h:99 > + FileChooserClient* m_client = nullptr; WebKit uses the " { nullptr }" syntax instead of the "= nullptr" syntax. Arbitrary, I know. 1334102 9 316918 bburg 2017-08-01 19:46:18 -0700 Comment on attachment 316918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316918&action=review >> Source/WebKit/ChangeLog:12 >> + when they are actually needed. > > Not sure that is the right thing for our future direction. > > Instead I was hoping that we could make sure there was a way to bridge C API to Cocoa API so they can be mixed and then we would add this feature *only* to the Cocoa API. I'm not sure how to accomplish that. Have we tried it anywhere else? I'm happy to change the Cocoa API in a separate patch to bring it up to parity. But it will require additional tests (API tests?) to make sure it's good for general consumption. 1334109 10 thorton 2017-08-01 20:15:04 -0700 (In reply to Brian Burg from comment #9) > Comment on attachment 316918 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316918&action=review > > >> Source/WebKit/ChangeLog:12 > >> + when they are actually needed. > > > > Not sure that is the right thing for our future direction. > > > > Instead I was hoping that we could make sure there was a way to bridge C API to Cocoa API so they can be mixed and then we would add this feature *only* to the Cocoa API. > > I'm not sure how to accomplish that. Have we tried it anywhere else? Most of the ObjC API objects are toll-free bridged with their C API counterparts. > I'm happy to change the Cocoa API in a separate patch to bring it up to > parity. But it will require additional tests (API tests?) to make sure it's > good for general consumption. 1334278 11 bburg 2017-08-02 10:39:01 -0700 Committed r220135: <http://trac.webkit.org/changeset/220135> 1334374 12 darin 2017-08-02 13:52:20 -0700 (In reply to Brian Burg from comment #9) > I'm not sure how to accomplish that. Have we tried it anywhere else? Yes, I believe we have been taking that approach elsewhere. > I'm happy to change the Cocoa API in a separate patch to bring it up to > parity. But it will require additional tests (API tests?) to make sure it's > good for general consumption. I was not suggesting bringing it up to parity. I was suggesting putting new features *only* in Cocoa API and not adding to the C API. 316918 2017-08-01 17:25:28 -0700 2017-08-01 18:22:26 -0700 Patch bug-95698-20170801172527.patch text/plain 8837 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzYxNjc2ZTUxMjY5NzQ0 NmJlZTViYjc4OTFjYjYxODdkNmE1MWNlMi4uMmY2ODY4MTQwNzYwYzdlZTM3YjliMmQwMzAyYjY2 NjJmMjE4ZTZkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA4LTAxICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIEhUTUwgZmlsZSBpbnB1dCBlbGVt ZW50cyBkbyBub3Qgc3VwcG9ydCBmaWxlIGV4dGVuc2lvbnMgaW4gdGhlICJhY2NlcHQiIGF0dHJp YnV0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU2 OTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyMjMxODUwPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlcmlhbGl6ZSB0aGUgYWNjZXB0ZWQgZmls ZSBleHRlbnNpb25zIHNvIHRoZXkgY2FuIGJlIGFjY2Vzc2VkIGluIFVJUFJyb2Nlc3MuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9GaWxlQ2hvb3Nlci5oOgorICAgICAgICAqIHBsYXRmb3JtL0ZpbGVD aG9vc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZpbGVDaG9vc2VyOjppbnZhbGlkYXRlKTog TW9kZXJuaXplLgorICAgICAgICAoV2ViQ29yZTo6RmlsZUNob29zZXJTZXR0aW5nczo6YWNjZXB0 VHlwZXMgY29uc3QpOiBEZWxldGVkLgorICAgICAgICBUaGlzIGlzIGRlYWQgY29kZSwgaXQgd2Fz IG9ubHkgdXNlZCBieSBDaHJvbWl1bS4KKwogMjAxNy0wNy0zMSAgU2FtIFdlaW5pZyAgPHNhbUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBleGNlcHRpb25zIGZyb20g c3RvcmFnZSBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE1YzAwZjJjNjgwZmU1ZTkxZjMwYjdkNGY1ODk2MzI4 OGVhNmVmYjAuLjQ2MTBhOGY4ZTI1ZGMwMjFmZmExZTI3MzliNmM0YWM5YTkwMGMxYjggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTctMDgtMDEgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBs ZS5jb20+CisKKyAgICAgICAgSFRNTCBmaWxlIGlucHV0IGVsZW1lbnRzIGRvIG5vdCBzdXBwb3J0 IGZpbGUgZXh0ZW5zaW9ucyBpbiB0aGUgImFjY2VwdCIgYXR0cmlidXRlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTY5OAorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMTIyMzE4NTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUGx1bWIgYWNjZXB0ZWQgZmlsZSBleHRlbnNpb25zIG91dCB0byB0aGUgQyBB UEkuIEl0IGlzIG5vdAorICAgICAgICBhZGRlZCB0byB0aGUgQ29jb2EgQVBJIHNpbmNlIHRoZSBh Y2NlcHRlZCBNSU1FIHR5cGVzIGFyZSBub3QKKyAgICAgICAgYXZhaWxhYmxlIHRocm91Z2ggdGhh dCBlaXRoZXIuIEJldHRlciB0byBhZGQgYm90aCB0b2dldGhlcgorICAgICAgICB3aGVuIHRoZXkg YXJlIGFjdHVhbGx5IG5lZWRlZC4KKworICAgICAgICAqIFNoYXJlZC9XZWJDb3JlQXJndW1lbnRD b2RlcnMuY3BwOgorICAgICAgICAoSVBDOjpBcmd1bWVudENvZGVyPEZpbGVDaG9vc2VyU2V0dGlu Z3M+OjplbmNvZGUpOgorICAgICAgICAoSVBDOjpBcmd1bWVudENvZGVyPEZpbGVDaG9vc2VyU2V0 dGluZ3M+OjpkZWNvZGUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQVBJT3BlblBhbmVsUGFy YW1ldGVycy5jcHA6CisgICAgICAgIChBUEk6Ok9wZW5QYW5lbFBhcmFtZXRlcnM6OmFjY2VwdEZp bGVFeHRlbnNpb25zIGNvbnN0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0FQSU9wZW5QYW5l bFBhcmFtZXRlcnMuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tPcGVuUGFuZWxQYXJh bWV0ZXJzUmVmLmNwcDoKKyAgICAgICAgKFdLT3BlblBhbmVsUGFyYW1ldGVyc0NvcHlBY2NlcHRl ZEZpbGVFeHRlbnNpb25zKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tPcGVuUGFuZWxQ YXJhbWV0ZXJzUmVmLmg6CisKIDIwMTctMDctMzEgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9y Zz4KIAogICAgICAgICBSZW1vdmUgdW5uZWNlc3NhcnkgZXhjZXB0aW9ucyBmcm9tIHN0b3JhZ2Ug Y29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRmlsZUNob29zZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRmlsZUNob29zZXIuY3BwCmluZGV4IGVhZGE0OWJh NjI3YmVhZTFkN2RlNDVhN2ZjZTFlZGE2NzNmYWY3MjMuLmYzMGM0OWYxNWFiZjM4NTg4ODRlZGRj ZjA0YWMzNWZkOWYwMzNmZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0Zp bGVDaG9vc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlQ2hvb3Nlci5j cHAKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA3LCAyMDA4IEFwcGxl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwNy0yMDE3IEFw cGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQg dXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlm aWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0 aW9ucwpAQCAtNTAsNyArNTAsNyBAQCB2b2lkIEZpbGVDaG9vc2VyOjppbnZhbGlkYXRlKCkKIHsK ICAgICBBU1NFUlQobV9jbGllbnQpOwogCi0gICAgbV9jbGllbnQgPSAwOworICAgIG1fY2xpZW50 ID0gbnVsbHB0cjsKIH0KIAogdm9pZCBGaWxlQ2hvb3Nlcjo6Y2hvb3NlRmlsZShjb25zdCBTdHJp bmcmIGZpbGVuYW1lKQpAQCAtMTEwLDEzICsxMTAsNCBAQCB2b2lkIEZpbGVDaG9vc2VyOjpjaG9v c2VGaWxlcyhjb25zdCBWZWN0b3I8RmlsZUNob29zZXJGaWxlSW5mbz4mIGZpbGVzKQogICAgICAg ICBtX2NsaWVudC0+ZmlsZXNDaG9zZW4oZmlsZXMpOwogfQogCi1WZWN0b3I8U3RyaW5nPiBGaWxl Q2hvb3NlclNldHRpbmdzOjphY2NlcHRUeXBlcygpIGNvbnN0Ci17Ci0gICAgVmVjdG9yPFN0cmlu Zz4gYWNjZXB0VHlwZXM7Ci0gICAgYWNjZXB0VHlwZXMucmVzZXJ2ZUNhcGFjaXR5KGFjY2VwdE1J TUVUeXBlcy5zaXplKCkgKyBhY2NlcHRGaWxlRXh0ZW5zaW9ucy5zaXplKCkpOwotICAgIGFjY2Vw dFR5cGVzLmFwcGVuZFZlY3RvcihhY2NlcHRNSU1FVHlwZXMpOwotICAgIGFjY2VwdFR5cGVzLmFw cGVuZFZlY3RvcihhY2NlcHRGaWxlRXh0ZW5zaW9ucyk7Ci0gICAgcmV0dXJuIGFjY2VwdFR5cGVz OwotfQotCi19Cit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9GaWxlQ2hvb3Nlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRmls ZUNob29zZXIuaAppbmRleCA3ZTMyOTBmMTgxODFhMjEwYWNjODJiNzY0ZjBlODgwM2YxZjI1ZDVk Li5lZjA2NTlkNzdiMTdlODY2NDM0YjE0OTY3ZWVhMzAwZjMwMWVkMTA2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlQ2hvb3Nlci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL0ZpbGVDaG9vc2VyLmgKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0 IChDKSAyMDA2LCAyMDA3LCAyMDA4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq IENvcHlyaWdodCAoQykgMjAwNi0yMDE3IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K ICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z LCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNjQsOSArNjQsNiBAQCBzdHJ1Y3Qg RmlsZUNob29zZXJTZXR0aW5ncyB7CiAjaWYgRU5BQkxFKE1FRElBX0NBUFRVUkUpCiAgICAgTWVk aWFDYXB0dXJlVHlwZSBtZWRpYUNhcHR1cmVUeXBlOwogI2VuZGlmCi0KLSAgICAvLyBSZXR1cm5z IGEgY29tYmluZWQgdmVjdG9yIG9mIGFjY2VwdE1JTUVUeXBlcyBhbmQgYWNjZXB0RmlsZUV4dGVu c2lvbnMuCi0gICAgVmVjdG9yPFN0cmluZz4gYWNjZXB0VHlwZXMoKSBjb25zdDsKIH07CiAKIGNs YXNzIEZpbGVDaG9vc2VyQ2xpZW50IHsKQEAgLTk5LDcgKzk2LDcgQEAgcHVibGljOgogcHJpdmF0 ZToKICAgICBGaWxlQ2hvb3NlcihGaWxlQ2hvb3NlckNsaWVudCosIGNvbnN0IEZpbGVDaG9vc2Vy U2V0dGluZ3MmKTsKIAotICAgIEZpbGVDaG9vc2VyQ2xpZW50KiBtX2NsaWVudDsKKyAgICBGaWxl Q2hvb3NlckNsaWVudCogbV9jbGllbnQgPSBudWxscHRyOwogICAgIEZpbGVDaG9vc2VyU2V0dGlu Z3MgbV9zZXR0aW5nczsKIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dl YkNvcmVBcmd1bWVudENvZGVycy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJDb3JlQXJn dW1lbnRDb2RlcnMuY3BwCmluZGV4IDEzMGQ2M2Q4ZmM0ZmRjZWE0ZTMyZTliZWNmNmE3ZjVmNDA2 OThhODEuLjk5YzM5NTRkYzk1YTZhZmM3YmEyNzQ1MGFjOGZkNmJjYzZiMDk5MDcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5jcHAKKysrIGIv U291cmNlL1dlYktpdC9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcApAQCAtMTU2MCw2 ICsxNTYwLDcgQEAgdm9pZCBBcmd1bWVudENvZGVyPEZpbGVDaG9vc2VyU2V0dGluZ3M+OjplbmNv ZGUoRW5jb2RlciYgZW5jb2RlciwgY29uc3QgRmlsZUNob28KIHsKICAgICBlbmNvZGVyIDw8IHNl dHRpbmdzLmFsbG93c011bHRpcGxlRmlsZXM7CiAgICAgZW5jb2RlciA8PCBzZXR0aW5ncy5hY2Nl cHRNSU1FVHlwZXM7CisgICAgZW5jb2RlciA8PCBzZXR0aW5ncy5hY2NlcHRGaWxlRXh0ZW5zaW9u czsKICAgICBlbmNvZGVyIDw8IHNldHRpbmdzLnNlbGVjdGVkRmlsZXM7CiAjaWYgRU5BQkxFKE1F RElBX0NBUFRVUkUpCiAgICAgZW5jb2Rlci5lbmNvZGVFbnVtKHNldHRpbmdzLm1lZGlhQ2FwdHVy ZVR5cGUpOwpAQCAtMTU3Miw2ICsxNTczLDggQEAgYm9vbCBBcmd1bWVudENvZGVyPEZpbGVDaG9v c2VyU2V0dGluZ3M+OjpkZWNvZGUoRGVjb2RlciYgZGVjb2RlciwgRmlsZUNob29zZXJTZXQKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGlmICghZGVjb2Rlci5kZWNvZGUoc2V0dGluZ3MuYWNj ZXB0TUlNRVR5cGVzKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGlmICghZGVjb2Rlci5k ZWNvZGUoc2V0dGluZ3MuYWNjZXB0RmlsZUV4dGVuc2lvbnMpKQorICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShzZXR0aW5ncy5zZWxlY3RlZEZpbGVzKSkKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogI2lmIEVOQUJMRShNRURJQV9DQVBUVVJFKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSU9wZW5QYW5lbFBhcmFtZXRlcnMuY3Bw IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSU9wZW5QYW5lbFBhcmFtZXRlcnMuY3Bw CmluZGV4IGQxNDQyYTNlYTcyZGZmOGMwYTg0ZjZkOGM1ZmM5MjJiMjlkYzk5YjUuLjc3MTk5MGE3 NGMxM2U2OTNiM2FhOGE3Y2FlNWIzYTc3NzgxODNjY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9BUElPcGVuUGFuZWxQYXJhbWV0ZXJzLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJT3BlblBhbmVsUGFyYW1ldGVycy5jcHAKQEAgLTU0LDYg KzU0LDExIEBAIFJlZjxBUEk6OkFycmF5PiBPcGVuUGFuZWxQYXJhbWV0ZXJzOjphY2NlcHRNSU1F VHlwZXMoKSBjb25zdAogICAgIHJldHVybiBBUEk6OkFycmF5OjpjcmVhdGVTdHJpbmdBcnJheSht X3NldHRpbmdzLmFjY2VwdE1JTUVUeXBlcyk7CiB9CiAKK1JlZjxBUEk6OkFycmF5PiBPcGVuUGFu ZWxQYXJhbWV0ZXJzOjphY2NlcHRGaWxlRXh0ZW5zaW9ucygpIGNvbnN0Cit7CisgICAgcmV0dXJu IEFQSTo6QXJyYXk6OmNyZWF0ZVN0cmluZ0FycmF5KG1fc2V0dGluZ3MuYWNjZXB0RmlsZUV4dGVu c2lvbnMpOworfQorCiAjaWYgRU5BQkxFKE1FRElBX0NBUFRVUkUpCiBXZWJDb3JlOjpNZWRpYUNh cHR1cmVUeXBlIE9wZW5QYW5lbFBhcmFtZXRlcnM6Om1lZGlhQ2FwdHVyZVR5cGUoKSBjb25zdAog ewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSU9wZW5QYW5lbFBh cmFtZXRlcnMuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElPcGVuUGFuZWxQYXJh bWV0ZXJzLmgKaW5kZXggZGRmN2E0Y2VkMDIwZDM4ZjJjN2UyNzNkNTIzZDEwNzg5OWMxYWIxZS4u M2NkMGRhNjZhMzJlZmVkZDhhNjk5MDIxNGI0YjMxNTIzYTIwNGYzMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSU9wZW5QYW5lbFBhcmFtZXRlcnMuaAorKysgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJT3BlblBhbmVsUGFyYW1ldGVycy5oCkBAIC00 MCw2ICs0MCw3IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgYWxsb3dNdWx0aXBsZUZpbGVzKCkgY29u c3QgeyByZXR1cm4gbV9zZXR0aW5ncy5hbGxvd3NNdWx0aXBsZUZpbGVzOyB9CiAgICAgUmVmPEFQ STo6QXJyYXk+IGFjY2VwdE1JTUVUeXBlcygpIGNvbnN0OworICAgIFJlZjxBUEk6OkFycmF5PiBh Y2NlcHRGaWxlRXh0ZW5zaW9ucygpIGNvbnN0OwogICAgIFJlZjxBUEk6OkFycmF5PiBzZWxlY3Rl ZEZpbGVOYW1lcygpIGNvbnN0OwogI2lmIEVOQUJMRShNRURJQV9DQVBUVVJFKQogICAgIFdlYkNv cmU6Ok1lZGlhQ2FwdHVyZVR5cGUgbWVkaWFDYXB0dXJlVHlwZSgpIGNvbnN0OwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tPcGVuUGFuZWxQYXJhbWV0ZXJzUmVm LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLT3BlblBhbmVsUGFyYW1ldGVy c1JlZi5jcHAKaW5kZXggYzhhZDhkYTBmZTVkZDEyZjk1NTMyM2Q0YWNlOTFmODJmNjI0YjFjZi4u ZjBlYWMwYjdmNjk5ZDg0YzFjMTU2ZmZmMDYxYjUyZjg3YmI5MGQyYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tPcGVuUGFuZWxQYXJhbWV0ZXJzUmVmLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS09wZW5QYW5lbFBhcmFtZXRlcnNS ZWYuY3BwCkBAIC00OCw2ICs0OCwxMSBAQCBXS0FycmF5UmVmIFdLT3BlblBhbmVsUGFyYW1ldGVy c0NvcHlBY2NlcHRlZE1JTUVUeXBlcyhXS09wZW5QYW5lbFBhcmFtZXRlcnNSZWYgcAogICAgIHJl dHVybiB0b0FQSSgmdG9JbXBsKHBhcmFtZXRlcnNSZWYpLT5hY2NlcHRNSU1FVHlwZXMoKS5sZWFr UmVmKCkpOwogfQogCitXS0FycmF5UmVmIFdLT3BlblBhbmVsUGFyYW1ldGVyc0NvcHlBY2NlcHRl ZEZpbGVFeHRlbnNpb25zKFdLT3BlblBhbmVsUGFyYW1ldGVyc1JlZiBwYXJhbWV0ZXJzUmVmKQor eworICAgIHJldHVybiB0b0FQSSgmdG9JbXBsKHBhcmFtZXRlcnNSZWYpLT5hY2NlcHRGaWxlRXh0 ZW5zaW9ucygpLmxlYWtSZWYoKSk7Cit9CisKIC8vIERlcHJlY2F0ZWQuCiBXS1N0cmluZ1JlZiBX S09wZW5QYW5lbFBhcmFtZXRlcnNDb3B5Q2FwdHVyZShXS09wZW5QYW5lbFBhcmFtZXRlcnNSZWYp CiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS09wZW5QYW5l bFBhcmFtZXRlcnNSZWYuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLT3BlblBh bmVsUGFyYW1ldGVyc1JlZi5oCmluZGV4IGQ4Y2E3YzQwZGFjNDUxNzUxMjM3ZjNhNWIxMWI1ODAy NzU1NDNhYWYuLmY1MWM1ZGUwNzIzOTk1M2QxZjhkNGI5MmFjNzFlMTQ3MWM1YTM3NTUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLT3BlblBhbmVsUGFyYW1ldGVy c1JlZi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLT3BlblBhbmVsUGFy YW1ldGVyc1JlZi5oCkBAIC00Miw2ICs0Miw3IEBAIFdLX0VYUE9SVCBXS1R5cGVJRCBXS09wZW5Q YW5lbFBhcmFtZXRlcnNHZXRUeXBlSUQoKTsKIFdLX0VYUE9SVCBib29sIFdLT3BlblBhbmVsUGFy YW1ldGVyc0dldEFsbG93c011bHRpcGxlRmlsZXMoV0tPcGVuUGFuZWxQYXJhbWV0ZXJzUmVmIHBh cmFtZXRlcnMpOwogCiBXS19FWFBPUlQgV0tBcnJheVJlZiBXS09wZW5QYW5lbFBhcmFtZXRlcnND b3B5QWNjZXB0ZWRNSU1FVHlwZXMoV0tPcGVuUGFuZWxQYXJhbWV0ZXJzUmVmIHBhcmFtZXRlcnMp OworV0tfRVhQT1JUIFdLQXJyYXlSZWYgV0tPcGVuUGFuZWxQYXJhbWV0ZXJzQ29weUFjY2VwdGVk RmlsZUV4dGVuc2lvbnMoV0tPcGVuUGFuZWxQYXJhbWV0ZXJzUmVmIHBhcmFtZXRlcnMpOwogCiAv KiBERVBSRUNBVEVEIC0gUGxlYXNlIHVzZSBXS09wZW5QYW5lbFBhcmFtZXRlcnNHZXRDYXB0dXJl RW5hYmxlZCgpIGluc3RlYWQuICovCiBXS19FWFBPUlQgV0tTdHJpbmdSZWYgV0tPcGVuUGFuZWxQ YXJhbWV0ZXJzQ29weUNhcHR1cmUoV0tPcGVuUGFuZWxQYXJhbWV0ZXJzUmVmIHBhcmFtZXRlcnMp Owo=