95689 2012-09-03 07:33:54 -0700 [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher 2012-09-03 11:38:36 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 710644 0 ryuan.choi 2012-09-03 07:33:54 -0700 In Minibrowser & EWebLauncher, webview lost focus when url bar is clicked. So, key events are always generated in url bar although user clicked webview. Below is simple step to reproduce this bug. 1. load google.com 2. click url bar 3. click search field in webview. 4. try to write something. 710655 1 161928 ryuan.choi 2012-09-03 07:49:41 -0700 Created attachment 161928 Patch 710658 2 161928 cdumez 2012-09-03 07:57:51 -0700 Comment on attachment 161928 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161928&action=review LGTM but small nits: > Tools/MiniBrowser/efl/main.c:136 > +on_mouse_down(void* data, Evas* e, Evas_Object* webview, void* event_info) Stars on wrong side. > Tools/MiniBrowser/efl/main.c:138 > + Evas_Event_Mouse_Down *ev = (Evas_Event_Mouse_Down*) event_info; Shouldn't there be a space before the star? 710669 3 161934 ryuan.choi 2012-09-03 08:26:46 -0700 Created attachment 161934 Patch 710670 4 161935 ryuan.choi 2012-09-03 08:27:56 -0700 Created attachment 161935 Patch 710672 5 ryuan.choi 2012-09-03 08:30:44 -0700 (In reply to comment #2) > (From update of attachment 161928 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161928&action=review > > LGTM but small nits: > > > Tools/MiniBrowser/efl/main.c:136 > > +on_mouse_down(void* data, Evas* e, Evas_Object* webview, void* event_info) > > Stars on wrong side. > > > Tools/MiniBrowser/efl/main.c:138 > > + Evas_Event_Mouse_Down *ev = (Evas_Event_Mouse_Down*) event_info; > > Shouldn't there be a space before the star? Right, Fixed style issues in the codes which I change. 710679 6 161935 cdumez 2012-09-03 08:42:00 -0700 Comment on attachment 161935 Patch LGTM. Thanks. 710680 7 161935 kenneth 2012-09-03 08:51:06 -0700 Comment on attachment 161935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161935&action=review > Tools/ChangeLog:10 > + So, there are bug that key events are always generated in url bar although > + user clicked webview. Could use a bit more 'the's. although the user clicked on the web view 710683 8 161936 ryuan.choi 2012-09-03 09:01:42 -0700 Created attachment 161936 Patch 710686 9 161936 ryuan.choi 2012-09-03 09:04:50 -0700 Comment on attachment 161936 Patch I updated comments. s/webview/the web view/ s/focus/the focus/ s/user/the user/ 710730 10 161936 webkit.review.bot 2012-09-03 11:38:32 -0700 Comment on attachment 161936 Patch Clearing flags on attachment: 161936 Committed r127431: <http://trac.webkit.org/changeset/127431> 710731 11 webkit.review.bot 2012-09-03 11:38:36 -0700 All reviewed patches have been landed. Closing bug. 161928 2012-09-03 07:49:41 -0700 2012-09-03 08:26:42 -0700 Patch bug-95689-20120903234923.patch text/plain 3097 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzgyYTNhNTQ4ODJiOTVhNjIwNDRhZjZhYzU2YjlhZTgx Njg3NWFiYi4uZTNkNmVlODdiYzJmMGIwZWM0ZWViMDE1M2M0ZDA3NWIyMmFiYTcwOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTA5LTAzICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXSBDaGFuZ2UgZm9jdXMgd2hlbiB3ZWJ2aWV3IGlzIGNsaWNrZWQgaW4gTWlu aUJyb3dzZXIgYW5kIEVXZWJMYXVuY2hlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTU2ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbiBNaW5pYnJvd3NlciAmIEVXZWJMYXVuY2hlciwgd2Vidmlld3Mg bG9zZSB0aGUgZm9jdXMgd2hlbiB1cmwgYmFyIGlzIGNsaWNrZWQuCisgICAgICAgIFNvLCB0aGVy ZSBhcmUgYnVnIHRoYXQga2V5IGV2ZW50cyBhcmUgYWx3YXlzIGdlbmVyYXRlZCBpbiB1cmwgYmFy IGFsdGhvdWdoCisgICAgICAgIHVzZXIgY2xpY2tlZCB3ZWJ2aWV3LgorCisgICAgICAgIFRoaXMg cGF0Y2ggcmVjb3ZlcnMgdGhlIGZvY3VzIG9mIHdlYnZpZXcgd2hlbiBsZWZ0IGJ1dHRvbiBpcyBw cmVzc2VkIGFuZAorICAgICAgICBhZGRzIGZvciBNaW5pQnJvd3NlciB0byB0b2dnbGUgdGhlIGZv Y3VzIHdoZW4gbWlkZGxlIGJ1dHRvbiBpcyBwcmVzc2VkCisgICAgICAgIGxpa2UgRVdlYkxhdW5j aGVyIGFscmVhZHkgZGlkLgorCisgICAgICAgICogRVdlYkxhdW5jaGVyL21haW4uYzoKKyAgICAg ICAgKG9uX21vdXNlX2Rvd24pOgorICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWluLmM6Cisg ICAgICAgIChvbl9tb3VzZV9kb3duKToKKyAgICAgICAgKGJyb3dzZXJDcmVhdGUpOgorCiAyMDEy LTA5LTAzICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAK ICAgICAgICAgW0VGTF0gRml4IHJlc2l6aW5nIGlzc3VlcyByZWxhdGVkIHRvIFVSTCBiYXIgaW4g TWluaWJyb3dzZXIgLyBFV2ViTGF1bmNoZXIKZGlmZiAtLWdpdCBhL1Rvb2xzL0VXZWJMYXVuY2hl ci9tYWluLmMgYi9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCmluZGV4IDRjMzM5ZDFlNGJkYWZj ZmViYWJiZjhkNDY5NzgwY2ZlYjcxYzc4NDAuLmNkM2YzYzg0Y2I0ZDQ0YjUyNWFjODY2N2FmYjZk ZTAxNDI3ODllMDAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKKysrIGIv VG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYwpAQCAtNDM0LDcgKzQzNCwxMCBAQCBzdGF0aWMgdm9p ZAogb25fbW91c2VfZG93bih2b2lkKiBkYXRhLCBFdmFzKiBlLCBFdmFzX09iamVjdCogd2Vidmll dywgdm9pZCogZXZlbnRfaW5mbykKIHsKICAgICBFdmFzX0V2ZW50X01vdXNlX0Rvd24gKmV2ID0g KEV2YXNfRXZlbnRfTW91c2VfRG93biopIGV2ZW50X2luZm87Ci0gICAgaWYgKGV2LT5idXR0b24g PT0gMikKKworICAgIGlmIChldi0+YnV0dG9uID09IDEpCisgICAgICAgIGV2YXNfb2JqZWN0X2Zv Y3VzX3NldCh3ZWJ2aWV3LCBFSU5BX1RSVUUpOworICAgIGVsc2UgaWYgKGV2LT5idXR0b24gPT0g MikKICAgICAgICAgZXZhc19vYmplY3RfZm9jdXNfc2V0KHdlYnZpZXcsICFldmFzX29iamVjdF9m b2N1c19nZXQod2VidmlldykpOwogfQogCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9l ZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwppbmRleCBjM2NhZmE3YzY1 N2RkMzhlNzdkN2ZhYmNlZTdlZGZhYTM2OGQyZDEzLi43OTJjOGFhZTVhZTc3NjI0NmU4ZDU5MWFk ZGUwMjBjZGM3MDg2NjdmIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5j CisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKQEAgLTEzMyw2ICsxMzMsMTcgQEAg b25fa2V5X2Rvd24odm9pZCAqZGF0YSwgRXZhcyAqZSwgRXZhc19PYmplY3QgKm9iaiwgdm9pZCAq ZXZlbnRfaW5mbykKIH0KIAogc3RhdGljIHZvaWQKK29uX21vdXNlX2Rvd24odm9pZCogZGF0YSwg RXZhcyogZSwgRXZhc19PYmplY3QqIHdlYnZpZXcsIHZvaWQqIGV2ZW50X2luZm8pCit7CisgICAg RXZhc19FdmVudF9Nb3VzZV9Eb3duICpldiA9IChFdmFzX0V2ZW50X01vdXNlX0Rvd24qKSBldmVu dF9pbmZvOworCisgICAgaWYgKGV2LT5idXR0b24gPT0gMSkKKyAgICAgICAgZXZhc19vYmplY3Rf Zm9jdXNfc2V0KHdlYnZpZXcsIEVJTkFfVFJVRSk7CisgICAgZWxzZSBpZiAoZXYtPmJ1dHRvbiA9 PSAyKQorICAgICAgICBldmFzX29iamVjdF9mb2N1c19zZXQod2VidmlldywgIWV2YXNfb2JqZWN0 X2ZvY3VzX2dldCh3ZWJ2aWV3KSk7Cit9CisKK3N0YXRpYyB2b2lkCiB0aXRsZV9zZXQoRWNvcmVf RXZhcyAqZWUsIGNvbnN0IGNoYXIgKnRpdGxlLCBpbnQgcHJvZ3Jlc3MpCiB7CiAgICAgRWluYV9T dHJidWYqIGJ1ZmZlcjsKQEAgLTI0MSw2ICsyNTIsNyBAQCBzdGF0aWMgTWluaUJyb3dzZXIgKmJy b3dzZXJDcmVhdGUoY29uc3QgY2hhciAqdXJsLCBjb25zdCBjaGFyICplbmdpbmUpCiAgICAgZXZh c19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFwcC0+YnJvd3NlciwgInVyaSxjaGFuZ2VkIiwg b25fdXJsX2NoYW5nZWQsIGFwcCk7CiAKICAgICBldmFzX29iamVjdF9ldmVudF9jYWxsYmFja19h ZGQoYXBwLT5icm93c2VyLCBFVkFTX0NBTExCQUNLX0tFWV9ET1dOLCBvbl9rZXlfZG93biwgYXBw KTsKKyAgICBldmFzX29iamVjdF9ldmVudF9jYWxsYmFja19hZGQoYXBwLT5icm93c2VyLCBFVkFT X0NBTExCQUNLX01PVVNFX0RPV04sIG9uX21vdXNlX2Rvd24sIGFwcCk7CiAKICAgICBldmFzX29i amVjdF9zaXplX2hpbnRfd2VpZ2h0X3NldChhcHAtPmJyb3dzZXIsIEVWQVNfSElOVF9FWFBBTkQs IEVWQVNfSElOVF9FWFBBTkQpOwogICAgIGV2YXNfb2JqZWN0X21vdmUoYXBwLT5icm93c2VyLCAw LCBVUkxfQkFSX0hFSUdIVCk7Cg== 161934 2012-09-03 08:26:46 -0700 2012-09-03 08:27:52 -0700 Patch bug-95689-20120904002628.patch text/plain 3240 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzgyYTNhNTQ4ODJiOTVhNjIwNDRhZjZhYzU2YjlhZTgx Njg3NWFiYi4uZTNkNmVlODdiYzJmMGIwZWM0ZWViMDE1M2M0ZDA3NWIyMmFiYTcwOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTA5LTAzICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXSBDaGFuZ2UgZm9jdXMgd2hlbiB3ZWJ2aWV3IGlzIGNsaWNrZWQgaW4gTWlu aUJyb3dzZXIgYW5kIEVXZWJMYXVuY2hlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTU2ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbiBNaW5pYnJvd3NlciAmIEVXZWJMYXVuY2hlciwgd2Vidmlld3Mg bG9zZSB0aGUgZm9jdXMgd2hlbiB1cmwgYmFyIGlzIGNsaWNrZWQuCisgICAgICAgIFNvLCB0aGVy ZSBhcmUgYnVnIHRoYXQga2V5IGV2ZW50cyBhcmUgYWx3YXlzIGdlbmVyYXRlZCBpbiB1cmwgYmFy IGFsdGhvdWdoCisgICAgICAgIHVzZXIgY2xpY2tlZCB3ZWJ2aWV3LgorCisgICAgICAgIFRoaXMg cGF0Y2ggcmVjb3ZlcnMgdGhlIGZvY3VzIG9mIHdlYnZpZXcgd2hlbiBsZWZ0IGJ1dHRvbiBpcyBw cmVzc2VkIGFuZAorICAgICAgICBhZGRzIGZvciBNaW5pQnJvd3NlciB0byB0b2dnbGUgdGhlIGZv Y3VzIHdoZW4gbWlkZGxlIGJ1dHRvbiBpcyBwcmVzc2VkCisgICAgICAgIGxpa2UgRVdlYkxhdW5j aGVyIGFscmVhZHkgZGlkLgorCisgICAgICAgICogRVdlYkxhdW5jaGVyL21haW4uYzoKKyAgICAg ICAgKG9uX21vdXNlX2Rvd24pOgorICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWluLmM6Cisg ICAgICAgIChvbl9tb3VzZV9kb3duKToKKyAgICAgICAgKGJyb3dzZXJDcmVhdGUpOgorCiAyMDEy LTA5LTAzICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAK ICAgICAgICAgW0VGTF0gRml4IHJlc2l6aW5nIGlzc3VlcyByZWxhdGVkIHRvIFVSTCBiYXIgaW4g TWluaWJyb3dzZXIgLyBFV2ViTGF1bmNoZXIKZGlmZiAtLWdpdCBhL1Rvb2xzL0VXZWJMYXVuY2hl ci9tYWluLmMgYi9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCmluZGV4IDRjMzM5ZDFlNGJkYWZj ZmViYWJiZjhkNDY5NzgwY2ZlYjcxYzc4NDAuLmZmZWE5MGNlNTk4MWE3MDg2OTQxYmE2OGViYjVk YjUzYWU4ZTZhNGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKKysrIGIv VG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYwpAQCAtNDMzLDggKzQzMywxMSBAQCBvbl91cmxfY2hh bmdlZCh2b2lkKiB1c2VyX2RhdGEsIEV2YXNfT2JqZWN0KiB3ZWJ2aWV3LCB2b2lkKiBldmVudF9p bmZvKQogc3RhdGljIHZvaWQKIG9uX21vdXNlX2Rvd24odm9pZCogZGF0YSwgRXZhcyogZSwgRXZh c19PYmplY3QqIHdlYnZpZXcsIHZvaWQqIGV2ZW50X2luZm8pCiB7Ci0gICAgRXZhc19FdmVudF9N b3VzZV9Eb3duICpldiA9IChFdmFzX0V2ZW50X01vdXNlX0Rvd24qKSBldmVudF9pbmZvOwotICAg IGlmIChldi0+YnV0dG9uID09IDIpCisgICAgRXZhc19FdmVudF9Nb3VzZV9Eb3duICpldiA9IChF dmFzX0V2ZW50X01vdXNlX0Rvd24gKilldmVudF9pbmZvOworCisgICAgaWYgKGV2LT5idXR0b24g PT0gMSkKKyAgICAgICAgZXZhc19vYmplY3RfZm9jdXNfc2V0KHdlYnZpZXcsIEVJTkFfVFJVRSk7 CisgICAgZWxzZSBpZiAoZXYtPmJ1dHRvbiA9PSAyKQogICAgICAgICBldmFzX29iamVjdF9mb2N1 c19zZXQod2VidmlldywgIWV2YXNfb2JqZWN0X2ZvY3VzX2dldCh3ZWJ2aWV3KSk7CiB9CiAKZGlm ZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMgYi9Ub29scy9NaW5pQnJvd3Nl ci9lZmwvbWFpbi5jCmluZGV4IGMzY2FmYTdjNjU3ZGQzOGU3N2Q3ZmFiY2VlN2VkZmFhMzY4ZDJk MTMuLjc2OGFhODc2ZjZhOWE3YTFkOTM4ZmU1ZTQ3YWM3Mzg1M2QyMGQzNGIgMTAwNjQ0Ci0tLSBh L1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZs L21haW4uYwpAQCAtMTMzLDYgKzEzMywxNyBAQCBvbl9rZXlfZG93bih2b2lkICpkYXRhLCBFdmFz ICplLCBFdmFzX09iamVjdCAqb2JqLCB2b2lkICpldmVudF9pbmZvKQogfQogCiBzdGF0aWMgdm9p ZAorb25fbW91c2VfZG93bih2b2lkICpkYXRhLCBFdmFzICplLCBFdmFzX09iamVjdCAqd2Vidmll dywgdm9pZCAqZXZlbnRfaW5mbykKK3sKKyAgICBFdmFzX0V2ZW50X01vdXNlX0Rvd24gKmV2ID0g KEV2YXNfRXZlbnRfTW91c2VfRG93biopIGV2ZW50X2luZm87CisKKyAgICBpZiAoZXYtPmJ1dHRv biA9PSAxKQorICAgICAgICBldmFzX29iamVjdF9mb2N1c19zZXQod2VidmlldywgRUlOQV9UUlVF KTsKKyAgICBlbHNlIGlmIChldi0+YnV0dG9uID09IDIpCisgICAgICAgIGV2YXNfb2JqZWN0X2Zv Y3VzX3NldCh3ZWJ2aWV3LCAhZXZhc19vYmplY3RfZm9jdXNfZ2V0KHdlYnZpZXcpKTsKK30KKwor c3RhdGljIHZvaWQKIHRpdGxlX3NldChFY29yZV9FdmFzICplZSwgY29uc3QgY2hhciAqdGl0bGUs IGludCBwcm9ncmVzcykKIHsKICAgICBFaW5hX1N0cmJ1ZiogYnVmZmVyOwpAQCAtMjQxLDYgKzI1 Miw3IEBAIHN0YXRpYyBNaW5pQnJvd3NlciAqYnJvd3NlckNyZWF0ZShjb25zdCBjaGFyICp1cmws IGNvbnN0IGNoYXIgKmVuZ2luZSkKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQo YXBwLT5icm93c2VyLCAidXJpLGNoYW5nZWQiLCBvbl91cmxfY2hhbmdlZCwgYXBwKTsKIAogICAg IGV2YXNfb2JqZWN0X2V2ZW50X2NhbGxiYWNrX2FkZChhcHAtPmJyb3dzZXIsIEVWQVNfQ0FMTEJB Q0tfS0VZX0RPV04sIG9uX2tleV9kb3duLCBhcHApOworICAgIGV2YXNfb2JqZWN0X2V2ZW50X2Nh bGxiYWNrX2FkZChhcHAtPmJyb3dzZXIsIEVWQVNfQ0FMTEJBQ0tfTU9VU0VfRE9XTiwgb25fbW91 c2VfZG93biwgYXBwKTsKIAogICAgIGV2YXNfb2JqZWN0X3NpemVfaGludF93ZWlnaHRfc2V0KGFw cC0+YnJvd3NlciwgRVZBU19ISU5UX0VYUEFORCwgRVZBU19ISU5UX0VYUEFORCk7CiAgICAgZXZh c19vYmplY3RfbW92ZShhcHAtPmJyb3dzZXIsIDAsIFVSTF9CQVJfSEVJR0hUKTsK 161935 2012-09-03 08:27:56 -0700 2012-09-03 09:01:37 -0700 Patch bug-95689-20120904002739.patch text/plain 3240 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzgyYTNhNTQ4ODJiOTVhNjIwNDRhZjZhYzU2YjlhZTgx Njg3NWFiYi4uZTNkNmVlODdiYzJmMGIwZWM0ZWViMDE1M2M0ZDA3NWIyMmFiYTcwOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTA5LTAzICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXSBDaGFuZ2UgZm9jdXMgd2hlbiB3ZWJ2aWV3IGlzIGNsaWNrZWQgaW4gTWlu aUJyb3dzZXIgYW5kIEVXZWJMYXVuY2hlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTU2ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbiBNaW5pYnJvd3NlciAmIEVXZWJMYXVuY2hlciwgd2Vidmlld3Mg bG9zZSB0aGUgZm9jdXMgd2hlbiB1cmwgYmFyIGlzIGNsaWNrZWQuCisgICAgICAgIFNvLCB0aGVy ZSBhcmUgYnVnIHRoYXQga2V5IGV2ZW50cyBhcmUgYWx3YXlzIGdlbmVyYXRlZCBpbiB1cmwgYmFy IGFsdGhvdWdoCisgICAgICAgIHVzZXIgY2xpY2tlZCB3ZWJ2aWV3LgorCisgICAgICAgIFRoaXMg cGF0Y2ggcmVjb3ZlcnMgdGhlIGZvY3VzIG9mIHdlYnZpZXcgd2hlbiBsZWZ0IGJ1dHRvbiBpcyBw cmVzc2VkIGFuZAorICAgICAgICBhZGRzIGZvciBNaW5pQnJvd3NlciB0byB0b2dnbGUgdGhlIGZv Y3VzIHdoZW4gbWlkZGxlIGJ1dHRvbiBpcyBwcmVzc2VkCisgICAgICAgIGxpa2UgRVdlYkxhdW5j aGVyIGFscmVhZHkgZGlkLgorCisgICAgICAgICogRVdlYkxhdW5jaGVyL21haW4uYzoKKyAgICAg ICAgKG9uX21vdXNlX2Rvd24pOgorICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWluLmM6Cisg ICAgICAgIChvbl9tb3VzZV9kb3duKToKKyAgICAgICAgKGJyb3dzZXJDcmVhdGUpOgorCiAyMDEy LTA5LTAzICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAK ICAgICAgICAgW0VGTF0gRml4IHJlc2l6aW5nIGlzc3VlcyByZWxhdGVkIHRvIFVSTCBiYXIgaW4g TWluaWJyb3dzZXIgLyBFV2ViTGF1bmNoZXIKZGlmZiAtLWdpdCBhL1Rvb2xzL0VXZWJMYXVuY2hl ci9tYWluLmMgYi9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCmluZGV4IDRjMzM5ZDFlNGJkYWZj ZmViYWJiZjhkNDY5NzgwY2ZlYjcxYzc4NDAuLmZmZWE5MGNlNTk4MWE3MDg2OTQxYmE2OGViYjVk YjUzYWU4ZTZhNGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKKysrIGIv VG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYwpAQCAtNDMzLDggKzQzMywxMSBAQCBvbl91cmxfY2hh bmdlZCh2b2lkKiB1c2VyX2RhdGEsIEV2YXNfT2JqZWN0KiB3ZWJ2aWV3LCB2b2lkKiBldmVudF9p bmZvKQogc3RhdGljIHZvaWQKIG9uX21vdXNlX2Rvd24odm9pZCogZGF0YSwgRXZhcyogZSwgRXZh c19PYmplY3QqIHdlYnZpZXcsIHZvaWQqIGV2ZW50X2luZm8pCiB7Ci0gICAgRXZhc19FdmVudF9N b3VzZV9Eb3duICpldiA9IChFdmFzX0V2ZW50X01vdXNlX0Rvd24qKSBldmVudF9pbmZvOwotICAg IGlmIChldi0+YnV0dG9uID09IDIpCisgICAgRXZhc19FdmVudF9Nb3VzZV9Eb3duICpldiA9IChF dmFzX0V2ZW50X01vdXNlX0Rvd24gKilldmVudF9pbmZvOworCisgICAgaWYgKGV2LT5idXR0b24g PT0gMSkKKyAgICAgICAgZXZhc19vYmplY3RfZm9jdXNfc2V0KHdlYnZpZXcsIEVJTkFfVFJVRSk7 CisgICAgZWxzZSBpZiAoZXYtPmJ1dHRvbiA9PSAyKQogICAgICAgICBldmFzX29iamVjdF9mb2N1 c19zZXQod2VidmlldywgIWV2YXNfb2JqZWN0X2ZvY3VzX2dldCh3ZWJ2aWV3KSk7CiB9CiAKZGlm ZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMgYi9Ub29scy9NaW5pQnJvd3Nl ci9lZmwvbWFpbi5jCmluZGV4IGMzY2FmYTdjNjU3ZGQzOGU3N2Q3ZmFiY2VlN2VkZmFhMzY4ZDJk MTMuLjQxYWVhZWJkYzcxMjNiMzVlNzg5MjNjN2Q3MTgxZDlhNzRjYjNiZDkgMTAwNjQ0Ci0tLSBh L1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZs L21haW4uYwpAQCAtMTMzLDYgKzEzMywxNyBAQCBvbl9rZXlfZG93bih2b2lkICpkYXRhLCBFdmFz ICplLCBFdmFzX09iamVjdCAqb2JqLCB2b2lkICpldmVudF9pbmZvKQogfQogCiBzdGF0aWMgdm9p ZAorb25fbW91c2VfZG93bih2b2lkICpkYXRhLCBFdmFzICplLCBFdmFzX09iamVjdCAqd2Vidmll dywgdm9pZCAqZXZlbnRfaW5mbykKK3sKKyAgICBFdmFzX0V2ZW50X01vdXNlX0Rvd24gKmV2ID0g KEV2YXNfRXZlbnRfTW91c2VfRG93biAqKWV2ZW50X2luZm87CisKKyAgICBpZiAoZXYtPmJ1dHRv biA9PSAxKQorICAgICAgICBldmFzX29iamVjdF9mb2N1c19zZXQod2VidmlldywgRUlOQV9UUlVF KTsKKyAgICBlbHNlIGlmIChldi0+YnV0dG9uID09IDIpCisgICAgICAgIGV2YXNfb2JqZWN0X2Zv Y3VzX3NldCh3ZWJ2aWV3LCAhZXZhc19vYmplY3RfZm9jdXNfZ2V0KHdlYnZpZXcpKTsKK30KKwor c3RhdGljIHZvaWQKIHRpdGxlX3NldChFY29yZV9FdmFzICplZSwgY29uc3QgY2hhciAqdGl0bGUs IGludCBwcm9ncmVzcykKIHsKICAgICBFaW5hX1N0cmJ1ZiogYnVmZmVyOwpAQCAtMjQxLDYgKzI1 Miw3IEBAIHN0YXRpYyBNaW5pQnJvd3NlciAqYnJvd3NlckNyZWF0ZShjb25zdCBjaGFyICp1cmws IGNvbnN0IGNoYXIgKmVuZ2luZSkKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQo YXBwLT5icm93c2VyLCAidXJpLGNoYW5nZWQiLCBvbl91cmxfY2hhbmdlZCwgYXBwKTsKIAogICAg IGV2YXNfb2JqZWN0X2V2ZW50X2NhbGxiYWNrX2FkZChhcHAtPmJyb3dzZXIsIEVWQVNfQ0FMTEJB Q0tfS0VZX0RPV04sIG9uX2tleV9kb3duLCBhcHApOworICAgIGV2YXNfb2JqZWN0X2V2ZW50X2Nh bGxiYWNrX2FkZChhcHAtPmJyb3dzZXIsIEVWQVNfQ0FMTEJBQ0tfTU9VU0VfRE9XTiwgb25fbW91 c2VfZG93biwgYXBwKTsKIAogICAgIGV2YXNfb2JqZWN0X3NpemVfaGludF93ZWlnaHRfc2V0KGFw cC0+YnJvd3NlciwgRVZBU19ISU5UX0VYUEFORCwgRVZBU19ISU5UX0VYUEFORCk7CiAgICAgZXZh c19vYmplY3RfbW92ZShhcHAtPmJyb3dzZXIsIDAsIFVSTF9CQVJfSEVJR0hUKTsK 161936 2012-09-03 09:01:42 -0700 2012-09-03 11:38:32 -0700 Patch bug-95689-20120904010123.patch text/plain 3281 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzgyYTNhNTQ4ODJiOTVhNjIwNDRhZjZhYzU2YjlhZTgx Njg3NWFiYi4uNWEyYjVlOWY0MzU1NmRkN2NkNmUxYmJkN2VjMDc5MWUyY2ZlMTFmNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTA5LTAzICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXSBDaGFuZ2UgdGhlIGZvY3VzIHdoZW4gdGhlIHdlYiB2aWV3IGlzIGNsaWNr ZWQgaW4gTWluaUJyb3dzZXIgYW5kIEVXZWJMYXVuY2hlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU2ODkKKworICAgICAgICBSZXZpZXdlZCBieSBL ZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KKworICAgICAgICBJbiBNaW5pYnJvd3NlciAmIEVX ZWJMYXVuY2hlciwgdGhlIHdlYiB2aWV3IGxvc2VzIHRoZSBmb2N1cyB3aGVuIHVybCBiYXIgaXMg Y2xpY2tlZC4KKyAgICAgICAgU28sIHRoZXJlIGFyZSBidWdzIHRoYXQga2V5IGV2ZW50cyBhcmUg YWx3YXlzIGdlbmVyYXRlZCBpbiB1cmwgYmFyIGFsdGhvdWdoCisgICAgICAgIHRoZSB1c2VyIGNs aWNrZWQgdGhlIHdlYiB2aWV3LgorCisgICAgICAgIFRoaXMgcGF0Y2ggcmVjb3ZlcnMgdGhlIGZv Y3VzIG9mIHRoZSB3ZWIgdmlldyB3aGVuIGxlZnQgYnV0dG9uIGlzIHByZXNzZWQgYW5kCisgICAg ICAgIGFkZHMgZm9yIE1pbmlCcm93c2VyIHRvIHRvZ2dsZSB0aGUgZm9jdXMgd2hlbiBtaWRkbGUg YnV0dG9uIGlzIHByZXNzZWQKKyAgICAgICAgbGlrZSBFV2ViTGF1bmNoZXIgYWxyZWFkeSBkaWQu CisKKyAgICAgICAgKiBFV2ViTGF1bmNoZXIvbWFpbi5jOgorICAgICAgICAob25fbW91c2VfZG93 bik6CisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKG9uX21vdXNl X2Rvd24pOgorICAgICAgICAoYnJvd3NlckNyZWF0ZSk6CisKIDIwMTItMDktMDMgIENocmlzdG9w aGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBG aXggcmVzaXppbmcgaXNzdWVzIHJlbGF0ZWQgdG8gVVJMIGJhciBpbiBNaW5pYnJvd3NlciAvIEVX ZWJMYXVuY2hlcgpkaWZmIC0tZ2l0IGEvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYyBiL1Rvb2xz L0VXZWJMYXVuY2hlci9tYWluLmMKaW5kZXggNGMzMzlkMWU0YmRhZmNmZWJhYmJmOGQ0Njk3ODBj ZmViNzFjNzg0MC4uZmZlYTkwY2U1OTgxYTcwODY5NDFiYTY4ZWJiNWRiNTNhZThlNmE0ZiAxMDA2 NDQKLS0tIGEvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYworKysgYi9Ub29scy9FV2ViTGF1bmNo ZXIvbWFpbi5jCkBAIC00MzMsOCArNDMzLDExIEBAIG9uX3VybF9jaGFuZ2VkKHZvaWQqIHVzZXJf ZGF0YSwgRXZhc19PYmplY3QqIHdlYnZpZXcsIHZvaWQqIGV2ZW50X2luZm8pCiBzdGF0aWMgdm9p ZAogb25fbW91c2VfZG93bih2b2lkKiBkYXRhLCBFdmFzKiBlLCBFdmFzX09iamVjdCogd2Vidmll dywgdm9pZCogZXZlbnRfaW5mbykKIHsKLSAgICBFdmFzX0V2ZW50X01vdXNlX0Rvd24gKmV2ID0g KEV2YXNfRXZlbnRfTW91c2VfRG93biopIGV2ZW50X2luZm87Ci0gICAgaWYgKGV2LT5idXR0b24g PT0gMikKKyAgICBFdmFzX0V2ZW50X01vdXNlX0Rvd24gKmV2ID0gKEV2YXNfRXZlbnRfTW91c2Vf RG93biAqKWV2ZW50X2luZm87CisKKyAgICBpZiAoZXYtPmJ1dHRvbiA9PSAxKQorICAgICAgICBl dmFzX29iamVjdF9mb2N1c19zZXQod2VidmlldywgRUlOQV9UUlVFKTsKKyAgICBlbHNlIGlmIChl di0+YnV0dG9uID09IDIpCiAgICAgICAgIGV2YXNfb2JqZWN0X2ZvY3VzX3NldCh3ZWJ2aWV3LCAh ZXZhc19vYmplY3RfZm9jdXNfZ2V0KHdlYnZpZXcpKTsKIH0KIApkaWZmIC0tZ2l0IGEvVG9vbHMv TWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKaW5k ZXggYzNjYWZhN2M2NTdkZDM4ZTc3ZDdmYWJjZWU3ZWRmYWEzNjhkMmQxMy4uNDFhZWFlYmRjNzEy M2IzNWU3ODkyM2M3ZDcxODFkOWE3NGNiM2JkOSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dz ZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCkBAIC0xMzMs NiArMTMzLDE3IEBAIG9uX2tleV9kb3duKHZvaWQgKmRhdGEsIEV2YXMgKmUsIEV2YXNfT2JqZWN0 ICpvYmosIHZvaWQgKmV2ZW50X2luZm8pCiB9CiAKIHN0YXRpYyB2b2lkCitvbl9tb3VzZV9kb3du KHZvaWQgKmRhdGEsIEV2YXMgKmUsIEV2YXNfT2JqZWN0ICp3ZWJ2aWV3LCB2b2lkICpldmVudF9p bmZvKQoreworICAgIEV2YXNfRXZlbnRfTW91c2VfRG93biAqZXYgPSAoRXZhc19FdmVudF9Nb3Vz ZV9Eb3duICopZXZlbnRfaW5mbzsKKworICAgIGlmIChldi0+YnV0dG9uID09IDEpCisgICAgICAg IGV2YXNfb2JqZWN0X2ZvY3VzX3NldCh3ZWJ2aWV3LCBFSU5BX1RSVUUpOworICAgIGVsc2UgaWYg KGV2LT5idXR0b24gPT0gMikKKyAgICAgICAgZXZhc19vYmplY3RfZm9jdXNfc2V0KHdlYnZpZXcs ICFldmFzX29iamVjdF9mb2N1c19nZXQod2VidmlldykpOworfQorCitzdGF0aWMgdm9pZAogdGl0 bGVfc2V0KEVjb3JlX0V2YXMgKmVlLCBjb25zdCBjaGFyICp0aXRsZSwgaW50IHByb2dyZXNzKQog ewogICAgIEVpbmFfU3RyYnVmKiBidWZmZXI7CkBAIC0yNDEsNiArMjUyLDcgQEAgc3RhdGljIE1p bmlCcm93c2VyICpicm93c2VyQ3JlYXRlKGNvbnN0IGNoYXIgKnVybCwgY29uc3QgY2hhciAqZW5n aW5lKQogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHAtPmJyb3dzZXIsICJ1 cmksY2hhbmdlZCIsIG9uX3VybF9jaGFuZ2VkLCBhcHApOwogCiAgICAgZXZhc19vYmplY3RfZXZl bnRfY2FsbGJhY2tfYWRkKGFwcC0+YnJvd3NlciwgRVZBU19DQUxMQkFDS19LRVlfRE9XTiwgb25f a2V5X2Rvd24sIGFwcCk7CisgICAgZXZhc19vYmplY3RfZXZlbnRfY2FsbGJhY2tfYWRkKGFwcC0+ YnJvd3NlciwgRVZBU19DQUxMQkFDS19NT1VTRV9ET1dOLCBvbl9tb3VzZV9kb3duLCBhcHApOwog CiAgICAgZXZhc19vYmplY3Rfc2l6ZV9oaW50X3dlaWdodF9zZXQoYXBwLT5icm93c2VyLCBFVkFT X0hJTlRfRVhQQU5ELCBFVkFTX0hJTlRfRVhQQU5EKTsKICAgICBldmFzX29iamVjdF9tb3ZlKGFw cC0+YnJvd3NlciwgMCwgVVJMX0JBUl9IRUlHSFQpOwo=