95687 2012-09-03 06:58:22 -0700 Web Inspector: [WebGL] Bugfix: wrong texture binding target in replay for 3D textures 2012-09-04 05:30:15 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 aandrey aandrey apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 710616 0 aandrey 2012-09-03 06:58:22 -0700 gl.bindTexture accepts either TEXTURE_2D or TEXTURE_CUBE_MAP targets, but we tried to replay with TEXTURE_CUBE_MAP_POSITIVE_X and others for 3D textures. Patch to follow. 710619 1 161920 aandrey 2012-09-03 07:00:32 -0700 Created attachment 161920 Patch 711013 2 161920 webkit.review.bot 2012-09-04 05:30:12 -0700 Comment on attachment 161920 Patch Clearing flags on attachment: 161920 Committed r127459: <http://trac.webkit.org/changeset/127459> 711014 3 webkit.review.bot 2012-09-04 05:30:15 -0700 All reviewed patches have been landed. Closing bug. 161920 2012-09-03 07:00:32 -0700 2012-09-04 05:30:11 -0700 Patch bug-95687-20120903180015.patch text/plain 3558 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjE3Njg3OWNmOGQ1Nzg4 NjgxNmI5NTIxYTMzNzAzYjg4NTBjYmMxMC4uZDcyMTc3MTllYWUxM2NjNGZmM2VkMDg3MTViNTYx NjFkNDAyMWQwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTAzICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtXZWJHTF0gQnVnZml4OiB3cm9uZyB0ZXh0dXJlIGJpbmRpbmcgdGFyZ2V0IGluIHJlcGxh eSBmb3IgM0QgdGV4dHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk1Njg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgZ2wuYmluZFRleHR1cmUgYWNjZXB0cyBlaXRoZXIgVEVYVFVSRV8yRCBvciBURVhU VVJFX0NVQkVfTUFQIHRhcmdldHMsIGJ1dCB3ZSB0cmllZCB0byByZXBsYXkgd2l0aCBURVhUVVJF X0NVQkVfTUFQX1BPU0lUSVZFX1ggYW5kIG90aGVycyBmb3IgM0QgdGV4dHVyZXMuCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRXZWJHTE1vZHVsZVNvdXJjZS5qczoKKyAgICAg ICAgKC4pOgorCiAyMDEyLTA4LTMxICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGdldCByaWQgb2YgY29udGV4dCBleGVjdXRp b24gaWQgZmFsbGJhY2suCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5q ZWN0ZWRTY3JpcHRXZWJHTE1vZHVsZVNvdXJjZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbmplY3RlZFNjcmlwdFdlYkdMTW9kdWxlU291cmNlLmpzCmluZGV4IGVlZjkyMGY1YzQ4M2Qy MzM1ZTBlZWUwNmZiODVhZDk1ZmZhNzA2MWUuLjU3ZjdmNTUwNjYyNjBhYjE4MjAyZGFjZTUwYjc2 MzUyNzkzNThiNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3Rl ZFNjcmlwdFdlYkdMTW9kdWxlU291cmNlLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbmplY3RlZFNjcmlwdFdlYkdMTW9kdWxlU291cmNlLmpzCkBAIC0xMzY1LDE5ICsxMzY1LDIw IEBAIFdlYkdMUmVuZGVyaW5nQ29udGV4dFJlc291cmNlLnByb3RvdHlwZSA9IHsKICAgICAgICAg aWYgKHJlc291cmNlKQogICAgICAgICAgICAgcmV0dXJuIHJlc291cmNlOwogICAgICAgICB2YXIg Z2wgPSB0aGlzLndyYXBwZWRPYmplY3QoKTsKLSAgICAgICAgdmFyIGJpbmRpbmdUYXJnZXQ7Cisg ICAgICAgIHZhciBiaW5kaW5nUGFyYW1ldGVyOwogICAgICAgICB2YXIgYmluZE1ldGhvZE5hbWU7 CisgICAgICAgIHZhciBiaW5kTWV0aG9kVGFyZ2V0ID0gdGFyZ2V0OwogICAgICAgICBzd2l0Y2gg KHRhcmdldCkgewogICAgICAgICBjYXNlIGdsLkFSUkFZX0JVRkZFUjoKLSAgICAgICAgICAgIGJp bmRpbmdUYXJnZXQgPSBnbC5BUlJBWV9CVUZGRVJfQklORElORzsKKyAgICAgICAgICAgIGJpbmRp bmdQYXJhbWV0ZXIgPSBnbC5BUlJBWV9CVUZGRVJfQklORElORzsKICAgICAgICAgICAgIGJpbmRN ZXRob2ROYW1lID0gImJpbmRCdWZmZXIiOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNh c2UgZ2wuRUxFTUVOVF9BUlJBWV9CVUZGRVI6Ci0gICAgICAgICAgICBiaW5kaW5nVGFyZ2V0ID0g Z2wuRUxFTUVOVF9BUlJBWV9CVUZGRVJfQklORElORzsKKyAgICAgICAgICAgIGJpbmRpbmdQYXJh bWV0ZXIgPSBnbC5FTEVNRU5UX0FSUkFZX0JVRkZFUl9CSU5ESU5HOwogICAgICAgICAgICAgYmlu ZE1ldGhvZE5hbWUgPSAiYmluZEJ1ZmZlciI7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAg Y2FzZSBnbC5URVhUVVJFXzJEOgotICAgICAgICAgICAgYmluZGluZ1RhcmdldCA9IGdsLlRFWFRV UkVfQklORElOR18yRDsKKyAgICAgICAgICAgIGJpbmRpbmdQYXJhbWV0ZXIgPSBnbC5URVhUVVJF X0JJTkRJTkdfMkQ7CiAgICAgICAgICAgICBiaW5kTWV0aG9kTmFtZSA9ICJiaW5kVGV4dHVyZSI7 CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBnbC5URVhUVVJFX0NVQkVfTUFQOgpA QCAtMTM4NywyNCArMTM4OCwyNSBAQCBXZWJHTFJlbmRlcmluZ0NvbnRleHRSZXNvdXJjZS5wcm90 b3R5cGUgPSB7CiAgICAgICAgIGNhc2UgZ2wuVEVYVFVSRV9DVUJFX01BUF9ORUdBVElWRV9ZOgog ICAgICAgICBjYXNlIGdsLlRFWFRVUkVfQ1VCRV9NQVBfUE9TSVRJVkVfWjoKICAgICAgICAgY2Fz ZSBnbC5URVhUVVJFX0NVQkVfTUFQX05FR0FUSVZFX1o6Ci0gICAgICAgICAgICBiaW5kaW5nVGFy Z2V0ID0gZ2wuVEVYVFVSRV9CSU5ESU5HX0NVQkVfTUFQOworICAgICAgICAgICAgYmluZGluZ1Bh cmFtZXRlciA9IGdsLlRFWFRVUkVfQklORElOR19DVUJFX01BUDsKKyAgICAgICAgICAgIGJpbmRN ZXRob2RUYXJnZXQgPSBnbC5URVhUVVJFX0NVQkVfTUFQOwogICAgICAgICAgICAgYmluZE1ldGhv ZE5hbWUgPSAiYmluZFRleHR1cmUiOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2Ug Z2wuRlJBTUVCVUZGRVI6Ci0gICAgICAgICAgICBiaW5kaW5nVGFyZ2V0ID0gZ2wuRlJBTUVCVUZG RVJfQklORElORzsKKyAgICAgICAgICAgIGJpbmRpbmdQYXJhbWV0ZXIgPSBnbC5GUkFNRUJVRkZF Ul9CSU5ESU5HOwogICAgICAgICAgICAgYmluZE1ldGhvZE5hbWUgPSAiYmluZEZyYW1lYnVmZmVy IjsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIGdsLlJFTkRFUkJVRkZFUjoKLSAg ICAgICAgICAgIGJpbmRpbmdUYXJnZXQgPSBnbC5SRU5ERVJCVUZGRVJfQklORElORzsKKyAgICAg ICAgICAgIGJpbmRpbmdQYXJhbWV0ZXIgPSBnbC5SRU5ERVJCVUZGRVJfQklORElORzsKICAgICAg ICAgICAgIGJpbmRNZXRob2ROYW1lID0gImJpbmRSZW5kZXJidWZmZXIiOwogICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICBjb25zb2xlLmVycm9yKCJBU1NF UlRfTk9UX1JFQUNIRUQ6IHVua25vd24gYmluZGluZyB0YXJnZXQgIiArIHRhcmdldCk7CiAgICAg ICAgICAgICByZXR1cm4gbnVsbDsKICAgICAgICAgfQotICAgICAgICByZXNvdXJjZSA9IFJlc291 cmNlLmZvck9iamVjdChnbC5nZXRQYXJhbWV0ZXIoYmluZGluZ1RhcmdldCkpOworICAgICAgICBy ZXNvdXJjZSA9IFJlc291cmNlLmZvck9iamVjdChnbC5nZXRQYXJhbWV0ZXIoYmluZGluZ1BhcmFt ZXRlcikpOwogICAgICAgICBpZiAocmVzb3VyY2UpCi0gICAgICAgICAgICByZXNvdXJjZS5wdXNo QmluZGluZyh0YXJnZXQsIGJpbmRNZXRob2ROYW1lKTsKKyAgICAgICAgICAgIHJlc291cmNlLnB1 c2hCaW5kaW5nKGJpbmRNZXRob2RUYXJnZXQsIGJpbmRNZXRob2ROYW1lKTsKICAgICAgICAgcmV0 dXJuIHJlc291cmNlOwogICAgIH0sCiAK