95683 2012-09-03 06:08:06 -0700 [Qt] Not all activated elements highlighted, but some frames are 2012-09-03 12:14:22 -0700 1 1 1 Unclassified WebKit WebKit2 420+ Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen dglazkov peter+ews webkit.review.bot oldest_to_newest 710583 0 allan.jensen 2012-09-03 06:08:06 -0700 There are cases where we currently fail to show the tap-highlight for the element touch-adjustment has determined should be activated. Also there are cases where we end up tap-highlighting entire frames because they are focusable. 710587 1 161912 allan.jensen 2012-09-03 06:11:39 -0700 Created attachment 161912 Patch 710600 2 161912 peter+ews 2012-09-03 06:34:09 -0700 Comment on attachment 161912 Patch Attachment 161912 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13740164 710639 3 161912 allan.jensen 2012-09-03 07:29:00 -0700 Comment on attachment 161912 Patch The build-failure can not have been caused by this patch. 710738 4 161912 webkit.review.bot 2012-09-03 12:14:19 -0700 Comment on attachment 161912 Patch Clearing flags on attachment: 161912 Committed r127432: <http://trac.webkit.org/changeset/127432> 710739 5 webkit.review.bot 2012-09-03 12:14:22 -0700 All reviewed patches have been landed. Closing bug. 161912 2012-09-03 06:11:39 -0700 2012-09-03 12:14:19 -0700 Patch bug-95683-20120903151113.patch text/plain 1956 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmU5OWY2MzgwYzE1NTE2 YmI5Mzc4YzFmMjU1OTVjNDFmMjFiMzU2YS4uNjhlYjY3YTQ1ZDIyY2NiNGQwNmUzZGZkM2IwYjNm ZTc5MWM0OWJmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEyLTA5LTAzICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgogCisgICAgICAgIFtR dF0gTm90IGFsbCBhY3RpdmF0ZWQgZWxlbWVudHMgaGlnaGxpZ2h0ZWQsIGJ1dCBzb21lIGZyYW1l cyBhcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1 NjgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNl IHRoZSBuZXcgZnVuY3Rpb24gTm9kZTo6d2lsbFJlc3BvbmRUb01vdXNlQ2xpY2tFdmVudHMgdG8g YmV0dGVyIGRldGVybWluZSBpZiB0aGUgZWxlbWVudAorICAgICAgICBjYW4gYmUgdGFwLWFjdGl2 YXRlZCBhbmQgYXZvaWQgZG9jdW1lbnRzIGFuZCBmcmFtZXMgY29tcGxldGVseS4KKworICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi UGFnZTo6aGlnaGxpZ2h0UG90ZW50aWFsQWN0aXZhdGlvbik6CisKKzIwMTItMDktMDMgIEFsbGFu IFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CisKICAgICAgICAgQWxs b3cgY2hpbGQtZnJhbWUgY29udGVudCBpbiBoaXQtdGVzdHMuCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTIwNAogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggZWNhYzEyY2Y2MzIyNDZlYzMzN2Mz YTViYWUyMTBjNjM4MGM4ZjFmMS4uZjQwYWEwYTNlMzNhMGYwNDMxMmU1YmZmYmEwNTBkZTFjMzk0 ZDBiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cApAQCAtMTU2Miw3ICsxNTYyLDkgQEAgdm9pZCBXZWJQYWdlOjpoaWdobGlnaHRQb3RlbnRpYWxB Y3RpdmF0aW9uKGNvbnN0IEludFBvaW50JiBwb2ludCwgY29uc3QgSW50U2l6ZSYKICAgICAgICAg Ly8gcGFnZXMgaGFzIGEgZ2xvYmFsIGNsaWNrIGhhbmRsZXIgYW5kIHdlIGRvIG5vdCB3YW50IHRv IGhpZ2hsaWdodCB0aGUgYm9keS4KICAgICAgICAgLy8gSW5zdGVhZCBmaW5kIHRoZSBlbmNsb3Np bmcgbGluayBvciBmb2N1c2FibGUgZWxlbWVudCwgb3IgdGhlIGxhc3QgZW5jbG9zaW5nIGlubGlu ZSBlbGVtZW50LgogICAgICAgICBmb3IgKE5vZGUqIG5vZGUgPSBhZGp1c3RlZE5vZGU7IG5vZGU7 IG5vZGUgPSBub2RlLT5wYXJlbnRPckhvc3ROb2RlKCkpIHsKLSAgICAgICAgICAgIGlmIChub2Rl LT5pc01vdXNlRm9jdXNhYmxlKCkgfHwgbm9kZS0+aXNMaW5rKCkpIHsKKyAgICAgICAgICAgIGlm IChub2RlLT5pc0RvY3VtZW50Tm9kZSgpIHx8IG5vZGUtPmlzRnJhbWVPd25lckVsZW1lbnQoKSkK KyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIGlmIChub2RlLT5pc01vdXNlRm9j dXNhYmxlKCkgfHwgbm9kZS0+d2lsbFJlc3BvbmRUb01vdXNlQ2xpY2tFdmVudHMoKSkgewogICAg ICAgICAgICAgICAgIGFjdGl2YXRpb25Ob2RlID0gbm9kZTsKICAgICAgICAgICAgICAgICBicmVh azsKICAgICAgICAgICAgIH0K