95682 2012-09-03 05:42:15 -0700 Web Inspector: [WebGL] Make the injected __resourceObject property non-enumerable 2012-09-03 09:09:34 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 aandrey aandrey apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 710567 0 aandrey 2012-09-03 05:42:15 -0700 Make the injected auxiliary property __resourceObject non-enumerable to hide it from for..in iterations. 710568 1 161906 aandrey 2012-09-03 05:47:21 -0700 Created attachment 161906 Patch 710573 2 161906 pfeldman 2012-09-03 05:54:20 -0700 Comment on attachment 161906 Patch Is there a test? 710580 3 aandrey 2012-09-03 06:04:14 -0700 I don't think we need to test that Object.defineProperty does what the specs says. Otherwise, plz suggest a test case. 710689 4 161906 webkit.review.bot 2012-09-03 09:09:30 -0700 Comment on attachment 161906 Patch Clearing flags on attachment: 161906 Committed r127426: <http://trac.webkit.org/changeset/127426> 710690 5 webkit.review.bot 2012-09-03 09:09:34 -0700 All reviewed patches have been landed. Closing bug. 161906 2012-09-03 05:47:21 -0700 2012-09-03 09:09:30 -0700 Patch bug-95682-20120903164705.patch text/plain 4608 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjE3Njg3OWNmOGQ1Nzg4 NjgxNmI5NTIxYTMzNzAzYjg4NTBjYmMxMC4uYTlhZmM1MWZiMmE3NTQ4M2UzMTk3OWJlYjQ4YjMw YjFmMmU2NDZmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTAzICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtXZWJHTF0gTWFrZSB0aGUgaW5qZWN0ZWQgX19yZXNvdXJjZU9iamVjdCBwcm9wZXJ0eSBu b24tZW51bWVyYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTU2ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBNYWtlIHRoZSBpbmplY3RlZCBhdXhpbGlhcnkgcHJvcGVydHkgX19yZXNvdXJjZU9iamVj dCBub24tZW51bWVyYWJsZSB0byBoaWRlIGl0IGZyb20gZm9yLi5pbiBpdGVyYXRpb25zLgorICAg ICAgICBJZGVhbGx5IHRoaXMgcHJvcGVydHkgc2hvdWxkIGJlIGNvbXBsZXRlbHkgaGlkZGVuIGZy b20gdGhlIHVzZXIncyBjb2RlLgorICAgICAgICBEcml2ZS1ieTogRml4IGNvdXBsZSBvZiBzbWFs bCBGSVhNRSdzLgorCisgICAgICAgICogaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0V2ViR0xNb2R1 bGVTb3VyY2UuanM6CisgICAgICAgICguKToKKwogMjAxMi0wOC0zMSAgUGF2ZWwgRmVsZG1hbiAg PHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBnZXQgcmlk IG9mIGNvbnRleHQgZXhlY3V0aW9uIGlkIGZhbGxiYWNrLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0V2ViR0xNb2R1bGVTb3VyY2UuanMgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRXZWJHTE1vZHVsZVNvdXJjZS5qcwpp bmRleCBlZWY5MjBmNWM0ODNkMjMzNWUwZWVlMDZmYjg1YWQ5NWZmYTcwNjFlLi5jMzlhMjZkMDQ1 MGExMDAxZTU5NjFlNjlmNDMwMGFhNzljNDUzZWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRXZWJHTE1vZHVsZVNvdXJjZS5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRXZWJHTE1vZHVsZVNvdXJjZS5qcwpA QCAtNjQ5LDExICs2NDksMTYgQEAgUmVzb3VyY2UucHJvdG90eXBlID0gewogICAgIH0sCiAKICAg ICAvKioKLSAgICAgKiBAcGFyYW0ge09iamVjdH0gb2JqZWN0CisgICAgICogQHBhcmFtIHshT2Jq ZWN0fSBvYmplY3QKICAgICAgKi8KICAgICBfYmluZE9iamVjdFRvUmVzb3VyY2U6IGZ1bmN0aW9u KG9iamVjdCkKICAgICB7Ci0gICAgICAgIG9iamVjdFsiX19yZXNvdXJjZU9iamVjdCJdID0gdGhp czsKKyAgICAgICAgT2JqZWN0LmRlZmluZVByb3BlcnR5KG9iamVjdCwgIl9fcmVzb3VyY2VPYmpl Y3QiLCB7CisgICAgICAgICAgICB2YWx1ZTogdGhpcywKKyAgICAgICAgICAgIHdyaXRhYmxlOiBm YWxzZSwKKyAgICAgICAgICAgIGVudW1lcmFibGU6IGZhbHNlLAorICAgICAgICAgICAgY29uZmln dXJhYmxlOiB0cnVlCisgICAgICAgIH0pOwogICAgIH0KIH0KIApAQCAtMTQzOCw2ICsxNDQzLDcg QEAgV2ViR0xSZW5kZXJpbmdDb250ZXh0UmVzb3VyY2UucHJvdG90eXBlID0gewogICAgICAgICAg ICAgICAgICAgICB9LAogICAgICAgICAgICAgICAgICAgICBzZXQ6IGZ1bmN0aW9uKHZhbHVlKQog ICAgICAgICAgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICAgICAgICBjb25zb2xlLmVy cm9yKCJBU1NFUlRfTk9UX1JFQUNIRUQ6IFdlIGFzc3VtZSBhbGwgV2ViR0xSZW5kZXJpbmdDb250 ZXh0IGF0dHJpYnV0ZXMgYXJlIHJlYWRvbmx5LiBUcnlpbmcgdG8gbXV0YXRlICIgKyBwcm9wZXJ0 eSk7CiAgICAgICAgICAgICAgICAgICAgICAgICBnbFtwcm9wZXJ0eV0gPSB2YWx1ZTsKICAgICAg ICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIH0pOwpAQCAtMTQ0Nyw2ICsxNDUzLDcg QEAgV2ViR0xSZW5kZXJpbmdDb250ZXh0UmVzb3VyY2UucHJvdG90eXBlID0gewogICAgICAgICBm b3IgKHZhciBwcm9wZXJ0eSBpbiBnbCkKICAgICAgICAgICAgIHByb2Nlc3NQcm9wZXJ0eShwcm9w ZXJ0eSk7CiAKKyAgICAgICAgdGhpcy5fYmluZE9iamVjdFRvUmVzb3VyY2UocHJveHkpOwogICAg ICAgICByZXR1cm4gcHJveHk7CiAgICAgfSwKIApAQCAtMTg1OCw3ICsxODY1LDcgQEAgSW5qZWN0 ZWRTY3JpcHQucHJvdG90eXBlID0gewogICAgICAqLwogICAgIHdyYXBXZWJHTENvbnRleHQ6IGZ1 bmN0aW9uKGdsQ29udGV4dCkKICAgICB7Ci0gICAgICAgIHZhciByZXNvdXJjZSA9IFJlc291cmNl LmZvck9iamVjdChnbENvbnRleHQpIHx8IG5ldyBXZWJHTFJlbmRlcmluZ0NvbnRleHRSZXNvdXJj ZShnbENvbnRleHQsIHRoaXMuX2NvbnN0cnVjdFJlcGxheUNvbnRleHQuYmluZCh0aGlzLCBnbENv bnRleHQpKTsKKyAgICAgICAgdmFyIHJlc291cmNlID0gUmVzb3VyY2UuZm9yT2JqZWN0KGdsQ29u dGV4dCkgfHwgbmV3IFdlYkdMUmVuZGVyaW5nQ29udGV4dFJlc291cmNlKGdsQ29udGV4dCwgdGhp cy5fY29uc3RydWN0V2ViR0xSZXBsYXlDb250ZXh0LmJpbmQodGhpcywgZ2xDb250ZXh0KSk7CiAg ICAgICAgIHRoaXMuX21hbmFnZXIucmVnaXN0ZXJSZXNvdXJjZShyZXNvdXJjZSk7CiAgICAgICAg IHZhciBwcm94eSA9IHJlc291cmNlLnByb3h5T2JqZWN0KCk7CiAgICAgICAgIHJldHVybiBwcm94 eTsKQEAgLTE5NTEsMTUgKzE5NTgsMjYgQEAgSW5qZWN0ZWRTY3JpcHQucHJvdG90eXBlID0gewog ICAgICAqIEBwYXJhbSB7V2ViR0xSZW5kZXJpbmdDb250ZXh0fSBvcmlnaW5hbEdsQ29udGV4dAog ICAgICAqIEByZXR1cm4ge1dlYkdMUmVuZGVyaW5nQ29udGV4dH0KICAgICAgKi8KLSAgICBfY29u c3RydWN0UmVwbGF5Q29udGV4dDogZnVuY3Rpb24ob3JpZ2luYWxHbENvbnRleHQpCisgICAgX2Nv bnN0cnVjdFdlYkdMUmVwbGF5Q29udGV4dDogZnVuY3Rpb24ob3JpZ2luYWxHbENvbnRleHQpCiAg ICAgewogICAgICAgICB2YXIgcmVwbGF5Q29udGV4dCA9IG9yaWdpbmFsR2xDb250ZXh0WyJfX3Jl cGxheUNvbnRleHQiXTsKICAgICAgICAgaWYgKCFyZXBsYXlDb250ZXh0KSB7CiAgICAgICAgICAg ICB2YXIgY2FudmFzID0gb3JpZ2luYWxHbENvbnRleHQuY2FudmFzLmNsb25lTm9kZSh0cnVlKTsK LSAgICAgICAgICAgIC8vIEZJWE1FOiBQYXNzIG9yaWdpbmFsIGNvbnRleHQgaWQgaW5zdGVhZCBv ZiAiZXhwZXJpbWVudGFsLXdlYmdsIi4KLSAgICAgICAgICAgIC8vIEZJWE1FOiBQYXNzIG9yaWdp bmFsIENvbnRleHRBdHRyaWJ1dGVzIHRvIHRoZSBnZXRDb250ZXh0KCkgbWV0aG9kLgotICAgICAg ICAgICAgcmVwbGF5Q29udGV4dCA9IC8qKiBAdHlwZSB7V2ViR0xSZW5kZXJpbmdDb250ZXh0fSAq LyBSZXNvdXJjZS53cmFwcGVkT2JqZWN0KGNhbnZhcy5nZXRDb250ZXh0KCJleHBlcmltZW50YWwt d2ViZ2wiKSk7Ci0gICAgICAgICAgICBvcmlnaW5hbEdsQ29udGV4dFsiX19yZXBsYXlDb250ZXh0 Il0gPSByZXBsYXlDb250ZXh0OworICAgICAgICAgICAgdmFyIGF0dHJpYnV0ZXMgPSBvcmlnaW5h bEdsQ29udGV4dC5nZXRDb250ZXh0QXR0cmlidXRlcygpOworICAgICAgICAgICAgdmFyIGNvbnRl eHRJZHMgPSBbImV4cGVyaW1lbnRhbC13ZWJnbCIsICJ3ZWJraXQtM2QiLCAiM2QiXTsKKyAgICAg ICAgICAgIGZvciAodmFyIGkgPSAwLCBjb250ZXh0SWQ7IGNvbnRleHRJZCA9IGNvbnRleHRJZHNb aV07ICsraSkgeworICAgICAgICAgICAgICAgIHJlcGxheUNvbnRleHQgPSBjYW52YXMuZ2V0Q29u dGV4dChjb250ZXh0SWQsIGF0dHJpYnV0ZXMpOworICAgICAgICAgICAgICAgIGlmIChyZXBsYXlD b250ZXh0KSB7CisgICAgICAgICAgICAgICAgICAgIHJlcGxheUNvbnRleHQgPSAvKiogQHR5cGUg e1dlYkdMUmVuZGVyaW5nQ29udGV4dH0gKi8gUmVzb3VyY2Uud3JhcHBlZE9iamVjdChyZXBsYXlD b250ZXh0KTsKKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgfQor ICAgICAgICAgICAgfQorICAgICAgICAgICAgT2JqZWN0LmRlZmluZVByb3BlcnR5KG9yaWdpbmFs R2xDb250ZXh0LCAiX19yZXBsYXlDb250ZXh0IiwgeworICAgICAgICAgICAgICAgIHZhbHVlOiBy ZXBsYXlDb250ZXh0LAorICAgICAgICAgICAgICAgIHdyaXRhYmxlOiBmYWxzZSwKKyAgICAgICAg ICAgICAgICBlbnVtZXJhYmxlOiBmYWxzZSwKKyAgICAgICAgICAgICAgICBjb25maWd1cmFibGU6 IHRydWUKKyAgICAgICAgICAgIH0pOwogICAgICAgICAgICAgdGhpcy5fcmVwbGF5Q29udGV4dCA9 IHJlcGxheUNvbnRleHQ7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAvLyBGSVhNRTog UmVzZXQgdGhlIHJlcGxheSBHTCBzdGF0ZSBhbmQgY2xlYXIgdGhlIGNhbnZhcy4K