95643 2012-09-01 06:24:46 -0700 [Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure 2012-09-01 11:16:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jdiggs webkit-unassigned webkit.review.bot oldest_to_newest 710224 0 jdiggs 2012-09-01 06:24:46 -0700 As part of the fix for 72811, a test which needed to be updated was updated by Zan. (Thanks!) One more tweak needs to be made. Now that my build has finished, I am seeing: --- /home/jd/checkout/WebKit/WebKitBuild/Release/layout-test-results/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt +++ /home/jd/checkout/WebKit/WebKitBuild/Release/layout-test-results/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-actual.txt @@ -19,7 +19,8 @@ AXRole: document frame AXRole: panel AXValue: <obj>text area<\n> AXRole: entry AXValue: text area - AXRole: push button + AXRole: section AXValue: Div<\n><obj>button + AXRole: push button AXRole: heading AXValue: Heading<\n><obj>button<\n><obj> The push button is inside a div and the div has additional content, so one would expect the div to be in the accessible hierarchy. And in gtk a11y, div == section. Thus the above seems correct. The question is, why didn't the bot where the test originally failed see that? I'll attach a patch and leave it to the gardeners to sort out the bots. :) 710226 1 161825 jdiggs 2012-09-01 06:29:06 -0700 Created attachment 161825 Patch 710250 2 161829 jdiggs 2012-09-01 08:40:53 -0700 Created attachment 161829 Patch 710270 3 161829 webkit.review.bot 2012-09-01 11:15:57 -0700 Comment on attachment 161829 Patch Clearing flags on attachment: 161829 Committed r127377: <http://trac.webkit.org/changeset/127377> 710271 4 webkit.review.bot 2012-09-01 11:16:00 -0700 All reviewed patches have been landed. Closing bug. 161825 2012-09-01 06:29:06 -0700 2012-09-01 08:40:49 -0700 Patch bug-95643-20120901092852.patch text/plain 1641 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MzcwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDY3MDhiNzM1ZDA3MGFmMWJhNTIx OTQ5MGE1MWY5N2EwNDg2NGNlOS4uY2EyZDExZGViOTNkZDEzYzNmNjNlODQ2MmY5NjFkMjNmYzQ3 Yjk4NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDEyLTA5LTAxICBKb2FubWFyaWUgRGlnZ3Mg IDxqZGlnZ3NAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR3RrXSBhY2Nlc3NpYmlsaXR5L3JlcGxh Y2VkLW9iamVjdHMtaW4tYW5vbnltb3VzLWJsb2NrcyBsYXlvdXQgdGVzdCBmYWlsdXJlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTY0MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L2FjY2Vzc2liaWxpdHkvcmVwbGFjZWQtb2JqZWN0cy1pbi1hbm9ueW1vdXMtYmxvY2tzLWV4cGVj dGVkLnR4dDogQ29ycmVjdGVkLgorCisyMDEyLTA5LTAxICBKb2FubWFyaWUgRGlnZ3MgIDxqZGln Z3NAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR3RrXSBObyBhY2Nlc3NpYmxlIGNhcmV0LW1vdmVk IGV2ZW50cyBmb3VuZCBpbiBjZXJ0YWluIGNvbnRlbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyODExCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3JlcGxhY2VkLW9iamVjdHMtaW4tYW5vbnltb3Vz LWJsb2Nrcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJp bGl0eS9yZXBsYWNlZC1vYmplY3RzLWluLWFub255bW91cy1ibG9ja3MtZXhwZWN0ZWQudHh0Cmlu ZGV4IDIxNzVkYzAzM2U5MTcxNDFhYTMzNTgxMmY0MGQ4NzVjMjc1ZDI3YjQuLjRjYThjYjk1OGJj ODhhZDU1M2Q3ZjhiZjMxYjcwZDc4OGZiZTViMzYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3JlcGxhY2VkLW9iamVjdHMtaW4tYW5vbnltb3VzLWJs b2Nrcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2li aWxpdHkvcmVwbGFjZWQtb2JqZWN0cy1pbi1hbm9ueW1vdXMtYmxvY2tzLWV4cGVjdGVkLnR4dApA QCAtMTksNyArMTksOCBAQCBBWFJvbGU6IGRvY3VtZW50IGZyYW1lCiAgICAgICAgICAgICBBWFJv bGU6IGRvY3VtZW50IGZyYW1lIAogICAgIEFYUm9sZTogcGFuZWwgQVhWYWx1ZTogPG9iaj50ZXh0 IGFyZWE8XG4+CiAgICAgICAgIEFYUm9sZTogZW50cnkgQVhWYWx1ZTogdGV4dCBhcmVhCi0gICAg QVhSb2xlOiBwdXNoIGJ1dHRvbiAKKyAgICBBWFJvbGU6IHNlY3Rpb24gQVhWYWx1ZTogRGl2PFxu PjxvYmo+YnV0dG9uCisgICAgICAgIEFYUm9sZTogcHVzaCBidXR0b24gCiAgICAgQVhSb2xlOiBo ZWFkaW5nIEFYVmFsdWU6IEhlYWRpbmc8XG4+PG9iaj5idXR0b248XG4+PG9iaj4KICAgICAgICAg QVhSb2xlOiBwdXNoIGJ1dHRvbiAKICAgICAgICAgQVhSb2xlOiBpbWFnZSAK 161829 2012-09-01 08:40:53 -0700 2012-09-01 11:15:57 -0700 Patch bug-95643-20120901114039.patch text/plain 1675 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MzcxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDY3MDhiNzM1ZDA3MGFmMWJhNTIx OTQ5MGE1MWY5N2EwNDg2NGNlOS4uYzViN2FmOGRmYWRjNzA5Njg4NWIzN2U1NTZhZTFkNDYxMjky N2IzNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDEyLTA5LTAxICBKb2FubWFyaWUgRGlnZ3Mg IDxqZGlnZ3NAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR3RrXSBhY2Nlc3NpYmlsaXR5L3JlcGxh Y2VkLW9iamVjdHMtaW4tYW5vbnltb3VzLWJsb2NrcyBsYXlvdXQgdGVzdCBmYWlsdXJlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTY0MworCisgICAg ICAgIFVucmV2aWV3ZWQgR1RLIGdhcmRlbmluZywgcmViYXNlbGluaW5nIGFuIGFjY2Vzc2liaWxp dHkgdGVzdC4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3JlcGxhY2Vk LW9iamVjdHMtaW4tYW5vbnltb3VzLWJsb2Nrcy1leHBlY3RlZC50eHQ6IENvcnJlY3RlZC4KKwor MjAxMi0wOS0wMSAgSm9hbm1hcmllIERpZ2dzICA8amRpZ2dzQGlnYWxpYS5jb20+CisKICAgICAg ICAgW0d0a10gTm8gYWNjZXNzaWJsZSBjYXJldC1tb3ZlZCBldmVudHMgZm91bmQgaW4gY2VydGFp biBjb250ZW50CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MjgxMQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJp bGl0eS9yZXBsYWNlZC1vYmplY3RzLWluLWFub255bW91cy1ibG9ja3MtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvcmVwbGFjZWQtb2JqZWN0cy1p bi1hbm9ueW1vdXMtYmxvY2tzLWV4cGVjdGVkLnR4dAppbmRleCAyMTc1ZGMwMzNlOTE3MTQxYWEz MzU4MTJmNDBkODc1YzI3NWQyN2I0Li40Y2E4Y2I5NThiYzg4YWQ1NTNkN2Y4YmYzMWI3MGQ3ODhm YmU1YjM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0 eS9yZXBsYWNlZC1vYmplY3RzLWluLWFub255bW91cy1ibG9ja3MtZXhwZWN0ZWQudHh0CisrKyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3JlcGxhY2VkLW9iamVjdHMt aW4tYW5vbnltb3VzLWJsb2Nrcy1leHBlY3RlZC50eHQKQEAgLTE5LDcgKzE5LDggQEAgQVhSb2xl OiBkb2N1bWVudCBmcmFtZQogICAgICAgICAgICAgQVhSb2xlOiBkb2N1bWVudCBmcmFtZSAKICAg ICBBWFJvbGU6IHBhbmVsIEFYVmFsdWU6IDxvYmo+dGV4dCBhcmVhPFxuPgogICAgICAgICBBWFJv bGU6IGVudHJ5IEFYVmFsdWU6IHRleHQgYXJlYQotICAgIEFYUm9sZTogcHVzaCBidXR0b24gCisg ICAgQVhSb2xlOiBzZWN0aW9uIEFYVmFsdWU6IERpdjxcbj48b2JqPmJ1dHRvbgorICAgICAgICBB WFJvbGU6IHB1c2ggYnV0dG9uIAogICAgIEFYUm9sZTogaGVhZGluZyBBWFZhbHVlOiBIZWFkaW5n PFxuPjxvYmo+YnV0dG9uPFxuPjxvYmo+CiAgICAgICAgIEFYUm9sZTogcHVzaCBidXR0b24gCiAg ICAgICAgIEFYUm9sZTogaW1hZ2UgCg==