95638 2012-09-01 00:36:46 -0700 [Qt] REGRESSION(r127321): It made 3 notification test timeout 2012-09-04 02:20:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 79668 95263 1 ossy webkit-unassigned ap jonlee ossy oldest_to_newest 710176 0 ossy 2012-09-01 00:36:46 -0700 Could you check what happened? --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/notifications/notifications-display-close-events-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/notifications/notifications-display-close-events-actual.txt @@ -1,7 +1,5 @@ DESKTOP NOTIFICATION: icon , title New E-mail, text Meet me tonight at 8! -DESKTOP NOTIFICATION CLOSED: New E-mail +FAIL: Timed out waiting for notifyDone to be called Sending notifications with permission... -PASS: display event invoked. -PASS: close event invoked. --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/notifications/notifications-double-show-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/notifications/notifications-double-show-actual.txt @@ -1,4 +1,5 @@ DESKTOP NOTIFICATION: icon http://0.0.0.0/my_icon.png, title New E-mail, text Meet me tonight at 8! +FAIL: Timed out waiting for notifyDone to be called Sending notifications... --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/notifications/notifications-with-permission-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/notifications/notifications-with-permission-actual.txt @@ -1,5 +1,6 @@ DESKTOP NOTIFICATION: contents at http://0.0.0.0/my_notification.html DESKTOP NOTIFICATION: icon http://0.0.0.0/my_icon.png, title New E-mail, text Meet me tonight at 8! +FAIL: Timed out waiting for notifyDone to be called Sending notifications with permission... 710283 1 jonlee 2012-09-01 13:22:45 -0700 That patch aliases "display" for "show". So I think you just need to dispatch the "show" event instead. Posted a patch; not sure if it will get run by EWS-- might be worth trying it on your end? 710284 2 161833 jonlee 2012-09-01 13:23:30 -0700 Created attachment 161833 Proposed patch 710443 3 ossy 2012-09-03 00:10:31 -0700 (In reply to comment #2) > Created an attachment (id=161833) [details] > Proposed patch Thanks for the fix, I tried it and it works for me. (EWS doesn't run tests, only the Chromium EWS does it.) Could you upload it with changelog, please? 710909 4 ossy 2012-09-04 02:20:04 -0700 Fix landed in https://trac.webkit.org/changeset/127450 161833 2012-09-01 13:23:30 -0700 2012-09-01 13:23:30 -0700 Proposed patch patch text/plain 609 jonlee ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9u UHJlc2VudGVyQ2xpZW50UXQuY3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9O b3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5jcHAKaW5kZXggZDY5M2M0YS4uNTZlZDBiNCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25Q cmVzZW50ZXJDbGllbnRRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9y dC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5jcHAKQEAgLTM4NCw3ICszODQsNyBAQCB2 b2lkIE5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0OjpzZW5kRGlzcGxheUV2ZW50KE5vdGlm aWNhdGlvbldyYXBwZXIqIHdyYXBwZQogewogICAgIE5vdGlmaWNhdGlvbiogbm90aWZpY2F0aW9u ID0gbm90aWZpY2F0aW9uRm9yV3JhcHBlcih3cmFwcGVyKTsKICAgICBpZiAobm90aWZpY2F0aW9u KQotICAgICAgICBzZW5kRXZlbnQobm90aWZpY2F0aW9uLCAiZGlzcGxheSIpOworICAgICAgICBz ZW5kRXZlbnQobm90aWZpY2F0aW9uLCAic2hvdyIpOwogfQogCiAK