95636 2012-09-01 00:22:40 -0700 [EFL] Fix e_dbus_shutdown() error when exiting the Minibrowser 2012-09-03 18:44:22 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song cdumez dglazkov gyuyoung.kim kenneth kihong.kwon peter+ews rakuco webkit.review.bot oldest_to_newest 710169 0 jinwoo7.song 2012-09-01 00:22:40 -0700 The destructor of BatteryProviderEfl should not call stopUpdating() because it invokes e_ukit_shutdown() even though e_ukit_init() is not called. The e_ukit_shutdown() calls the e_dbus_shutdown() and it returns error that the init is not called properly. EAPI int e_dbus_shutdown(void) { if (_edbus_init_count <= 0) { EINA_LOG_ERR("Init count not greater than 0 in shutdown."); return 0; } ... } 710170 1 161818 jinwoo7.song 2012-09-01 00:24:51 -0700 Created attachment 161818 patch. 710225 2 161818 rakuco 2012-09-01 06:27:41 -0700 Comment on attachment 161818 patch. View in context: https://bugs.webkit.org/attachment.cgi?id=161818&action=review > Source/WebKit2/ChangeLog:9 > + The destructor of BatteryProviderEfl should not call stopUpdating() > + because it invokes e_ukit_shutdown() even though e_ukit_init() is not called. e_ukit_init() is called in BatteryProviderEFl::startUpdating(), so there seems to be some other problem here. 710228 3 161818 cdumez 2012-09-01 06:37:05 -0700 Comment on attachment 161818 patch. View in context: https://bugs.webkit.org/attachment.cgi?id=161818&action=review >> Source/WebKit2/ChangeLog:9 >> + because it invokes e_ukit_shutdown() even though e_ukit_init() is not called. > > e_ukit_init() is called in BatteryProviderEFl::startUpdating(), so there seems to be some other problem here. Well, the problem is possibly that stopUpdating() is called several times? > Source/WebKit2/UIProcess/API/efl/BatteryProvider.cpp:-55 > - m_provider.stopUpdating(); Could we maybe add a boolean property to the class to know if we are updating or not? This way we should call m_provider.stopUpdating() only we we are still updating (i.e. stopUpdating() was not explicitly called). I think this would be more reliable. 710229 4 cdumez 2012-09-01 06:41:42 -0700 Actually, the fix seems consistent with the WebKit1 implementation so OK. In addition to your fix, I would also add a check in BatteryProviderEfl::stopUpdating() / BatteryProviderEfl::startUpdating() to avoid such issue in the future. It should not cause any problem to call BatteryProviderEfl::stopUpdating() twice or BatteryProviderEfl::startUpdating() twice. 710404 5 jinwoo7.song 2012-09-02 21:46:50 -0700 (In reply to comment #2) > (From update of attachment 161818 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161818&action=review > > > Source/WebKit2/ChangeLog:9 > > + The destructor of BatteryProviderEfl should not call stopUpdating() > > + because it invokes e_ukit_shutdown() even though e_ukit_init() is not called. > > e_ukit_init() is called in BatteryProviderEFl::startUpdating(), so there seems to be some other problem here. Currently, startUpdating() is not called when the Minibrowser launches. 710405 6 jinwoo7.song 2012-09-02 21:49:06 -0700 (In reply to comment #4) > Actually, the fix seems consistent with the WebKit1 implementation so OK. > > In addition to your fix, I would also add a check in BatteryProviderEfl::stopUpdating() / BatteryProviderEfl::startUpdating() to avoid such issue in the future. It should not cause any problem to call BatteryProviderEfl::stopUpdating() twice or BatteryProviderEfl::startUpdating() twice. I totally agree you that we need such code and would like you to add that. Thanks for your review. 710418 7 kihong.kwon 2012-09-02 22:21:17 -0700 (In reply to comment #4) > Actually, the fix seems consistent with the WebKit1 implementation so OK. > > In addition to your fix, I would also add a check in BatteryProviderEfl::stopUpdating() / BatteryProviderEfl::startUpdating() to avoid such issue in the future. It should not cause any problem to call BatteryProviderEfl::stopUpdating() twice or BatteryProviderEfl::startUpdating() twice. I agree with this. IMO, We need to add a flag to check for starting update. 710599 8 161916 jinwoo7.song 2012-09-03 06:33:03 -0700 Created attachment 161916 patch 710603 9 161916 webkit.review.bot 2012-09-03 06:36:51 -0700 Comment on attachment 161916 patch Attachment 161916 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13755029 710613 10 jinwoo7.song 2012-09-03 06:52:13 -0700 (In reply to comment #7) > (In reply to comment #4) > > Actually, the fix seems consistent with the WebKit1 implementation so OK. > > > > In addition to your fix, I would also add a check in BatteryProviderEfl::stopUpdating() / BatteryProviderEfl::startUpdating() to avoid such issue in the future. It should not cause any problem to call BatteryProviderEfl::stopUpdating() twice or BatteryProviderEfl::startUpdating() twice. > > I agree with this. > IMO, We need to add a flag to check for starting update. I did not add a new flag to check the updating status but used the existing one, m_timer in the BatteryProviderEfl.h. By checking if the m_timer is active or not, stopUpdating() is executed only when we are updating. Also, I added stopUpdating() in the destructor of BatteryClientEfl.cpp as we can check if we are updating or not. 710614 11 161916 peter+ews 2012-09-03 06:52:25 -0700 Comment on attachment 161916 patch Attachment 161916 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13734463 710656 12 161916 cdumez 2012-09-03 07:50:11 -0700 Comment on attachment 161916 patch LGTM. Thanks, this version is much better IMHO. 710657 13 cdumez 2012-09-03 07:50:45 -0700 Why didn't you set review flag? 710663 14 jinwoo7.song 2012-09-03 08:07:20 -0700 (In reply to comment #13) > Why didn't you set review flag? I changed the bug title to match the ChangeLog and set review flag. 710765 15 161951 jinwoo7.song 2012-09-03 17:41:57 -0700 Created attachment 161951 patch 710775 16 161951 gyuyoung.kim 2012-09-03 18:38:43 -0700 Comment on attachment 161951 patch Looks fine. 710777 17 161951 webkit.review.bot 2012-09-03 18:44:17 -0700 Comment on attachment 161951 patch Clearing flags on attachment: 161951 Committed r127436: <http://trac.webkit.org/changeset/127436> 710778 18 webkit.review.bot 2012-09-03 18:44:22 -0700 All reviewed patches have been landed. Closing bug. 161818 2012-09-01 00:24:51 -0700 2012-09-03 06:33:03 -0700 patch. battery_provider.patch text/plain 1318 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4ZDc5M2E1Li4zNTNmMjFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDgtMzEgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdW1dLMl0gRml4IGVfZGJ1c19zaHV0ZG93bigpIGVycm9yIHdoZW4gZXhp dGluZyB0aGUgTWluaWJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk1NjM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlIGRlc3RydWN0b3Igb2YgQmF0dGVyeVByb3ZpZGVyRWZsIHNob3VsZCBu b3QgY2FsbCBzdG9wVXBkYXRpbmcoKSAKKyAgICAgICAgYmVjYXVzZSBpdCBpbnZva2VzIGVfdWtp dF9zaHV0ZG93bigpIGV2ZW4gdGhvdWdoIGVfdWtpdF9pbml0KCkgaXMgbm90IGNhbGxlZC4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0JhdHRlcnlQcm92aWRlci5jcHA6CisgICAgICAg IChCYXR0ZXJ5UHJvdmlkZXI6On5CYXR0ZXJ5UHJvdmlkZXIpOgorCiAyMDEyLTA4LTMxICBBbGV4 ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFtXSzJdIFVzZSBpbml0 aWFsIHByb2Nlc3MgaW4gbXVsdGktcHJvY2VzcyBtb2RlLCB0b28KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0JhdHRlcnlQcm92aWRlci5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9CYXR0ZXJ5UHJvdmlkZXIuY3BwCmluZGV4IDE4Yzll MTQuLmE3MTMzZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L0JhdHRlcnlQcm92aWRlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvQmF0dGVyeVByb3ZpZGVyLmNwcApAQCAtNTIsNyArNTIsNiBAQCBzdGF0aWMgdm9pZCBzdG9w VXBkYXRpbmdDYWxsYmFjayhXS0JhdHRlcnlNYW5hZ2VyUmVmIGJhdHRlcnlNYW5hZ2VyLCBjb25z dCB2b2lkKgogCiBCYXR0ZXJ5UHJvdmlkZXI6On5CYXR0ZXJ5UHJvdmlkZXIoKQogewotICAgIG1f cHJvdmlkZXIuc3RvcFVwZGF0aW5nKCk7CiB9CiAKIFBhc3NSZWZQdHI8QmF0dGVyeVByb3ZpZGVy PiBCYXR0ZXJ5UHJvdmlkZXI6OmNyZWF0ZShXS0JhdHRlcnlNYW5hZ2VyUmVmIHdrQmF0dGVyeU1h bmFnZXIpCg== 161916 2012-09-03 06:33:03 -0700 2012-09-03 17:41:57 -0700 patch battery_provider.patch text/plain 3370 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMWE0OTViLi5lYjQyZGQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDktMDMgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdIEZpeCBlX2RidXNfc2h1dGRvd24oKSBlcnJvciB3aGVuIGV4aXRpbmcg dGhlIE1pbmlicm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NTYzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENoZWNrIGlmIHRoZSBtX3RpbWVyIGlzIGFjdGl2ZSBpbiBzdG9wVXBkYXRpbmcoKQor ICAgICAgICB0byBrbm93IHRoZSBCYXR0ZXJ5UHJvdmlkZXIgaXMgdXBkYXRpbmcgb3Igbm90Lgor ICAgICAgICBCeSBjaGVja2luZyB0aGUgdGltZXIsIHN0b3BVcGRhdGluZygpIHdpbGwgYmUgY2Fs bGVkIAorICAgICAgICBvbmx5IEJhdHRlcnlQcm92aWRlckVmbCBpcyB1cGRhdGluZy4KKworICAg ICAgICAqIHBsYXRmb3JtL2VmbC9CYXR0ZXJ5UHJvdmlkZXJFZmwuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6QmF0dGVyeVByb3ZpZGVyRWZsOjpzdG9wVXBkYXRpbmcpOgorCiAyMDEyLTA5LTAyICBC ZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEltcHJvdmUg dGhlIHdheSB3ZSB1c2UgY29udmVydGVkU3BhY2VTdHJpbmcoKSBpbiBjb252ZXJ0SFRNTFRleHRU b0ludGVyY2hhbmdlRm9ybWF0KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2VmbC9CYXR0ZXJ5UHJvdmlkZXJFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZs L0JhdHRlcnlQcm92aWRlckVmbC5jcHAKaW5kZXggMmMxNWVmYS4uMWJlOWUxZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0JhdHRlcnlQcm92aWRlckVmbC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0JhdHRlcnlQcm92aWRlckVmbC5jcHAKQEAg LTU5LDYgKzU5LDkgQEAgdm9pZCBCYXR0ZXJ5UHJvdmlkZXJFZmw6OnN0YXJ0VXBkYXRpbmcoKQog CiB2b2lkIEJhdHRlcnlQcm92aWRlckVmbDo6c3RvcFVwZGF0aW5nKCkKIHsKKyAgICBpZiAoIW1f dGltZXIuaXNBY3RpdmUoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgbV90aW1lci5zdG9wKCk7 CiAgICAgZV91a2l0X3NodXRkb3duKCk7CiAgICAgZV9kYnVzX3NodXRkb3duKCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFu Z2VMb2cKaW5kZXggYmJmYTQ3Zi4uZDVkZjEwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9l ZmwvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDEyLTA5LTAzICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNv bT4KKworICAgICAgICBbRUZMXSBGaXggZV9kYnVzX3NodXRkb3duKCkgZXJyb3Igd2hlbiBleGl0 aW5nIHRoZSBNaW5pYnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTU2MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbnZva2Ugc3RvcFVwZGF0aW5nKCkgaW4gdGhlIGRlc3RydWN0b3Igb2YgQmF0 dGVyeUNsaW5ldEVmbCgpCisgICAgICAgIHRvIGNhbGwgZV91a2l0X3NodXRkb3duKCkgYW5kIGVf ZGJ1c19zaHV0ZG93bigpIGlmIGFuZCB3aGVuIAorICAgICAgICBzdG9wVXBkYXRpbmcoKSBoYXMg bm90IGJlZW4gY2FsbGVkIGV4cGxpY2l0bHkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9C YXR0ZXJ5Q2xpZW50RWZsLmNwcDoKKyAgICAgICAgKEJhdHRlcnlDbGllbnRFZmw6On5CYXR0ZXJ5 Q2xpZW50RWZsKToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9CYXR0ZXJ5Q2xpZW50RWZsLmg6 CisgICAgICAgIChCYXR0ZXJ5Q2xpZW50RWZsKToKKwogMjAxMi0wOS0wMSAgSmlud29vIFNvbmcg IDxqaW53b283LnNvbmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gUmVmYWN0b3Jpbmcg dGhlIER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvV2ViQ29yZVN1cHBvcnQvQmF0dGVyeUNsaWVudEVmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Vm bC9XZWJDb3JlU3VwcG9ydC9CYXR0ZXJ5Q2xpZW50RWZsLmNwcAppbmRleCA5ZGU2MDdhLi5jYTIw MjVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9CYXR0ZXJ5 Q2xpZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9CYXR0 ZXJ5Q2xpZW50RWZsLmNwcApAQCAtMzIsNiArMzIsMTEgQEAgQmF0dGVyeUNsaWVudEVmbDo6QmF0 dGVyeUNsaWVudEVmbChFdmFzX09iamVjdCogdmlldykKIHsKIH0KIAorQmF0dGVyeUNsaWVudEVm bDo6fkJhdHRlcnlDbGllbnRFZmwoKQoreworICAgIG1fcHJvdmlkZXIuc3RvcFVwZGF0aW5nKCk7 Cit9CisKIHZvaWQgQmF0dGVyeUNsaWVudEVmbDo6c3RhcnRVcGRhdGluZygpCiB7CiAgICAgbV9w cm92aWRlci5zdGFydFVwZGF0aW5nKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9X ZWJDb3JlU3VwcG9ydC9CYXR0ZXJ5Q2xpZW50RWZsLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJD b3JlU3VwcG9ydC9CYXR0ZXJ5Q2xpZW50RWZsLmgKaW5kZXggZjYzM2FhZC4uZDExYWNjOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQmF0dGVyeUNsaWVudEVm bC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0JhdHRlcnlDbGllbnRF ZmwuaApAQCAtMzYsNyArMzYsNyBAQCBjbGFzcyBCYXR0ZXJ5Q29udHJvbGxlcjsKIGNsYXNzIEJh dHRlcnlDbGllbnRFZmwgOiBwdWJsaWMgV2ViQ29yZTo6QmF0dGVyeUNsaWVudCwgcHVibGljIFdl YkNvcmU6OkJhdHRlcnlQcm92aWRlckVmbENsaWVudCB7CiBwdWJsaWM6CiAgICAgZXhwbGljaXQg QmF0dGVyeUNsaWVudEVmbChFdmFzX09iamVjdCogdmlldyk7Ci0gICAgdmlydHVhbCB+QmF0dGVy eUNsaWVudEVmbCgpIHsgfQorICAgIHZpcnR1YWwgfkJhdHRlcnlDbGllbnRFZmwoKTsKIAogICAg IC8vIEJhdHRlcnlDbGllbnQgaW50ZXJmYWNlLgogICAgIHZpcnR1YWwgdm9pZCBzdGFydFVwZGF0 aW5nKCk7Cg== 161951 2012-09-03 17:41:57 -0700 2012-09-03 18:44:17 -0700 patch battery_provider.patch text/plain 3370 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMWE0OTViLi5lYjQyZGQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDktMDMgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdIEZpeCBlX2RidXNfc2h1dGRvd24oKSBlcnJvciB3aGVuIGV4aXRpbmcg dGhlIE1pbmlicm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NTYzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENoZWNrIGlmIHRoZSBtX3RpbWVyIGlzIGFjdGl2ZSBpbiBzdG9wVXBkYXRpbmcoKQor ICAgICAgICB0byBrbm93IHRoZSBCYXR0ZXJ5UHJvdmlkZXIgaXMgdXBkYXRpbmcgb3Igbm90Lgor ICAgICAgICBCeSBjaGVja2luZyB0aGUgdGltZXIsIHN0b3BVcGRhdGluZygpIHdpbGwgYmUgY2Fs bGVkIAorICAgICAgICBvbmx5IEJhdHRlcnlQcm92aWRlckVmbCBpcyB1cGRhdGluZy4KKworICAg ICAgICAqIHBsYXRmb3JtL2VmbC9CYXR0ZXJ5UHJvdmlkZXJFZmwuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6QmF0dGVyeVByb3ZpZGVyRWZsOjpzdG9wVXBkYXRpbmcpOgorCiAyMDEyLTA5LTAyICBC ZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEltcHJvdmUg dGhlIHdheSB3ZSB1c2UgY29udmVydGVkU3BhY2VTdHJpbmcoKSBpbiBjb252ZXJ0SFRNTFRleHRU b0ludGVyY2hhbmdlRm9ybWF0KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2VmbC9CYXR0ZXJ5UHJvdmlkZXJFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZs L0JhdHRlcnlQcm92aWRlckVmbC5jcHAKaW5kZXggMmMxNWVmYS4uMWJlOWUxZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0JhdHRlcnlQcm92aWRlckVmbC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0JhdHRlcnlQcm92aWRlckVmbC5jcHAKQEAg LTU5LDYgKzU5LDkgQEAgdm9pZCBCYXR0ZXJ5UHJvdmlkZXJFZmw6OnN0YXJ0VXBkYXRpbmcoKQog CiB2b2lkIEJhdHRlcnlQcm92aWRlckVmbDo6c3RvcFVwZGF0aW5nKCkKIHsKKyAgICBpZiAoIW1f dGltZXIuaXNBY3RpdmUoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgbV90aW1lci5zdG9wKCk7 CiAgICAgZV91a2l0X3NodXRkb3duKCk7CiAgICAgZV9kYnVzX3NodXRkb3duKCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFu Z2VMb2cKaW5kZXggYmJmYTQ3Zi4uZDVkZjEwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9l ZmwvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDEyLTA5LTAzICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNv bT4KKworICAgICAgICBbRUZMXSBGaXggZV9kYnVzX3NodXRkb3duKCkgZXJyb3Igd2hlbiBleGl0 aW5nIHRoZSBNaW5pYnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTU2MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbnZva2Ugc3RvcFVwZGF0aW5nKCkgaW4gdGhlIGRlc3RydWN0b3Igb2YgQmF0 dGVyeUNsaW5ldEVmbCgpCisgICAgICAgIHRvIGNhbGwgZV91a2l0X3NodXRkb3duKCkgYW5kIGVf ZGJ1c19zaHV0ZG93bigpIGlmIGFuZCB3aGVuIAorICAgICAgICBzdG9wVXBkYXRpbmcoKSBoYXMg bm90IGJlZW4gY2FsbGVkIGV4cGxpY2l0bHkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9C YXR0ZXJ5Q2xpZW50RWZsLmNwcDoKKyAgICAgICAgKEJhdHRlcnlDbGllbnRFZmw6On5CYXR0ZXJ5 Q2xpZW50RWZsKToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9CYXR0ZXJ5Q2xpZW50RWZsLmg6 CisgICAgICAgIChCYXR0ZXJ5Q2xpZW50RWZsKToKKwogMjAxMi0wOS0wMSAgSmlud29vIFNvbmcg IDxqaW53b283LnNvbmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gUmVmYWN0b3Jpbmcg dGhlIER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvV2ViQ29yZVN1cHBvcnQvQmF0dGVyeUNsaWVudEVmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Vm bC9XZWJDb3JlU3VwcG9ydC9CYXR0ZXJ5Q2xpZW50RWZsLmNwcAppbmRleCA5ZGU2MDdhLi5jYTIw MjVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9CYXR0ZXJ5 Q2xpZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9CYXR0 ZXJ5Q2xpZW50RWZsLmNwcApAQCAtMzIsNiArMzIsMTEgQEAgQmF0dGVyeUNsaWVudEVmbDo6QmF0 dGVyeUNsaWVudEVmbChFdmFzX09iamVjdCogdmlldykKIHsKIH0KIAorQmF0dGVyeUNsaWVudEVm bDo6fkJhdHRlcnlDbGllbnRFZmwoKQoreworICAgIG1fcHJvdmlkZXIuc3RvcFVwZGF0aW5nKCk7 Cit9CisKIHZvaWQgQmF0dGVyeUNsaWVudEVmbDo6c3RhcnRVcGRhdGluZygpCiB7CiAgICAgbV9w cm92aWRlci5zdGFydFVwZGF0aW5nKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9X ZWJDb3JlU3VwcG9ydC9CYXR0ZXJ5Q2xpZW50RWZsLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJD b3JlU3VwcG9ydC9CYXR0ZXJ5Q2xpZW50RWZsLmgKaW5kZXggZjYzM2FhZC4uZDExYWNjOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQmF0dGVyeUNsaWVudEVm bC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0JhdHRlcnlDbGllbnRF ZmwuaApAQCAtMzYsNyArMzYsNyBAQCBjbGFzcyBCYXR0ZXJ5Q29udHJvbGxlcjsKIGNsYXNzIEJh dHRlcnlDbGllbnRFZmwgOiBwdWJsaWMgV2ViQ29yZTo6QmF0dGVyeUNsaWVudCwgcHVibGljIFdl YkNvcmU6OkJhdHRlcnlQcm92aWRlckVmbENsaWVudCB7CiBwdWJsaWM6CiAgICAgZXhwbGljaXQg QmF0dGVyeUNsaWVudEVmbChFdmFzX09iamVjdCogdmlldyk7Ci0gICAgdmlydHVhbCB+QmF0dGVy eUNsaWVudEVmbCgpIHsgfQorICAgIHZpcnR1YWwgfkJhdHRlcnlDbGllbnRFZmwoKTsKIAogICAg IC8vIEJhdHRlcnlDbGllbnQgaW50ZXJmYWNlLgogICAgIHZpcnR1YWwgdm9pZCBzdGFydFVwZGF0 aW5nKCk7Cg==