95618 2012-08-31 15:49:05 -0700 [Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex 2012-09-04 06:43:50 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Critical --- 1 mrobinson mario cgarcia jdiggs mario webkit.review.bot oldest_to_newest 710037 0 mrobinson 2012-08-31 15:49:05 -0700 Just saw this crash with the stable branch (1.9.90). Marking critical since this is a crash in the stable series. I caused this to happen by clicking on my inbox in Yahoo mail. #0 0x00007ffff629e8f8 in WebCore::HTMLSelectElement::selectedIndex() const () from /home/martin/work/gnome-shell/install/lib/libwebkitgtk-3.0.so.0 #1 0x00007ffff629ea25 in WebCore::HTMLSelectElement::activeSelectionStartListIndex() const () from /home/martin/work/gnome-shell/install/lib/libwebkitgtk-3.0.so.0 #2 0x00007ffff6e5293d in WebCore::AXObjectCache::postPlatformNotification(WebCore::AccessibilityObject*, WebCore::AXObjectCache::AXNotification) () from /home/martin/work/gnome-shell/install/lib/libwebkitgtk-3.0.so.0 #3 0x00007ffff5f1e47c in WebCore::AXObjectCache::notificationPostTimerFired(WebCore::Timer<WebCore::AXObjectCache>*) () from /home/martin/work/gnome-shell/install/lib/libwebkitgtk-3.0.so.0 #4 0x00007ffff65e4742 in WebCore::ThreadTimers::sharedTimerFiredInternal() () from /home/martin/work/gnome-shell/install/lib/libwebkitgtk-3.0.so.0 #5 0x00007ffff6e8b842 in WebCore::timeout_cb(void*) () from /home/martin/work/gnome-shell/install/lib/libwebkitgtk-3.0.so.0 #6 0x00007ffff3cbefab in g_timeout_dispatch (source=<optimized out>, callback=<optimized out>, user_data=<optimized out>) at gmain.c:4026 #7 0x00007ffff3cbe3e3 in g_main_dispatch (context=0x6f6d50) at gmain.c:2715 #8 g_main_context_dispatch (context=0x6f6d50) at gmain.c:3219 #9 0x00007ffff3cbe730 in g_main_context_iterate (dispatch=1, block=<optimized out>, context=0x6f6d50, self=<optimized out>) at gmain.c:3290 #10 g_main_context_iterate (context=0x6f6d50, block=<optimized out>, dispatch=1, self=<optimized out>) at gmain.c:3227 #11 0x00007ffff3cbe7f4 in g_main_context_iteration (context=0x6f6d50, may_block=1) at gmain.c:3351 #12 0x00007ffff42888b4 in g_application_run (application=0x7fa070, argc=<optimized out>, argv=0x7fffffffd888) at gapplication.c:1607 #13 0x000000000042dd85 in main (argc=1, argv=0x7fffffffd888) at ephy-main.c:493 Adding Mario to the CC since the stack intersects with the accessibility code. 710545 1 161899 mario 2012-09-03 04:44:11 -0700 Created attachment 161899 Patch proposal Simple patch to fix this issue, by protecting us against the situation exposed here: a selector which is not rendered through a HTML <select> element. I propose this patch because the current code was assuming that was the case (a HTML <select> element was always there), which seems to be plainly wrong, as this situation clearly exposes. Of course, some better improvements could be done (e.g. supporting WAI-ARIA selectors), but I think the focus should be now put on fixing this crash, and so that's what this patch does, by ensuring we only emit the signal when such an assumption is right. 710702 2 161899 mrobinson 2012-09-03 10:07:30 -0700 Comment on attachment 161899 Patch proposal Great work!! Is it easy to reproduce this crash? Perhaps we could add a simple test case? 710905 3 161992 mario 2012-09-04 02:14:17 -0700 Created attachment 161992 Patch proposal + Layout test Good idea. I'm attaching a new patch with a simple test case that crashes without the patch (and obviously doesn't with it) 711034 4 161992 mrobinson 2012-09-04 05:53:39 -0700 Comment on attachment 161992 Patch proposal + Layout test View in context: https://bugs.webkit.org/attachment.cgi?id=161992&action=review Great! Do you mind adding this to the list at: https://trac.webkit.org/wiki/WebKitGTK/1.10.x ? > LayoutTests/platform/gtk/accessibility/aria-listbox-crash.html:34 > + window.setTimeout("testRunner.notifyDone()",0); Just a little nit here: you're missing a space after the comma, I think. 711064 5 161992 webkit.review.bot 2012-09-04 06:35:46 -0700 Comment on attachment 161992 Patch proposal + Layout test Clearing flags on attachment: 161992 Committed r127466: <http://trac.webkit.org/changeset/127466> 711065 6 webkit.review.bot 2012-09-04 06:35:49 -0700 All reviewed patches have been landed. Closing bug. 711072 7 mario 2012-09-04 06:43:50 -0700 (In reply to comment #4) > (From update of attachment 161992 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161992&action=review > > Great! Do you mind adding this to the list at: https://trac.webkit.org/wiki/WebKitGTK/1.10.x ? Already did yesterday. > > LayoutTests/platform/gtk/accessibility/aria-listbox-crash.html:34 > > + window.setTimeout("testRunner.notifyDone()",0); > > Just a little nit here: you're missing a space after the comma, I think. Sure, sorry about it. Anyway, now the patch has been already committed so I think it makes no sense to commit a "fix" just for that "issue" :) Thanks 161899 2012-09-03 04:44:11 -0700 2012-09-04 02:14:10 -0700 Patch proposal 0001-2012-09-03-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3253 mario RnJvbSA5OTYyNzMyN2Q4OTJmMWM0YjhmYjZlZDRkMmRhNjg0ODUzZGY5MjZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBNb24sIDMgU2VwIDIwMTIgMTM6MzA6MDMgKzAyMDAKU3ViamVjdDogW1BBVENI XSAyMDEyLTA5LTAzICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K CiAgICAgICAgW1N0YWJsZV0gW0dUS10gQ3Jhc2ggaW4gV2ViQ29yZTo6SFRNTFNlbGVjdEVsZW1l bnQ6OnNlbGVjdGVkSW5kZXgKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTU2MTgKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAg ICAgIE1ha2Ugc3VyZSB3ZSBvbmx5IGVtaXQgdGhlIHRoZSBzaWduYWwgZm9yIG1lbnUgbGlzdHMg YW5kIGxpc3QKICAgICAgICBib3hlcyByZW5kZXJlZCBmcm9tIGFjdHVhbCBIVE1MIHNlbGVjdCBl bGVtZW50cy4KCiAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0ay9BWE9iamVjdENhY2hlQXRrLmNw cDoKICAgICAgICAoV2ViQ29yZTo6bm90aWZ5Q2hpbGRyZW5TZWxlY3Rpb25DaGFuZ2UpOiBXZSBz dXBwb3J0IGFjY2Vzc2liaWxpdHkKICAgICAgICBMaXN0Qm94ZXMgYW5kIE1lbnVMaXN0cyBvbmx5 IGhlcmUsIGFzc3VtaW5nIHRoZXkgcmVwcmVzZW50IEhUTUwKICAgICAgICBzZWxlY3QgZWxlbWVu dHMsIHdoaWNoIG1pZ2h0IGJlIG5vdCBhbHdheXMgdHJ1ZSAoZS5nLiBBUklBKS4gVGh1cywKICAg ICAgICBjaGVjayBpZiB0aGF0IGNvbmRpdGlvbiBpcyB0cnVlLCBlYXJseSByZXR1cm5pbmcgaW4g b3RoZXIgY2FzZS4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8IDE2ICsrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvZ3RrL0FYT2JqZWN0Q2FjaGVBdGsuY3BwIHwgIDcgKysrKysrLQogMiBmaWxlcyBj aGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDdi MzM1YmIuLjU5ZjM5NGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0wOS0wMyAg TWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1N0 YWJsZV0gW0dUS10gQ3Jhc2ggaW4gV2ViQ29yZTo6SFRNTFNlbGVjdEVsZW1lbnQ6OnNlbGVjdGVk SW5kZXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1 NjE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFr ZSBzdXJlIHdlIG9ubHkgZW1pdCB0aGUgdGhlIHNpZ25hbCBmb3IgbWVudSBsaXN0cyBhbmQgbGlz dAorICAgICAgICBib3hlcyByZW5kZXJlZCBmcm9tIGFjdHVhbCBIVE1MIHNlbGVjdCBlbGVtZW50 cy4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvZ3RrL0FYT2JqZWN0Q2FjaGVBdGsuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6bm90aWZ5Q2hpbGRyZW5TZWxlY3Rpb25DaGFuZ2UpOiBXZSBzdXBw b3J0IGFjY2Vzc2liaWxpdHkKKyAgICAgICAgTGlzdEJveGVzIGFuZCBNZW51TGlzdHMgb25seSBo ZXJlLCBhc3N1bWluZyB0aGV5IHJlcHJlc2VudCBIVE1MCisgICAgICAgIHNlbGVjdCBlbGVtZW50 cywgd2hpY2ggbWlnaHQgYmUgbm90IGFsd2F5cyB0cnVlIChlLmcuIEFSSUEpLiBUaHVzLAorICAg ICAgICBjaGVjayBpZiB0aGF0IGNvbmRpdGlvbiBpcyB0cnVlLCBlYXJseSByZXR1cm5pbmcgaW4g b3RoZXIgY2FzZS4KKwogMjAxMi0wOS0wMiAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtGb3Jtc10gRW1wdHkgdmlzaWJsZSB2YWx1ZSBvZiBBTS9QTSBm aWVsZCBvZiBtdWx0aXBsZSBmaWVsZHMgdGltZSBpbnB1dCBVSSBzaG91bGQgZGlzcGxheSB2YXJp YWJsZSBudW1iZXIgb2YgIi0iIGJhc2VkIG9uIG1heGltdW0gbnVtYmVyIG9mIGxhYmVscwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQVhPYmplY3RDYWNoZUF0 ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BWE9iamVjdENhY2hlQXRr LmNwcAppbmRleCAwMDU0ZjE2Li45NDljMzgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2d0ay9BWE9iamVjdENhY2hlQXRrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L2d0ay9BWE9iamVjdENhY2hlQXRrLmNwcApAQCAtODEsMTEgKzgxLDE2 IEBAIHN0YXRpYyB2b2lkIG5vdGlmeUNoaWxkcmVuU2VsZWN0aW9uQ2hhbmdlKEFjY2Vzc2liaWxp dHlPYmplY3QqIG9iamVjdCkKICAgICBpZiAoIW9iamVjdCB8fCAhKG9iamVjdC0+aXNMaXN0Qm94 KCkgfHwgb2JqZWN0LT5pc01lbnVMaXN0KCkpKQogICAgICAgICByZXR1cm47CiAKKyAgICAvLyBP bmx5IHN1cHBvcnQgSFRNTCBzZWxlY3QgZWxlbWVudHMgc28gZmFyIChBUklBIHNlbGVjdG9ycyBu b3Qgc3VwcG9ydGVkKS4KKyAgICBOb2RlKiBub2RlID0gb2JqZWN0LT5ub2RlKCk7CisgICAgaWYg KCFub2RlIHx8ICFub2RlLT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6c2VsZWN0VGFnKSkKKyAgICAg ICAgcmV0dXJuOworCiAgICAgLy8gRW1pdCBzaWduYWwgZnJvbSB0aGUgbGlzdGJveCdzIHBvaW50 IG9mIHZpZXcgZmlyc3QuCiAgICAgZ19zaWduYWxfZW1pdF9ieV9uYW1lKG9iamVjdC0+d3JhcHBl cigpLCAic2VsZWN0aW9uLWNoYW5nZWQiKTsKIAogICAgIC8vIEZpbmQgdGhlIGl0ZW0gd2hlcmUg dGhlIHNlbGVjdGlvbiBjaGFuZ2Ugd2FzIHRyaWdnZXJlZCBmcm9tLgotICAgIEhUTUxTZWxlY3RF bGVtZW50KiBzZWxlY3QgPSB0b0hUTUxTZWxlY3RFbGVtZW50KG9iamVjdC0+bm9kZSgpKTsKKyAg ICBIVE1MU2VsZWN0RWxlbWVudCogc2VsZWN0ID0gdG9IVE1MU2VsZWN0RWxlbWVudChub2RlKTsK ICAgICBpZiAoIXNlbGVjdCkKICAgICAgICAgcmV0dXJuOwogICAgIGludCBjaGFuZ2VkSXRlbUlu ZGV4ID0gc2VsZWN0LT5hY3RpdmVTZWxlY3Rpb25TdGFydExpc3RJbmRleCgpOwotLSAKMS43LjEx LjIKCg== 161992 2012-09-04 02:14:17 -0700 2012-09-04 06:35:46 -0700 Patch proposal + Layout test bug-95618-20120904111400.patch text/plain 5933 mario U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2IzMzViYjhiN2MxNGQx M2Y4NGFkNWQzYTUwNmUzNzBkZjhhZjA4Ny4uYmZjNmYzYzIxZmQ4OTBkYjE0MzRiNDJiNzFlZDli ZGYzMmM5MjU1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTA0ICBNYXJp byBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbU3RhYmxl XSBbR1RLXSBDcmFzaCBpbiBXZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6c2VsZWN0ZWRJbmRl eAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU2MTgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1 cmUgd2Ugb25seSBlbWl0IHRoZSB0aGUgc2lnbmFsIGZvciBtZW51IGxpc3RzIGFuZCBsaXN0Cisg ICAgICAgIGJveGVzIHJlbmRlcmVkIGZyb20gYWN0dWFsIEhUTUwgc2VsZWN0IGVsZW1lbnRzLgor CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9ndGsvQVhPYmplY3RDYWNoZUF0ay5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpub3RpZnlDaGlsZHJlblNlbGVjdGlvbkNoYW5nZSk6IFdlIHN1cHBvcnQg YWNjZXNzaWJpbGl0eQorICAgICAgICBMaXN0Qm94ZXMgYW5kIE1lbnVMaXN0cyBvbmx5IGhlcmUs IGFzc3VtaW5nIHRoZXkgcmVwcmVzZW50IEhUTUwKKyAgICAgICAgc2VsZWN0IGVsZW1lbnRzLCB3 aGljaCBtaWdodCBiZSBub3QgYWx3YXlzIHRydWUgKGUuZy4gQVJJQSkuIFRodXMsCisgICAgICAg IGNoZWNrIGlmIHRoYXQgY29uZGl0aW9uIGlzIHRydWUsIGVhcmx5IHJldHVybmluZyBpbiBvdGhl ciBjYXNlLgorCiAyMDEyLTA5LTAyICBZb3NoaWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgW0Zvcm1zXSBFbXB0eSB2aXNpYmxlIHZhbHVlIG9mIEFNL1BNIGZpZWxk IG9mIG11bHRpcGxlIGZpZWxkcyB0aW1lIGlucHV0IFVJIHNob3VsZCBkaXNwbGF5IHZhcmlhYmxl IG51bWJlciBvZiAiLSIgYmFzZWQgb24gbWF4aW11bSBudW1iZXIgb2YgbGFiZWxzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BWE9iamVjdENhY2hlQXRrLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FYT2JqZWN0Q2FjaGVBdGsuY3Bw CmluZGV4IDAwNTRmMTYxOWNjODAzM2EzMTg2MWEyNmY4YmI3MGU2OWMwYmM2ZDUuLjk0OWMzODMz ZGZlZDdmNmY4NjUwMWEzOGI2Mzc3NmI3MmE2M2JjNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FYT2JqZWN0Q2FjaGVBdGsuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FYT2JqZWN0Q2FjaGVBdGsuY3BwCkBAIC04MSwxMSAr ODEsMTYgQEAgc3RhdGljIHZvaWQgbm90aWZ5Q2hpbGRyZW5TZWxlY3Rpb25DaGFuZ2UoQWNjZXNz aWJpbGl0eU9iamVjdCogb2JqZWN0KQogICAgIGlmICghb2JqZWN0IHx8ICEob2JqZWN0LT5pc0xp c3RCb3goKSB8fCBvYmplY3QtPmlzTWVudUxpc3QoKSkpCiAgICAgICAgIHJldHVybjsKIAorICAg IC8vIE9ubHkgc3VwcG9ydCBIVE1MIHNlbGVjdCBlbGVtZW50cyBzbyBmYXIgKEFSSUEgc2VsZWN0 b3JzIG5vdCBzdXBwb3J0ZWQpLgorICAgIE5vZGUqIG5vZGUgPSBvYmplY3QtPm5vZGUoKTsKKyAg ICBpZiAoIW5vZGUgfHwgIW5vZGUtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpzZWxlY3RUYWcpKQor ICAgICAgICByZXR1cm47CisKICAgICAvLyBFbWl0IHNpZ25hbCBmcm9tIHRoZSBsaXN0Ym94J3Mg cG9pbnQgb2YgdmlldyBmaXJzdC4KICAgICBnX3NpZ25hbF9lbWl0X2J5X25hbWUob2JqZWN0LT53 cmFwcGVyKCksICJzZWxlY3Rpb24tY2hhbmdlZCIpOwogCiAgICAgLy8gRmluZCB0aGUgaXRlbSB3 aGVyZSB0aGUgc2VsZWN0aW9uIGNoYW5nZSB3YXMgdHJpZ2dlcmVkIGZyb20uCi0gICAgSFRNTFNl bGVjdEVsZW1lbnQqIHNlbGVjdCA9IHRvSFRNTFNlbGVjdEVsZW1lbnQob2JqZWN0LT5ub2RlKCkp OworICAgIEhUTUxTZWxlY3RFbGVtZW50KiBzZWxlY3QgPSB0b0hUTUxTZWxlY3RFbGVtZW50KG5v ZGUpOwogICAgIGlmICghc2VsZWN0KQogICAgICAgICByZXR1cm47CiAgICAgaW50IGNoYW5nZWRJ dGVtSW5kZXggPSBzZWxlY3QtPmFjdGl2ZVNlbGVjdGlvblN0YXJ0TGlzdEluZGV4KCk7CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggZThjY2UwNmU3OTUyOWQ3YzljZjMwODY4YzA3ZjRjMDAzZWVlMGZmNy4uMGQ2ZGUzOGU5YzQ2 ZTA1Y2YwMjVlZmZhNTYzNTBlMTY4YTNlNmEzOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEy LTA5LTA0ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAg ICAgICBbU3RhYmxlXSBbR1RLXSBDcmFzaCBpbiBXZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6 c2VsZWN0ZWRJbmRleAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTU2MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBOZXcgbGF5b3V0IHRlc3QgdG8gZW5zdXJlIHdlIGRvbid0IGNyYXNoIHdpdGggQVRLIG5v dGlmaWNhdGlvbnMKKyAgICAgICAgYW55bW9yZSB3aGVuIGNoYW5naW5nIHRoZSBzZWxlY3Rpb24g aW4gYW4gQVJJQSBsaXN0Ym94LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxp dHkvYXJpYS1saXN0Ym94LWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGxh dGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvYXJpYS1saXN0Ym94LWNyYXNoLmh0bWw6IEFkZGVkLgor CiAyMDEyLTA5LTAyICBLZW5pY2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBbQ2hyb21pdW1dIFVucmV2aWV3ZWQgdGVzdCBleHBlY3RhdGlvbiB1cGRhdGUgYWZ0 ZXIgcjEyNzM5OApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2li aWxpdHkvYXJpYS1saXN0Ym94LWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2d0ay9hY2Nlc3NpYmlsaXR5L2FyaWEtbGlzdGJveC1jcmFzaC1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNWExNDE4NjFlNmJkM2M2NGJmNzdlYTY4MTAzMjM1NTE1ODlkYjA3YgotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L2FyaWEt bGlzdGJveC1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMSBAQAorZm9vCitiYXIKK1Ro aXMgdGVzdHMgdGhhdCBzZWxlY3RpbmcgYW4gb3B0aW9uIGluIGFuIEFSSUEgbGlzdGJveCBkb2Vz bid0IGNyYXNoLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1Mi IG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBzdWNjZXNz ZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L2FyaWEtbGlzdGJveC1jcmFzaC5odG1s IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvYXJpYS1saXN0Ym94LWNy YXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uOGQzYjFkYmM3N2EzMGJkMThkMDgyMDUxOTc3MWFjZDJiYjFi OGRiZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3Np YmlsaXR5L2FyaWEtbGlzdGJveC1jcmFzaC5odG1sCkBAIC0wLDAgKzEsNDkgQEAKKzwhRE9DVFlQ RSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8 c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwv c2NyaXB0PgorPHNjcmlwdD4KK2Z1bmN0aW9uIHRlc3QoKQoreworICBkZXNjcmlwdGlvbigiVGhp cyB0ZXN0cyB0aGF0IHNlbGVjdGluZyBhbiBvcHRpb24gaW4gYW4gQVJJQSBsaXN0Ym94IGRvZXNu J3QgY3Jhc2guIik7CisKKyAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5l ci5kdW1wQXNUZXh0KCk7CisgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisKKyAgICAv LyBXZSBmb2N1cyBvbiB0aGUgYm9keSBhbmQgZ2V0IHRoZSBhc3NvY2lhdGVkIGFjY2Vzc2liaWxp dHkKKyAgICAvLyBvYmplY3QgdG8gZm9yY2UgdGhlIGNyZWF0aW9uIG9mIHRoZSBhY2Nlc3NpYmls aXR5IGhpZXJhcmNoeS4KKyAgICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKQor ICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImJvZHkiKS5mb2N1cygpOworICAgICAgYWNj ZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQ7CisgICAgfQorCisgICAvLyBHZXQg cmVmZXJlbmNlcyB0byB0aGUgbGlzdCBhbmQgdGhlIGl0ZW1zLCBhbmQgY2hhbmdlIHNlbGVjdGlv bi4KKyAgIGxpc3QgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnbGlzdCcpOworICAgcHJlU2Vs ZWN0ZWRJdGVtID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xpc3RfaXRlbV8xJyk7CisgICB0 YXJnZXRJdGVtID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xpc3RfaXRlbV8yJyk7CisKKyAg IGxpc3Quc2V0QXR0cmlidXRlKCdhcmlhLWFjdGl2ZWRlc2NlbmRhbnQnLCB0YXJnZXRJdGVtLmlk KTsKKyAgIHByZVNlbGVjdGVkSXRlbS5zZXRBdHRyaWJ1dGUoJ2FyaWEtc2VsZWN0ZWQnLCBmYWxz ZSk7CisgICB0YXJnZXRJdGVtLnNldEF0dHJpYnV0ZSgnYXJpYS1zZWxlY3RlZCcsIHRydWUpOwor CisgICAvLyBXZSBuZWVkIHRvIGZpbmlzaCBvbiBpZGxlIHRvIGdpdmUgcm9vbSBmb3IgdGhlIGNy YXNoIHRvIGhhcHBlbiwKKyAgIC8vIHNpbmNlIGl0J3Mgc3VwcG9zZWQgdG8gY3Jhc2ggYmVjYXVz ZSBvZiBhIG5vdGlmaWNhdGlvbiBhYm91dCB0aGUKKyAgIC8vIHNlbGVjdGlvbiBjaGFuZ2luZyBh bmQgc28gaWYgd2Ugbm90aWZ5RG9uZSgpIG5vdyBpdCB3b3VsZCBiZSB0b28KKyAgIC8vIHNvb24g YW5kIHdlIHdvdWxkIHNraXAgc3VjaCBlbWlzc2lvbiwgbm90IGNyYXNoaW5nIGF0IGFsbC4KKyAg IHdpbmRvdy5zZXRUaW1lb3V0KCJ0ZXN0UnVubmVyLm5vdGlmeURvbmUoKSIsMCk7Cit9Cis8L3Nj cmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5IiBvbmxvYWQ9InRlc3QoKTsiPgorPHVsIGlk PSJsaXN0IiByb2xlPSJsaXN0Ym94IiBhcmlhLWFjdGl2ZWRlc2NlbmRhbnQ9Imxpc3RfaXRlbV8x Ij4KKyAgPGxpIGlkPSJsaXN0X2l0ZW1fMSIgcm9sZT0ib3B0aW9uIiBhcmlhLXNlbGVjdGVkPSJm YWxzZSI+Zm9vPC9saT4KKyAgPGxpIGlkPSJsaXN0X2l0ZW1fMiIgcm9sZT0ib3B0aW9uIiBhcmlh LXNlbGVjdGVkPSJmYWxzZSI+YmFyPC9saT4KKzwvdWw+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+ PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9m YXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgo=